| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fc09841b-0c1f-1f95-7829-a6ec7e38751c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D492:231C2E:192F85:22394B:6A4C74A2 |
| html-safe-nonce | 81e1df9bfc40a0e81417e1c8d1f936a4fa082720375559cc2df87ef15991090f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDkyOjIzMUMyRToxOTJGODU6MjIzOTRCOjZBNEM3NEEyIiwidmlzaXRvcl9pZCI6IjQwNTg2ODc0NDE1ODk3OTM5NTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0a01a4fcb7b0389ecace8bca04969f973ea6f3f4591f9f68efa4ebf223a1ca65 |
| hovercard-subject-tag | pull_request:2060303688 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/54857/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4f4ef0f890d92e694e9145912229ec8db1471f3c539e7e4e116582d44a2d3903/nodejs/node/pull/54857 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4f4ef0f890d92e694e9145912229ec8db1471f3c539e7e4e116582d44a2d3903/nodejs/node/pull/54857 |
| og:image:alt | Fixes: #48771
What is the problem being solved?
#48771 Reported request object returned from http.request method cannot catch error events triggered when there’s an immediate failure trying to conn... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | anilhelvaci |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 56ac743bebb13694b888673bb7257f4b97a4b7fd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/54857#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54857 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54857 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/54857 |
| Reload | https://github.com/nodejs/node/pull/54857 |
| Reload | https://github.com/nodejs/node/pull/54857 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
964
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| anilhelvaci | https://github.com/anilhelvaci |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| anilhelvaci:fix-48771-net-exception-with-tests | https://github.com/anilhelvaci/node/tree/fix-48771-net-exception-with-tests |
| Conversation | https://github.com/nodejs/node/pull/54857 |
| Commits5 (5) | https://github.com/nodejs/node/pull/54857/commits |
| Checks | https://github.com/nodejs/node/pull/54857/checks |
| Files changed | https://github.com/nodejs/node/pull/54857/files |
| net: defer self.destroy calls to nextTick | https://github.com/nodejs/node/pull/54857#top |
| anilhelvaci | https://github.com/anilhelvaci |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| anilhelvaci:fix-48771-net-exception-with-tests | https://github.com/anilhelvaci/node/tree/fix-48771-net-exception-with-tests |
|
| https://github.com/anilhelvaci |
| anilhelvaci | https://github.com/anilhelvaci |
| Sep 9, 2024 | https://github.com/nodejs/node/pull/54857#issue-2513065657 |
| #48771 | https://github.com/nodejs/node/issues/48771 |
| #48771 | https://github.com/nodejs/node/issues/48771 |
| #51038 | https://github.com/nodejs/node/pull/51038 |
| #48771 (comment) | https://github.com/nodejs/node/issues/48771#issuecomment-1661858958 |
| #51038 | https://github.com/nodejs/node/pull/51038 |
| #51038 (review) | https://github.com/nodejs/node/pull/51038#pullrequestreview-1761719500 |
| node/lib/net.js | https://github.com/nodejs/node/blob/9404d3aaaf0a8264ee08ba169ec24685bf8d487d/lib/net.js#L1113 |
| 9404d3a | https://github.com/nodejs/node/commit/9404d3aaaf0a8264ee08ba169ec24685bf8d487d |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 9, 2024 | https://github.com/nodejs/node/pull/54857#issuecomment-2337267967 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
| Sep 9, 2024 | https://github.com/nodejs/node/pull/54857#event-14177876579 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Sep 9, 2024
| https://github.com/nodejs/node/pull/54857#pullrequestreview-2289033949 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54857/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/54857#pullrequestreview-2289033949 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| ShogunPanda | https://github.com/ShogunPanda |
| September 9, 2024 07:23 | https://github.com/nodejs/node/pull/54857#event-14178283718 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 9, 2024 | https://github.com/nodejs/node/pull/54857#event-14178285093 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Sep 9, 2024 | https://github.com/nodejs/node/pull/54857#issuecomment-2337472735 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| Codecov | https://app.codecov.io/gh/nodejs/node/pull/54857?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| 4396cf2 | https://app.codecov.io/gh/nodejs/node/commit/4396cf2d45f0e1b13524722919a259264a07998f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| 793c722 | https://app.codecov.io/gh/nodejs/node/commit/793c722760e1d5aec44091919b5e4564dd20f093?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/54857?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| lib/_http_client.js | https://app.codecov.io/gh/nodejs/node/pull/54857?src=pr&el=tree&filepath=lib%2F_http_client.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL19odHRwX2NsaWVudC5qcw== |
| 44 files with indirect coverage changes | https://app.codecov.io/gh/nodejs/node/pull/54857/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Test Analytics | https://docs.codecov.com/docs/test-analytics |
| JS Bundle Analysis | https://docs.codecov.com/docs/javascript-bundle-analysis |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 9, 2024
| https://github.com/nodejs/node/pull/54857#pullrequestreview-2290050775 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54857/files |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
|
Sep 9, 2024
| https://github.com/nodejs/node/pull/54857#pullrequestreview-2290098767 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54857/files |
| ShogunPanda | https://github.com/ShogunPanda |
| https://github.com/nodejs/node/pull/54857#pullrequestreview-2290098767 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Sep 9, 2024
| https://github.com/nodejs/node/pull/54857#pullrequestreview-2290126797 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54857/files |
| anonrig | https://github.com/anonrig |
| https://github.com/nodejs/node/pull/54857#pullrequestreview-2290126797 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 9, 2024 | https://github.com/nodejs/node/pull/54857#event-14190449052 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54857 |
| https://github.com/anilhelvaci |
| anilhelvaci | https://github.com/anilhelvaci |
| Sep 10, 2024 | https://github.com/nodejs/node/pull/54857#issuecomment-2340508930 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| @anonrig | https://github.com/anonrig |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/JungMinu |
| JungMinu | https://github.com/JungMinu |
|
Sep 11, 2024
| https://github.com/nodejs/node/pull/54857#pullrequestreview-2295628644 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54857/files |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 11, 2024 | https://github.com/nodejs/node/pull/54857#event-14213401174 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 11, 2024 | https://github.com/nodejs/node/pull/54857#issuecomment-2343213056 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 11, 2024 | https://github.com/nodejs/node/pull/54857#event-14213548985 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 11, 2024 | https://github.com/nodejs/node/pull/54857#issuecomment-2343243906 |
| https://ci.nodejs.org/job/node-test-pull-request/62310/ | https://ci.nodejs.org/job/node-test-pull-request/62310/ |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/anilhelvaci |
| anilhelvaci | https://github.com/anilhelvaci |
| Sep 11, 2024 | https://github.com/nodejs/node/pull/54857#issuecomment-2343975145 |
| @mcollina | https://github.com/mcollina |
| parallel.test-http-client-immidiate-error.js | https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel8-s390x/45768/testReport/junit/(root)/parallel/test_http_client_immediate_error/ |
| parallel.test-runner-watch-mode-complex | https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu2204_sharedlibs_shared_x64/46257/testReport/junit/(root)/parallel/test_runner_watch_mode_complex/ |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Sep 13, 2024 | https://github.com/nodejs/node/pull/54857#issuecomment-2348371447 |
| parallel.test-http-client-immidiate-error.js | https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel8-s390x/45768/testReport/junit/(root)/parallel/test_http_client_immediate_error/ |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/anilhelvaci |
| anilhelvaci | https://github.com/anilhelvaci |
| Sep 13, 2024 | https://github.com/nodejs/node/pull/54857#issuecomment-2348437863 |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Sep 18, 2024 | https://github.com/nodejs/node/pull/54857#issuecomment-2358265575 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
|
Oct 15, 2024
| https://github.com/nodejs/node/pull/54857#pullrequestreview-2368321795 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54857/files |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Oct 15, 2024 | https://github.com/nodejs/node/pull/54857#issuecomment-2414478459 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/anilhelvaci |
| anilhelvaci | https://github.com/anilhelvaci |
| Oct 15, 2024 | https://github.com/nodejs/node/pull/54857#issuecomment-2414868745 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Oct 15, 2024 | https://github.com/nodejs/node/pull/54857#issuecomment-2415121642 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/anilhelvaci |
| anilhelvaci | https://github.com/anilhelvaci |
| force-pushed | https://github.com/nodejs/node/compare/4725298187ed49c40ac4b7289cc15caef86c5d2b..fcc49dbeeb3453a8f51fde0f66dfd8a1e8079f4d |
| 4725298 | https://github.com/nodejs/node/commit/4725298187ed49c40ac4b7289cc15caef86c5d2b |
| fcc49db | https://github.com/nodejs/node/commit/fcc49dbeeb3453a8f51fde0f66dfd8a1e8079f4d |
|
Compare
| https://github.com/nodejs/node/compare/4725298187ed49c40ac4b7289cc15caef86c5d2b..fcc49dbeeb3453a8f51fde0f66dfd8a1e8079f4d |
| June 17, 2025 09:47 | https://github.com/nodejs/node/pull/54857#event-18187211689 |
| https://github.com/anilhelvaci |
| anilhelvaci | https://github.com/anilhelvaci |
| Jun 17, 2025 | https://github.com/nodejs/node/pull/54857#issuecomment-2979705214 |
| @ShogunPanda | https://github.com/ShogunPanda |
| @anonrig | https://github.com/anonrig |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Jun 17, 2025 | https://github.com/nodejs/node/pull/54857#issuecomment-2979828760 |
| @anilhelvaci | https://github.com/anilhelvaci |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Jun 17, 2025
| https://github.com/nodejs/node/pull/54857#pullrequestreview-2935215702 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54857/files |
| https://github.com/anilhelvaci |
| anilhelvaci | https://github.com/anilhelvaci |
| Sep 14, 2025 | https://github.com/nodejs/node/pull/54857#issuecomment-3289650786 |
| @mcollina | https://github.com/mcollina |
| @ronag | https://github.com/ronag |
| @ShogunPanda | https://github.com/ShogunPanda |
| @mcollina | https://github.com/mcollina |
| this comment | https://github.com/nodejs/node/pull/54857#issuecomment-3199444776 |
| @ronag | https://github.com/ronag |
| comment | https://github.com/nodejs/node/pull/54857#issuecomment-2358265575 |
| node/lib/_http_client.js | https://github.com/nodejs/node/blob/ff11b5956954e96e7b0917c83ef0d901adf62dcf/lib/_http_client.js#L939-L943 |
| ff11b59 | https://github.com/nodejs/node/commit/ff11b5956954e96e7b0917c83ef0d901adf62dcf |
| @ronag | https://github.com/ronag |
| node/lib/net.js | https://github.com/nodejs/node/blob/c8c6bfab23abfe874289d0d58d849a8617e044b3/lib/net.js#L1356-L1360 |
| c8c6bfa | https://github.com/nodejs/node/commit/c8c6bfab23abfe874289d0d58d849a8617e044b3 |
| comment | https://github.com/nodejs/node/issues/48771#issuecomment-1663743554 |
| @ShogunPanda | https://github.com/ShogunPanda |
| @mcollina | https://github.com/mcollina |
| @ShogunPanda | https://github.com/ShogunPanda |
| comment | https://github.com/nodejs/node/issues/48771#issuecomment-1661858958 |
| node/lib/net.js | https://github.com/nodejs/node/blob/ff11b5956954e96e7b0917c83ef0d901adf62dcf/lib/net.js#L1417-L1430 |
| ff11b59 | https://github.com/nodejs/node/commit/ff11b5956954e96e7b0917c83ef0d901adf62dcf |
| comment | https://github.com/nodejs/node/pull/54857#issuecomment-3106951245 |
| @anonrig | https://github.com/anonrig |
| @UlisesGascon | https://github.com/UlisesGascon |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Sep 14, 2025 | https://github.com/nodejs/node/pull/54857#issuecomment-3289722974 |
| @anilhelvaci | https://github.com/anilhelvaci |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/anilhelvaci |
| anilhelvaci | https://github.com/anilhelvaci |
| Sep 15, 2025 | https://github.com/nodejs/node/pull/54857#issuecomment-3293416813 |
| @anilhelvaci | https://github.com/anilhelvaci |
| @ronag | https://github.com/ronag |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| anilhelvaci | https://github.com/anilhelvaci |
| September 23, 2025 11:59 | https://github.com/nodejs/node/pull/54857#commits-pushed-07034b4 |
|
| https://github.com/anilhelvaci |
| net: defer self.destroy calls to nextTick | https://github.com/nodejs/node/pull/54857/commits/07034b41c1819fe2a3b01e3a94190a1bf9cacb23 |
| 07034b4 | https://github.com/nodejs/node/pull/54857/commits/07034b41c1819fe2a3b01e3a94190a1bf9cacb23 |
| nodejs#48771 (comment) | https://github.com/nodejs/node/issues/48771#issuecomment-1661858958 |
| nodejs#48771 | https://github.com/nodejs/node/issues/48771 |
|
| https://github.com/anilhelvaci |
| debug: insert console.logs for detecting where the test times out. Wi… | https://github.com/nodejs/node/pull/54857/commits/24ec50c4251a63f92605c3ed37ed4c7ed1a245a5 |
| 24ec50c | https://github.com/nodejs/node/pull/54857/commits/24ec50c4251a63f92605c3ed37ed4c7ed1a245a5 |
| https://github.com/anilhelvaci |
| anilhelvaci | https://github.com/anilhelvaci |
| force-pushed | https://github.com/nodejs/node/compare/e9ce89217117562ff1a428a896c8d759e42042e2..4ab33764379ca10f215acffc665a4f6637752811 |
| e9ce892 | https://github.com/nodejs/node/commit/e9ce89217117562ff1a428a896c8d759e42042e2 |
| 4ab3376 | https://github.com/nodejs/node/commit/4ab33764379ca10f215acffc665a4f6637752811 |
|
Compare
| https://github.com/nodejs/node/compare/e9ce89217117562ff1a428a896c8d759e42042e2..4ab33764379ca10f215acffc665a4f6637752811 |
| September 24, 2025 05:07 | https://github.com/nodejs/node/pull/54857#event-19882225643 |
|
| https://github.com/anilhelvaci |
| chore: try handling the error event onSocket | https://github.com/nodejs/node/pull/54857/commits/a69a7e1a7780999eab76c28d698653f22c73a103 |
| a69a7e1 | https://github.com/nodejs/node/pull/54857/commits/a69a7e1a7780999eab76c28d698653f22c73a103 |
| https://github.com/anilhelvaci |
| anilhelvaci | https://github.com/anilhelvaci |
| force-pushed | https://github.com/nodejs/node/compare/4ab33764379ca10f215acffc665a4f6637752811..a69a7e1a7780999eab76c28d698653f22c73a103 |
| 4ab3376 | https://github.com/nodejs/node/commit/4ab33764379ca10f215acffc665a4f6637752811 |
| a69a7e1 | https://github.com/nodejs/node/commit/a69a7e1a7780999eab76c28d698653f22c73a103 |
|
Compare
| https://github.com/nodejs/node/compare/4ab33764379ca10f215acffc665a4f6637752811..a69a7e1a7780999eab76c28d698653f22c73a103 |
| September 24, 2025 05:20 | https://github.com/nodejs/node/pull/54857#event-19882568506 |
| https://github.com/anilhelvaci |
| anilhelvaci | https://github.com/anilhelvaci |
| mcollina | https://github.com/mcollina |
| September 24, 2025 05:21 | https://github.com/nodejs/node/pull/54857#event-19882580510 |
| https://github.com/anilhelvaci |
| anilhelvaci | https://github.com/anilhelvaci |
| Sep 24, 2025 | https://github.com/nodejs/node/pull/54857#issuecomment-3326593540 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| a69a7e1 | https://github.com/nodejs/node/commit/a69a7e1a7780999eab76c28d698653f22c73a103 |
| @mcollina | https://github.com/mcollina |
| @ronag | https://github.com/ronag |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Sep 24, 2025 | https://github.com/nodejs/node/pull/54857#issuecomment-3326613950 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/anilhelvaci |
| anilhelvaci | https://github.com/anilhelvaci |
| Sep 24, 2025 | https://github.com/nodejs/node/pull/54857#issuecomment-3326620944 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| @ronag | https://github.com/ronag |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Sep 24, 2025 | https://github.com/nodejs/node/pull/54857#issuecomment-3326631654 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/anilhelvaci |
| anilhelvaci | https://github.com/anilhelvaci |
| Sep 24, 2025 | https://github.com/nodejs/node/pull/54857#issuecomment-3326638659 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| Files Changed | https://github.com/nodejs/node/pull/54857/files |
| @ronag | https://github.com/ronag |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Sep 24, 2025 | https://github.com/nodejs/node/pull/54857#issuecomment-3326640749 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Sep 24, 2025
| https://github.com/nodejs/node/pull/54857#pullrequestreview-3261102412 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54857/files/a69a7e1a7780999eab76c28d698653f22c73a103 |
| lib/_http_client.js | https://github.com/nodejs/node/pull/54857/files/a69a7e1a7780999eab76c28d698653f22c73a103#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43 |
| ronag | https://github.com/ronag |
| Sep 24, 2025 | https://github.com/nodejs/node/pull/54857#discussion_r2374487307 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| anilhelvaci | https://github.com/anilhelvaci |
| Sep 25, 2025 | https://github.com/nodejs/node/pull/54857#discussion_r2377770305 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 793c722 | https://github.com/nodejs/node/commit/793c722760e1d5aec44091919b5e4564dd20f093 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
|
| https://github.com/anilhelvaci |
| http: use private symbol for immediateError property | https://github.com/nodejs/node/pull/54857/commits/793c722760e1d5aec44091919b5e4564dd20f093 |
| 793c722 | https://github.com/nodejs/node/pull/54857/commits/793c722760e1d5aec44091919b5e4564dd20f093 |
| nodejs#48771 | https://github.com/nodejs/node/issues/48771 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Sep 25, 2025
| https://github.com/nodejs/node/pull/54857#pullrequestreview-3266441573 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54857/files/793c722760e1d5aec44091919b5e4564dd20f093 |
| lib/_http_client.js | https://github.com/nodejs/node/pull/54857/files/793c722760e1d5aec44091919b5e4564dd20f093#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
|
| https://github.com/anilhelvaci |
| chore: apply private symbol to onImmediateError and address linting e… | https://github.com/nodejs/node/pull/54857/commits/0b8febf698347983f23149be5d568b94115d8cf0 |
| 0b8febf | https://github.com/nodejs/node/pull/54857/commits/0b8febf698347983f23149be5d568b94115d8cf0 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Oct 1, 2025 | https://github.com/nodejs/node/pull/54857#event-20028249544 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Oct 1, 2025 | https://github.com/nodejs/node/pull/54857#event-20028452442 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Oct 1, 2025 | https://github.com/nodejs/node/pull/54857#issuecomment-3355294376 |
| https://github.com/nodejs/node/actions/runs/18156288164 | https://github.com/nodejs/node/actions/runs/18156288164 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/anilhelvaci |
| anilhelvaci | https://github.com/anilhelvaci |
| Oct 7, 2025 | https://github.com/nodejs/node/pull/54857#issuecomment-3376426418 |
| @mcollina | https://github.com/mcollina |
| @joyeecheung | https://github.com/joyeecheung |
| @ronag | https://github.com/ronag |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Oct 30, 2025 | https://github.com/nodejs/node/pull/54857#issuecomment-3467834162 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| @anilhelvaci | https://github.com/anilhelvaci |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Oct 30, 2025
| https://github.com/nodejs/node/pull/54857#pullrequestreview-3399507194 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54857/files/0b8febf698347983f23149be5d568b94115d8cf0 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
|
request-ci-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed |
| Oct 30, 2025 | https://github.com/nodejs/node/pull/54857#event-20608662744 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Oct 30, 2025 | https://github.com/nodejs/node/pull/54857#event-20608744436 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 30, 2025 | https://github.com/nodejs/node/pull/54857#issuecomment-3467911781 |
| https://ci.nodejs.org/job/node-test-pull-request/69957/ | https://ci.nodejs.org/job/node-test-pull-request/69957/ |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54857 |
|
| https://github.com/ShogunPanda |
|
ShogunPanda
| https://github.com/ShogunPanda |
|
| https://github.com/nodejs/node/pull/54857/files/ff6e39a5ecc972d4bc86e40c6aa27872cbecacb8 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/54857/files/ff6e39a5ecc972d4bc86e40c6aa27872cbecacb8 |
|
| https://github.com/anonrig |
|
anonrig
| https://github.com/anonrig |
|
| https://github.com/nodejs/node/pull/54857/files/ff6e39a5ecc972d4bc86e40c6aa27872cbecacb8 |
|
| https://github.com/ronag |
|
ronag
| https://github.com/ronag |
|
| https://github.com/nodejs/node/pull/54857/files/0b8febf698347983f23149be5d568b94115d8cf0 |
|
| https://github.com/JungMinu |
|
JungMinu
| https://github.com/JungMinu |
|
| https://github.com/nodejs/node/pull/54857/files/ff6e39a5ecc972d4bc86e40c6aa27872cbecacb8 |
|
| https://github.com/UlisesGascon |
|
UlisesGascon
| https://github.com/UlisesGascon |
|
| https://github.com/nodejs/node/pull/54857/files/ff6e39a5ecc972d4bc86e40c6aa27872cbecacb8 |
|
| https://github.com/Ethan-Arrowood |
|
Ethan-Arrowood
| https://github.com/Ethan-Arrowood |
|
| https://github.com/nodejs/node/pull/54857/files/ff6e39a5ecc972d4bc86e40c6aa27872cbecacb8 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/mertcanaltin |
|
mertcanaltin
| https://github.com/mertcanaltin |
|
| https://github.com/nodejs/node/pull/54857/files/ff6e39a5ecc972d4bc86e40c6aa27872cbecacb8 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
|
Conditional unhandled 'error' event when http.request with .lookup
| https://github.com/nodejs/node/issues/48771 |
| Please reload this page | https://github.com/nodejs/node/pull/54857 |
|
| https://github.com/anilhelvaci |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mcollina |
|
| https://github.com/aduh95 |
|
| https://github.com/ronag |
|
| https://github.com/ShogunPanda |
|
| https://github.com/joyeecheung |
|
| https://github.com/jasnell |
|
| https://github.com/anonrig |
|
| https://github.com/JungMinu |
|
| https://github.com/UlisesGascon |
|
| https://github.com/Ethan-Arrowood |
|
| https://github.com/mertcanaltin |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |