| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bb712b44-ad46-5747-e137-9f9ce35ceaf0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CD90:22476E:98556C:D5BEFB:696A5C6A |
| html-safe-nonce | fae85222d3daa922b7689c97d147e11686b3eeed3a1e39cbc5b2a226920245ac |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDkwOjIyNDc2RTo5ODU1NkM6RDVCRUZCOjY5NkE1QzZBIiwidmlzaXRvcl9pZCI6IjcxMjM4MTkwMjczNTA4MzgzNzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5224b37e011d4f0f3f897d89f3e53449b6d7a309e7ef20f93b2d90f51b25bf69 |
| hovercard-subject-tag | pull_request:2059142458 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/54831/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4558ad8cf18da16cb92baf431284042b56755b2c7837682bd22b149830030de8/nodejs/node/pull/54831 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4558ad8cf18da16cb92baf431284042b56755b2c7837682bd22b149830030de8/nodejs/node/pull/54831 |
| og:image:alt | Convert more things to use Maybe instead of Maybe |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jasnell |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63c426b30d262aba269ef14c40e3c817b384cd61 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/54831#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54831 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54831 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/54831 |
| Reload | https://github.com/nodejs/node/pull/54831 |
| Reload | https://github.com/nodejs/node/pull/54831 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/54831#issue-comment-box |
| jasnell | https://github.com/jasnell |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| jasnell:use-maybevoid-more | https://github.com/jasnell/node/tree/use-maybevoid-more |
|
src: move more stuff over to use Maybe
| https://github.com/nodejs/node/pull/54831#top |
| jasnell | https://github.com/jasnell |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| jasnell:use-maybevoid-more | https://github.com/jasnell/node/tree/use-maybevoid-more |
|
Conversation
16
| https://github.com/nodejs/node/pull/54831 |
|
Commits
1
| https://github.com/nodejs/node/pull/54831/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/54831/checks |
|
Files changed
| https://github.com/nodejs/node/pull/54831/files |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 7, 2024 | https://github.com/nodejs/node/pull/54831#issue-2511721047 |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| addaleax | https://github.com/addaleax |
| targos | https://github.com/targos |
| September 7, 2024 14:54 | https://github.com/nodejs/node/pull/54831#event-14170145498 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Sep 7, 2024 | https://github.com/nodejs/node/pull/54831#event-14170160716 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Sep 7, 2024 | https://github.com/nodejs/node/pull/54831#issuecomment-2335820149 |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
| Codecov | https://app.codecov.io/gh/nodejs/node/pull/54831?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (a1cd3c8) | https://app.codecov.io/gh/nodejs/node/commit/a1cd3c8777604fe3fc531186364ce9c2529f087b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (d7f1948) | https://app.codecov.io/gh/nodejs/node/commit/d7f1948d6489ef2715238a4159ae8cd66c3cf930?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/54831?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/api/environment.cc | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&filepath=src%2Fapi%2Fenvironment.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2FwaS9lbnZpcm9ubWVudC5jYw== |
| 11 Missing and 1 partial ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/spawn_sync.cc | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&filepath=src%2Fspawn_sync.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL3NwYXduX3N5bmMuY2M= |
| 6 Missing and 1 partial ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/node_messaging.cc | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&filepath=src%2Fnode_messaging.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfbWVzc2FnaW5nLmNj |
| 3 Missing and 3 partials ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/cares_wrap.cc | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&filepath=src%2Fcares_wrap.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2NhcmVzX3dyYXAuY2M= |
| 2 Missing and 2 partials ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/node_env_var.cc | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&filepath=src%2Fnode_env_var.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZW52X3Zhci5jYw== |
| 0 Missing and 1 partial ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/54831?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/api/hooks.cc | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&filepath=src%2Fapi%2Fhooks.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2FwaS9ob29rcy5jYw== |
| src/base_object.cc | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&filepath=src%2Fbase_object.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2Jhc2Vfb2JqZWN0LmNj |
| src/base_object.h | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&filepath=src%2Fbase_object.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2Jhc2Vfb2JqZWN0Lmg= |
| src/node_internals.h | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&filepath=src%2Fnode_internals.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfaW50ZXJuYWxzLmg= |
| src/node_messaging.h | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&filepath=src%2Fnode_messaging.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfbWVzc2FnaW5nLmg= |
| src/spawn_sync.h | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&filepath=src%2Fspawn_sync.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL3NwYXduX3N5bmMuaA== |
| src/util.h | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&filepath=src%2Futil.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL3V0aWwuaA== |
| src/node_env_var.cc | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&filepath=src%2Fnode_env_var.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZW52X3Zhci5jYw== |
| src/cares_wrap.cc | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&filepath=src%2Fcares_wrap.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2NhcmVzX3dyYXAuY2M= |
| src/node_messaging.cc | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree&filepath=src%2Fnode_messaging.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfbWVzc2FnaW5nLmNj |
| 2 more | https://app.codecov.io/gh/nodejs/node/pull/54831?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| 86 files with indirect coverage changes | https://app.codecov.io/gh/nodejs/node/pull/54831/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Sep 7, 2024 | https://github.com/nodejs/node/pull/54831#event-14171869036 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 7, 2024 | https://github.com/nodejs/node/pull/54831#issuecomment-2336049525 |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 7, 2024 | https://github.com/nodejs/node/pull/54831#event-14172809064 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 7, 2024 | https://github.com/nodejs/node/pull/54831#event-14172818496 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54831 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54831 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| anonrig | https://github.com/anonrig |
| September 8, 2024 19:07 | https://github.com/nodejs/node/pull/54831#event-14174857643 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/4fc399d18863f26c3a9ada6494a99bbab9d0973a..bbfc24b4e5399732d01099e349e41119c119219b |
| 4fc399d | https://github.com/nodejs/node/commit/4fc399d18863f26c3a9ada6494a99bbab9d0973a |
| bbfc24b | https://github.com/nodejs/node/commit/bbfc24b4e5399732d01099e349e41119c119219b |
|
Compare
| https://github.com/nodejs/node/compare/4fc399d18863f26c3a9ada6494a99bbab9d0973a..bbfc24b4e5399732d01099e349e41119c119219b |
| September 11, 2024 14:42 | https://github.com/nodejs/node/pull/54831#event-14217601394 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 11, 2024 | https://github.com/nodejs/node/pull/54831#issuecomment-2343882515 |
| https://ci.nodejs.org/job/node-test-pull-request/62324/ | https://ci.nodejs.org/job/node-test-pull-request/62324/ |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Sep 11, 2024
| https://github.com/nodejs/node/pull/54831#pullrequestreview-2297383429 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54831/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 11, 2024 | https://github.com/nodejs/node/pull/54831#issuecomment-2343997524 |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Sep 19, 2024 | https://github.com/nodejs/node/pull/54831#issuecomment-2360949879 |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/bbfc24b4e5399732d01099e349e41119c119219b..b2ca235608ff79bcea0275afe459d368c2e57611 |
| bbfc24b | https://github.com/nodejs/node/commit/bbfc24b4e5399732d01099e349e41119c119219b |
| b2ca235 | https://github.com/nodejs/node/commit/b2ca235608ff79bcea0275afe459d368c2e57611 |
|
Compare
| https://github.com/nodejs/node/compare/bbfc24b4e5399732d01099e349e41119c119219b..b2ca235608ff79bcea0275afe459d368c2e57611 |
| September 22, 2024 15:16 | https://github.com/nodejs/node/pull/54831#event-14354901206 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54831 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/b2ca235608ff79bcea0275afe459d368c2e57611..f90a790f813330df5b6d4d02177fd91e10cb0e17 |
| b2ca235 | https://github.com/nodejs/node/commit/b2ca235608ff79bcea0275afe459d368c2e57611 |
| f90a790 | https://github.com/nodejs/node/commit/f90a790f813330df5b6d4d02177fd91e10cb0e17 |
|
Compare
| https://github.com/nodejs/node/compare/b2ca235608ff79bcea0275afe459d368c2e57611..f90a790f813330df5b6d4d02177fd91e10cb0e17 |
| September 22, 2024 15:18 | https://github.com/nodejs/node/pull/54831#event-14354906207 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54831 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 22, 2024 | https://github.com/nodejs/node/pull/54831#issuecomment-2366834436 |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Sep 22, 2024 | https://github.com/nodejs/node/pull/54831#event-14354908071 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| anonrig | https://github.com/anonrig |
| September 22, 2024 15:20 | https://github.com/nodejs/node/pull/54831#event-14354908534 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Sep 22, 2024
| https://github.com/nodejs/node/pull/54831#pullrequestreview-2320877130 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54831/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 22, 2024 | https://github.com/nodejs/node/pull/54831#issuecomment-2366856943 |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| September 22, 2024 16:14 | https://github.com/nodejs/node/pull/54831#event-14355015626 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 22, 2024
| https://github.com/nodejs/node/pull/54831#pullrequestreview-2320906582 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54831/files |
| src/spawn_sync.cc | https://github.com/nodejs/node/pull/54831/files#diff-f774c89c36e3b418d01b3f9c2ef90f798f6360dda69811cf7472c3c6bbca36c7 |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
|
| https://github.com/jasnell |
| src: move more stuff over to use Maybe | https://github.com/nodejs/node/pull/54831/commits/d7f1948d6489ef2715238a4159ae8cd66c3cf930 |
| d7f1948 | https://github.com/nodejs/node/pull/54831/commits/d7f1948d6489ef2715238a4159ae8cd66c3cf930 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/f90a790f813330df5b6d4d02177fd91e10cb0e17..d7f1948d6489ef2715238a4159ae8cd66c3cf930 |
| f90a790 | https://github.com/nodejs/node/commit/f90a790f813330df5b6d4d02177fd91e10cb0e17 |
| d7f1948 | https://github.com/nodejs/node/commit/d7f1948d6489ef2715238a4159ae8cd66c3cf930 |
|
Compare
| https://github.com/nodejs/node/compare/f90a790f813330df5b6d4d02177fd91e10cb0e17..d7f1948d6489ef2715238a4159ae8cd66c3cf930 |
| September 24, 2024 17:09 | https://github.com/nodejs/node/pull/54831#event-14385246771 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| September 24, 2024 17:09 | https://github.com/nodejs/node/pull/54831#event-14385251739 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 24, 2024 | https://github.com/nodejs/node/pull/54831#issuecomment-2371862057 |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
| https://ci.nodejs.org/job/node-test-pull-request/62740/ | https://ci.nodejs.org/job/node-test-pull-request/62740/ |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 26, 2024
| https://github.com/nodejs/node/pull/54831#pullrequestreview-2330259213 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54831/files/d7f1948d6489ef2715238a4159ae8cd66c3cf930 |
| jasnell | https://github.com/jasnell |
|
Sep 26, 2024
| https://github.com/nodejs/node/pull/54831#ref-commit-812806a |
|
| https://github.com/jasnell |
| src: move more stuff over to use Maybe | https://github.com/nodejs/node/commit/812806a757b6f5ad83fdd18c301a11347f5c3e37 |
| 812806a | https://github.com/nodejs/node/commit/812806a757b6f5ad83fdd18c301a11347f5c3e37 |
| #54831 | https://github.com/nodejs/node/pull/54831 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 26, 2024 | https://github.com/nodejs/node/pull/54831#issuecomment-2377823503 |
| 812806a | https://github.com/nodejs/node/commit/812806a757b6f5ad83fdd18c301a11347f5c3e37 |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 26, 2024 | https://github.com/nodejs/node/pull/54831#event-14421941177 |
| targos | https://github.com/targos |
|
Oct 4, 2024
| https://github.com/nodejs/node/pull/54831#ref-commit-49eb68b |
|
| https://github.com/jasnell |
|
| https://github.com/targos |
| src: move more stuff over to use Maybe | https://github.com/nodejs/node/commit/49eb68bc19c3290a8ac462334b51b66348a0216a |
| 49eb68b | https://github.com/nodejs/node/commit/49eb68bc19c3290a8ac462334b51b66348a0216a |
| #54831 | https://github.com/nodejs/node/pull/54831 |
| targos | https://github.com/targos |
|
Oct 4, 2024
| https://github.com/nodejs/node/pull/54831#ref-commit-a96d5d1 |
|
| https://github.com/jasnell |
|
| https://github.com/targos |
| src: move more stuff over to use Maybe | https://github.com/nodejs/node/commit/a96d5d1bccc66978b1a6147e261f194cf3eede0a |
| a96d5d1 | https://github.com/nodejs/node/commit/a96d5d1bccc66978b1a6147e261f194cf3eede0a |
| #54831 | https://github.com/nodejs/node/pull/54831 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Oct 9, 2024
| https://github.com/nodejs/node/pull/54831#ref-pullrequest-2577076550 |
|
V22.10.0 proposal
#55343
| https://github.com/nodejs/node/pull/55343 |
| louwers | https://github.com/louwers |
|
Nov 2, 2024
| https://github.com/nodejs/node/pull/54831#ref-commit-d8bba4e |
|
| https://github.com/jasnell |
|
| https://github.com/louwers |
| src: move more stuff over to use Maybe | https://github.com/louwers/node/commit/d8bba4ebfc897cf9cebbe1838ea056d6428946ea |
| d8bba4e | https://github.com/louwers/node/commit/d8bba4ebfc897cf9cebbe1838ea056d6428946ea |
| nodejs#54831 | https://github.com/nodejs/node/pull/54831 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
dont-land-on-v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x |
| Nov 16, 2024 | https://github.com/nodejs/node/pull/54831#event-15321020139 |
| tpoisseau | https://github.com/tpoisseau |
|
Nov 21, 2024
| https://github.com/nodejs/node/pull/54831#ref-commit-4f5a8e1 |
|
| https://github.com/jasnell |
|
| https://github.com/tpoisseau |
| src: move more stuff over to use Maybe | https://github.com/tpoisseau/node/commit/4f5a8e1809b1378279c8e96088b7c7ffd0c103e1 |
| 4f5a8e1 | https://github.com/tpoisseau/node/commit/4f5a8e1809b1378279c8e96088b7c7ffd0c103e1 |
| nodejs#54831 | https://github.com/nodejs/node/pull/54831 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54831 |
|
| https://github.com/anonrig |
|
anonrig
| https://github.com/anonrig |
|
| https://github.com/nodejs/node/pull/54831/files/f90a790f813330df5b6d4d02177fd91e10cb0e17 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/54831/files/d7f1948d6489ef2715238a4159ae8cd66c3cf930 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
dont-land-on-v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Please reload this page | https://github.com/nodejs/node/pull/54831 |
|
| https://github.com/jasnell |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/joyeecheung |
|
| https://github.com/anonrig |
|
| https://github.com/marco-ippolito |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |