René's URL Explorer Experiment


Title: build: run lint before tests by Trott · Pull Request #5470 · nodejs/node · GitHub

Open Graph Title: build: run lint before tests by Trott · Pull Request #5470 · nodejs/node

X Title: build: run lint before tests by Trott · Pull Request #5470 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Have make test run linting tools before tests rather than after. Lint is likely to find issues quickly. Tests may take a while to run. So do the linting first. Interestingly, it appears that vcbuil...

X Description: Have make test run linting tools before tests rather than after. Lint is likely to find issues quickly. Tests may take a while to run. So do the linting first. Interestingly, it appears that vcbuil...

Opengraph URL: https://github.com/nodejs/node/pull/5470

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:de1c1f17-fcc6-21f3-8f83-b7e6050c7084
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9AB4:2E7285:17C532C:20B5879:6A4EA82B
html-safe-nonced5e9e0e87175249da93a8b2b1e9009e1ea09e554e074e393756a35a0d421cdf1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUI0OjJFNzI4NToxN0M1MzJDOjIwQjU4Nzk6NkE0RUE4MkIiLCJ2aXNpdG9yX2lkIjoiNDUzMTc2MDQwNjg2Mzk4MDU4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9d662acb583ec5a9175ff3c7e0662ae83b7f7fa81d369070e6ab00764b1033da
hovercard-subject-tagpull_request:60980278
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/5470/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cb5432eadf0be56242b8f358b90d3bc4e7644d52beca6e2752e6e1882717fb98/nodejs/node/pull/5470
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cb5432eadf0be56242b8f358b90d3bc4e7644d52beca6e2752e6e1882717fb98/nodejs/node/pull/5470
og:image:altHave make test run linting tools before tests rather than after. Lint is likely to find issues quickly. Tests may take a while to run. So do the linting first. Interestingly, it appears that vcbuil...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/5470#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5470
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5470
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/5470
Reloadhttps://github.com/nodejs/node/pull/5470
Reloadhttps://github.com/nodejs/node/pull/5470
Please reload this pagehttps://github.com/nodejs/node/pull/5470
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/5470
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:lint-before-testhttps://github.com/Trott/io.js/tree/lint-before-test
Conversationhttps://github.com/nodejs/node/pull/5470
Commits1 (1)https://github.com/nodejs/node/pull/5470/commits
Checkshttps://github.com/nodejs/node/pull/5470/checks
Files changedhttps://github.com/nodejs/node/pull/5470/files
build: run lint before testshttps://github.com/nodejs/node/pull/5470#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:lint-before-testhttps://github.com/Trott/io.js/tree/lint-before-test
https://github.com/Trott
Trotthttps://github.com/Trott
Feb 28, 2016https://github.com/nodejs/node/pull/5470#issue-137012059
#4546 (comment)https://github.com/nodejs/node/issues/4546#issuecomment-189755007
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/Trott
build: run lint before testshttps://github.com/nodejs/node/pull/5470/commits/86167c2043e4df7e58cb5eb91b3ff12e70e682ef
86167c2https://github.com/nodejs/node/pull/5470/commits/86167c2043e4df7e58cb5eb91b3ff12e70e682ef
nodejs#4546 (comment)https://github.com/nodejs/node/issues/4546#issuecomment-189755007
https://github.com/Trott
Trotthttps://github.com/Trott
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Feb 28, 2016https://github.com/nodejs/node/pull/5470#event-569543583
https://github.com/Trott
Trotthttps://github.com/Trott
Feb 28, 2016 https://github.com/nodejs/node/pull/5470#ref-issue-125090460
test-net-connect-options-ipv6 takes way to long on OS X #4546 https://github.com/nodejs/node/issues/4546
https://github.com/jbergstroem
jbergstroemhttps://github.com/jbergstroem
Feb 28, 2016https://github.com/nodejs/node/pull/5470#issuecomment-189804218
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/ronkorving
ronkorvinghttps://github.com/ronkorving
Feb 28, 2016https://github.com/nodejs/node/pull/5470#issuecomment-189817387
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 28, 2016https://github.com/nodejs/node/pull/5470#issuecomment-189838581
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Feb 28, 2016https://github.com/nodejs/node/pull/5470#issuecomment-189854108
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Feb 29, 2016https://github.com/nodejs/node/pull/5470#issuecomment-190239738
https://github.com/nodejs/node/blob/3c79bbd/vcbuild.bat#L249-L257https://github.com/nodejs/node/blob/3c79bbd/vcbuild.bat#L249-L257
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 1, 2016https://github.com/nodejs/node/pull/5470#issuecomment-190925214
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 1, 2016https://github.com/nodejs/node/pull/5470#issuecomment-190926556
https://ci.nodejs.org/job/node-test-pull-request/1797/https://ci.nodejs.org/job/node-test-pull-request/1797/
Please reload this pagehttps://github.com/nodejs/node/pull/5470
Trotthttps://github.com/Trott
Mar 1, 2016 https://github.com/nodejs/node/pull/5470#ref-commit-d9f7a59
https://github.com/Trott
build: run lint before testshttps://github.com/Trott/io.js/commit/d9f7a597e4d2f5cefda898f8b1223e3fcfb7a07c
d9f7a59https://github.com/Trott/io.js/commit/d9f7a597e4d2f5cefda898f8b1223e3fcfb7a07c
nodejs#4546 (comment)https://github.com/nodejs/node/issues/4546#issuecomment-189755007
nodejs#5470https://github.com/nodejs/node/pull/5470
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 1, 2016https://github.com/nodejs/node/pull/5470#issuecomment-190943561
d9f7a59https://github.com/nodejs/node/commit/d9f7a597e4d2f5cefda898f8b1223e3fcfb7a07c
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 1, 2016https://github.com/nodejs/node/pull/5470#event-573810943
Fishrock123https://github.com/Fishrock123
Mar 2, 2016 https://github.com/nodejs/node/pull/5470#ref-commit-2c619f2
https://github.com/Trott
https://github.com/Fishrock123
build: run lint before testshttps://github.com/nodejs/node/commit/2c619f20129b8b5d9c44a7a310d2ef6e7609ce23
2c619f2https://github.com/nodejs/node/commit/2c619f20129b8b5d9c44a7a310d2ef6e7609ce23
#4546 (comment)https://github.com/nodejs/node/issues/4546#issuecomment-189755007
#5470https://github.com/nodejs/node/pull/5470
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Mar 5, 2016https://github.com/nodejs/node/pull/5470#issuecomment-192699505
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Mar 5, 2016https://github.com/nodejs/node/pull/5470#issuecomment-192712130
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 5, 2016https://github.com/nodejs/node/pull/5470#issuecomment-192729472
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Mar 5, 2016https://github.com/nodejs/node/pull/5470#issuecomment-192735487
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Mar 6, 2016https://github.com/nodejs/node/pull/5470#issuecomment-192870296
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 7, 2016https://github.com/nodejs/node/pull/5470#issuecomment-193375103
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 8, 2016https://github.com/nodejs/node/pull/5470#issuecomment-193598283
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 8, 2016https://github.com/nodejs/node/pull/5470#issuecomment-193621820
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 8, 2016https://github.com/nodejs/node/pull/5470#issuecomment-193622594
@thealphanerdhttps://github.com/thealphanerd
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/jbergstroem
jbergstroemhttps://github.com/jbergstroem
Mar 8, 2016https://github.com/nodejs/node/pull/5470#issuecomment-193630401
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 8, 2016https://github.com/nodejs/node/pull/5470#issuecomment-193875673
#5602https://github.com/nodejs/node/pull/5602
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 8, 2016 https://github.com/nodejs/node/pull/5470#ref-issue-139408394
discuss: Should we alter the behavior of make test? #5607 https://github.com/nodejs/node/issues/5607
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 17, 2016https://github.com/nodejs/node/pull/5470#issuecomment-198033277
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Mar 17, 2016https://github.com/nodejs/node/pull/5470#event-593899512
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 18, 2017 https://github.com/nodejs/node/pull/5470#ref-pullrequest-266368482
build: run linter before running tests #16284 https://github.com/nodejs/node/pull/16284
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:42https://github.com/nodejs/node/pull/5470#event-5890935176
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5470
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Please reload this pagehttps://github.com/nodejs/node/pull/5470
https://github.com/Trott
https://github.com/jbergstroem
https://github.com/ronkorving
https://github.com/MylesBorins
https://github.com/evanlucas
https://github.com/joaocgreis
https://github.com/bnoordhuis
https://github.com/Fishrock123
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.