René's URL Explorer Experiment


Title: [v22.x] src: handle errors correctly in webstorage by targos · Pull Request #54683 · nodejs/node · GitHub

Open Graph Title: [v22.x] src: handle errors correctly in webstorage by targos · Pull Request #54683 · nodejs/node

X Title: [v22.x] src: handle errors correctly in webstorage by targos · Pull Request #54683 · nodejs/node

Opengraph URL: https://github.com/nodejs/node/pull/54683

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8e6c2a67-871b-7978-4574-6a103b15c49f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id80CA:2F21B4:CDC0CE:10AE87E:696B2BFD
html-safe-noncefe4c40a647ce02defc76a5fda5b67a5fd8d8a5ffd0bed7167991faddf107ec2c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MENBOjJGMjFCNDpDREMwQ0U6MTBBRTg3RTo2OTZCMkJGRCIsInZpc2l0b3JfaWQiOiI0NDYwMjYwNTI3MTk5NDMxNjc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac87ea9f54f3681b21722ca22f3b61d28af146f48a561a9d69004d3b211ca871ab
hovercard-subject-tagpull_request:2048100361
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/54683/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/18197a1c4e3faabb6aa6a34c6b69915a809851a363acdd66bc6eb729aecbfbc6/nodejs/node/pull/54683
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/18197a1c4e3faabb6aa6a34c6b69915a809851a363acdd66bc6eb729aecbfbc6/nodejs/node/pull/54683
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametargos
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/54683#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54683
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54683
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/54683
Reloadhttps://github.com/nodejs/node/pull/54683
Reloadhttps://github.com/nodejs/node/pull/54683
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/54683
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/54683
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/54683#issue-comment-box
targoshttps://github.com/targos
nodejs:v22.x-staginghttps://github.com/nodejs/node/tree/v22.x-staging
targos:backport-54544-v22https://github.com/targos/node/tree/backport-54544-v22
[v22.x] src: handle errors correctly in webstorage https://github.com/nodejs/node/pull/54683#top
targoshttps://github.com/targos
nodejs:v22.x-staginghttps://github.com/nodejs/node/tree/v22.x-staging
targos:backport-54544-v22https://github.com/targos/node/tree/backport-54544-v22
Conversation 8 https://github.com/nodejs/node/pull/54683
Commits 1 https://github.com/nodejs/node/pull/54683/commits
Checks 0 https://github.com/nodejs/node/pull/54683/checks
Files changed https://github.com/nodejs/node/pull/54683/files
Please reload this pagehttps://github.com/nodejs/node/pull/54683
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/targos
targoshttps://github.com/targos
Sep 1, 2024https://github.com/nodejs/node/pull/54683#issue-2499309894
Please reload this pagehttps://github.com/nodejs/node/pull/54683
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v22.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av22.x
Sep 1, 2024https://github.com/nodejs/node/pull/54683#event-14093844342
https://github.com/targos
targoshttps://github.com/targos
Sep 1, 2024 https://github.com/nodejs/node/pull/54683#ref-pullrequest-2484729688
src: handle errors correctly in webstorage #54544 https://github.com/nodejs/node/pull/54544
https://github.com/targos
targoshttps://github.com/targos
Sep 1, 2024 https://github.com/nodejs/node/pull/54683#pullrequestreview-2274242378
View reviewed changes https://github.com/nodejs/node/pull/54683/files
src/node_webstorage.cchttps://github.com/nodejs/node/pull/54683/files#diff-9db77e69b882a1a27952f7c02939474c044ba385d9de529087e93bb5e6b32ff1
Please reload this pagehttps://github.com/nodejs/node/pull/54683
https://github.com/targos
targoshttps://github.com/targos
September 1, 2024 09:38https://github.com/nodejs/node/pull/54683#event-14094011613
https://github.com/targos
targoshttps://github.com/targos
force-pushedhttps://github.com/nodejs/node/compare/d8416b717d32dec78b43020104ee0788a3e56058..170a9aec9b8b8ed5e1b2d5269ff690d8d365d066
d8416b7https://github.com/nodejs/node/commit/d8416b717d32dec78b43020104ee0788a3e56058
170a9aehttps://github.com/nodejs/node/commit/170a9aec9b8b8ed5e1b2d5269ff690d8d365d066
Compare https://github.com/nodejs/node/compare/d8416b717d32dec78b43020104ee0788a3e56058..170a9aec9b8b8ed5e1b2d5269ff690d8d365d066
September 5, 2024 16:07https://github.com/nodejs/node/pull/54683#event-14149869556
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2024https://github.com/nodejs/node/pull/54683#issuecomment-2332129585
Please reload this pagehttps://github.com/nodejs/node/pull/54683
Please reload this pagehttps://github.com/nodejs/node/pull/54683
https://github.com/targos
targoshttps://github.com/targos
September 5, 2024 16:09https://github.com/nodejs/node/pull/54683#event-14149891618
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 5, 2024 https://github.com/nodejs/node/pull/54683#pullrequestreview-2283634699
View reviewed changes https://github.com/nodejs/node/pull/54683/files/87ece12f639ef6e39a5855baa16203b89b81eb29
https://github.com/targos
targoshttps://github.com/targos
Sep 6, 2024https://github.com/nodejs/node/pull/54683#issuecomment-2333322421
Please reload this pagehttps://github.com/nodejs/node/pull/54683
https://github.com/aduh95
aduh95https://github.com/aduh95
force-pushedhttps://github.com/nodejs/node/compare/fec390e4cf66dbfaa7a79b09de8a4bdfb860b4f4..2b68c30a26cc3880db64662ff28927807fea428b
fec390ehttps://github.com/nodejs/node/commit/fec390e4cf66dbfaa7a79b09de8a4bdfb860b4f4
2b68c30https://github.com/nodejs/node/commit/2b68c30a26cc3880db64662ff28927807fea428b
Compare https://github.com/nodejs/node/compare/fec390e4cf66dbfaa7a79b09de8a4bdfb860b4f4..2b68c30a26cc3880db64662ff28927807fea428b
September 13, 2024 22:27https://github.com/nodejs/node/pull/54683#event-14255074858
https://github.com/targos
src: handle errors correctly in webstoragehttps://github.com/nodejs/node/pull/54683/commits/87ece12f639ef6e39a5855baa16203b89b81eb29
87ece12https://github.com/nodejs/node/pull/54683/commits/87ece12f639ef6e39a5855baa16203b89b81eb29
nodejs#54544https://github.com/nodejs/node/pull/54544
https://github.com/targos
targoshttps://github.com/targos
force-pushedhttps://github.com/nodejs/node/compare/170a9aec9b8b8ed5e1b2d5269ff690d8d365d066..87ece12f639ef6e39a5855baa16203b89b81eb29
170a9aehttps://github.com/nodejs/node/commit/170a9aec9b8b8ed5e1b2d5269ff690d8d365d066
87ece12https://github.com/nodejs/node/commit/87ece12f639ef6e39a5855baa16203b89b81eb29
Compare https://github.com/nodejs/node/compare/170a9aec9b8b8ed5e1b2d5269ff690d8d365d066..87ece12f639ef6e39a5855baa16203b89b81eb29
September 16, 2024 06:35https://github.com/nodejs/node/pull/54683#event-14267375510
https://github.com/targos
targoshttps://github.com/targos
Sep 16, 2024https://github.com/nodejs/node/pull/54683#issuecomment-2352113179
Please reload this pagehttps://github.com/nodejs/node/pull/54683
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
force-pushedhttps://github.com/nodejs/node/compare/8997e69080f29cbb2eab664481a54f7aa2f7c740..beb4925c1d3281cb0c722f0243c8bb95a0a8a8f9
8997e69https://github.com/nodejs/node/commit/8997e69080f29cbb2eab664481a54f7aa2f7c740
beb4925https://github.com/nodejs/node/commit/beb4925c1d3281cb0c722f0243c8bb95a0a8a8f9
Compare https://github.com/nodejs/node/compare/8997e69080f29cbb2eab664481a54f7aa2f7c740..beb4925c1d3281cb0c722f0243c8bb95a0a8a8f9
September 17, 2024 02:21https://github.com/nodejs/node/pull/54683#event-14283222531
https://github.com/targos
targoshttps://github.com/targos
Sep 17, 2024https://github.com/nodejs/node/pull/54683#issuecomment-2355295367
#54966https://github.com/nodejs/node/pull/54966
Please reload this pagehttps://github.com/nodejs/node/pull/54683
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
force-pushedhttps://github.com/nodejs/node/compare/beb4925c1d3281cb0c722f0243c8bb95a0a8a8f9..93116dd7b1f9f121f410b9856fe3626a92d2db2b
beb4925https://github.com/nodejs/node/commit/beb4925c1d3281cb0c722f0243c8bb95a0a8a8f9
93116ddhttps://github.com/nodejs/node/commit/93116dd7b1f9f121f410b9856fe3626a92d2db2b
Compare https://github.com/nodejs/node/compare/beb4925c1d3281cb0c722f0243c8bb95a0a8a8f9..93116dd7b1f9f121f410b9856fe3626a92d2db2b
September 17, 2024 14:18https://github.com/nodejs/node/pull/54683#event-14292241617
https://github.com/targos
targoshttps://github.com/targos
Sep 19, 2024https://github.com/nodejs/node/pull/54683#issuecomment-2360123794
@RafaelGSShttps://github.com/RafaelGSS
Please reload this pagehttps://github.com/nodejs/node/pull/54683
https://github.com/targos
targoshttps://github.com/targos
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 5, 2024https://github.com/nodejs/node/pull/54683#event-14527278546
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 5, 2024https://github.com/nodejs/node/pull/54683#event-14527286062
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 5, 2024https://github.com/nodejs/node/pull/54683#issuecomment-2394988687
https://ci.nodejs.org/job/node-test-pull-request/62925/https://ci.nodejs.org/job/node-test-pull-request/62925/
Please reload this pagehttps://github.com/nodejs/node/pull/54683
targoshttps://github.com/targos
Oct 6, 2024 https://github.com/nodejs/node/pull/54683#ref-commit-0999949
https://github.com/targos
src: handle errors correctly in webstoragehttps://github.com/nodejs/node/commit/09999491bf386011d282b651fc862ee9c7e86cc1
0999949https://github.com/nodejs/node/commit/09999491bf386011d282b651fc862ee9c7e86cc1
#54544https://github.com/nodejs/node/pull/54544
#54683https://github.com/nodejs/node/pull/54683
https://github.com/targos
targoshttps://github.com/targos
Oct 6, 2024https://github.com/nodejs/node/pull/54683#issuecomment-2395450752
0999949https://github.com/nodejs/node/commit/09999491bf386011d282b651fc862ee9c7e86cc1
Please reload this pagehttps://github.com/nodejs/node/pull/54683
https://github.com/targos
targoshttps://github.com/targos
Oct 6, 2024https://github.com/nodejs/node/pull/54683#event-14530667513
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54683
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/54683/files/87ece12f639ef6e39a5855baa16203b89b81eb29
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v22.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av22.x
Please reload this pagehttps://github.com/nodejs/node/pull/54683
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.