| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f5f9cfb1-7a80-f2c5-95ea-224661e98184 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9FF8:247E0C:568249:787EE7:696A78D6 |
| html-safe-nonce | fd1d29f42d4767ca563571653eea5b618c4a9e0f7d6a89c8a0b62d56eb55a90d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkY4OjI0N0UwQzo1NjgyNDk6Nzg3RUU3OjY5NkE3OEQ2IiwidmlzaXRvcl9pZCI6Ijc3OTU0MTgxMDcwMzQxMDYwNzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 71a420f160273077476307cca51f561ce8557d04646626e384cb29977f413536 |
| hovercard-subject-tag | pull_request:2038242310 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/54575/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f54ffc61ecb891172fb97805f3a44ddcf4a9db700afe1a015f3dd14dc47f5cb0/nodejs/node/pull/54575 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f54ffc61ecb891172fb97805f3a44ddcf4a9db700afe1a015f3dd14dc47f5cb0/nodejs/node/pull/54575 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | targos |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5b774e44f85c14a75886edd04ddda4e5a25ddebbb241bcbb590b08a3048730e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cc5f4eee261b3601c1e98e217ceaf28508b9567e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/54575#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54575 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54575 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/54575 |
| Reload | https://github.com/nodejs/node/pull/54575 |
| Reload | https://github.com/nodejs/node/pull/54575 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/54575#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| targos:src-maybe-void | https://github.com/targos/node/tree/src-maybe-void |
|
src: use Maybe where bool isn't needed
| https://github.com/nodejs/node/pull/54575#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| targos:src-maybe-void | https://github.com/targos/node/tree/src-maybe-void |
|
Conversation
12
| https://github.com/nodejs/node/pull/54575 |
|
Commits
1
| https://github.com/nodejs/node/pull/54575/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/54575/checks |
|
Files changed
| https://github.com/nodejs/node/pull/54575/files |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/targos |
| targos | https://github.com/targos |
| Aug 26, 2024 | https://github.com/nodejs/node/pull/54575#issue-2487762832 |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 26, 2024 | https://github.com/nodejs/node/pull/54575#issuecomment-2311074520 |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Aug 26, 2024 | https://github.com/nodejs/node/pull/54575#event-14018954060 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Aug 26, 2024 | https://github.com/nodejs/node/pull/54575#issuecomment-2311233690 |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
| Codecov | https://app.codecov.io/gh/nodejs/node/pull/54575?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (53ede87) | https://app.codecov.io/gh/nodejs/node/commit/53ede878a51aee2dd2d1c97b5cefa43ae12f14aa?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (d64b603) | https://app.codecov.io/gh/nodejs/node/commit/d64b603f23451b75ef765d815f295c96cd2753e2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/54575?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/node_contextify.cc | https://app.codecov.io/gh/nodejs/node/pull/54575?src=pr&el=tree&filepath=src%2Fnode_contextify.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfY29udGV4dGlmeS5jYw== |
| 4 Missing ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/54575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/cares_wrap.cc | https://app.codecov.io/gh/nodejs/node/pull/54575?src=pr&el=tree&filepath=src%2Fcares_wrap.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2NhcmVzX3dyYXAuY2M= |
| 1 Missing ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/54575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/string_bytes.h | https://app.codecov.io/gh/nodejs/node/pull/54575?src=pr&el=tree&filepath=src%2Fstring_bytes.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL3N0cmluZ19ieXRlcy5o |
| 1 Missing ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/54575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/54575?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/node_contextify.h | https://app.codecov.io/gh/nodejs/node/pull/54575?src=pr&el=tree&filepath=src%2Fnode_contextify.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfY29udGV4dGlmeS5o |
| src/cares_wrap.cc | https://app.codecov.io/gh/nodejs/node/pull/54575?src=pr&el=tree&filepath=src%2Fcares_wrap.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2NhcmVzX3dyYXAuY2M= |
| src/string_bytes.h | https://app.codecov.io/gh/nodejs/node/pull/54575?src=pr&el=tree&filepath=src%2Fstring_bytes.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL3N0cmluZ19ieXRlcy5o |
| src/node_contextify.cc | https://app.codecov.io/gh/nodejs/node/pull/54575?src=pr&el=tree&filepath=src%2Fnode_contextify.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfY29udGV4dGlmeS5jYw== |
| 22 files with indirect coverage changes | https://app.codecov.io/gh/nodejs/node/pull/54575/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 27, 2024
| https://github.com/nodejs/node/pull/54575#pullrequestreview-2263831718 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54575/files/d64b603f23451b75ef765d815f295c96cd2753e2 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Aug 29, 2024
| https://github.com/nodejs/node/pull/54575#pullrequestreview-2267836713 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54575/files/d64b603f23451b75ef765d815f295c96cd2753e2 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
| Aug 29, 2024 | https://github.com/nodejs/node/pull/54575#event-14056692797 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 29, 2024 | https://github.com/nodejs/node/pull/54575#event-14056709357 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 29, 2024 | https://github.com/nodejs/node/pull/54575#issuecomment-2316852604 |
| https://ci.nodejs.org/job/node-test-pull-request/61641/ | https://ci.nodejs.org/job/node-test-pull-request/61641/ |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Aug 29, 2024
| https://github.com/nodejs/node/pull/54575#pullrequestreview-2269451169 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54575/files/d64b603f23451b75ef765d815f295c96cd2753e2 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 30, 2024 | https://github.com/nodejs/node/pull/54575#issuecomment-2320079416 |
| https://ci.nodejs.org/job/node-test-pull-request/61687/ | https://ci.nodejs.org/job/node-test-pull-request/61687/ |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 31, 2024 | https://github.com/nodejs/node/pull/54575#issuecomment-2322797831 |
| https://ci.nodejs.org/job/node-test-pull-request/61731/ | https://ci.nodejs.org/job/node-test-pull-request/61731/ |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
| https://github.com/JungMinu |
| JungMinu | https://github.com/JungMinu |
|
Sep 1, 2024
| https://github.com/nodejs/node/pull/54575#pullrequestreview-2274211746 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54575/files/d64b603f23451b75ef765d815f295c96cd2753e2 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Sep 1, 2024
| https://github.com/nodejs/node/pull/54575#pullrequestreview-2274310097 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54575/files/d64b603f23451b75ef765d815f295c96cd2753e2 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 1, 2024 | https://github.com/nodejs/node/pull/54575#issuecomment-2323286469 |
| https://ci.nodejs.org/job/node-test-pull-request/61782/ | https://ci.nodejs.org/job/node-test-pull-request/61782/ |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 2, 2024 | https://github.com/nodejs/node/pull/54575#issuecomment-2324186071 |
| https://ci.nodejs.org/job/node-test-pull-request/61813/ | https://ci.nodejs.org/job/node-test-pull-request/61813/ |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 2, 2024 | https://github.com/nodejs/node/pull/54575#issuecomment-2324938698 |
| https://ci.nodejs.org/job/node-test-pull-request/61827/ | https://ci.nodejs.org/job/node-test-pull-request/61827/ |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
|
| https://github.com/targos |
| src: use Maybe where bool isn't needed | https://github.com/nodejs/node/pull/54575/commits/d64b603f23451b75ef765d815f295c96cd2753e2 |
| d64b603 | https://github.com/nodejs/node/pull/54575/commits/d64b603f23451b75ef765d815f295c96cd2753e2 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/8e4b978f8eef0a05ec30043d0860b16ba56903dd..d64b603f23451b75ef765d815f295c96cd2753e2 |
| 8e4b978 | https://github.com/nodejs/node/commit/8e4b978f8eef0a05ec30043d0860b16ba56903dd |
| d64b603 | https://github.com/nodejs/node/commit/d64b603f23451b75ef765d815f295c96cd2753e2 |
|
Compare
| https://github.com/nodejs/node/compare/8e4b978f8eef0a05ec30043d0860b16ba56903dd..d64b603f23451b75ef765d815f295c96cd2753e2 |
| September 16, 2024 06:33 | https://github.com/nodejs/node/pull/54575#event-14267359059 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 16, 2024 | https://github.com/nodejs/node/pull/54575#issuecomment-2352111433 |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 16, 2024 | https://github.com/nodejs/node/pull/54575#event-14272342668 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 16, 2024 | https://github.com/nodejs/node/pull/54575#event-14272499198 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 16, 2024 | https://github.com/nodejs/node/pull/54575#issuecomment-2352827508 |
| https://ci.nodejs.org/job/node-test-pull-request/62476/ | https://ci.nodejs.org/job/node-test-pull-request/62476/ |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 17, 2024 | https://github.com/nodejs/node/pull/54575#issuecomment-2354626205 |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 17, 2024
| https://github.com/nodejs/node/pull/54575#pullrequestreview-2308528437 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54575/files/d64b603f23451b75ef765d815f295c96cd2753e2 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
| Sep 17, 2024 | https://github.com/nodejs/node/pull/54575#event-14286243768 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Sep 17, 2024 | https://github.com/nodejs/node/pull/54575#event-14286266407 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| d2a4f92 | https://github.com/nodejs/node/commit/d2a4f92920b8257b2f1916440d08057508d54bc0 |
| Sep 17, 2024 | https://github.com/nodejs/node/pull/54575#event-14286267147 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 17, 2024 | https://github.com/nodejs/node/pull/54575#issuecomment-2354801208 |
| d2a4f92 | https://github.com/nodejs/node/commit/d2a4f92920b8257b2f1916440d08057508d54bc0 |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
| https://github.com/targos |
| targos | https://github.com/targos |
| September 17, 2024 07:57 | https://github.com/nodejs/node/pull/54575#event-14286322618 |
| targos | https://github.com/targos |
|
Oct 4, 2024
| https://github.com/nodejs/node/pull/54575#ref-commit-f332c4c |
|
| https://github.com/targos |
| src: use Maybe where bool isn't needed | https://github.com/nodejs/node/commit/f332c4c4fcc48efd8b6542b51fec9a22ec8d87aa |
| f332c4c | https://github.com/nodejs/node/commit/f332c4c4fcc48efd8b6542b51fec9a22ec8d87aa |
| #54575 | https://github.com/nodejs/node/pull/54575 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Oct 9, 2024
| https://github.com/nodejs/node/pull/54575#ref-pullrequest-2577076550 |
|
V22.10.0 proposal
#55343
| https://github.com/nodejs/node/pull/55343 |
| louwers | https://github.com/louwers |
|
Nov 2, 2024
| https://github.com/nodejs/node/pull/54575#ref-commit-7060b7f |
|
| https://github.com/targos |
|
| https://github.com/louwers |
| src: use Maybe where bool isn't needed | https://github.com/louwers/node/commit/7060b7f5cef64b707eae6c45a012413ee3afede6 |
| 7060b7f | https://github.com/louwers/node/commit/7060b7f5cef64b707eae6c45a012413ee3afede6 |
| nodejs#54575 | https://github.com/nodejs/node/pull/54575 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
dont-land-on-v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x |
| Nov 16, 2024 | https://github.com/nodejs/node/pull/54575#event-15320998619 |
| tpoisseau | https://github.com/tpoisseau |
|
Nov 21, 2024
| https://github.com/nodejs/node/pull/54575#ref-commit-9e55ed0 |
|
| https://github.com/targos |
|
| https://github.com/tpoisseau |
| src: use Maybe where bool isn't needed | https://github.com/tpoisseau/node/commit/9e55ed0e4d409813a6bef77f084077edc3289289 |
| 9e55ed0 | https://github.com/tpoisseau/node/commit/9e55ed0e4d409813a6bef77f084077edc3289289 |
| nodejs#54575 | https://github.com/nodejs/node/pull/54575 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54575 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/54575/files/d64b603f23451b75ef765d815f295c96cd2753e2 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/54575/files/d64b603f23451b75ef765d815f295c96cd2753e2 |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/54575/files/d64b603f23451b75ef765d815f295c96cd2753e2 |
|
| https://github.com/JungMinu |
|
JungMinu
| https://github.com/JungMinu |
|
| https://github.com/nodejs/node/pull/54575/files/d64b603f23451b75ef765d815f295c96cd2753e2 |
|
| https://github.com/legendecas |
|
legendecas
| https://github.com/legendecas |
|
| https://github.com/nodejs/node/pull/54575/files/d64b603f23451b75ef765d815f295c96cd2753e2 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
dont-land-on-v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Please reload this page | https://github.com/nodejs/node/pull/54575 |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/tniessen |
|
| https://github.com/JungMinu |
|
| https://github.com/legendecas |
|
| https://github.com/marco-ippolito |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |