René's URL Explorer Experiment


Title: test: refactor test-abortcontroller to use node:test by jasnell · Pull Request #54574 · nodejs/node · GitHub

Open Graph Title: test: refactor test-abortcontroller to use node:test by jasnell · Pull Request #54574 · nodejs/node

X Title: test: refactor test-abortcontroller to use node:test by jasnell · Pull Request #54574 · nodejs/node

Description: Starting the long process of refactoring our own tests to use the node:test module and mocks. Also, splits the test that depends on internal API from the rest of the tests to make it easier to diff...

Open Graph Description: Starting the long process of refactoring our own tests to use the node:test module and mocks. Also, splits the test that depends on internal API from the rest of the tests to make it easier to diff...

X Description: Starting the long process of refactoring our own tests to use the node:test module and mocks. Also, splits the test that depends on internal API from the rest of the tests to make it easier to diff...

Opengraph URL: https://github.com/nodejs/node/pull/54574

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:68503dc7-7bbc-b93a-bfc8-a9933b76f80e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCC0:217CB4:1BB1D2:2668EE:696A63D1
html-safe-nonceb1ec07784f5bb6016087e52b3726a0eaf1928b0d7994c84c39149a3ef9984525
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0MwOjIxN0NCNDoxQkIxRDI6MjY2OEVFOjY5NkE2M0QxIiwidmlzaXRvcl9pZCI6Ijc5Njc2MTg2Nzg5NjM5ODc0MDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac160fe4bd96db9f7baf0af3b7e299dfc9c6f6b2d41c305d368a72e68f6d3fcfc0
hovercard-subject-tagpull_request:2038236145
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/54574/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7646a604efdac7a9833ae38e0bd6107213e3079abbbb7f397fe12a6155794a1e/nodejs/node/pull/54574
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7646a604efdac7a9833ae38e0bd6107213e3079abbbb7f397fe12a6155794a1e/nodejs/node/pull/54574
og:image:altStarting the long process of refactoring our own tests to use the node:test module and mocks. Also, splits the test that depends on internal API from the rest of the tests to make it easier to diff...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
None9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release87cbd411c2982752221b5751d583a515b23bf5fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/54574#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54574
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54574
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/54574
Reloadhttps://github.com/nodejs/node/pull/54574
Reloadhttps://github.com/nodejs/node/pull/54574
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/54574
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 694 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/54574
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/54574#issue-comment-box
jasnellhttps://github.com/jasnell
nodejs:mainhttps://github.com/nodejs/node/tree/main
jasnell:use-test-in-test-abortcontrollerhttps://github.com/jasnell/node/tree/use-test-in-test-abortcontroller
test: refactor test-abortcontroller to use node:test https://github.com/nodejs/node/pull/54574#top
jasnellhttps://github.com/jasnell
nodejs:mainhttps://github.com/nodejs/node/tree/main
jasnell:use-test-in-test-abortcontrollerhttps://github.com/jasnell/node/tree/use-test-in-test-abortcontroller
Conversation 15 https://github.com/nodejs/node/pull/54574
Commits 1 https://github.com/nodejs/node/pull/54574/commits
Checks 0 https://github.com/nodejs/node/pull/54574/checks
Files changed https://github.com/nodejs/node/pull/54574/files
Please reload this pagehttps://github.com/nodejs/node/pull/54574
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 26, 2024https://github.com/nodejs/node/pull/54574#issue-2487756166
Please reload this pagehttps://github.com/nodejs/node/pull/54574
https://github.com/jasnell
test: refactor test-abortcontroller to use node:testhttps://github.com/nodejs/node/pull/54574/commits/fb44af9620c6ea9d714cb85d6464a30ffc10f386
fb44af9https://github.com/nodejs/node/pull/54574/commits/fb44af9620c6ea9d714cb85d6464a30ffc10f386
https://github.com/jasnell
jasnellhttps://github.com/jasnell
anonrighttps://github.com/anonrig
August 26, 2024 20:49https://github.com/nodejs/node/pull/54574#event-14018915535
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Aug 26, 2024https://github.com/nodejs/node/pull/54574#event-14018916257
https://github.com/jasnell
jasnellhttps://github.com/jasnell
mcollinahttps://github.com/mcollina
August 26, 2024 20:49https://github.com/nodejs/node/pull/54574#event-14018916622
https://github.com/anonrig
anonrighttps://github.com/anonrig
Aug 26, 2024 https://github.com/nodejs/node/pull/54574#pullrequestreview-2261625175
View reviewed changes https://github.com/nodejs/node/pull/54574/files/fb44af9620c6ea9d714cb85d6464a30ffc10f386
test/parallel/test-abortcontroller.jshttps://github.com/nodejs/node/pull/54574/files/fb44af9620c6ea9d714cb85d6464a30ffc10f386#diff-640f9a072a22cd20152bc70a19a844696a1894a46deae08abbea7cd67b3b4dd0
anonrighttps://github.com/anonrig
Aug 26, 2024https://github.com/nodejs/node/pull/54574#discussion_r1731814685
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/54574
https://github.com/jasnell
jasnellhttps://github.com/jasnell
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 26, 2024https://github.com/nodejs/node/pull/54574#event-14019299076
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 26, 2024https://github.com/nodejs/node/pull/54574#event-14019357140
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54574
https://github.com/apps/codecov
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54574
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 27, 2024https://github.com/nodejs/node/pull/54574#issuecomment-2312544263
Please reload this pagehttps://github.com/nodejs/node/pull/54574
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 27, 2024https://github.com/nodejs/node/pull/54574#issuecomment-2312617499
Please reload this pagehttps://github.com/nodejs/node/pull/54574
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 27, 2024https://github.com/nodejs/node/pull/54574#issuecomment-2312662020
Please reload this pagehttps://github.com/nodejs/node/pull/54574
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 27, 2024https://github.com/nodejs/node/pull/54574#issuecomment-2312741676
Please reload this pagehttps://github.com/nodejs/node/pull/54574
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54574
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 27, 2024https://github.com/nodejs/node/pull/54574#issuecomment-2312764520
Please reload this pagehttps://github.com/nodejs/node/pull/54574
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 27, 2024https://github.com/nodejs/node/pull/54574#issuecomment-2312773791
Please reload this pagehttps://github.com/nodejs/node/pull/54574
Please reload this pagehttps://github.com/nodejs/node/pull/54574
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 27, 2024https://github.com/nodejs/node/pull/54574#issuecomment-2312831355
Please reload this pagehttps://github.com/nodejs/node/pull/54574
Please reload this pagehttps://github.com/nodejs/node/pull/54574
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 27, 2024https://github.com/nodejs/node/pull/54574#issuecomment-2312876915
Please reload this pagehttps://github.com/nodejs/node/pull/54574
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 28, 2024 https://github.com/nodejs/node/pull/54574#pullrequestreview-2266168292
View reviewed changes https://github.com/nodejs/node/pull/54574/files/fb44af9620c6ea9d714cb85d6464a30ffc10f386
https://github.com/jasnell
jasnellhttps://github.com/jasnell
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 28, 2024https://github.com/nodejs/node/pull/54574#event-14053330523
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54574
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 28, 2024https://github.com/nodejs/node/pull/54574#issuecomment-2316428811
Please reload this pagehttps://github.com/nodejs/node/pull/54574
https://ci.nodejs.org/job/node-test-pull-request/61617/https://ci.nodejs.org/job/node-test-pull-request/61617/
Please reload this pagehttps://github.com/nodejs/node/pull/54574
jasnellhttps://github.com/jasnell
Aug 29, 2024 https://github.com/nodejs/node/pull/54574#ref-commit-39215e1
https://github.com/jasnell
test: refactor test-abortcontroller to use node:testhttps://github.com/nodejs/node/commit/39215e1cfa3d689b6f2090de988a6c7b6e3a761d
39215e1https://github.com/nodejs/node/commit/39215e1cfa3d689b6f2090de988a6c7b6e3a761d
#54574https://github.com/nodejs/node/pull/54574
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 29, 2024https://github.com/nodejs/node/pull/54574#issuecomment-2316562064
39215e1https://github.com/nodejs/node/commit/39215e1cfa3d689b6f2090de988a6c7b6e3a761d
Please reload this pagehttps://github.com/nodejs/node/pull/54574
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 29, 2024https://github.com/nodejs/node/pull/54574#event-14054717774
RafaelGSShttps://github.com/RafaelGSS
Aug 30, 2024 https://github.com/nodejs/node/pull/54574#ref-commit-1f9d654
https://github.com/jasnell
https://github.com/RafaelGSS
test: refactor test-abortcontroller to use node:testhttps://github.com/nodejs/node/commit/1f9d654085f35c066d420107f28f074dd112184d
1f9d654https://github.com/nodejs/node/commit/1f9d654085f35c066d420107f28f074dd112184d
#54574https://github.com/nodejs/node/pull/54574
RafaelGSShttps://github.com/RafaelGSS
Aug 30, 2024 https://github.com/nodejs/node/pull/54574#ref-commit-9d0628a
https://github.com/jasnell
https://github.com/RafaelGSS
test: refactor test-abortcontroller to use node:testhttps://github.com/nodejs/node/commit/9d0628a84853ebad24407b730377258ef301483d
9d0628ahttps://github.com/nodejs/node/commit/9d0628a84853ebad24407b730377258ef301483d
#54574https://github.com/nodejs/node/pull/54574
RafaelGSShttps://github.com/RafaelGSS
Aug 30, 2024 https://github.com/nodejs/node/pull/54574#ref-commit-64442fc
https://github.com/jasnell
https://github.com/RafaelGSS
test: refactor test-abortcontroller to use node:testhttps://github.com/nodejs/node/commit/64442fce6b02c624e23dfeb00e2cbfec3dddc625
64442fchttps://github.com/nodejs/node/commit/64442fce6b02c624e23dfeb00e2cbfec3dddc625
#54574https://github.com/nodejs/node/pull/54574
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Aug 30, 2024 https://github.com/nodejs/node/pull/54574#ref-pullrequest-2485481605
v22.8.0 proposal #54560 https://github.com/nodejs/node/pull/54560
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x
Sep 22, 2024https://github.com/nodejs/node/pull/54574#event-14351928275
louwershttps://github.com/louwers
Nov 2, 2024 https://github.com/nodejs/node/pull/54574#ref-commit-7ea4858
https://github.com/jasnell
https://github.com/louwers
test: refactor test-abortcontroller to use node:testhttps://github.com/louwers/node/commit/7ea4858563daf55a3f46fef259a4d66e76367b9e
7ea4858https://github.com/louwers/node/commit/7ea4858563daf55a3f46fef259a4d66e76367b9e
nodejs#54574https://github.com/nodejs/node/pull/54574
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 22, 2025 https://github.com/nodejs/node/pull/54574#ref-pullrequest-2800434240
improve the structure of the test-event-emitter-num-args file and use the node test runner #56671 https://github.com/nodejs/node/pull/56671
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54574
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/54574/files/fb44af9620c6ea9d714cb85d6464a30ffc10f386
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/54574/files/fb44af9620c6ea9d714cb85d6464a30ffc10f386
https://github.com/mcollina
mcollina https://github.com/mcollina
dont-land-on-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/54574
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com/cjihrig
https://github.com/lpinca
https://github.com/anonrig
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.