| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:463ca7a4-00e8-46af-3a0e-ff0780b3f0a3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B94C:39C817:7FD1D9:B244FB:696A2AC6 |
| html-safe-nonce | 19ef3e3a01307ba8ee6fb7ba084813ff6a6e285e644e6b3566096ac5d115055f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTRDOjM5QzgxNzo3RkQxRDk6QjI0NEZCOjY5NkEyQUM2IiwidmlzaXRvcl9pZCI6IjQxMzE5MDE1MTEzOTE5MTQ2OTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1c4fe2af5c36e42546be71bd8aa9b62ba4a6a13fa7ddd737fc91c6d93253f7fb |
| hovercard-subject-tag | pull_request:2035510449 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/54541/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/22d353c8d3cdea0428bd95b039675d3906c0370ef7416cc3df602daed24e3a0c/nodejs/node/pull/54541 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/22d353c8d3cdea0428bd95b039675d3906c0370ef7416cc3df602daed24e3a0c/nodejs/node/pull/54541 |
| og:image:alt | First commit allows to simplify the code I changed in the second one. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | targos |
| hostname | github.com |
| expected-hostname | github.com |
| None | a1022f03e4f0d91ea173e4e5dac892c982e0588c62f1ce56121d755a320a3569 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f472b8e6c7b3fdd5d0354972a3f4c516289bf0be |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/54541#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54541 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54541 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/54541 |
| Reload | https://github.com/nodejs/node/pull/54541 |
| Reload | https://github.com/nodejs/node/pull/54541 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/54541 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/54541 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/54541#issue-comment-box |
| targos | https://github.com/targos |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| targos:permission-maybe | https://github.com/targos/node/tree/permission-maybe |
|
src: handle errors correctly in permission.cc
| https://github.com/nodejs/node/pull/54541#top |
| targos | https://github.com/targos |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| targos:permission-maybe | https://github.com/targos/node/tree/permission-maybe |
|
Conversation
7
| https://github.com/nodejs/node/pull/54541 |
|
Commits
2
| https://github.com/nodejs/node/pull/54541/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/54541/checks |
|
Files changed
| https://github.com/nodejs/node/pull/54541/files |
| Please reload this page | https://github.com/nodejs/node/pull/54541 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/targos |
| targos | https://github.com/targos |
| Aug 24, 2024 | https://github.com/nodejs/node/pull/54541#issue-2484647376 |
| Please reload this page | https://github.com/nodejs/node/pull/54541 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
commit-queue-rebase
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-rebase |
| Aug 24, 2024 | https://github.com/nodejs/node/pull/54541#event-14001560810 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 24, 2024 | https://github.com/nodejs/node/pull/54541#issuecomment-2308419105 |
| Please reload this page | https://github.com/nodejs/node/pull/54541 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Aug 24, 2024 | https://github.com/nodejs/node/pull/54541#event-14001561196 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Aug 24, 2024
| https://github.com/nodejs/node/pull/54541#pullrequestreview-2258754711 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54541/files |
| targos | https://github.com/targos |
| August 24, 2024 16:55 | https://github.com/nodejs/node/pull/54541#commits-pushed-6b7082a |
|
| https://github.com/targos |
| src: return v8::Object from error constructors | https://github.com/nodejs/node/pull/54541/commits/6b7082a7537c9956a08165d32230c8b6e165ca14 |
| 6b7082a | https://github.com/nodejs/node/pull/54541/commits/6b7082a7537c9956a08165d32230c8b6e165ca14 |
|
| https://github.com/targos |
| src: handle errors correctly in permission.cc | https://github.com/nodejs/node/pull/54541/commits/de8b9ec46c336ea218405813e00a0c2e50724544 |
| de8b9ec | https://github.com/nodejs/node/pull/54541/commits/de8b9ec46c336ea218405813e00a0c2e50724544 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/928b14a069b5d047c9e7faa4bd0f70c7ece74fdc..de8b9ec46c336ea218405813e00a0c2e50724544 |
| 928b14a | https://github.com/nodejs/node/commit/928b14a069b5d047c9e7faa4bd0f70c7ece74fdc |
| de8b9ec | https://github.com/nodejs/node/commit/de8b9ec46c336ea218405813e00a0c2e50724544 |
|
Compare
| https://github.com/nodejs/node/compare/928b14a069b5d047c9e7faa4bd0f70c7ece74fdc..de8b9ec46c336ea218405813e00a0c2e50724544 |
| August 24, 2024 14:55 | https://github.com/nodejs/node/pull/54541#event-14001574559 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Aug 24, 2024 | https://github.com/nodejs/node/pull/54541#issuecomment-2308421543 |
| Please reload this page | https://github.com/nodejs/node/pull/54541 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Aug 24, 2024 | https://github.com/nodejs/node/pull/54541#issuecomment-2308446623 |
| Please reload this page | https://github.com/nodejs/node/pull/54541 |
| Codecov | https://app.codecov.io/gh/nodejs/node/pull/54541?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (9edf4a0) | https://app.codecov.io/gh/nodejs/node/commit/9edf4a0856681a7665bd9dcf2ca7cac252784b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (de8b9ec) | https://app.codecov.io/gh/nodejs/node/commit/de8b9ec46c336ea218405813e00a0c2e50724544?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/54541?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/permission/permission.cc | https://app.codecov.io/gh/nodejs/node/pull/54541?src=pr&el=tree&filepath=src%2Fpermission%2Fpermission.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL3Blcm1pc3Npb24vcGVybWlzc2lvbi5jYw== |
| 1 Missing and 3 partials ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/54541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/node_errors.h | https://app.codecov.io/gh/nodejs/node/pull/54541?src=pr&el=tree&filepath=src%2Fnode_errors.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZXJyb3JzLmg= |
| 1 Missing ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/54541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/54541?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/node_errors.h | https://app.codecov.io/gh/nodejs/node/pull/54541?src=pr&el=tree&filepath=src%2Fnode_errors.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZXJyb3JzLmg= |
| src/permission/permission.cc | https://app.codecov.io/gh/nodejs/node/pull/54541?src=pr&el=tree&filepath=src%2Fpermission%2Fpermission.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL3Blcm1pc3Npb24vcGVybWlzc2lvbi5jYw== |
| 26 files with indirect coverage changes | https://app.codecov.io/gh/nodejs/node/pull/54541/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Please reload this page | https://github.com/nodejs/node/pull/54541 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 24, 2024 | https://github.com/nodejs/node/pull/54541#event-14001799567 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 24, 2024 | https://github.com/nodejs/node/pull/54541#event-14001805500 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54541 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
Aug 24, 2024
| https://github.com/nodejs/node/pull/54541#pullrequestreview-2258796956 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54541/files/de8b9ec46c336ea218405813e00a0c2e50724544 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54541 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 24, 2024
| https://github.com/nodejs/node/pull/54541#pullrequestreview-2258977050 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54541/files/de8b9ec46c336ea218405813e00a0c2e50724544 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 25, 2024 | https://github.com/nodejs/node/pull/54541#issuecomment-2308671828 |
| https://ci.nodejs.org/job/node-test-pull-request/61438/ | https://ci.nodejs.org/job/node-test-pull-request/61438/ |
| Please reload this page | https://github.com/nodejs/node/pull/54541 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Aug 25, 2024 | https://github.com/nodejs/node/pull/54541#event-14003394933 |
| https://github.com/VoltrexKeyva |
| VoltrexKeyva | https://github.com/VoltrexKeyva |
|
Aug 25, 2024
| https://github.com/nodejs/node/pull/54541#pullrequestreview-2259304395 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/54541/files/de8b9ec46c336ea218405813e00a0c2e50724544 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Aug 26, 2024 | https://github.com/nodejs/node/pull/54541#event-14014960853 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 26, 2024 | https://github.com/nodejs/node/pull/54541#issuecomment-2310437545 |
| 8f1fa03...4ce9864 | https://github.com/nodejs/node/compare/8f1fa03c130828d7ccb6e445274653496c94edd7...4ce986468c98098ddf08b34570c949c0d089e344 |
| Please reload this page | https://github.com/nodejs/node/pull/54541 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Aug 26, 2024
| https://github.com/nodejs/node/pull/54541#ref-commit-eab97b5 |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
| src: return v8::Object from error constructors | https://github.com/nodejs/node/commit/eab97b54d4bc7d7a15d26a40cc2c66f032972954 |
| eab97b5 | https://github.com/nodejs/node/commit/eab97b54d4bc7d7a15d26a40cc2c66f032972954 |
| #54541 | https://github.com/nodejs/node/pull/54541 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Aug 26, 2024
| https://github.com/nodejs/node/pull/54541#ref-commit-4ce9864 |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
| src: handle errors correctly in permission.cc | https://github.com/nodejs/node/commit/4ce986468c98098ddf08b34570c949c0d089e344 |
| 4ce9864 | https://github.com/nodejs/node/commit/4ce986468c98098ddf08b34570c949c0d089e344 |
| #54541 | https://github.com/nodejs/node/pull/54541 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 26, 2024 | https://github.com/nodejs/node/pull/54541#event-14014963048 |
| https://github.com/targos |
| targos | https://github.com/targos |
| August 26, 2024 15:25 | https://github.com/nodejs/node/pull/54541#event-14015230918 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Aug 30, 2024
| https://github.com/nodejs/node/pull/54541#ref-commit-b16531a |
|
| https://github.com/targos |
|
| https://github.com/RafaelGSS |
| src: return v8::Object from error constructors | https://github.com/nodejs/node/commit/b16531aab0a0390ce2c533c5a40634ee6cb88311 |
| b16531a | https://github.com/nodejs/node/commit/b16531aab0a0390ce2c533c5a40634ee6cb88311 |
| #54541 | https://github.com/nodejs/node/pull/54541 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Aug 30, 2024
| https://github.com/nodejs/node/pull/54541#ref-commit-d074bcd |
|
| https://github.com/targos |
|
| https://github.com/RafaelGSS |
| src: handle errors correctly in permission.cc | https://github.com/nodejs/node/commit/d074bcd6f5ecb5ae49091cd4ee223f71f03c05d5 |
| d074bcd | https://github.com/nodejs/node/commit/d074bcd6f5ecb5ae49091cd4ee223f71f03c05d5 |
| #54541 | https://github.com/nodejs/node/pull/54541 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Aug 30, 2024
| https://github.com/nodejs/node/pull/54541#ref-commit-4938188 |
|
| https://github.com/targos |
|
| https://github.com/RafaelGSS |
| src: return v8::Object from error constructors | https://github.com/nodejs/node/commit/49381886827ed2d8ea4f08d92865ea3b66e3723c |
| 4938188 | https://github.com/nodejs/node/commit/49381886827ed2d8ea4f08d92865ea3b66e3723c |
| #54541 | https://github.com/nodejs/node/pull/54541 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Aug 30, 2024
| https://github.com/nodejs/node/pull/54541#ref-commit-1ff3f63 |
|
| https://github.com/targos |
|
| https://github.com/RafaelGSS |
| src: handle errors correctly in permission.cc | https://github.com/nodejs/node/commit/1ff3f63f5ed0390524d1037357edb2d79ca87500 |
| 1ff3f63 | https://github.com/nodejs/node/commit/1ff3f63f5ed0390524d1037357edb2d79ca87500 |
| #54541 | https://github.com/nodejs/node/pull/54541 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
Aug 30, 2024
| https://github.com/nodejs/node/pull/54541#ref-pullrequest-2485481605 |
|
v22.8.0 proposal
#54560
| https://github.com/nodejs/node/pull/54560 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
dont-land-on-v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x |
|
dont-land-on-v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x |
| Sep 22, 2024 | https://github.com/nodejs/node/pull/54541#event-14351767637 |
| targos | https://github.com/targos |
|
Sep 22, 2024
| https://github.com/nodejs/node/pull/54541#ref-commit-be7c2dc |
|
| https://github.com/targos |
| src: return v8::Object from error constructors | https://github.com/nodejs/node/commit/be7c2dc049a309e13e5fdbdb78a075eada283e7b |
| be7c2dc | https://github.com/nodejs/node/commit/be7c2dc049a309e13e5fdbdb78a075eada283e7b |
| #54541 | https://github.com/nodejs/node/pull/54541 |
| targos | https://github.com/targos |
|
Sep 22, 2024
| https://github.com/nodejs/node/pull/54541#ref-commit-495a780 |
|
| https://github.com/targos |
| src: handle errors correctly in permission.cc | https://github.com/nodejs/node/commit/495a7801997e1dd80201b004c0237b9a77182a07 |
| 495a780 | https://github.com/nodejs/node/commit/495a7801997e1dd80201b004c0237b9a77182a07 |
| #54541 | https://github.com/nodejs/node/pull/54541 |
| targos | https://github.com/targos |
|
Sep 26, 2024
| https://github.com/nodejs/node/pull/54541#ref-commit-415b63e |
|
| https://github.com/targos |
| src: return v8::Object from error constructors | https://github.com/nodejs/node/commit/415b63e79356094f9db38aae0ad2fe07f548cae6 |
| 415b63e | https://github.com/nodejs/node/commit/415b63e79356094f9db38aae0ad2fe07f548cae6 |
| #54541 | https://github.com/nodejs/node/pull/54541 |
| targos | https://github.com/targos |
|
Sep 26, 2024
| https://github.com/nodejs/node/pull/54541#ref-commit-281fd1b |
|
| https://github.com/targos |
| src: handle errors correctly in permission.cc | https://github.com/nodejs/node/commit/281fd1b814a794f4df52239025681f3b9f3e18b6 |
| 281fd1b | https://github.com/nodejs/node/commit/281fd1b814a794f4df52239025681f3b9f3e18b6 |
| #54541 | https://github.com/nodejs/node/pull/54541 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 30, 2024
| https://github.com/nodejs/node/pull/54541#ref-pullrequest-2556012299 |
|
v20.18.0 release proposal
#55170
| https://github.com/nodejs/node/pull/55170 |
| targos | https://github.com/targos |
|
Oct 2, 2024
| https://github.com/nodejs/node/pull/54541#ref-commit-90ff714 |
|
| https://github.com/targos |
| src: return v8::Object from error constructors | https://github.com/nodejs/node/commit/90ff714699d09680cd7966cc1dd753e37ae559b2 |
| 90ff714 | https://github.com/nodejs/node/commit/90ff714699d09680cd7966cc1dd753e37ae559b2 |
| #54541 | https://github.com/nodejs/node/pull/54541 |
| targos | https://github.com/targos |
|
Oct 2, 2024
| https://github.com/nodejs/node/pull/54541#ref-commit-342c324 |
|
| https://github.com/targos |
| src: handle errors correctly in permission.cc | https://github.com/nodejs/node/commit/342c32483a17fb5f19a3e9201c420131d5a5b2cc |
| 342c324 | https://github.com/nodejs/node/commit/342c32483a17fb5f19a3e9201c420131d5a5b2cc |
| #54541 | https://github.com/nodejs/node/pull/54541 |
| mwalbeck | https://github.com/mwalbeck |
|
Oct 5, 2024
| https://github.com/nodejs/node/pull/54541#ref-commit-a72da9f |
|
| https://github.com/mwalbeck |
| Update Node.js to v20.18.0 (#328) | https://github.com/mwalbeck/docker-cyberchef/commit/a72da9f3ae25093a944222df50fe7b120577c41c |
| a72da9f | https://github.com/mwalbeck/docker-cyberchef/commit/a72da9f3ae25093a944222df50fe7b120577c41c |
| tmeijn | https://github.com/tmeijn |
|
Oct 17, 2024
| https://github.com/nodejs/node/pull/54541#ref-commit-64d7ea6 |
|
| https://github.com/tmeijn |
| build(deps): update node to v20.18.0 | https://github.com/tmeijn/dotfiles/commit/64d7ea66423f59c70a475f59351029b3beefe66d |
| 64d7ea6 | https://github.com/tmeijn/dotfiles/commit/64d7ea66423f59c70a475f59351029b3beefe66d |
| louwers | https://github.com/louwers |
|
Nov 2, 2024
| https://github.com/nodejs/node/pull/54541#ref-commit-5d80db8 |
|
| https://github.com/targos |
|
| https://github.com/louwers |
| src: return v8::Object from error constructors | https://github.com/louwers/node/commit/5d80db87805d528f96d9ec3fc9d4f543c652bd4f |
| 5d80db8 | https://github.com/louwers/node/commit/5d80db87805d528f96d9ec3fc9d4f543c652bd4f |
| nodejs#54541 | https://github.com/nodejs/node/pull/54541 |
| louwers | https://github.com/louwers |
|
Nov 2, 2024
| https://github.com/nodejs/node/pull/54541#ref-commit-3bc5804 |
|
| https://github.com/targos |
|
| https://github.com/louwers |
| src: handle errors correctly in permission.cc | https://github.com/louwers/node/commit/3bc5804817b7ec936193e508a36b11226d10f710 |
| 3bc5804 | https://github.com/louwers/node/commit/3bc5804817b7ec936193e508a36b11226d10f710 |
| nodejs#54541 | https://github.com/nodejs/node/pull/54541 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54541 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/54541/files/de8b9ec46c336ea218405813e00a0c2e50724544 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/54541/files/928b14a069b5d047c9e7faa4bd0f70c7ece74fdc |
|
| https://github.com/RafaelGSS |
|
RafaelGSS
| https://github.com/RafaelGSS |
|
| https://github.com/nodejs/node/pull/54541/files/de8b9ec46c336ea218405813e00a0c2e50724544 |
|
| https://github.com/VoltrexKeyva |
|
VoltrexKeyva
| https://github.com/VoltrexKeyva |
|
| https://github.com/nodejs/node/pull/54541/files/de8b9ec46c336ea218405813e00a0c2e50724544 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
commit-queue-rebase
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-rebase |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Please reload this page | https://github.com/nodejs/node/pull/54541 |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/RafaelGSS |
|
| https://github.com/VoltrexKeyva |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |