René's URL Explorer Experiment


Title: src: use `for` loop in `Dotenv::GetPathFromArgs` by avivkeller · Pull Request #54385 · nodejs/node · GitHub

Open Graph Title: src: use `for` loop in `Dotenv::GetPathFromArgs` by avivkeller · Pull Request #54385 · nodejs/node

X Title: src: use `for` loop in `Dotenv::GetPathFromArgs` by avivkeller · Pull Request #54385 · nodejs/node

Description: This PR replaces the old while loop with a newer for loop. Fixes the following edge cases: node script.js --env-file .env node --env-file-ABCD .env node -- --env-file .env node -invalid --env-file .env # this will error, but the env file is still processed Unfortunately, this introduces an edge case where some argument parameters, such as --eval <...> cause any future --env-file arguments to be ignored. node --eval "1+1" --env-file notparsed.env Fixes #54255 Fixes #54232 Related to #54237

Open Graph Description: This PR replaces the old while loop with a newer for loop. Fixes the following edge cases: node script.js --env-file .env node --env-file-ABCD .env node -- --env-file .env node -invalid --env-file ...

X Description: This PR replaces the old while loop with a newer for loop. Fixes the following edge cases: node script.js --env-file .env node --env-file-ABCD .env node -- --env-file .env node -invalid --env-file ...

Opengraph URL: https://github.com/nodejs/node/pull/54385

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files/:range(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b800c592-24c0-4955-395a-2d5be9726523
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA6D2:26B462:2D94B5:3ECE5F:6AEDADAC
html-safe-nonce0851c0158d4576058ccf872e3460fe7e2631a76e0fc026691b1b2d80d991d18d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkQyOjI2QjQ2MjoyRDk0QjU6M0VDRTVGOjZBRURBREFDIiwidmlzaXRvcl9pZCI6Ijc3NzQxOTM3MTg3MTI0NDYzODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacae5f055158e883f60f922d25753c70009932b458707421ac4c5bb2fcf3afef6e
hovercard-subject-tagpull_request:2020083919
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa
twitter:imagehttps://avatars.githubusercontent.com/u/38299977?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/38299977?s=400&v=4
og:image:altThis PR replaces the old while loop with a newer for loop. Fixes the following edge cases: node script.js --env-file .env node --env-file-ABCD .env node -- --env-file .env node -invalid --env-file ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9f51e3b6c7a190e426e641ae15acbc58dd1ac2003e96b58879bbc298e213dbf3
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7060660810b587033ea861b8aa67beb72c8e6542
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54385%2Ffiles%2F35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F54385%2Ffiles%2F35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa
Reloadhttps://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa
Reloadhttps://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests663 (663)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
avivkellerhttps://github.com/avivkeller
nodejs:mainhttps://github.com/nodejs/node/tree/main
Conversation 12 https://github.com/nodejs/node/pull/54385
Commits 2 https://github.com/nodejs/node/pull/54385/commits
Checks 0 https://github.com/nodejs/node/pull/54385/checks
Files changed https://github.com/nodejs/node/pull/54385/files
Please reload this pagehttps://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa
src: use for loop in Dotenv::GetPathFromArgs https://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa#top
Show all changes 2 commits https://github.com/nodejs/node/pull/54385/files
8511b3c src: use `for` loop in `Dotenv::GetPathFromArgs` avivkeller Aug 14, 2024 https://github.com/nodejs/node/pull/54385/commits/8511b3c0dcefe289c77b5fc9860f202a19337a49
35c4dae fix avivkeller Aug 15, 2024 https://github.com/nodejs/node/pull/54385/commits/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa
Clear filters https://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa
Please reload this pagehttps://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa
Please reload this pagehttps://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa
node.gyp https://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa#diff-9f1d0716c75f4df39d9e88499ac205b50301c0c672b816ce54d5339be4c2238c
node_dotenv.cc https://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa#diff-16952113caf4254d32120f31060ec512394a126ac2ddbdaed85b7d0d35ee6fcf
test_dotenv.cc https://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa#diff-8583ea2ec8d60c9a7f001431641dabcbaf0f819d5116b16c0dec19140b4b6ac7
test-dotenv-edge-cases.js https://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa#diff-a0eed9a136d858d6ff6b26d6895f781a166fae601ef34b8cffb71b670c9b3ad9
node.gyphttps://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa#diff-9f1d0716c75f4df39d9e88499ac205b50301c0c672b816ce54d5339be4c2238c
View file https://github.com/nodejs/node/blob/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa/node.gyp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/54385/files/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa#diff-9f1d0716c75f4df39d9e88499ac205b50301c0c672b816ce54d5339be4c2238c
https://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa#diff-9f1d0716c75f4df39d9e88499ac205b50301c0c672b816ce54d5339be4c2238c
src/node_dotenv.cchttps://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa#diff-16952113caf4254d32120f31060ec512394a126ac2ddbdaed85b7d0d35ee6fcf
View file https://github.com/nodejs/node/blob/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa/src/node_dotenv.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/54385/files/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa#diff-16952113caf4254d32120f31060ec512394a126ac2ddbdaed85b7d0d35ee6fcf
Please reload this pagehttps://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa
https://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa#diff-16952113caf4254d32120f31060ec512394a126ac2ddbdaed85b7d0d35ee6fcf
test/cctest/test_dotenv.cchttps://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa#diff-8583ea2ec8d60c9a7f001431641dabcbaf0f819d5116b16c0dec19140b4b6ac7
View file https://github.com/nodejs/node/blob/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa/test/cctest/test_dotenv.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/54385/files/{{ revealButtonHref }}
test/parallel/test-dotenv-edge-cases.jshttps://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa#diff-a0eed9a136d858d6ff6b26d6895f781a166fae601ef34b8cffb71b670c9b3ad9
View file https://github.com/nodejs/node/blob/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa/test/parallel/test-dotenv-edge-cases.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/54385/files/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/54385/files/35c4daed5771dbb2e4b2fc31316b43a5fcbc88fa#diff-a0eed9a136d858d6ff6b26d6895f781a166fae601ef34b8cffb71b670c9b3ad9
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.