René's URL Explorer Experiment


Title: src: do not save c_str of a temp string by zcbenz · Pull Request #53941 · nodejs/node · GitHub

Open Graph Title: src: do not save c_str of a temp string by zcbenz · Pull Request #53941 · nodejs/node

X Title: src: do not save c_str of a temp string by zcbenz · Pull Request #53941 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: file_path.string() creates a temporary string object, we should not store its c_str() before storing the string object first.

X Description: file_path.string() creates a temporary string object, we should not store its c_str() before storing the string object first.

Opengraph URL: https://github.com/nodejs/node/pull/53941

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a8a19d97-80cb-9fac-872e-585f1f0a9632
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC36:38E6D:52D811:6BC2B0:6AED284F
html-safe-nonce3f7568f679ad9050e7aef49cb363acf7b3763528d229cce27c26e84d25107e66
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzM2OjM4RTZEOjUyRDgxMTo2QkMyQjA6NkFFRDI4NEYiLCJ2aXNpdG9yX2lkIjoiNDgwMTI1NjQ1MzUwODUwNzcyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb6b073f4eed90b7d41da7e1100dd42cc25c762d6b7d5aba443d996f92c208cc3
hovercard-subject-tagpull_request:1977784649
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/53941/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fe669185f87c3d5fe32cf7e2dd854334edd32cf1a0dfd20533f60adc62618bf7/nodejs/node/pull/53941
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fe669185f87c3d5fe32cf7e2dd854334edd32cf1a0dfd20533f60adc62618bf7/nodejs/node/pull/53941
og:image:altfile_path.string() creates a temporary string object, we should not store its c_str() before storing the string object first.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezcbenz
hostnamegithub.com
expected-hostnamegithub.com
None9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release98b41fa4b5635ceb45a4c54320fced73817ff290
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/53941#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53941
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53941
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/53941
Reloadhttps://github.com/nodejs/node/pull/53941
Reloadhttps://github.com/nodejs/node/pull/53941
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
zcbenz:path-c-strhttps://github.com/zcbenz/node/tree/path-c-str
Conversationhttps://github.com/nodejs/node/pull/53941
Commits1 (1)https://github.com/nodejs/node/pull/53941/commits
Checkshttps://github.com/nodejs/node/pull/53941/checks
Files changedhttps://github.com/nodejs/node/pull/53941/files
src: do not save c_str of a temp stringhttps://github.com/nodejs/node/pull/53941#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
zcbenz:path-c-strhttps://github.com/zcbenz/node/tree/path-c-str
https://github.com/zcbenz
zcbenzhttps://github.com/zcbenz
Jul 19, 2024https://github.com/nodejs/node/pull/53941#issue-2418647032
Please reload this pagehttps://github.com/nodejs/node/pull/53941
https://github.com/zcbenz
src: do not save c_str of a temp stringhttps://github.com/nodejs/node/pull/53941/commits/a4075cfbb1ca29f582bcafaa7e43752f3b489923
a4075cfhttps://github.com/nodejs/node/pull/53941/commits/a4075cfbb1ca29f582bcafaa7e43752f3b489923
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jul 19, 2024https://github.com/nodejs/node/pull/53941#event-13572723032
https://github.com/zcbenz
zcbenzhttps://github.com/zcbenz
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 19, 2024https://github.com/nodejs/node/pull/53941#event-13573188350
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 19, 2024https://github.com/nodejs/node/pull/53941#event-13573303687
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53941
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jul 19, 2024 https://github.com/nodejs/node/pull/53941#pullrequestreview-2188363376
View reviewed changes https://github.com/nodejs/node/pull/53941/files/a4075cfbb1ca29f582bcafaa7e43752f3b489923
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jul 19, 2024https://github.com/nodejs/node/pull/53941#issuecomment-2239294892
Please reload this pagehttps://github.com/nodejs/node/pull/53941
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 19, 2024https://github.com/nodejs/node/pull/53941#issuecomment-2240717024
https://ci.nodejs.org/job/node-test-pull-request/60457/https://ci.nodejs.org/job/node-test-pull-request/60457/
Please reload this pagehttps://github.com/nodejs/node/pull/53941
https://github.com/zcbenz
zcbenzhttps://github.com/zcbenz
Jul 19, 2024https://github.com/nodejs/node/pull/53941#issuecomment-2240739050
Please reload this pagehttps://github.com/nodejs/node/pull/53941
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 19, 2024https://github.com/nodejs/node/pull/53941#issuecomment-2240765507
#52809 (comment)https://github.com/nodejs/node/issues/52809#issuecomment-2107331677
Please reload this pagehttps://github.com/nodejs/node/pull/53941
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 21, 2024 https://github.com/nodejs/node/pull/53941#pullrequestreview-2190383307
View reviewed changes https://github.com/nodejs/node/pull/53941/files/a4075cfbb1ca29f582bcafaa7e43752f3b489923
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 22, 2024https://github.com/nodejs/node/pull/53941#issuecomment-2241984746
https://ci.nodejs.org/job/node-test-pull-request/60526/https://ci.nodejs.org/job/node-test-pull-request/60526/
Please reload this pagehttps://github.com/nodejs/node/pull/53941
https://github.com/zcbenz
zcbenzhttps://github.com/zcbenz
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 22, 2024https://github.com/nodejs/node/pull/53941#event-13596481824
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 22, 2024https://github.com/nodejs/node/pull/53941#event-13596616701
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
097a528https://github.com/nodejs/node/commit/097a52848ed414c3a7fc91b16cc9ddec07ddf09b
Jul 22, 2024https://github.com/nodejs/node/pull/53941#event-13596617368
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 22, 2024https://github.com/nodejs/node/pull/53941#issuecomment-2242252942
097a528https://github.com/nodejs/node/commit/097a52848ed414c3a7fc91b16cc9ddec07ddf09b
Please reload this pagehttps://github.com/nodejs/node/pull/53941
https://github.com/targos
targoshttps://github.com/targos
Jul 30, 2024https://github.com/nodejs/node/pull/53941#issuecomment-2257976414
#53617https://github.com/nodejs/node/pull/53617
Please reload this pagehttps://github.com/nodejs/node/pull/53941
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v18.x
dont-land-on-v22.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v22.x
Jul 30, 2024https://github.com/nodejs/node/pull/53941#event-13693483026
https://github.com/zcbenz
zcbenzhttps://github.com/zcbenz
July 30, 2024 13:02https://github.com/nodejs/node/pull/53941#event-13695684495
https://github.com/aduh95
aduh95https://github.com/aduh95
Oct 14, 2024 https://github.com/nodejs/node/pull/53941#ref-pullrequest-2576566977
2024-10-16, Version 23.0.0 (Current) #55338 https://github.com/nodejs/node/pull/55338
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53941
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/53941/files/a4075cfbb1ca29f582bcafaa7e43752f3b489923
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/53941/files/a4075cfbb1ca29f582bcafaa7e43752f3b489923
Please reload this pagehttps://github.com/nodejs/node/pull/53941
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
dont-land-on-v22.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v22.x
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/53941
https://github.com/zcbenz
https://github.com/nodejs-github-bot
https://github.com/anonrig
https://github.com/richardlau
https://github.com/targos
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.