René's URL Explorer Experiment


Title: url: fix off-by-one error with parse() by mscdex · Pull Request #5394 · nodejs/node · GitHub

Open Graph Title: url: fix off-by-one error with parse() by mscdex · Pull Request #5394 · nodejs/node

X Title: url: fix off-by-one error with parse() by mscdex · Pull Request #5394 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Description of change This fixes an off-by-one error with url.parse(). Ref #5393. Pull Request check-list Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (includi...

X Description: Description of change This fixes an off-by-one error with url.parse(). Ref #5393. Pull Request check-list Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (includi...

Opengraph URL: https://github.com/nodejs/node/pull/5394

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2b5e3416-965e-1d22-3494-db0cbb3fe9ce
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C0C:16E020:84DB2A:BAFABF:6A4E7C66
html-safe-nonced21ad9c379297ddd4d2b86ba6a6fa994e87f96eb9377e83fc1b93f8f1c045a6a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzBDOjE2RTAyMDo4NERCMkE6QkFGQUJGOjZBNEU3QzY2IiwidmlzaXRvcl9pZCI6Ijg0MTM4MDQwODM4MjgxMjg4NzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac945e576dad509f24cfda8a4bb3ce8b72d0a9d5a8049debe8109da97e8376cbb7
hovercard-subject-tagpull_request:60397006
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/5394/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4eb1a7666f4fedcdb8196cf1781b1cf7488a0fc05c6c2065011302c1d9749301/nodejs/node/pull/5394
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4eb1a7666f4fedcdb8196cf1781b1cf7488a0fc05c6c2065011302c1d9749301/nodejs/node/pull/5394
og:image:altDescription of change This fixes an off-by-one error with url.parse(). Ref #5393. Pull Request check-list Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (includi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemscdex
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/5394#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5394
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5394
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/5394
Reloadhttps://github.com/nodejs/node/pull/5394
Reloadhttps://github.com/nodejs/node/pull/5394
Please reload this pagehttps://github.com/nodejs/node/pull/5394
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/5394
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mscdexhttps://github.com/mscdex
nodejs:masterhttps://github.com/nodejs/node/tree/master
mscdex:url-fix-parse-off-by-onehttps://github.com/mscdex/io.js/tree/url-fix-parse-off-by-one
Conversationhttps://github.com/nodejs/node/pull/5394
Commits1 (1)https://github.com/nodejs/node/pull/5394/commits
Checkshttps://github.com/nodejs/node/pull/5394/checks
Files changedhttps://github.com/nodejs/node/pull/5394/files
url: fix off-by-one error with parse()https://github.com/nodejs/node/pull/5394#top
mscdexhttps://github.com/mscdex
nodejs:masterhttps://github.com/nodejs/node/tree/master
mscdex:url-fix-parse-off-by-onehttps://github.com/mscdex/io.js/tree/url-fix-parse-off-by-one
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 23, 2016https://github.com/nodejs/node/pull/5394#issue-135841966
#5393https://github.com/nodejs/node/issues/5393
CONTRIBUTING.mdhttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit
Please reload this pagehttps://github.com/nodejs/node/pull/5394
https://github.com/mscdex
url: fix off-by-one error with parse()https://github.com/nodejs/node/pull/5394/commits/b6e847ad2dd89a51c5e341213176e533b52ca9a2
b6e847ahttps://github.com/nodejs/node/pull/5394/commits/b6e847ad2dd89a51c5e341213176e533b52ca9a2
nodejs#5393https://github.com/nodejs/node/issues/5393
https://github.com/mscdex
mscdexhttps://github.com/mscdex
url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl
Feb 23, 2016https://github.com/nodejs/node/pull/5394#event-562242052
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 23, 2016https://github.com/nodejs/node/pull/5394#issuecomment-187875778
Please reload this pagehttps://github.com/nodejs/node/pull/5394
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 23, 2016https://github.com/nodejs/node/pull/5394#issuecomment-187876458
Please reload this pagehttps://github.com/nodejs/node/pull/5394
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Feb 23, 2016https://github.com/nodejs/node/pull/5394#issuecomment-187876902
Please reload this pagehttps://github.com/nodejs/node/pull/5394
https://github.com/rvagg
rvagghttps://github.com/rvagg
Feb 24, 2016https://github.com/nodejs/node/pull/5394#issuecomment-187997505
Please reload this pagehttps://github.com/nodejs/node/pull/5394
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Feb 24, 2016https://github.com/nodejs/node/pull/5394#issuecomment-188236076
Please reload this pagehttps://github.com/nodejs/node/pull/5394
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Feb 24, 2016https://github.com/nodejs/node/pull/5394#issuecomment-188318801
#5400https://github.com/nodejs/node/issues/5400
Please reload this pagehttps://github.com/nodejs/node/pull/5394
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 25, 2016https://github.com/nodejs/node/pull/5394#issuecomment-188595579
https://ci.nodejs.org/job/node-test-pull-request/1739/https://ci.nodejs.org/job/node-test-pull-request/1739/
Please reload this pagehttps://github.com/nodejs/node/pull/5394
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 25, 2016https://github.com/nodejs/node/pull/5394#issuecomment-188609698
Please reload this pagehttps://github.com/nodejs/node/pull/5394
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Feb 25, 2016https://github.com/nodejs/node/pull/5394#issuecomment-189042566
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/5394
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 26, 2016https://github.com/nodejs/node/pull/5394#issuecomment-189052915
@Fishrock123https://github.com/Fishrock123
Please reload this pagehttps://github.com/nodejs/node/pull/5394
https://github.com/rvagg
rvagghttps://github.com/rvagg
Feb 27, 2016 https://github.com/nodejs/node/pull/5394#ref-pullrequest-136885682
Release proposal: v5.7.1 #5464 https://github.com/nodejs/node/pull/5464
silverwindhttps://github.com/silverwind
Feb 27, 2016 https://github.com/nodejs/node/pull/5394#ref-commit-8b16ba3
https://github.com/mscdex
https://github.com/silverwind
url: fix off-by-one error with parse()https://github.com/nodejs/node/commit/8b16ba3bbf381249552c2a038233141e4abbe731
8b16ba3https://github.com/nodejs/node/commit/8b16ba3bbf381249552c2a038233141e4abbe731
#5393https://github.com/nodejs/node/issues/5393
#5394https://github.com/nodejs/node/pull/5394
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Feb 27, 2016https://github.com/nodejs/node/pull/5394#issuecomment-189642486
8b16ba3https://github.com/nodejs/node/commit/8b16ba3bbf381249552c2a038233141e4abbe731
Please reload this pagehttps://github.com/nodejs/node/pull/5394
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Feb 27, 2016https://github.com/nodejs/node/pull/5394#event-568947469
https://github.com/silverwind
silverwindhttps://github.com/silverwind
5.7.1https://github.com/nodejs/node/milestone/16
Feb 27, 2016https://github.com/nodejs/node/pull/5394#event-568947538
rvagghttps://github.com/rvagg
Feb 28, 2016 https://github.com/nodejs/node/pull/5394#ref-commit-dfe45f1
https://github.com/mscdex
https://github.com/rvagg
url: fix off-by-one error with parse()https://github.com/nodejs/node/commit/dfe45f13e7fd9d509aaec0db37d46ec46dd1e498
dfe45f1https://github.com/nodejs/node/commit/dfe45f13e7fd9d509aaec0db37d46ec46dd1e498
#5393https://github.com/nodejs/node/issues/5393
#5394https://github.com/nodejs/node/pull/5394
https://github.com/jasnell
jasnellhttps://github.com/jasnell
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Mar 2, 2016https://github.com/nodejs/node/pull/5394#event-574906107
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 2, 2016https://github.com/nodejs/node/pull/5394#issuecomment-191312519
@thealphanerdhttps://github.com/thealphanerd
Please reload this pagehttps://github.com/nodejs/node/pull/5394
Fishrock123https://github.com/Fishrock123
Mar 2, 2016 https://github.com/nodejs/node/pull/5394#ref-commit-805f054
https://github.com/Fishrock123
2016-03-02, Version 5.7.1 (Stable)https://github.com/nodejs/node/commit/805f054cc7791c447dbb960fbf3b179ea05294ac
805f054https://github.com/nodejs/node/commit/805f054cc7791c447dbb960fbf3b179ea05294ac
#5507https://github.com/nodejs/node/pull/5507
https://www.openssl.org/news/vulnerabilities.html#2016-0705https://www.openssl.org/news/vulnerabilities.html#2016-0705
https://www.openssl.org/news/vulnerabilities.html#2016-0797https://www.openssl.org/news/vulnerabilities.html#2016-0797
https://ssrg.nicta.com.au/projects/TS/cachebleed/https://ssrg.nicta.com.au/projects/TS/cachebleed/
https://www.openssl.org/news/vulnerabilities.html#2016-0702https://www.openssl.org/news/vulnerabilities.html#2016-0702
#5389https://github.com/nodejs/node/pull/5389
#5456https://github.com/nodejs/node/pull/5456
#5490https://github.com/nodejs/node/pull/5490
#5394https://github.com/nodejs/node/pull/5394
#5407https://github.com/nodejs/node/pull/5407
#5464https://github.com/nodejs/node/pull/5464
Fishrock123https://github.com/Fishrock123
Mar 2, 2016 https://github.com/nodejs/node/pull/5394#ref-commit-9091ccd
https://github.com/Fishrock123
2016-03-02, Version 5.7.1 (Stable)https://github.com/Fishrock123/node/commit/9091ccdc2d1d01709176484a1557e9ca8f3fab33
9091ccdhttps://github.com/Fishrock123/node/commit/9091ccdc2d1d01709176484a1557e9ca8f3fab33
nodejs#5507https://github.com/nodejs/node/pull/5507
https://www.openssl.org/news/vulnerabilities.html#2016-0705https://www.openssl.org/news/vulnerabilities.html#2016-0705
https://www.openssl.org/news/vulnerabilities.html#2016-0797https://www.openssl.org/news/vulnerabilities.html#2016-0797
https://ssrg.nicta.com.au/projects/TS/cachebleed/https://ssrg.nicta.com.au/projects/TS/cachebleed/
https://www.openssl.org/news/vulnerabilities.html#2016-0702https://www.openssl.org/news/vulnerabilities.html#2016-0702
nodejs#5389https://github.com/nodejs/node/pull/5389
nodejs#5456https://github.com/nodejs/node/pull/5456
nodejs#5490https://github.com/nodejs/node/pull/5490
nodejs#5394https://github.com/nodejs/node/pull/5394
nodejs#5407https://github.com/nodejs/node/pull/5407
nodejs#5464https://github.com/nodejs/node/pull/5464
https://github.com/mscdex
mscdexhttps://github.com/mscdex
March 4, 2016 23:40https://github.com/nodejs/node/pull/5394#event-578536691
https://github.com/Clemens-git76
Clemens-git76https://github.com/Clemens-git76
Apr 16, 2024 https://github.com/nodejs/node/pull/5394#ref-pullrequest-2246372620
[Snyk] Upgrade rollup from 2.75.6 to 4.13.0 Clemens-git76/node#4 https://github.com/Clemens-git76/node/pull/4
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5394
url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl
5.7.1 https://github.com/nodejs/node/milestone/16
Please reload this pagehttps://github.com/nodejs/node/pull/5394
https://github.com/mscdex
https://github.com/MylesBorins
https://github.com/silverwind
https://github.com/rvagg
https://github.com/evanlucas
https://github.com/Fishrock123
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.