| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:58bd4cfe-08d2-26e3-7902-c436c59fdfc0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A400:DEF83:E46A4D:13669B6:6A4F03FB |
| html-safe-nonce | caa3fe6d6f605fbb16e44f349c6e570d59a260df8f597d377be3c08ec32b5fbf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDAwOkRFRjgzOkU0NkE0RDoxMzY2OUI2OjZBNEYwM0ZCIiwidmlzaXRvcl9pZCI6IjQwOTUyNTk4MTgyNTk4NDIwNDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e20c98398f1d712023c3dd444686bf934aa39ef3b9e9dcbea897b0388bc96086 |
| hovercard-subject-tag | pull_request:60260210 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/5372/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/44ebfa0ac9c1aa19987e63675c1a3c1c5bb5470e8095ef3967cc5d3ef298da02/nodejs/node/pull/5372 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/44ebfa0ac9c1aa19987e63675c1a3c1c5bb5470e8095ef3967cc5d3ef298da02/nodejs/node/pull/5372 |
| og:image:alt | Backport of #5214 for v4.x LTS.
/cc @thealphanerd |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/5372#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5372 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5372 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/5372 |
| Reload | https://github.com/nodejs/node/pull/5372 |
| Reload | https://github.com/nodejs/node/pull/5372 |
| Please reload this page | https://github.com/nodejs/node/pull/5372 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/5372 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
965
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:v4.x-staging | https://github.com/nodejs/node/tree/v4.x-staging |
| Trott:v4-eslint-2 | https://github.com/Trott/io.js/tree/v4-eslint-2 |
| Conversation | https://github.com/nodejs/node/pull/5372 |
| Commits4 (4) | https://github.com/nodejs/node/pull/5372/commits |
| Checks | https://github.com/nodejs/node/pull/5372/checks |
| Files changed | https://github.com/nodejs/node/pull/5372/files |
| V4 eslint 2 | https://github.com/nodejs/node/pull/5372#top |
| Trott | https://github.com/Trott |
| nodejs:v4.x-staging | https://github.com/nodejs/node/tree/v4.x-staging |
| Trott:v4-eslint-2 | https://github.com/Trott/io.js/tree/v4-eslint-2 |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Feb 22, 2016 | https://github.com/nodejs/node/pull/5372#issue-135577438 |
| #5214 | https://github.com/nodejs/node/pull/5214 |
| @thealphanerd | https://github.com/thealphanerd |
| Please reload this page | https://github.com/nodejs/node/pull/5372 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Feb 22, 2016
| https://github.com/nodejs/node/pull/5372#ref-pullrequest-133404783 |
|
tools: update ESLint to version 2.1.0
#5214
| https://github.com/nodejs/node/pull/5214 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
|
v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av4.x |
| Feb 23, 2016 | https://github.com/nodejs/node/pull/5372#event-560697979 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Feb 24, 2016 | https://github.com/nodejs/node/pull/5372#issuecomment-188514094 |
| @thealphanerd | https://github.com/thealphanerd |
| Please reload this page | https://github.com/nodejs/node/pull/5372 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Feb 24, 2016 | https://github.com/nodejs/node/pull/5372#issuecomment-188515700 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/5372 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Feb 24, 2016 | https://github.com/nodejs/node/pull/5372#issuecomment-188519789 |
| @thealphanerd | https://github.com/thealphanerd |
| Please reload this page | https://github.com/nodejs/node/pull/5372 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Feb 24, 2016 | https://github.com/nodejs/node/pull/5372#issuecomment-188520660 |
| Please reload this page | https://github.com/nodejs/node/pull/5372 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/e5b8bc17d5e2cc435d4bb4c975b710b7d2676bc4..2f8bef3bc3568eb72a4077c9cceb53f3e9bb0e96 |
| e5b8bc1 | https://github.com/nodejs/node/commit/e5b8bc17d5e2cc435d4bb4c975b710b7d2676bc4 |
| 2f8bef3 | https://github.com/nodejs/node/commit/2f8bef3bc3568eb72a4077c9cceb53f3e9bb0e96 |
|
Compare
| https://github.com/nodejs/node/compare/e5b8bc17d5e2cc435d4bb4c975b710b7d2676bc4..2f8bef3bc3568eb72a4077c9cceb53f3e9bb0e96 |
| February 24, 2016 23:45 | https://github.com/nodejs/node/pull/5372#event-564596752 |
| Trott | https://github.com/Trott |
| February 24, 2016 15:45 | https://github.com/nodejs/node/pull/5372#commits-pushed-f79f54f |
|
| https://github.com/Trott |
| src,test,tools: modify for more stringent linting | https://github.com/nodejs/node/pull/5372/commits/f79f54fd6f9e9f97b4ca01dcac25c6b5b8b0e5ed |
| f79f54f | https://github.com/nodejs/node/pull/5372/commits/f79f54fd6f9e9f97b4ca01dcac25c6b5b8b0e5ed |
| nodejs#5214 | https://github.com/nodejs/node/pull/5214 |
|
| https://github.com/Trott |
| tools: remove obsolete lint rules | https://github.com/nodejs/node/pull/5372/commits/7f225ccf8131034d3acb88ca47a597b23ec183af |
| 7f225cc | https://github.com/nodejs/node/pull/5372/commits/7f225ccf8131034d3acb88ca47a597b23ec183af |
| nodejs#5214 | https://github.com/nodejs/node/pull/5214 |
|
| https://github.com/Trott |
| tools: update ESLint to version 2.1.0 | https://github.com/nodejs/node/pull/5372/commits/6248f411b91c781b908a1e7db369955f879830dd |
| 6248f41 | https://github.com/nodejs/node/pull/5372/commits/6248f411b91c781b908a1e7db369955f879830dd |
| nodejs#5214 | https://github.com/nodejs/node/pull/5214 |
|
| https://github.com/Trott |
| tools: replace obsolete ESLint rules | https://github.com/nodejs/node/pull/5372/commits/ee8b998e79eb2e7da04efe7f79c0681787d64ed6 |
| ee8b998 | https://github.com/nodejs/node/pull/5372/commits/ee8b998e79eb2e7da04efe7f79c0681787d64ed6 |
| nodejs#5214 | https://github.com/nodejs/node/pull/5214 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/2f8bef3bc3568eb72a4077c9cceb53f3e9bb0e96..ee8b998e79eb2e7da04efe7f79c0681787d64ed6 |
| 2f8bef3 | https://github.com/nodejs/node/commit/2f8bef3bc3568eb72a4077c9cceb53f3e9bb0e96 |
| ee8b998 | https://github.com/nodejs/node/commit/ee8b998e79eb2e7da04efe7f79c0681787d64ed6 |
|
Compare
| https://github.com/nodejs/node/compare/2f8bef3bc3568eb72a4077c9cceb53f3e9bb0e96..ee8b998e79eb2e7da04efe7f79c0681787d64ed6 |
| February 24, 2016 23:46 | https://github.com/nodejs/node/pull/5372#event-564597881 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Feb 24, 2016 | https://github.com/nodejs/node/pull/5372#issuecomment-188522572 |
| Please reload this page | https://github.com/nodejs/node/pull/5372 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 25, 2016
| https://github.com/nodejs/node/pull/5372#ref-issue-136232371 |
|
linter fails after running make test-addons
#5424
| https://github.com/nodejs/node/issues/5424 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Feb 25, 2016 | https://github.com/nodejs/node/pull/5372#issuecomment-188531733 |
| #5425 | https://github.com/nodejs/node/pull/5425 |
| Please reload this page | https://github.com/nodejs/node/pull/5372 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Feb 27, 2016 | https://github.com/nodejs/node/pull/5372#issuecomment-189734579 |
| Please reload this page | https://github.com/nodejs/node/pull/5372 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Feb 27, 2016 | https://github.com/nodejs/node/pull/5372#event-569260910 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:42 | https://github.com/nodejs/node/pull/5372#event-5890934699 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5372 |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/5372 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
|
| https://github.com/mscdex |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |