René's URL Explorer Experiment


Title: fs: move `rmSync` implementation to c++ by anonrig · Pull Request #53617 · nodejs/node · GitHub

Open Graph Title: fs: move `rmSync` implementation to c++ by anonrig · Pull Request #53617 · nodejs/node

X Title: fs: move `rmSync` implementation to c++ by anonrig · Pull Request #53617 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Work in progress. I need to write some benchmarks before making this pull-request ready. Benchmark on all fs commands: https://ci.nodejs.org/view/Node.js benchmark/job/benchmark-node-micro-bench...

X Description: Work in progress. I need to write some benchmarks before making this pull-request ready. Benchmark on all fs commands: https://ci.nodejs.org/view/Node.js benchmark/job/benchmark-node-micro-bench...

Opengraph URL: https://github.com/nodejs/node/pull/53617

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:4110994f-ebe7-663f-f6e1-ba1c8b2bdb96
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE9C6:137C1B:1A7D8E:22BD34:6AED1679
html-safe-nonced862330a0e7546d9e5bd8437562158677744a53c1de0dcc76ca5a24b1a7c851a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUM2OjEzN0MxQjoxQTdEOEU6MjJCRDM0OjZBRUQxNjc5IiwidmlzaXRvcl9pZCI6Ijc4MTA5MjI2OTQxODQ4Njc0NDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0f02b0fcce0335cea43978d8fd4a1ae00f7a2a557fd45cdcb3d282032acbc52f
hovercard-subject-tagpull_request:1943367058
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/53617
twitter:imagehttps://opengraph.githubassets.com/21ac8606d6bd200cdb348324e0853a35a09a55ff15b4bed31224e1f6394e7fd5/nodejs/node/pull/53617
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/21ac8606d6bd200cdb348324e0853a35a09a55ff15b4bed31224e1f6394e7fd5/nodejs/node/pull/53617
og:image:altWork in progress. I need to write some benchmarks before making this pull-request ready. Benchmark on all fs commands: https://ci.nodejs.org/view/Node.js benchmark/job/benchmark-node-micro-bench...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameanonrig
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/53617#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53617
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53617
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/53617
Reloadhttps://github.com/nodejs/node/pull/53617
Reloadhttps://github.com/nodejs/node/pull/53617
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
anonrig:improve-rmSync-performancehttps://github.com/anonrig/node/tree/improve-rmSync-performance
Conversationhttps://github.com/nodejs/node/pull/53617
Commits1 (1)https://github.com/nodejs/node/pull/53617/commits
Checkshttps://github.com/nodejs/node/pull/53617/checks
Files changedhttps://github.com/nodejs/node/pull/53617/files
fs: move rmSync implementation to c++https://github.com/nodejs/node/pull/53617#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
anonrig:improve-rmSync-performancehttps://github.com/anonrig/node/tree/improve-rmSync-performance
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jun 28, 2024https://github.com/nodejs/node/pull/53617#issue-2379312372
Please reload this pagehttps://github.com/nodejs/node/pull/53617
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1575/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1575/
Please reload this pagehttps://github.com/nodejs/node/pull/53617
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jun 28, 2024https://github.com/nodejs/node/pull/53617#event-13324816020
https://github.com/anonrig
anonrighttps://github.com/anonrig
force-pushedhttps://github.com/nodejs/node/compare/c5411556db7222d3b67a38cebdd638e5baa5a140..3d2975d72fd0f71006a70136135badc689e1fac4
c541155https://github.com/nodejs/node/commit/c5411556db7222d3b67a38cebdd638e5baa5a140
3d2975dhttps://github.com/nodejs/node/commit/3d2975d72fd0f71006a70136135badc689e1fac4
Compare https://github.com/nodejs/node/compare/c5411556db7222d3b67a38cebdd638e5baa5a140..3d2975d72fd0f71006a70136135badc689e1fac4
June 28, 2024 00:39https://github.com/nodejs/node/pull/53617#event-13324817914
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53617
https://github.com/anonrig
anonrighttps://github.com/anonrig
force-pushedhttps://github.com/nodejs/node/compare/3d2975d72fd0f71006a70136135badc689e1fac4..d820ac1e4be4233952f20eaf51222060efa52a6b
3d2975dhttps://github.com/nodejs/node/commit/3d2975d72fd0f71006a70136135badc689e1fac4
d820ac1https://github.com/nodejs/node/commit/d820ac1e4be4233952f20eaf51222060efa52a6b
Compare https://github.com/nodejs/node/compare/3d2975d72fd0f71006a70136135badc689e1fac4..d820ac1e4be4233952f20eaf51222060efa52a6b
June 28, 2024 00:46https://github.com/nodejs/node/pull/53617#event-13324857877
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 28, 2024https://github.com/nodejs/node/pull/53617#issuecomment-2195888463
https://ci.nodejs.org/job/node-test-pull-request/60003/https://ci.nodejs.org/job/node-test-pull-request/60003/
Please reload this pagehttps://github.com/nodejs/node/pull/53617
https://github.com/anonrig
anonrighttps://github.com/anonrig
force-pushedhttps://github.com/nodejs/node/compare/d820ac1e4be4233952f20eaf51222060efa52a6b..8d026382e1f82b0beb5a7bc68c118e9d8074b7d8
d820ac1https://github.com/nodejs/node/commit/d820ac1e4be4233952f20eaf51222060efa52a6b
8d02638https://github.com/nodejs/node/commit/8d026382e1f82b0beb5a7bc68c118e9d8074b7d8
Compare https://github.com/nodejs/node/compare/d820ac1e4be4233952f20eaf51222060efa52a6b..8d026382e1f82b0beb5a7bc68c118e9d8074b7d8
June 28, 2024 13:54https://github.com/nodejs/node/pull/53617#event-13332078892
https://github.com/anonrig
anonrighttps://github.com/anonrig
jasnellhttps://github.com/jasnell
lemirehttps://github.com/lemire
June 28, 2024 13:54https://github.com/nodejs/node/pull/53617#event-13332083884
https://github.com/lemire
lemirehttps://github.com/lemire
Jun 28, 2024 https://github.com/nodejs/node/pull/53617#pullrequestreview-2148123129
View reviewed changes https://github.com/nodejs/node/pull/53617/files
src/node_file.cchttps://github.com/nodejs/node/pull/53617/files#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6
Please reload this pagehttps://github.com/nodejs/node/pull/53617
https://github.com/anonrig
anonrighttps://github.com/anonrig
force-pushedhttps://github.com/nodejs/node/compare/8d026382e1f82b0beb5a7bc68c118e9d8074b7d8..2538925fb32b58049968cba93005299bf86e5414
8d02638https://github.com/nodejs/node/commit/8d026382e1f82b0beb5a7bc68c118e9d8074b7d8
2538925https://github.com/nodejs/node/commit/2538925fb32b58049968cba93005299bf86e5414
Compare https://github.com/nodejs/node/compare/8d026382e1f82b0beb5a7bc68c118e9d8074b7d8..2538925fb32b58049968cba93005299bf86e5414
June 28, 2024 14:03https://github.com/nodejs/node/pull/53617#event-13332220911
https://github.com/lemire
lemirehttps://github.com/lemire
Jun 28, 2024 https://github.com/nodejs/node/pull/53617#pullrequestreview-2148128319
View reviewed changes https://github.com/nodejs/node/pull/53617/files
https://github.com/anonrig
anonrighttps://github.com/anonrig
addaleaxhttps://github.com/addaleax
benjamingrhttps://github.com/benjamingr
tniessenhttps://github.com/tniessen
June 28, 2024 14:06https://github.com/nodejs/node/pull/53617#event-13332254732
https://github.com/anonrig
anonrighttps://github.com/anonrig
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 28, 2024https://github.com/nodejs/node/pull/53617#event-13332267614
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jun 28, 2024https://github.com/nodejs/node/pull/53617#issuecomment-2197471870
Please reload this pagehttps://github.com/nodejs/node/pull/53617
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 30, 2024 https://github.com/nodejs/node/pull/53617#pullrequestreview-2149957684
View reviewed changes https://github.com/nodejs/node/pull/53617/files
test/parallel/test-fs-rm.jshttps://github.com/nodejs/node/pull/53617/files#diff-596c3dc1f2c2b0c3dc8f6c087b9e0f1910188ff28eaee22800367acc0e9a4f43
Please reload this pagehttps://github.com/nodejs/node/pull/53617
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 30, 2024 https://github.com/nodejs/node/pull/53617#pullrequestreview-2149957707
View reviewed changes https://github.com/nodejs/node/pull/53617/files
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 3, 2024https://github.com/nodejs/node/pull/53617#event-13385489453
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 3, 2024https://github.com/nodejs/node/pull/53617#issuecomment-2207123150
https://github.com/nodejs/node/actions/runs/9784060111https://github.com/nodejs/node/actions/runs/9784060111
Please reload this pagehttps://github.com/nodejs/node/pull/53617
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed
Jul 3, 2024https://github.com/nodejs/node/pull/53617#event-13385489938
https://github.com/anonrig
anonrighttps://github.com/anonrig
jasnellhttps://github.com/jasnell
lemirehttps://github.com/lemire
July 3, 2024 21:33https://github.com/nodejs/node/pull/53617#event-13386588347
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 4, 2024 https://github.com/nodejs/node/pull/53617#pullrequestreview-2157913438
View reviewed changes https://github.com/nodejs/node/pull/53617/files
https://github.com/anonrig
anonrighttps://github.com/anonrig
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
request-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed
Jul 4, 2024https://github.com/nodejs/node/pull/53617#event-13392895124
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 4, 2024https://github.com/nodejs/node/pull/53617#event-13392991136
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 21, 2024https://github.com/nodejs/node/pull/53617#issuecomment-2241620045
#53962 (comment)https://github.com/nodejs/node/issues/53962#issuecomment-2240820724
Please reload this pagehttps://github.com/nodejs/node/pull/53617
https://github.com/aduh95
aduh95https://github.com/aduh95
dont-land-on-v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v18.x
dont-land-on-v22.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v22.x
Jul 21, 2024https://github.com/nodejs/node/pull/53617#event-13592500255
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jul 21, 2024https://github.com/nodejs/node/pull/53617#issuecomment-2241696778
@richardlauhttps://github.com/richardlau
@aduh95https://github.com/aduh95
Please reload this pagehttps://github.com/nodejs/node/pull/53617
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 21, 2024https://github.com/nodejs/node/pull/53617#issuecomment-2241707083
@anonrighttps://github.com/anonrig
Please reload this pagehttps://github.com/nodejs/node/pull/53617
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jul 21, 2024https://github.com/nodejs/node/pull/53617#issuecomment-2241707727
@anonrighttps://github.com/anonrig
Please reload this pagehttps://github.com/nodejs/node/pull/53617
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 24, 2024 https://github.com/nodejs/node/pull/53617#ref-pullrequest-2426576537
sqlite: split up large test file #54014 https://github.com/nodejs/node/pull/54014
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 25, 2024 https://github.com/nodejs/node/pull/53617#ref-pullrequest-2426551485
test_runner: remove redundant bootstrap boolean #54013 https://github.com/nodejs/node/pull/54013
https://github.com/targos
targoshttps://github.com/targos
Jul 28, 2024https://github.com/nodejs/node/pull/53617#issuecomment-2254385762
cf2bce6https://github.com/nodejs/node/commit/cf2bce63862d995d238802ff4a7a24966361360a
Please reload this pagehttps://github.com/nodejs/node/pull/53617
fs: fix regression on rmsync #53982 https://github.com/nodejs/node/pull/53982
src: do not save c_str of a temp string #53941 https://github.com/nodejs/node/pull/53941
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 2, 2024 https://github.com/nodejs/node/pull/53617#ref-pullrequest-2440989442
test_runner: run after hooks even if test is aborted #54151 https://github.com/nodejs/node/pull/54151
https://github.com/aduh95
aduh95https://github.com/aduh95
Oct 14, 2024 https://github.com/nodejs/node/pull/53617#ref-pullrequest-2576566977
2024-10-16, Version 23.0.0 (Current) #55338 https://github.com/nodejs/node/pull/55338
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 29, 2024 https://github.com/nodejs/node/pull/53617#ref-issue-2701300828
fs.rmSync('速') crash without throw #56049 https://github.com/nodejs/node/issues/56049
https://github.com/apps/claude
claudehttps://github.com/apps/claude
Jul 8, 2026 https://github.com/nodejs/node/pull/53617#ref-pullrequest-4840935807
fix: clear read-only attribute before removal in RmSync on Windows electron/electron#52291 https://github.com/electron/electron/pull/52291
https://github.com/nmggithub
nmggithubhttps://github.com/nmggithub
Jul 8, 2026 https://github.com/nodejs/node/pull/53617#ref-issue-4841123411
fs.rmSync cannot remove read-only files on Windows when Node is built with libc++ #64374 https://github.com/nodejs/node/issues/64374
https://github.com/hobbes7878
hobbes7878https://github.com/hobbes7878
Jul 28, 2026 https://github.com/nodejs/node/pull/53617#ref-pullrequest-5000874966
fix: support Node 24 by testing against real temp projects reuters-graphics/graphics-kit-publisher#163 https://github.com/reuters-graphics/graphics-kit-publisher/pull/163
https://github.com/Micka420-collab
Micka420-collabhttps://github.com/Micka420-collab
Sep 28, 2026 https://github.com/nodejs/node/pull/53617#ref-pullrequest-5618670762
fix(node): task folders erase under the desktop app on Windows; refusals say their real cause Micka420-collab/hive#538 https://github.com/Micka420-collab/hive/pull/538
https://github.com/tchopoorian
tchopoorianhttps://github.com/tchopoorian
Sep 28, 2026 https://github.com/nodejs/node/pull/53617#ref-pullrequest-5620705958
test(update): remove the data symlink with unlinkSync, not rmSync nanocoai/nanoclaw#3963 https://github.com/nanocoai/nanoclaw/pull/3963
Micka420-collabhttps://github.com/Micka420-collab
Oct 3, 2026 https://github.com/nodejs/node/pull/53617#ref-commit-51101cb
https://github.com/claude
fix(node): erase task folders with fs.promises.rm; refusals carry the…https://github.com/Micka420-collab/hive/commit/51101cbcea1b8e164e6a46e10a3ca4a423c5962d
51101cbhttps://github.com/Micka420-collab/hive/commit/51101cbcea1b8e164e6a46e10a3ca4a423c5962d
nodejs/node#53617https://github.com/nodejs/node/pull/53617
nodejs/node#64374https://github.com/nodejs/node/issues/64374
https://github.com/llevintza
llevintzahttps://github.com/llevintza
Oct 8, 2026 https://github.com/nodejs/node/pull/53617#ref-pullrequest-5761509198
[workflows] gate-tests: robust temp-repo cleanup (ENOTEMPTY race) (#249) llevintza/credit-desk-analytics#263 https://github.com/llevintza/credit-desk-analytics/pull/263
https://github.com/AmarWaqar-TSKLI
AmarWaqar-TSKLIhttps://github.com/AmarWaqar-TSKLI
Oct 14, 2026 https://github.com/nodejs/node/pull/53617#ref-pullrequest-5377966952
fs: normalize trailing dot segments for rm #65883 https://github.com/nodejs/node/pull/65883
https://github.com/jarinudom
jarinudomhttps://github.com/jarinudom
Oct 16, 2026 https://github.com/nodejs/node/pull/53617#ref-pullrequest-5880673318
fix(voiceover): replace dangling portable preference symlinks guidepup/guidepup#180 https://github.com/guidepup/guidepup/pull/180
https://github.com/arieller
ariellerhttps://github.com/arieller
Oct 26, 2026 https://github.com/nodejs/node/pull/53617#ref-issue-6033952263
fs: rmSync with recursive returns without throwing while the directory still exists #67010 https://github.com/nodejs/node/issues/67010
ariellerhttps://github.com/arieller
Oct 26, 2026 https://github.com/nodejs/node/pull/53617#ref-commit-3063dfd
https://github.com/arieller
fs: finish rmSync when an entry vanishes during the walkhttps://github.com/arieller/node/commit/3063dfde2862996735891f84af953375d9a07fae
3063dfdhttps://github.com/arieller/node/commit/3063dfde2862996735891f84af953375d9a07fae
nodejs#67010https://github.com/nodejs/node/issues/67010
nodejs#53617https://github.com/nodejs/node/pull/53617
ijun17https://github.com/ijun17
Oct 28, 2026 https://github.com/nodejs/node/pull/53617#ref-commit-9ba0bbc
https://github.com/ijun17
fix(host): state that rmSync is native from Node 23 in the OS contract (https://github.com/ijun17/centralu/commit/9ba0bbc65525514948497ec205fe892c2502a05a
9ba0bbchttps://github.com/ijun17/centralu/commit/9ba0bbc65525514948497ec205fe892c2502a05a
#1599https://github.com/ijun17/centralu/issues/1599
nodejs/node#53617https://github.com/nodejs/node/pull/53617
feat(host): an Os interface with real and in-memory OSes ijun17/centralu#1650 https://github.com/ijun17/centralu/pull/1650
Run the OS contract under the remote Node before a change lands, not only in the merge queue's full tier ijun17/centralu#1709 https://github.com/ijun17/centralu/issues/1709
https://github.com/yohannesjoya
yohannesjoyahttps://github.com/yohannesjoya
Nov 1, 2026 https://github.com/nodejs/node/pull/53617#ref-issue-6148774687
fs: rmSync() deletes a symlinked directory's contents then throws ENOTDIR when the path has a trailing slash #67186 https://github.com/nodejs/node/issues/67186
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53617
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/53617/files/8c8e2770ab6202f2b44c0fc600a462f7ffdf7c10
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/lemire
lemire https://github.com/lemire
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/jasnell
jasnell https://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/53617
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
dont-land-on-v22.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v22.x
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/53617
https://github.com/anonrig
https://github.com/nodejs-github-bot
https://github.com/benjamingr
https://github.com/aduh95
https://github.com/targos
https://github.com/lemire
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.