| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f87c824b-b60f-3455-1f92-1ccc73c627a8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9C9E:1651C0:1A398:24FB2:696A66B7 |
| html-safe-nonce | f15ff70e0fc8ff84dccdbc55d735029e51fe0a8f8c95c386de8b5a217fc3b5cc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzlFOjE2NTFDMDoxQTM5ODoyNEZCMjo2OTZBNjZCNyIsInZpc2l0b3JfaWQiOiI2MzgzODk1NDkxOTU4Njk1NjA3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7831b57fbdc8452d0f9ccef837dda17edd75b062ec1f4963981d05166d6c5b47 |
| hovercard-subject-tag | pull_request:1900304115 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/53292/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5413d5102ac23ea950488869864a4aa8f2158de95b7e11a524ddc78acfbfc740/nodejs/node/pull/53292 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5413d5102ac23ea950488869864a4aa8f2158de95b7e11a524ddc78acfbfc740/nodejs/node/pull/53292 |
| og:image:alt | This changes adds a second explicit gc call in the test. Without this
call, the test relies on gc eventually happening based, since the
first call doesn't free the object.
Relying on gc to even... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | targos |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6fea32d5b7276b841b7a803796d9715bc6cfb31ed549fdf9de2948ac25d12ba6 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f2d9f6432a5a115ec709295ae70623f33bb80aee |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/53292#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53292 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53292 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/53292 |
| Reload | https://github.com/nodejs/node/pull/53292 |
| Reload | https://github.com/nodejs/node/pull/53292 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/53292 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/53292 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/53292#issue-comment-box |
| targos | https://github.com/targos |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| targos:robust-gc | https://github.com/targos/node/tree/robust-gc |
|
test: fix test-http-server-keepalive-req-gc
| https://github.com/nodejs/node/pull/53292#top |
| targos | https://github.com/targos |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| targos:robust-gc | https://github.com/targos/node/tree/robust-gc |
|
Conversation
6
| https://github.com/nodejs/node/pull/53292 |
|
Commits
1
| https://github.com/nodejs/node/pull/53292/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/53292/checks |
|
Files changed
| https://github.com/nodejs/node/pull/53292/files |
| Please reload this page | https://github.com/nodejs/node/pull/53292 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/targos |
| targos | https://github.com/targos |
| Jun 3, 2024 | https://github.com/nodejs/node/pull/53292#issue-2330534599 |
| Please reload this page | https://github.com/nodejs/node/pull/53292 |
|
| https://github.com/etiennep-chromium |
|
| https://github.com/targos |
| test: fix test-http-server-keepalive-req-gc | https://github.com/nodejs/node/pull/53292/commits/0f0d773cf889bb031b4a910794b69e3b84cda489 |
| 0f0d773 | https://github.com/nodejs/node/pull/53292/commits/0f0d773cf889bb031b4a910794b69e3b84cda489 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
commit-queue-rebase
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-rebase |
| Jun 3, 2024 | https://github.com/nodejs/node/pull/53292#event-13017223554 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jun 3, 2024 | https://github.com/nodejs/node/pull/53292#issuecomment-2144621503 |
| v8#186 | https://github.com/v8/node/pull/186 |
| Please reload this page | https://github.com/nodejs/node/pull/53292 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Jun 3, 2024 | https://github.com/nodejs/node/pull/53292#event-13017226694 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 3, 2024 | https://github.com/nodejs/node/pull/53292#issuecomment-2145244488 |
| https://ci.nodejs.org/job/node-test-pull-request/59634/ | https://ci.nodejs.org/job/node-test-pull-request/59634/ |
| Please reload this page | https://github.com/nodejs/node/pull/53292 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 6, 2024 | https://github.com/nodejs/node/pull/53292#issuecomment-2151419052 |
| https://ci.nodejs.org/job/node-test-pull-request/59670/ | https://ci.nodejs.org/job/node-test-pull-request/59670/ |
| Please reload this page | https://github.com/nodejs/node/pull/53292 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jun 6, 2024 | https://github.com/nodejs/node/pull/53292#issuecomment-2151522946 |
| Please reload this page | https://github.com/nodejs/node/pull/53292 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jun 7, 2024
| https://github.com/nodejs/node/pull/53292#pullrequestreview-2105182781 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/53292/files/0f0d773cf889bb031b4a910794b69e3b84cda489 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Jun 10, 2024 | https://github.com/nodejs/node/pull/53292#event-13096909493 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Jun 10, 2024 | https://github.com/nodejs/node/pull/53292#event-13097083225 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 10, 2024 | https://github.com/nodejs/node/pull/53292#issuecomment-2157670476 |
| https://github.com/nodejs/node/actions/runs/9444846586 | https://github.com/nodejs/node/actions/runs/9444846586 |
| Please reload this page | https://github.com/nodejs/node/pull/53292 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
|
commit-queue-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed |
| Jun 10, 2024 | https://github.com/nodejs/node/pull/53292#event-13098389278 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Jun 10, 2024 | https://github.com/nodejs/node/pull/53292#event-13098463820 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Jun 10, 2024
| https://github.com/nodejs/node/pull/53292#ref-commit-2dea6a4 |
|
| https://github.com/etiennep-chromium |
|
| https://github.com/nodejs-github-bot |
| test: fix test-http-server-keepalive-req-gc | https://github.com/nodejs/node/commit/2dea6a4520b8f235465f638e25ed89cedfc8bf81 |
| 2dea6a4 | https://github.com/nodejs/node/commit/2dea6a4520b8f235465f638e25ed89cedfc8bf81 |
| #53292 | https://github.com/nodejs/node/pull/53292 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 10, 2024 | https://github.com/nodejs/node/pull/53292#issuecomment-2157854383 |
| db09f62...2dea6a4 | https://github.com/nodejs/node/compare/db09f62c7987c2ce5496811135f6194b40456616...2dea6a4520b8f235465f638e25ed89cedfc8bf81 |
| Please reload this page | https://github.com/nodejs/node/pull/53292 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 10, 2024 | https://github.com/nodejs/node/pull/53292#event-13098465827 |
| https://github.com/targos |
| targos | https://github.com/targos |
| June 10, 2024 09:41 | https://github.com/nodejs/node/pull/53292#event-13098514442 |
| targos | https://github.com/targos |
|
Jun 20, 2024
| https://github.com/nodejs/node/pull/53292#ref-commit-4a3525b |
|
| https://github.com/etiennep-chromium |
|
| https://github.com/targos |
| test: fix test-http-server-keepalive-req-gc | https://github.com/nodejs/node/commit/4a3525bb085dfa03178ac5d148d9a02d06712f7c |
| 4a3525b | https://github.com/nodejs/node/commit/4a3525bb085dfa03178ac5d148d9a02d06712f7c |
| #53292 | https://github.com/nodejs/node/pull/53292 |
| ebouye | https://github.com/ebouye |
|
Jun 20, 2024
| https://github.com/nodejs/node/pull/53292#ref-commit-0f1b3b2 |
|
| https://github.com/etiennep-chromium |
|
| https://github.com/ebouye |
| test: fix test-http-server-keepalive-req-gc | https://github.com/ebouye/node/commit/0f1b3b22637e816c15ddcf9a3976a798bcc9bea0 |
| 0f1b3b2 | https://github.com/ebouye/node/commit/0f1b3b22637e816c15ddcf9a3976a798bcc9bea0 |
| nodejs#53292 | https://github.com/nodejs/node/pull/53292 |
| bmeck | https://github.com/bmeck |
|
Jun 22, 2024
| https://github.com/nodejs/node/pull/53292#ref-commit-261eb67 |
|
| https://github.com/etiennep-chromium |
|
| https://github.com/bmeck |
| test: fix test-http-server-keepalive-req-gc | https://github.com/bmeck/node/commit/261eb678a8cdf09b3418c409bbd9ce3e3051efea |
| 261eb67 | https://github.com/bmeck/node/commit/261eb678a8cdf09b3418c409bbd9ce3e3051efea |
| nodejs#53292 | https://github.com/nodejs/node/pull/53292 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jun 25, 2024
| https://github.com/nodejs/node/pull/53292#ref-pullrequest-2372507873 |
|
v22.4.0 release proposal
#53583
| https://github.com/nodejs/node/pull/53583 |
| https://github.com/Karliz24 |
| Karliz24 | https://github.com/Karliz24 |
|
Jul 9, 2024
| https://github.com/nodejs/node/pull/53292#ref-issue-2396946531 |
|
## 2024-07-02, Version 22.4.0 (Current), @targos
Karliz24/Marley-#16
| https://github.com/Karliz24/Marley-/issues/16 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jul 19, 2024
| https://github.com/nodejs/node/pull/53292#ref-commit-ca3220f |
|
| https://github.com/etiennep-chromium |
|
| https://github.com/marco-ippolito |
| test: fix test-http-server-keepalive-req-gc | https://github.com/nodejs/node/commit/ca3220ffaf0d24661c37791fd91c9d8735a3cf72 |
| ca3220f | https://github.com/nodejs/node/commit/ca3220ffaf0d24661c37791fd91c9d8735a3cf72 |
| #53292 | https://github.com/nodejs/node/pull/53292 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jul 19, 2024
| https://github.com/nodejs/node/pull/53292#ref-commit-49e6f33 |
|
| https://github.com/etiennep-chromium |
|
| https://github.com/marco-ippolito |
| test: fix test-http-server-keepalive-req-gc | https://github.com/nodejs/node/commit/49e6f3302146ff72f9a88bc026e54d5a2c65be5c |
| 49e6f33 | https://github.com/nodejs/node/commit/49e6f3302146ff72f9a88bc026e54d5a2c65be5c |
| #53292 | https://github.com/nodejs/node/pull/53292 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jul 19, 2024
| https://github.com/nodejs/node/pull/53292#ref-pullrequest-2418939282 |
|
v20.16.0 proposal
#53945
| https://github.com/nodejs/node/pull/53945 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53292 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/53292/files/0f0d773cf889bb031b4a910794b69e3b84cda489 |
|
commit-queue-rebase
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-rebase |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/53292 |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/lpinca |
|
| https://github.com/etiennep-chromium |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |