| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6b7cdd18-efa9-4bff-7466-1405464637de |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B134:2A6639:1012A3:14F8E0:696AFD5A |
| html-safe-nonce | 5c47cc85398539a131a5755b92db02d42395e490632102051eddda0caa313001 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTM0OjJBNjYzOToxMDEyQTM6MTRGOEUwOjY5NkFGRDVBIiwidmlzaXRvcl9pZCI6IjUzNjg1ODUxODYxOTIzMjU5NzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 60637fde58a17a109356393d3b26b0acd7e991efbb4570a32bd6abe16df5a730 |
| hovercard-subject-tag | pull_request:1898723006 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/53239/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b285dcd734ac6acddf939b4ef05951fb7b19bc56d8bec2175cdf6676ad662705/nodejs/node/pull/53239 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b285dcd734ac6acddf939b4ef05951fb7b19bc56d8bec2175cdf6676ad662705/nodejs/node/pull/53239 |
| og:image:alt | This PR basically ports on-exit-leak-free to core, in their words:
This module helps dispose of an object gracefully when the Node.js process exits. It executes a function with a given parameter o... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | H4ad |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/53239#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53239 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53239 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/53239 |
| Reload | https://github.com/nodejs/node/pull/53239 |
| Reload | https://github.com/nodejs/node/pull/53239 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
692
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/53239#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| H4ad:add-on-exit-leak | https://github.com/H4ad/node/tree/add-on-exit-leak |
|
process: port on-exit-leak-free to core
| https://github.com/nodejs/node/pull/53239#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| H4ad:add-on-exit-leak | https://github.com/H4ad/node/tree/add-on-exit-leak |
|
Conversation
98
| https://github.com/nodejs/node/pull/53239 |
|
Commits
20
| https://github.com/nodejs/node/pull/53239/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/53239/checks |
|
Files changed
| https://github.com/nodejs/node/pull/53239/files |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
| May 31, 2024 | https://github.com/nodejs/node/pull/53239#issue-2328690051 |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| on-exit-leak-free | https://github.com/mcollina/on-exit-leak-free |
| 'exit' | https://nodejs.org/api/process.html#event-exit |
| @mcollina | https://github.com/mcollina |
| #48058 | https://github.com/nodejs/node/issues/48058 |
| @tniessen | https://github.com/tniessen |
| ref comment | https://github.com/nodejs/node/issues/48058#issuecomment-1554691802 |
| @aduh95 | https://github.com/aduh95 |
| ref comment | https://github.com/nodejs/node/issues/48058#issuecomment-1555043303 |
| on-exit-leak-free, copy or move to core? H4ad/nodejs-logging-proposal#10 | https://github.com/H4ad/nodejs-logging-proposal/issues/10 |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 31, 2024 | https://github.com/nodejs/node/pull/53239#issuecomment-2143082035 |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess |
| May 31, 2024 | https://github.com/nodejs/node/pull/53239#event-13006580454 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jun 1, 2024
| https://github.com/nodejs/node/pull/53239#pullrequestreview-2092025444 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/53239/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/53239#pullrequestreview-2092025444 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| lib/internal/process/per_thread.js | https://github.com/nodejs/node/pull/53239/files#diff-38d3873e06750436cd724af3eb60026b1bb8da914467797cf7ef7a3c94bd74ce |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Jun 1, 2024 | https://github.com/nodejs/node/pull/53239#event-13009373025 |
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
| June 1, 2024 15:20 | https://github.com/nodejs/node/pull/53239#event-13009464055 |
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
| mcollina | https://github.com/mcollina |
| June 1, 2024 18:05 | https://github.com/nodejs/node/pull/53239#event-13009816621 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Jun 1, 2024
| https://github.com/nodejs/node/pull/53239#pullrequestreview-2092184586 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/53239/files |
| LICENSE | https://github.com/nodejs/node/pull/53239/files#diff-c693279643b8cd5d248172d9c22cb7cf4ed163a3c98c8a3f69c2717edd3eacb7 |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jun 2, 2024
| https://github.com/nodejs/node/pull/53239#pullrequestreview-2092230836 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/53239/files |
| doc/api/process.md | https://github.com/nodejs/node/pull/53239/files#diff-5212ec434ff69f31e0de5e7e6f57abd45d810780c60f05736ab31eae5a395186 |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/atlowChemi |
| atlowChemi | https://github.com/atlowChemi |
|
Jun 2, 2024
| https://github.com/nodejs/node/pull/53239#pullrequestreview-2092593520 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/53239/files |
| lib/internal/process/finalization.js | https://github.com/nodejs/node/pull/53239/files#diff-b79ec0072bb9f274c7ef124dfe08c0708a3c6bcebc8d8b39852487c2db437067 |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/atlowChemi |
| atlowChemi | https://github.com/atlowChemi |
|
Jun 2, 2024
| https://github.com/nodejs/node/pull/53239#pullrequestreview-2092593566 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/53239/files |
| lib/internal/process/finalization.js | https://github.com/nodejs/node/pull/53239/files#diff-b79ec0072bb9f274c7ef124dfe08c0708a3c6bcebc8d8b39852487c2db437067 |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| lib/internal/process/finalization.js | https://github.com/nodejs/node/pull/53239/files#diff-b79ec0072bb9f274c7ef124dfe08c0708a3c6bcebc8d8b39852487c2db437067 |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| lib/internal/process/finalization.js | https://github.com/nodejs/node/pull/53239/files#diff-b79ec0072bb9f274c7ef124dfe08c0708a3c6bcebc8d8b39852487c2db437067 |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jun 4, 2024
| https://github.com/nodejs/node/pull/53239#pullrequestreview-2095590912 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/53239/files |
| doc/api/process.md | https://github.com/nodejs/node/pull/53239/files#diff-5212ec434ff69f31e0de5e7e6f57abd45d810780c60f05736ab31eae5a395186 |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jun 8, 2024
| https://github.com/nodejs/node/pull/53239#pullrequestreview-2105841043 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/53239/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/53239#pullrequestreview-2105841043 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/atlowChemi |
| atlowChemi | https://github.com/atlowChemi |
|
Jun 9, 2024
| https://github.com/nodejs/node/pull/53239#pullrequestreview-2106179187 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/53239/files |
| https://github.com/atlowChemi |
| atlowChemi | https://github.com/atlowChemi |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jun 9, 2024 | https://github.com/nodejs/node/pull/53239#event-13091146144 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jun 9, 2024 | https://github.com/nodejs/node/pull/53239#event-13091171833 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 9, 2024 | https://github.com/nodejs/node/pull/53239#issuecomment-2156532603 |
| https://ci.nodejs.org/job/node-test-pull-request/59706/ | https://ci.nodejs.org/job/node-test-pull-request/59706/ |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/atlowChemi |
| atlowChemi | https://github.com/atlowChemi |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jun 9, 2024 | https://github.com/nodejs/node/pull/53239#event-13091186285 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jun 9, 2024 | https://github.com/nodejs/node/pull/53239#event-13091357572 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 9, 2024 | https://github.com/nodejs/node/pull/53239#issuecomment-2156581964 |
| https://ci.nodejs.org/job/node-test-pull-request/59707/ | https://ci.nodejs.org/job/node-test-pull-request/59707/ |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 9, 2024 | https://github.com/nodejs/node/pull/53239#issuecomment-2156625953 |
| https://ci.nodejs.org/job/node-test-pull-request/59708/ | https://ci.nodejs.org/job/node-test-pull-request/59708/ |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
| Jun 9, 2024 | https://github.com/nodejs/node/pull/53239#issuecomment-2156629025 |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Jun 9, 2024 | https://github.com/nodejs/node/pull/53239#event-13091976505 |
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
| Jun 9, 2024 | https://github.com/nodejs/node/pull/53239#issuecomment-2156688217 |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
|
Jun 10, 2024
| https://github.com/nodejs/node/pull/53239#pullrequestreview-2107369870 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/53239/files |
| ShogunPanda | https://github.com/ShogunPanda |
| https://github.com/nodejs/node/pull/53239#pullrequestreview-2107369870 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
Jun 10, 2024
| https://github.com/nodejs/node/pull/53239#pullrequestreview-2108205124 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/53239/files |
| RafaelGSS | https://github.com/RafaelGSS |
| https://github.com/nodejs/node/pull/53239#pullrequestreview-2108205124 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| doc/api/process.md | https://github.com/nodejs/node/pull/53239/files#diff-5212ec434ff69f31e0de5e7e6f57abd45d810780c60f05736ab31eae5a395186 |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| doc/api/process.md | https://github.com/nodejs/node/pull/53239/files#diff-5212ec434ff69f31e0de5e7e6f57abd45d810780c60f05736ab31eae5a395186 |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| lib/internal/process/finalization.js | https://github.com/nodejs/node/pull/53239/files#diff-b79ec0072bb9f274c7ef124dfe08c0708a3c6bcebc8d8b39852487c2db437067 |
| RafaelGSS | https://github.com/RafaelGSS |
| Jun 10, 2024 | https://github.com/nodejs/node/pull/53239#discussion_r1633498248 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| H4ad | https://github.com/H4ad |
| Jun 10, 2024 | https://github.com/nodejs/node/pull/53239#discussion_r1633931282 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Jun 10, 2024 | https://github.com/nodejs/node/pull/53239#issuecomment-2158946339 |
| @H4ad | https://github.com/H4ad |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jun 11, 2024
| https://github.com/nodejs/node/pull/53239#pullrequestreview-2109917131 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/53239/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/53239#pullrequestreview-2109917131 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| H4ad | https://github.com/H4ad |
| July 11, 2024 08:24 | https://github.com/nodejs/node/pull/53239#commits-pushed-c094345 |
|
| https://github.com/H4ad |
| attempt to improve the docs | https://github.com/nodejs/node/pull/53239/commits/c094345b2fa62b1709699822e9cc1cce32929588 |
| c094345 | https://github.com/nodejs/node/pull/53239/commits/c094345b2fa62b1709699822e9cc1cce32929588 |
|
| https://github.com/H4ad |
| remove stdout usages | https://github.com/nodejs/node/pull/53239/commits/8002996d5ef8b1b7c59faba515573390eabe0986 |
| 8002996 | https://github.com/nodejs/node/pull/53239/commits/8002996d5ef8b1b7c59faba515573390eabe0986 |
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
| force-pushed | https://github.com/nodejs/node/compare/a9b9fe60ac8605e9dde90a9e7439895317622a47..8002996d5ef8b1b7c59faba515573390eabe0986 |
| a9b9fe6 | https://github.com/nodejs/node/commit/a9b9fe60ac8605e9dde90a9e7439895317622a47 |
| 8002996 | https://github.com/nodejs/node/commit/8002996d5ef8b1b7c59faba515573390eabe0986 |
|
Compare
| https://github.com/nodejs/node/compare/a9b9fe60ac8605e9dde90a9e7439895317622a47..8002996d5ef8b1b7c59faba515573390eabe0986 |
| July 11, 2024 11:42 | https://github.com/nodejs/node/pull/53239#event-13470464788 |
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
| Jul 11, 2024 | https://github.com/nodejs/node/pull/53239#issuecomment-2222725255 |
| @cjinhuo | https://github.com/cjinhuo |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jul 11, 2024 | https://github.com/nodejs/node/pull/53239#event-13472586458 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jul 11, 2024 | https://github.com/nodejs/node/pull/53239#event-13472630774 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 11, 2024 | https://github.com/nodejs/node/pull/53239#issuecomment-2223067751 |
| https://ci.nodejs.org/job/node-test-pull-request/60247/ | https://ci.nodejs.org/job/node-test-pull-request/60247/ |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Jul 11, 2024
| https://github.com/nodejs/node/pull/53239#pullrequestreview-2172571876 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/53239/files/8002996d5ef8b1b7c59faba515573390eabe0986 |
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
| Jul 11, 2024 | https://github.com/nodejs/node/pull/53239#event-13475408233 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Jul 11, 2024 | https://github.com/nodejs/node/pull/53239#event-13475490803 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| 05bb4a7 | https://github.com/nodejs/node/commit/05bb4a716b40385a0ed8e3ff315913fd8037b18a |
| Jul 11, 2024 | https://github.com/nodejs/node/pull/53239#event-13475491739 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 11, 2024 | https://github.com/nodejs/node/pull/53239#issuecomment-2223546597 |
| 05bb4a7 | https://github.com/nodejs/node/commit/05bb4a716b40385a0ed8e3ff315913fd8037b18a |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
| July 11, 2024 20:45 | https://github.com/nodejs/node/pull/53239#event-13477848984 |
| aduh95 | https://github.com/aduh95 |
|
Jul 12, 2024
| https://github.com/nodejs/node/pull/53239#ref-commit-132deec |
|
| https://github.com/H4ad |
|
| https://github.com/aduh95 |
| process: port on-exit-leak-free to core | https://github.com/nodejs/node/commit/132deec04cc496827fe704ac8719075f4e436265 |
| 132deec | https://github.com/nodejs/node/commit/132deec04cc496827fe704ac8719075f4e436265 |
| #53239 | https://github.com/nodejs/node/pull/53239 |
| aduh95 | https://github.com/aduh95 |
|
Jul 12, 2024
| https://github.com/nodejs/node/pull/53239#ref-commit-d4d03e2 |
|
| https://github.com/aduh95 |
| 2024-07-15, Version 22.5.0 (Current) | https://github.com/nodejs/node/commit/d4d03e25022680e019822d2425c820fa586c392f |
| d4d03e2 | https://github.com/nodejs/node/commit/d4d03e25022680e019822d2425c820fa586c392f |
| #53721 | https://github.com/nodejs/node/pull/53721 |
| #52166 | https://github.com/nodejs/node/pull/52166 |
| #52881 | https://github.com/nodejs/node/pull/52881 |
| #53239 | https://github.com/nodejs/node/pull/53239 |
| #53462 | https://github.com/nodejs/node/pull/53462 |
| #53682 | https://github.com/nodejs/node/pull/53682 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jul 12, 2024
| https://github.com/nodejs/node/pull/53239#ref-pullrequest-2405844873 |
|
V22.5.0 proposal
#53826
| https://github.com/nodejs/node/pull/53826 |
| aduh95 | https://github.com/aduh95 |
|
Jul 12, 2024
| https://github.com/nodejs/node/pull/53239#ref-commit-df75c77 |
|
| https://github.com/aduh95 |
| 2024-07-15, Version 22.5.0 (Current) | https://github.com/nodejs/node/commit/df75c779f41a4058f027db7f8e64a226be253a75 |
| df75c77 | https://github.com/nodejs/node/commit/df75c779f41a4058f027db7f8e64a226be253a75 |
| #53721 | https://github.com/nodejs/node/pull/53721 |
| #52166 | https://github.com/nodejs/node/pull/52166 |
| #52881 | https://github.com/nodejs/node/pull/52881 |
| #53239 | https://github.com/nodejs/node/pull/53239 |
| #53462 | https://github.com/nodejs/node/pull/53462 |
| #53682 | https://github.com/nodejs/node/pull/53682 |
| #53826 | https://github.com/nodejs/node/pull/53826 |
| aduh95 | https://github.com/aduh95 |
|
Jul 16, 2024
| https://github.com/nodejs/node/pull/53239#ref-commit-77936c3 |
|
| https://github.com/H4ad |
|
| https://github.com/aduh95 |
| process: port on-exit-leak-free to core | https://github.com/nodejs/node/commit/77936c3d2482ded2cb868f20f177433081b6dca8 |
| 77936c3 | https://github.com/nodejs/node/commit/77936c3d2482ded2cb868f20f177433081b6dca8 |
| #53239 | https://github.com/nodejs/node/pull/53239 |
| aduh95 | https://github.com/aduh95 |
|
Jul 16, 2024
| https://github.com/nodejs/node/pull/53239#ref-commit-b90d208 |
|
| https://github.com/aduh95 |
| 2024-07-16, Version 22.5.0 (Current) | https://github.com/nodejs/node/commit/b90d208f446d6711766ae42508cc2671881c7cc0 |
| b90d208 | https://github.com/nodejs/node/commit/b90d208f446d6711766ae42508cc2671881c7cc0 |
| #53721 | https://github.com/nodejs/node/pull/53721 |
| #53752 | https://github.com/nodejs/node/pull/53752 |
| #52166 | https://github.com/nodejs/node/pull/52166 |
| #52881 | https://github.com/nodejs/node/pull/52881 |
| #53239 | https://github.com/nodejs/node/pull/53239 |
| #53462 | https://github.com/nodejs/node/pull/53462 |
| #53553 | https://github.com/nodejs/node/pull/53553 |
| #53682 | https://github.com/nodejs/node/pull/53682 |
| #53826 | https://github.com/nodejs/node/pull/53826 |
| aduh95 | https://github.com/aduh95 |
|
Jul 16, 2024
| https://github.com/nodejs/node/pull/53239#ref-commit-3f9c06e |
|
| https://github.com/aduh95 |
| 2024-07-16, Version 22.5.0 (Current) | https://github.com/nodejs/node/commit/3f9c06ec87926b4948dbbb746be95230e0465112 |
| 3f9c06e | https://github.com/nodejs/node/commit/3f9c06ec87926b4948dbbb746be95230e0465112 |
| #53721 | https://github.com/nodejs/node/pull/53721 |
| #53752 | https://github.com/nodejs/node/pull/53752 |
| #52166 | https://github.com/nodejs/node/pull/52166 |
| #52881 | https://github.com/nodejs/node/pull/52881 |
| #53239 | https://github.com/nodejs/node/pull/53239 |
| #53462 | https://github.com/nodejs/node/pull/53462 |
| #53553 | https://github.com/nodejs/node/pull/53553 |
| #53682 | https://github.com/nodejs/node/pull/53682 |
| #53826 | https://github.com/nodejs/node/pull/53826 |
| aduh95 | https://github.com/aduh95 |
|
Jul 16, 2024
| https://github.com/nodejs/node/pull/53239#ref-commit-433f759 |
|
| https://github.com/aduh95 |
| 2024-07-16, Version 22.5.0 (Current) | https://github.com/nodejs/node/commit/433f759f20cdb832b812f3a3288bba6bd2a25fef |
| 433f759 | https://github.com/nodejs/node/commit/433f759f20cdb832b812f3a3288bba6bd2a25fef |
| #53721 | https://github.com/nodejs/node/pull/53721 |
| #53752 | https://github.com/nodejs/node/pull/53752 |
| #52166 | https://github.com/nodejs/node/pull/52166 |
| #52881 | https://github.com/nodejs/node/pull/52881 |
| #53239 | https://github.com/nodejs/node/pull/53239 |
| #53462 | https://github.com/nodejs/node/pull/53462 |
| #53553 | https://github.com/nodejs/node/pull/53553 |
| #53682 | https://github.com/nodejs/node/pull/53682 |
| #53826 | https://github.com/nodejs/node/pull/53826 |
| aduh95 | https://github.com/aduh95 |
|
Jul 17, 2024
| https://github.com/nodejs/node/pull/53239#ref-commit-34de839 |
|
| https://github.com/aduh95 |
| 2024-07-17, Version 22.5.0 (Current) | https://github.com/nodejs/node/commit/34de83994ef1b0d62bac5e351bbeb55f5318aa08 |
| 34de839 | https://github.com/nodejs/node/commit/34de83994ef1b0d62bac5e351bbeb55f5318aa08 |
| #53721 | https://github.com/nodejs/node/pull/53721 |
| #53752 | https://github.com/nodejs/node/pull/53752 |
| #52166 | https://github.com/nodejs/node/pull/52166 |
| #52881 | https://github.com/nodejs/node/pull/52881 |
| #53239 | https://github.com/nodejs/node/pull/53239 |
| #53462 | https://github.com/nodejs/node/pull/53462 |
| #53553 | https://github.com/nodejs/node/pull/53553 |
| #53682 | https://github.com/nodejs/node/pull/53682 |
| #53826 | https://github.com/nodejs/node/pull/53826 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Jul 17, 2024
| https://github.com/nodejs/node/pull/53239#ref-commit-db1c2be |
|
| https://github.com/aduh95 |
|
| https://github.com/RafaelGSS |
| 2024-07-17, Version 22.5.0 (Current) | https://github.com/nodejs/node/commit/db1c2beae64d950966b88d3940f35a40c2a448e6 |
| db1c2be | https://github.com/nodejs/node/commit/db1c2beae64d950966b88d3940f35a40c2a448e6 |
| #53721 | https://github.com/nodejs/node/pull/53721 |
| #53752 | https://github.com/nodejs/node/pull/53752 |
| #52166 | https://github.com/nodejs/node/pull/52166 |
| #52881 | https://github.com/nodejs/node/pull/52881 |
| #53239 | https://github.com/nodejs/node/pull/53239 |
| #53462 | https://github.com/nodejs/node/pull/53462 |
| #53553 | https://github.com/nodejs/node/pull/53553 |
| #53682 | https://github.com/nodejs/node/pull/53682 |
| #53826 | https://github.com/nodejs/node/pull/53826 |
| https://github.com/Araxeus |
| Araxeus | https://github.com/Araxeus |
|
Jul 18, 2024
| https://github.com/nodejs/node/pull/53239#ref-issue-1295849143 |
|
Not cleaning things up...
mcollina/on-exit-leak-free#31
| https://github.com/mcollina/on-exit-leak-free/issues/31 |
| ehsankhfr | https://github.com/ehsankhfr |
|
Jul 18, 2024
| https://github.com/nodejs/node/pull/53239#ref-commit-b18fee9 |
|
| https://github.com/H4ad |
|
| https://github.com/ehsankhfr |
| process: port on-exit-leak-free to core | https://github.com/ehsankhfr/node/commit/b18fee9d061cf9d1b31d2819e6ae6c5b497f71d2 |
| b18fee9 | https://github.com/ehsankhfr/node/commit/b18fee9d061cf9d1b31d2819e6ae6c5b497f71d2 |
| nodejs#53239 | https://github.com/nodejs/node/pull/53239 |
| ehsankhfr | https://github.com/ehsankhfr |
|
Jul 18, 2024
| https://github.com/nodejs/node/pull/53239#ref-commit-274b746 |
|
| https://github.com/aduh95 |
|
| https://github.com/ehsankhfr |
| 2024-07-17, Version 22.5.0 (Current) | https://github.com/ehsankhfr/node/commit/274b746519b3bfe4168a0ed1204efaa67de78e01 |
| 274b746 | https://github.com/ehsankhfr/node/commit/274b746519b3bfe4168a0ed1204efaa67de78e01 |
| nodejs#53721 | https://github.com/nodejs/node/pull/53721 |
| nodejs#53752 | https://github.com/nodejs/node/pull/53752 |
| nodejs#52166 | https://github.com/nodejs/node/pull/52166 |
| nodejs#52881 | https://github.com/nodejs/node/pull/52881 |
| nodejs#53239 | https://github.com/nodejs/node/pull/53239 |
| nodejs#53462 | https://github.com/nodejs/node/pull/53462 |
| nodejs#53553 | https://github.com/nodejs/node/pull/53553 |
| nodejs#53682 | https://github.com/nodejs/node/pull/53682 |
| nodejs#53826 | https://github.com/nodejs/node/pull/53826 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
dont-land-on-v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x |
| Sep 21, 2024 | https://github.com/nodejs/node/pull/53239#event-14349120742 |
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
|
Jan 18, 2025
| https://github.com/nodejs/node/pull/53239#ref-issue-2797051643 |
|
Should we deprecate this package?
mcollina/on-exit-leak-free#65
| https://github.com/mcollina/on-exit-leak-free/issues/65 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Oct 4, 2025
| https://github.com/nodejs/node/pull/53239#ref-pullrequest-3482900393 |
|
lib: create util.log function
#60116
| https://github.com/nodejs/node/pull/60116 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53239 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/53239/files/ba106bb57ffdfd0bea8775a81adbc996c91ccb52 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/53239/files/ba106bb57ffdfd0bea8775a81adbc996c91ccb52 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/53239/files/bdc14e363008544ff0d03a40f1e02ee5ff8c3f1d |
|
| https://github.com/RafaelGSS |
|
RafaelGSS
| https://github.com/RafaelGSS |
|
| https://github.com/nodejs/node/pull/53239/files/465efc15493e317047c771474f78cad4d69048fc |
|
| https://github.com/ShogunPanda |
|
ShogunPanda
| https://github.com/ShogunPanda |
|
| https://github.com/nodejs/node/pull/53239/files/465efc15493e317047c771474f78cad4d69048fc |
|
| https://github.com/anonrig |
|
anonrig
| https://github.com/anonrig |
|
| https://github.com/nodejs/node/pull/53239/files/8002996d5ef8b1b7c59faba515573390eabe0986 |
|
| https://github.com/atlowChemi |
|
atlowChemi
| https://github.com/atlowChemi |
|
| https://github.com/nodejs/node/pull/53239/files/465efc15493e317047c771474f78cad4d69048fc |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
|
dont-land-on-v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Please reload this page | https://github.com/nodejs/node/pull/53239 |
|
| https://github.com/H4ad |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mcollina |
|
| https://github.com/joyeecheung |
|
| https://github.com/benjamingr |
|
| https://github.com/GeoffreyBooth |
|
| https://github.com/cjinhuo |
|
| https://github.com/ShogunPanda |
|
| https://github.com/anonrig |
|
| https://github.com/targos |
|
| https://github.com/tniessen |
|
| https://github.com/RafaelGSS |
|
| https://github.com/atlowChemi |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |