René's URL Explorer Experiment


Title: module: allow module.register from workers by dygabo · Pull Request #53200 · nodejs/node · GitHub

Open Graph Title: module: allow module.register from workers by dygabo · Pull Request #53200 · nodejs/node

X Title: module: allow module.register from workers by dygabo · Pull Request #53200 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: this is a fix for #53182 by implementing a guard on the native side, we can ensure that the internal customization hooks thread is instantiated only once but not necessarily from the main thread. h...

X Description: this is a fix for #53182 by implementing a guard on the native side, we can ensure that the internal customization hooks thread is instantiated only once but not necessarily from the main thread. h...

Opengraph URL: https://github.com/nodejs/node/pull/53200

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:283423fc-568c-8f17-4dca-bbccd9f062e0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA3C6:22C227:428503:5AAE48:6A4DC756
html-safe-noncebc231ce85d7fb7db13130f011ab72adfe364093061072c1f5621bb1ec9db51f1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0M2OjIyQzIyNzo0Mjg1MDM6NUFBRTQ4OjZBNERDNzU2IiwidmlzaXRvcl9pZCI6IjI4ODQ3MDIzODY1NzEyOTg2NDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac78c6bf119879296af8d0bdd4365d18b2e06b0acd8f3cd49cbdafab1e0b7cc59f
hovercard-subject-tagpull_request:1893968687
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/53200/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2e5e865388775b7554a5b5ba9ca13d43ccd47f6eabca3ce07db6ee40c45c96b7/nodejs/node/pull/53200
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2e5e865388775b7554a5b5ba9ca13d43ccd47f6eabca3ce07db6ee40c45c96b7/nodejs/node/pull/53200
og:image:altthis is a fix for #53182 by implementing a guard on the native side, we can ensure that the internal customization hooks thread is instantiated only once but not necessarily from the main thread. h...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedygabo
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/53200#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53200
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53200
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/53200
Reloadhttps://github.com/nodejs/node/pull/53200
Reloadhttps://github.com/nodejs/node/pull/53200
Please reload this pagehttps://github.com/nodejs/node/pull/53200
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/53200
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 962 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
dygabohttps://github.com/dygabo
nodejs:mainhttps://github.com/nodejs/node/tree/main
dygabo:allow-hooks-thread-from-workerhttps://github.com/dygabo/node/tree/allow-hooks-thread-from-worker
Conversationhttps://github.com/nodejs/node/pull/53200
Commits12 (12)https://github.com/nodejs/node/pull/53200/commits
Checkshttps://github.com/nodejs/node/pull/53200/checks
Files changedhttps://github.com/nodejs/node/pull/53200/files
module: allow module.register from workershttps://github.com/nodejs/node/pull/53200#top
dygabohttps://github.com/dygabo
nodejs:mainhttps://github.com/nodejs/node/tree/main
dygabo:allow-hooks-thread-from-workerhttps://github.com/dygabo/node/tree/allow-hooks-thread-from-worker
https://github.com/dygabo
dygabohttps://github.com/dygabo
May 29, 2024https://github.com/nodejs/node/pull/53200#issue-2323392649
Please reload this pagehttps://github.com/nodejs/node/pull/53200
#53182https://github.com/nodejs/node/issues/53182
https://github.com/ShogunPanda/hooks-reprohttps://github.com/ShogunPanda/hooks-repro
this commenthttps://github.com/nodejs/node/issues/53182#issuecomment-2136443532
#53183https://github.com/nodejs/node/pull/53183
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 29, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2137469959
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
May 29, 2024https://github.com/nodejs/node/pull/53200#event-12972307607
https://github.com/dygabo
dygabohttps://github.com/dygabo
May 29, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2137471170
@mcollinahttps://github.com/mcollina
@ShogunPandahttps://github.com/ShogunPanda
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/dygabo
dygabohttps://github.com/dygabo
May 29, 2024 13:52https://github.com/nodejs/node/pull/53200#event-12972314992
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
May 29, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2137482645
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/aduh95
aduh95https://github.com/aduh95
May 29, 2024 https://github.com/nodejs/node/pull/53200#pullrequestreview-2085521963
View reviewed changes https://github.com/nodejs/node/pull/53200/files
lib/internal/modules/esm/hooks.jshttps://github.com/nodejs/node/pull/53200/files#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/aduh95
aduh95https://github.com/aduh95
May 29, 2024 https://github.com/nodejs/node/pull/53200#pullrequestreview-2085523919
View reviewed changes https://github.com/nodejs/node/pull/53200/files
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/53200/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/dygabo
dygabohttps://github.com/dygabo
May 29, 2024 14:37https://github.com/nodejs/node/pull/53200#event-12973017591
https://github.com/dygabo
dygabohttps://github.com/dygabo
May 29, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2137622245
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
May 29, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2137648245
Please reload this pagehttps://github.com/nodejs/node/pull/53200
@dygabohttps://github.com/dygabo
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/dygabo
dygabohttps://github.com/dygabo
May 29, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2137675234
@dygabohttps://github.com/dygabo
@ShogunPandahttps://github.com/ShogunPanda
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
May 29, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2137678363
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/dygabo
dygabohttps://github.com/dygabo
May 29, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2137685089
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
May 29, 2024 https://github.com/nodejs/node/pull/53200#pullrequestreview-2085765655
View reviewed changes https://github.com/nodejs/node/pull/53200/files
test/es-module/test-esm-loader-threads.mjshttps://github.com/nodejs/node/pull/53200/files#diff-8b9a40b32f417002721fbdcd322f9e3bda9f084d56e03935ee40b6ec8a4ba079
Please reload this pagehttps://github.com/nodejs/node/pull/53200
test/es-module/test-esm-loader-threads.mjshttps://github.com/nodejs/node/pull/53200/files#diff-8b9a40b32f417002721fbdcd322f9e3bda9f084d56e03935ee40b6ec8a4ba079
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
May 29, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2137710296
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
May 29, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2137731539
https://github.com/ShogunPanda/hooks-reprohttps://github.com/ShogunPanda/hooks-repro
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 29, 2024 https://github.com/nodejs/node/pull/53200#pullrequestreview-2085802732
View reviewed changes https://github.com/nodejs/node/pull/53200/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/53200#pullrequestreview-2085802732
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
May 29, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2137760365
@dygabohttps://github.com/dygabo
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
May 29, 2024 https://github.com/nodejs/node/pull/53200#pullrequestreview-2085826162
View reviewed changes https://github.com/nodejs/node/pull/53200/files
ShogunPandahttps://github.com/ShogunPanda
https://github.com/nodejs/node/pull/53200#pullrequestreview-2085826162
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/Flarna
Flarnahttps://github.com/Flarna
May 29, 2024 https://github.com/nodejs/node/pull/53200#pullrequestreview-2086046131
View reviewed changes https://github.com/nodejs/node/pull/53200/files
lib/internal/modules/esm/hooks.jshttps://github.com/nodejs/node/pull/53200/files#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d
Please reload this pagehttps://github.com/nodejs/node/pull/53200
lib/internal/modules/esm/hooks.jshttps://github.com/nodejs/node/pull/53200/files#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d
Please reload this pagehttps://github.com/nodejs/node/pull/53200
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/53200/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
Please reload this pagehttps://github.com/nodejs/node/pull/53200
src/node_worker.cchttps://github.com/nodejs/node/pull/53200/files#diff-b06b65a7f7e33816a1986d731765d732ab23f585bece6b23c5e83ca3682dba62
Flarnahttps://github.com/Flarna
May 29, 2024https://github.com/nodejs/node/pull/53200#discussion_r1619270697
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/53200
dygabohttps://github.com/dygabo
May 30, 2024https://github.com/nodejs/node/pull/53200#discussion_r1620462931
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/53200
dygabohttps://github.com/dygabo
May 31, 2024https://github.com/nodejs/node/pull/53200#discussion_r1622397455
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/53200
lib/internal/modules/esm/hooks.jshttps://github.com/nodejs/node/pull/53200/files#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d
Flarnahttps://github.com/Flarna
May 29, 2024https://github.com/nodejs/node/pull/53200#discussion_r1619274904
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/53200
mcollinahttps://github.com/mcollina
May 30, 2024https://github.com/nodejs/node/pull/53200#discussion_r1620151900
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/53200
dygabohttps://github.com/dygabo
May 30, 2024https://github.com/nodejs/node/pull/53200#discussion_r1620477476
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@ShogunPandahttps://github.com/ShogunPanda
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/Flarna
Flarnahttps://github.com/Flarna
May 29, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2137993205
herehttps://nodejs.org/docs/v22.2.0/api/module.html#communication-with-module-customization-hooks
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/aduh95
aduh95https://github.com/aduh95
May 29, 2024 https://github.com/nodejs/node/pull/53200#pullrequestreview-2086092208
View reviewed changes https://github.com/nodejs/node/pull/53200/files
lib/internal/modules/esm/hooks.jshttps://github.com/nodejs/node/pull/53200/files#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d
aduh95https://github.com/aduh95
May 29, 2024https://github.com/nodejs/node/pull/53200#discussion_r1619295309
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/53200
ShogunPandahttps://github.com/ShogunPanda
May 30, 2024https://github.com/nodejs/node/pull/53200#discussion_r1620649699
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/53200
dygabohttps://github.com/dygabo
May 30, 2024https://github.com/nodejs/node/pull/53200#discussion_r1620821419
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/53200
aduh95https://github.com/aduh95
May 30, 2024https://github.com/nodejs/node/pull/53200#discussion_r1621233389
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/53200
GeoffreyBoothhttps://github.com/GeoffreyBooth
May 30, 2024https://github.com/nodejs/node/pull/53200#discussion_r1621333948
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@aduh95https://github.com/aduh95
Please reload this pagehttps://github.com/nodejs/node/pull/53200
dygabohttps://github.com/dygabo
May 31, 2024https://github.com/nodejs/node/pull/53200#discussion_r1622395354
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/Flarna
Flarnahttps://github.com/Flarna
May 29, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2138000219
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/Flarna
Flarnahttps://github.com/Flarna
May 29, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2138019965
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/dygabo
dygabohttps://github.com/dygabo
May 29, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2138081712
Please reload this pagehttps://github.com/nodejs/node/pull/53200
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
May 29, 2024 https://github.com/nodejs/node/pull/53200#ref-pullrequest-2320537486
Revert "module: have a single hooks thread for all workers" #53183 https://github.com/nodejs/node/pull/53183
https://github.com/dygabo
dygabohttps://github.com/dygabo
May 30, 2024 00:17https://github.com/nodejs/node/pull/53200#event-12978464882
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 30, 2024 https://github.com/nodejs/node/pull/53200#pullrequestreview-2087866948
View reviewed changes https://github.com/nodejs/node/pull/53200/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/53200#pullrequestreview-2087866948
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#53195https://github.com/nodejs/node/issues/53195
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
Jun 4, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2146655636
@GeoffreyBoothhttps://github.com/GeoffreyBooth
#53183https://github.com/nodejs/node/pull/53183
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/dygabo
dygabohttps://github.com/dygabo
Jun 4, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2146657871
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/dygabo
dygabohttps://github.com/dygabo
force-pushedhttps://github.com/nodejs/node/compare/14d3115f29bacf3a0c84c8b1a452ec02f7e4bb00..f7cf9b6f30a2c15fe8367b1911548bf78818e5e9
14d3115https://github.com/nodejs/node/commit/14d3115f29bacf3a0c84c8b1a452ec02f7e4bb00
f7cf9b6https://github.com/nodejs/node/commit/f7cf9b6f30a2c15fe8367b1911548bf78818e5e9
Compare https://github.com/nodejs/node/compare/14d3115f29bacf3a0c84c8b1a452ec02f7e4bb00..f7cf9b6f30a2c15fe8367b1911548bf78818e5e9
June 4, 2024 07:21https://github.com/nodejs/node/pull/53200#event-13031350423
dygabohttps://github.com/dygabo
June 4, 2024 09:26https://github.com/nodejs/node/pull/53200#commits-pushed-da93a14
https://github.com/dygabo
module: have a single hooks thread for all workershttps://github.com/nodejs/node/pull/53200/commits/da93a14cb6ed913e9ed621451c731a3cc4484239
da93a14https://github.com/nodejs/node/pull/53200/commits/da93a14cb6ed913e9ed621451c731a3cc4484239
https://github.com/dygabo
module: allow module.register from workershttps://github.com/nodejs/node/pull/53200/commits/fd5ffdfcb97c3366f7c55f9764dea08fbbed4200
fd5ffdfhttps://github.com/nodejs/node/pull/53200/commits/fd5ffdfcb97c3366f7c55f9764dea08fbbed4200
https://github.com/dygabo
reenable tests on workershttps://github.com/nodejs/node/pull/53200/commits/f715679bb46bef590bf0ea223f60c9c134e2628a
f715679https://github.com/nodejs/node/pull/53200/commits/f715679bb46bef590bf0ea223f60c9c134e2628a
https://github.com/dygabo
fix unfinished renamehttps://github.com/nodejs/node/pull/53200/commits/34bc39847aec7c35dad3732514dada95bfd17b0c
34bc398https://github.com/nodejs/node/pull/53200/commits/34bc39847aec7c35dad3732514dada95bfd17b0c
https://github.com/dygabo
fixup! reenable tests on workershttps://github.com/nodejs/node/pull/53200/commits/a33afea0baec61b3e14a81996e41c71522eab5d1
a33afeahttps://github.com/nodejs/node/pull/53200/commits/a33afea0baec61b3e14a81996e41c71522eab5d1
https://github.com/dygabo
fixup! module: allow module.register from workershttps://github.com/nodejs/node/pull/53200/commits/332a22dd63d08bb4dc68b0e21e3ca96e004120c0
332a22dhttps://github.com/nodejs/node/pull/53200/commits/332a22dd63d08bb4dc68b0e21e3ca96e004120c0
https://github.com/dygabo
remove debugging output codehttps://github.com/nodejs/node/pull/53200/commits/c6213949b16b1f7de3337d7886fb1a052b6cc651
c621394https://github.com/nodejs/node/pull/53200/commits/c6213949b16b1f7de3337d7886fb1a052b6cc651
https://github.com/dygabo
linthttps://github.com/nodejs/node/pull/53200/commits/89b8d6be0b71d90b48afc2c34e00babd9b382148
89b8d6bhttps://github.com/nodejs/node/pull/53200/commits/89b8d6be0b71d90b48afc2c34e00babd9b382148
https://github.com/dygabo
https://github.com/GeoffreyBooth
Apply suggestions from code reviewhttps://github.com/nodejs/node/pull/53200/commits/8fe957eb08010abc2b76ff2d78d1ca6c94b835cb
8fe957ehttps://github.com/nodejs/node/pull/53200/commits/8fe957eb08010abc2b76ff2d78d1ca6c94b835cb
https://github.com/dygabo
make worker instantiation thread safe + some other review findingshttps://github.com/nodejs/node/pull/53200/commits/75dc437628ac80f8447d8f742fa1f0704d198fab
75dc437https://github.com/nodejs/node/pull/53200/commits/75dc437628ac80f8447d8f742fa1f0704d198fab
https://github.com/dygabo
ongoing work for hook ownershiphttps://github.com/nodejs/node/pull/53200/commits/f94be0a13987b53e973e76e12030ba4f6921c32c
f94be0ahttps://github.com/nodejs/node/pull/53200/commits/f94be0a13987b53e973e76e12030ba4f6921c32c
https://github.com/dygabo
rename tohttps://github.com/nodejs/node/pull/53200/commits/d9169d48eb84afe50ae086973210e3c12fb61460
d9169d4https://github.com/nodejs/node/pull/53200/commits/d9169d48eb84afe50ae086973210e3c12fb61460
https://github.com/dygabo
dygabohttps://github.com/dygabo
force-pushedhttps://github.com/nodejs/node/compare/f7cf9b6f30a2c15fe8367b1911548bf78818e5e9..d9169d48eb84afe50ae086973210e3c12fb61460
f7cf9b6https://github.com/nodejs/node/commit/f7cf9b6f30a2c15fe8367b1911548bf78818e5e9
d9169d4https://github.com/nodejs/node/commit/d9169d48eb84afe50ae086973210e3c12fb61460
Compare https://github.com/nodejs/node/compare/f7cf9b6f30a2c15fe8367b1911548bf78818e5e9..d9169d48eb84afe50ae086973210e3c12fb61460
June 4, 2024 07:27https://github.com/nodejs/node/pull/53200#event-13031453209
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
Jun 4, 2024 https://github.com/nodejs/node/pull/53200#ref-pullrequest-2333485203
module: allow multiple chain #53332 https://github.com/nodejs/node/pull/53332
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
Jun 4, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2147517520
#53332https://github.com/nodejs/node/pull/53332
@dygabohttps://github.com/dygabo
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jun 10, 2024 https://github.com/nodejs/node/pull/53200#ref-issue-2343734591
Node.js Technical Steering Committee (TSC) Meeting 2024-06-12 nodejs/TSC#1575 https://github.com/nodejs/TSC/issues/1575
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
tsc-agenda https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-agenda
Jun 10, 2024https://github.com/nodejs/node/pull/53200#event-13108229153
https://github.com/dygabo
dygabohttps://github.com/dygabo
Jun 13, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2166134297
@ShogunPandahttps://github.com/ShogunPanda
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Jun 13, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2166172674
@dygabohttps://github.com/dygabo
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
Jun 13, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2166529972
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/dygabo
dygabohttps://github.com/dygabo
Jun 14, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2167334695
Please reload this pagehttps://github.com/nodejs/node/pull/53200
@ShogunPandahttps://github.com/ShogunPanda
herehttps://github.com/nodejs/node/blob/main/src/node_worker.cc#L683
in libuvhttps://github.com/libuv/libuv/blob/v1.x/src/unix/thread.c#L172
Worker::Newhttps://github.com/dygabo/node/blob/allow-hooks-thread-from-worker/src/node_worker.cc#L488
herehttps://github.com/dygabo/node/blob/allow-hooks-thread-from-worker/lib/internal/worker.js#L214
herehttps://github.com/dygabo/node/blob/allow-hooks-thread-from-worker/lib/internal/modules/esm/hooks.js#L530
herehttps://github.com/dygabo/node/blob/allow-hooks-thread-from-worker/lib/internal/modules/esm/hooks.js#L530
@ShogunPandahttps://github.com/ShogunPanda
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
Jun 17, 2024https://github.com/nodejs/node/pull/53200#issuecomment-2173378756
@dygabohttps://github.com/dygabo
#53488https://github.com/nodejs/node/pull/53488
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/dygabo
dygabohttps://github.com/dygabo
Jun 17, 2024 https://github.com/nodejs/node/pull/53200#ref-pullrequest-2357330800
worker: add connect and setConnectionsListener #53488 https://github.com/nodejs/node/pull/53488
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Jun 17, 2024 https://github.com/nodejs/node/pull/53200#ref-issue-2358063497
Hooks thread direction nodejs/loaders#201 https://github.com/nodejs/loaders/issues/201
https://github.com/dygabo
dygabohttps://github.com/dygabo
Dec 3, 2025https://github.com/nodejs/node/pull/53200#issuecomment-3606669740
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/dygabo
dygabohttps://github.com/dygabo
Dec 3, 2025https://github.com/nodejs/node/pull/53200#event-21331870119
https://github.com/sshiza-490
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53200
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53200
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/53200/files/14d3115f29bacf3a0c84c8b1a452ec02f7e4bb00
https://github.com/ShogunPanda
ShogunPanda https://github.com/ShogunPanda
https://github.com/nodejs/node/pull/53200/files/14d3115f29bacf3a0c84c8b1a452ec02f7e4bb00
https://github.com/GeoffreyBooth
GeoffreyBooth https://github.com/GeoffreyBooth
https://github.com/nodejs/node/pull/53200/files/14d3115f29bacf3a0c84c8b1a452ec02f7e4bb00
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/53200/files/8aaa68e7e3fdf54a70c63caa545fa2f87cb90a88
https://github.com/Flarna
Flarna https://github.com/Flarna
https://github.com/nodejs/node/pull/53200/files/8aaa68e7e3fdf54a70c63caa545fa2f87cb90a88
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/53200
https://github.com/dygabo
https://github.com/nodejs-github-bot
https://github.com/ShogunPanda
https://github.com/GeoffreyBooth
https://github.com/Flarna
https://github.com/alan-agius4
https://github.com/mcollina
https://github.com/jasnell
https://github.com/sshiza-490
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.