René's URL Explorer Experiment


Title: build: fix building embedtest in GN build by zcbenz · Pull Request #53145 · nodejs/node · GitHub

Open Graph Title: build: fix building embedtest in GN build by zcbenz · Pull Request #53145 · nodejs/node

X Title: build: fix building embedtest in GN build by zcbenz · Pull Request #53145 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Update the GN build config of embedtest to match the change in #52646.

X Description: Update the GN build config of embedtest to match the change in #52646.

Opengraph URL: https://github.com/nodejs/node/pull/53145

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a5948f02-92d5-d46f-e8f8-0e3824c5fe6c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF98:2E51E:99612F:D8F83C:6A4E7C88
html-safe-nonce13a51c76a84881c631e4903017111a0a4e61ee577fcd5ee3a97d11dd3cbc348e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjk4OjJFNTFFOjk5NjEyRjpEOEY4M0M6NkE0RTdDODgiLCJ2aXNpdG9yX2lkIjoiNTkzNzEzMTkxMDM4Mzg1Mjg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacde6c56e270cf6e41d825bd2745b9cb70dc5850a7a5a9dfa06078665e4418155a
hovercard-subject-tagpull_request:1888126429
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/53145/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c4ca2a5321cb5f2d4acfcedbf200afa21608c560263492fc129209107cddc6d8/nodejs/node/pull/53145
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c4ca2a5321cb5f2d4acfcedbf200afa21608c560263492fc129209107cddc6d8/nodejs/node/pull/53145
og:image:altUpdate the GN build config of embedtest to match the change in #52646.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezcbenz
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/53145#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53145
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53145
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/53145
Reloadhttps://github.com/nodejs/node/pull/53145
Reloadhttps://github.com/nodejs/node/pull/53145
Please reload this pagehttps://github.com/nodejs/node/pull/53145
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/53145
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
zcbenzhttps://github.com/zcbenz
nodejs:mainhttps://github.com/nodejs/node/tree/main
zcbenz:gn-embedtesthttps://github.com/zcbenz/node/tree/gn-embedtest
Conversationhttps://github.com/nodejs/node/pull/53145
Commits1 (1)https://github.com/nodejs/node/pull/53145/commits
Checkshttps://github.com/nodejs/node/pull/53145/checks
Files changedhttps://github.com/nodejs/node/pull/53145/files
build: fix building embedtest in GN buildhttps://github.com/nodejs/node/pull/53145#top
zcbenzhttps://github.com/zcbenz
nodejs:mainhttps://github.com/nodejs/node/tree/main
zcbenz:gn-embedtesthttps://github.com/zcbenz/node/tree/gn-embedtest
https://github.com/zcbenz
zcbenzhttps://github.com/zcbenz
May 25, 2024https://github.com/nodejs/node/pull/53145#issue-2316801627
#52646https://github.com/nodejs/node/pull/52646
Please reload this pagehttps://github.com/nodejs/node/pull/53145
https://github.com/zcbenz
zcbenzhttps://github.com/zcbenz
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 25, 2024https://github.com/nodejs/node/pull/53145#event-12932424539
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 25, 2024https://github.com/nodejs/node/pull/53145#event-12932479379
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 25, 2024https://github.com/nodejs/node/pull/53145#issuecomment-2131220640
https://ci.nodejs.org/job/node-test-pull-request/59398/https://ci.nodejs.org/job/node-test-pull-request/59398/
Please reload this pagehttps://github.com/nodejs/node/pull/53145
https://github.com/targos
targoshttps://github.com/targos
May 25, 2024 https://github.com/nodejs/node/pull/53145#pullrequestreview-2079030229
View reviewed changes https://github.com/nodejs/node/pull/53145/files/bb94e153c9f22b446e26604bf1b8736a845e90b0
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 25, 2024 https://github.com/nodejs/node/pull/53145#pullrequestreview-2079101104
View reviewed changes https://github.com/nodejs/node/pull/53145/files/bb94e153c9f22b446e26604bf1b8736a845e90b0
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 25, 2024https://github.com/nodejs/node/pull/53145#issuecomment-2131386206
https://ci.nodejs.org/job/node-test-pull-request/59403/https://ci.nodejs.org/job/node-test-pull-request/59403/
Please reload this pagehttps://github.com/nodejs/node/pull/53145
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 27, 2024https://github.com/nodejs/node/pull/53145#issuecomment-2132446898
https://ci.nodejs.org/job/node-test-pull-request/59432/https://ci.nodejs.org/job/node-test-pull-request/59432/
Please reload this pagehttps://github.com/nodejs/node/pull/53145
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 27, 2024https://github.com/nodejs/node/pull/53145#issuecomment-2134147108
https://ci.nodejs.org/job/node-test-pull-request/59468/https://ci.nodejs.org/job/node-test-pull-request/59468/
Please reload this pagehttps://github.com/nodejs/node/pull/53145
https://github.com/zcbenz
build: fix building embedtest in GN buildhttps://github.com/nodejs/node/pull/53145/commits/bb94e153c9f22b446e26604bf1b8736a845e90b0
bb94e15https://github.com/nodejs/node/pull/53145/commits/bb94e153c9f22b446e26604bf1b8736a845e90b0
https://github.com/zcbenz
zcbenzhttps://github.com/zcbenz
force-pushedhttps://github.com/nodejs/node/compare/ca42a58e1d080fae837dce2f6eec6cdfa145ebaf..bb94e153c9f22b446e26604bf1b8736a845e90b0
ca42a58https://github.com/nodejs/node/commit/ca42a58e1d080fae837dce2f6eec6cdfa145ebaf
bb94e15https://github.com/nodejs/node/commit/bb94e153c9f22b446e26604bf1b8736a845e90b0
Compare https://github.com/nodejs/node/compare/ca42a58e1d080fae837dce2f6eec6cdfa145ebaf..bb94e153c9f22b446e26604bf1b8736a845e90b0
May 28, 2024 00:41https://github.com/nodejs/node/pull/53145#event-12950450983
https://github.com/zcbenz
zcbenzhttps://github.com/zcbenz
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 28, 2024https://github.com/nodejs/node/pull/53145#event-12950451734
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 28, 2024https://github.com/nodejs/node/pull/53145#event-12950477147
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 28, 2024https://github.com/nodejs/node/pull/53145#issuecomment-2134181233
https://ci.nodejs.org/job/node-test-pull-request/59470/https://ci.nodejs.org/job/node-test-pull-request/59470/
Please reload this pagehttps://github.com/nodejs/node/pull/53145
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 28, 2024https://github.com/nodejs/node/pull/53145#issuecomment-2134295119
https://ci.nodejs.org/job/node-test-pull-request/59473/https://ci.nodejs.org/job/node-test-pull-request/59473/
Please reload this pagehttps://github.com/nodejs/node/pull/53145
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 28, 2024https://github.com/nodejs/node/pull/53145#issuecomment-2134352976
https://ci.nodejs.org/job/node-test-pull-request/59474/https://ci.nodejs.org/job/node-test-pull-request/59474/
Please reload this pagehttps://github.com/nodejs/node/pull/53145
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 28, 2024https://github.com/nodejs/node/pull/53145#issuecomment-2134452667
https://ci.nodejs.org/job/node-test-pull-request/59476/https://ci.nodejs.org/job/node-test-pull-request/59476/
Please reload this pagehttps://github.com/nodejs/node/pull/53145
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 28, 2024https://github.com/nodejs/node/pull/53145#issuecomment-2134586720
https://ci.nodejs.org/job/node-test-pull-request/59478/https://ci.nodejs.org/job/node-test-pull-request/59478/
Please reload this pagehttps://github.com/nodejs/node/pull/53145
zcbenzhttps://github.com/zcbenz
May 28, 2024 https://github.com/nodejs/node/pull/53145#ref-commit-067ab06
https://github.com/zcbenz
build: fix building embedtest in GN buildhttps://github.com/nodejs/node/commit/067ab06f21e901dce5cd5ec36c4aae80abcb11bd
067ab06https://github.com/nodejs/node/commit/067ab06f21e901dce5cd5ec36c4aae80abcb11bd
#53145https://github.com/nodejs/node/pull/53145
https://github.com/zcbenz
zcbenzhttps://github.com/zcbenz
May 28, 2024https://github.com/nodejs/node/pull/53145#issuecomment-2134868933
067ab06https://github.com/nodejs/node/commit/067ab06f21e901dce5cd5ec36c4aae80abcb11bd
Please reload this pagehttps://github.com/nodejs/node/pull/53145
https://github.com/zcbenz
zcbenzhttps://github.com/zcbenz
May 28, 2024https://github.com/nodejs/node/pull/53145#event-12955304388
https://github.com/zcbenz
zcbenzhttps://github.com/zcbenz
May 28, 2024 10:24https://github.com/nodejs/node/pull/53145#event-12955305534
targoshttps://github.com/targos
Jun 1, 2024 https://github.com/nodejs/node/pull/53145#ref-commit-edcadf7
https://github.com/zcbenz
https://github.com/targos
build: fix building embedtest in GN buildhttps://github.com/nodejs/node/commit/edcadf7f8a55602019837cda49ac7e54cbfbf116
edcadf7https://github.com/nodejs/node/commit/edcadf7f8a55602019837cda49ac7e54cbfbf116
#53145https://github.com/nodejs/node/pull/53145
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Jun 7, 2024 https://github.com/nodejs/node/pull/53145#ref-pullrequest-2340516626
v22.3.0 proposal #53379 https://github.com/nodejs/node/pull/53379
soophoohttps://github.com/soophoo
Jun 20, 2024 https://github.com/nodejs/node/pull/53145#ref-commit-2fef207
https://github.com/zcbenz
https://github.com/soophoo
build: fix building embedtest in GN buildhttps://github.com/soophoo/node/commit/2fef20795b113aecccabac029497b87ccecd30b5
2fef207https://github.com/soophoo/node/commit/2fef20795b113aecccabac029497b87ccecd30b5
nodejs#53145https://github.com/nodejs/node/pull/53145
bmeckhttps://github.com/bmeck
Jun 22, 2024 https://github.com/nodejs/node/pull/53145#ref-commit-8427a2f
https://github.com/zcbenz
https://github.com/bmeck
build: fix building embedtest in GN buildhttps://github.com/bmeck/node/commit/8427a2f32d6bebf979ce17ba59f6cad29998b785
8427a2fhttps://github.com/bmeck/node/commit/8427a2f32d6bebf979ce17ba59f6cad29998b785
nodejs#53145https://github.com/nodejs/node/pull/53145
marco-ippolitohttps://github.com/marco-ippolito
Jul 19, 2024 https://github.com/nodejs/node/pull/53145#ref-commit-608d3de
https://github.com/zcbenz
https://github.com/marco-ippolito
build: fix building embedtest in GN buildhttps://github.com/nodejs/node/commit/608d3de04d990dcf5c19909f50d5218b8fcbbc1a
608d3dehttps://github.com/nodejs/node/commit/608d3de04d990dcf5c19909f50d5218b8fcbbc1a
#53145https://github.com/nodejs/node/pull/53145
marco-ippolitohttps://github.com/marco-ippolito
Jul 19, 2024 https://github.com/nodejs/node/pull/53145#ref-commit-bb06778
https://github.com/zcbenz
https://github.com/marco-ippolito
build: fix building embedtest in GN buildhttps://github.com/nodejs/node/commit/bb06778a654ee979f36750751a5c1bf42f0bf94b
bb06778https://github.com/nodejs/node/commit/bb06778a654ee979f36750751a5c1bf42f0bf94b
#53145https://github.com/nodejs/node/pull/53145
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
Jul 19, 2024 https://github.com/nodejs/node/pull/53145#ref-pullrequest-2418939282
v20.16.0 proposal #53945 https://github.com/nodejs/node/pull/53945
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53145
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/53145/files/bb94e153c9f22b446e26604bf1b8736a845e90b0
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/53145/files/bb94e153c9f22b446e26604bf1b8736a845e90b0
Please reload this pagehttps://github.com/nodejs/node/pull/53145
https://github.com/zcbenz
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.