René's URL Explorer Experiment


Title: [v20.x] Revert "Revert "stream: fix cloned webstreams not being unref'd"" by marco-ippolito · Pull Request #53144 · nodejs/node · GitHub

Open Graph Title: [v20.x] Revert "Revert "stream: fix cloned webstreams not being unref'd"" by marco-ippolito · Pull Request #53144 · nodejs/node

X Title: [v20.x] Revert "Revert "stream: fix cloned webstreams not being unref'd"" by marco-ippolito · Pull Request #53144 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This reverts commit 8d20b64. Fixes: #53143

X Description: This reverts commit 8d20b64. Fixes: #53143

Opengraph URL: https://github.com/nodejs/node/pull/53144

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.113.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4dfe2cf8-02e4-d016-498d-b7bb86da4e23
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id820A:90894:117B534:16490D0:6B035247
html-safe-noncea203798f310a7a906424094ae36ca7e15f9d67ab5c28643555f1148029c33277
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjBBOjkwODk0OjExN0I1MzQ6MTY0OTBEMDo2QjAzNTI0NyIsInZpc2l0b3JfaWQiOiIzMjMzMzQ5MzExNzczNDk1ODc5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9a2e8c6b4fa226765a3cfb5430d9617e1c143e94facec839952d439d32d525b2
hovercard-subject-tagpull_request:1888078396
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/53144/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/99c586c1577298a4e76a161e2bc2ddf4b5fee947c97f618a2ed07484425cce3e/nodejs/node/pull/53144
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/99c586c1577298a4e76a161e2bc2ddf4b5fee947c97f618a2ed07484425cce3e/nodejs/node/pull/53144
og:image:altThis reverts commit 8d20b64. Fixes: #53143
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemarco-ippolito
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/53144#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53144
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53144
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/53144
Reloadhttps://github.com/nodejs/node/pull/53144
Reloadhttps://github.com/nodejs/node/pull/53144
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
marco-ippolitohttps://github.com/marco-ippolito
nodejs:v20.x-staginghttps://github.com/nodejs/node/tree/v20.x-staging
marco-ippolito:feat/fix-revert-reverthttps://github.com/marco-ippolito/node/tree/feat/fix-revert-revert
Conversationhttps://github.com/nodejs/node/pull/53144
Commits1 (1)https://github.com/nodejs/node/pull/53144/commits
Checkshttps://github.com/nodejs/node/pull/53144/checks
Files changedhttps://github.com/nodejs/node/pull/53144/files
[v20.x] Revert "Revert "stream: fix cloned webstreams not being unref'd""https://github.com/nodejs/node/pull/53144#top
marco-ippolitohttps://github.com/marco-ippolito
nodejs:v20.x-staginghttps://github.com/nodejs/node/tree/v20.x-staging
marco-ippolito:feat/fix-revert-reverthttps://github.com/marco-ippolito/node/tree/feat/fix-revert-revert
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
May 25, 2024https://github.com/nodejs/node/pull/53144#issue-2316746801
8d20b64https://github.com/nodejs/node/commit/8d20b641a2ff79df804f6a0c21f2c9a0bdfe6f4a
#53143https://github.com/nodejs/node/issues/53143
Please reload this pagehttps://github.com/nodejs/node/pull/53144
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av20.x
web streams https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22web%20streams%22
May 25, 2024https://github.com/nodejs/node/pull/53144#event-12931450944
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
May 25, 2024 https://github.com/nodejs/node/pull/53144#ref-issue-2316173314
possible mistaken commit in v20.x branch webstreams #53143 https://github.com/nodejs/node/issues/53143
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
May 25, 2024https://github.com/nodejs/node/pull/53144#issuecomment-2130859563
Please reload this pagehttps://github.com/nodejs/node/pull/53144
Please reload this pagehttps://github.com/nodejs/node/pull/53144
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
force-pushedhttps://github.com/nodejs/node/compare/715d3b56a042c926b9b386d3bffcf23f3ca22234..0600cf16568a8fc86bc3c3bf983cecce4631e1af
715d3b5https://github.com/nodejs/node/commit/715d3b56a042c926b9b386d3bffcf23f3ca22234
0600cf1https://github.com/nodejs/node/commit/0600cf16568a8fc86bc3c3bf983cecce4631e1af
Compare https://github.com/nodejs/node/compare/715d3b56a042c926b9b386d3bffcf23f3ca22234..0600cf16568a8fc86bc3c3bf983cecce4631e1af
May 25, 2024 06:12https://github.com/nodejs/node/pull/53144#event-12931464294
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
May 25, 2024https://github.com/nodejs/node/pull/53144#event-12931473895
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
May 25, 2024https://github.com/nodejs/node/pull/53144#event-12931474080
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 25, 2024https://github.com/nodejs/node/pull/53144#event-12931761510
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 25, 2024https://github.com/nodejs/node/pull/53144#event-12931818039
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 25, 2024https://github.com/nodejs/node/pull/53144#issuecomment-2131121720
https://ci.nodejs.org/job/node-test-pull-request/59394/https://ci.nodejs.org/job/node-test-pull-request/59394/
Please reload this pagehttps://github.com/nodejs/node/pull/53144
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 25, 2024https://github.com/nodejs/node/pull/53144#issuecomment-2131217152
https://ci.nodejs.org/job/node-test-pull-request/59397/https://ci.nodejs.org/job/node-test-pull-request/59397/
Please reload this pagehttps://github.com/nodejs/node/pull/53144
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 25, 2024https://github.com/nodejs/node/pull/53144#issuecomment-2131288233
https://ci.nodejs.org/job/node-test-pull-request/59400/https://ci.nodejs.org/job/node-test-pull-request/59400/
Please reload this pagehttps://github.com/nodejs/node/pull/53144
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 25, 2024https://github.com/nodejs/node/pull/53144#issuecomment-2131371867
https://ci.nodejs.org/job/node-test-pull-request/59401/https://ci.nodejs.org/job/node-test-pull-request/59401/
Please reload this pagehttps://github.com/nodejs/node/pull/53144
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 26, 2024https://github.com/nodejs/node/pull/53144#issuecomment-2132074206
https://ci.nodejs.org/job/node-test-pull-request/59415/https://ci.nodejs.org/job/node-test-pull-request/59415/
Please reload this pagehttps://github.com/nodejs/node/pull/53144
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 26, 2024https://github.com/nodejs/node/pull/53144#issuecomment-2132120238
https://ci.nodejs.org/job/node-test-pull-request/59422/https://ci.nodejs.org/job/node-test-pull-request/59422/
Please reload this pagehttps://github.com/nodejs/node/pull/53144
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 26, 2024https://github.com/nodejs/node/pull/53144#issuecomment-2132279109
https://ci.nodejs.org/job/node-test-pull-request/59428/https://ci.nodejs.org/job/node-test-pull-request/59428/
Please reload this pagehttps://github.com/nodejs/node/pull/53144
https://github.com/marco-ippolito
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53144
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 27, 2024https://github.com/nodejs/node/pull/53144#issuecomment-2132902091
https://ci.nodejs.org/job/node-test-pull-request/59439/https://ci.nodejs.org/job/node-test-pull-request/59439/
Please reload this pagehttps://github.com/nodejs/node/pull/53144
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
force-pushedhttps://github.com/nodejs/node/compare/07c45ba389a916569758e89cec8c7744fd24a1c8..e6d9fbece21b225b63700f2263bc2bacac2ca222
07c45bahttps://github.com/nodejs/node/commit/07c45ba389a916569758e89cec8c7744fd24a1c8
e6d9fbehttps://github.com/nodejs/node/commit/e6d9fbece21b225b63700f2263bc2bacac2ca222
Compare https://github.com/nodejs/node/compare/07c45ba389a916569758e89cec8c7744fd24a1c8..e6d9fbece21b225b63700f2263bc2bacac2ca222
May 27, 2024 11:53https://github.com/nodejs/node/pull/53144#event-12944974262
https://github.com/marco-ippolito
Revert "stream: revert fix cloned webstreams not being unref'd"https://github.com/nodejs/node/pull/53144/commits/beedf90dbd0db650e89e72f9dc743eafaf6df7ff
beedf90https://github.com/nodejs/node/pull/53144/commits/beedf90dbd0db650e89e72f9dc743eafaf6df7ff
8d20b64https://github.com/marco-ippolito/node/commit/8d20b641a2ff79df804f6a0c21f2c9a0bdfe6f4a
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
force-pushedhttps://github.com/nodejs/node/compare/0600cf16568a8fc86bc3c3bf983cecce4631e1af..beedf90dbd0db650e89e72f9dc743eafaf6df7ff
0600cf1https://github.com/nodejs/node/commit/0600cf16568a8fc86bc3c3bf983cecce4631e1af
beedf90https://github.com/nodejs/node/commit/beedf90dbd0db650e89e72f9dc743eafaf6df7ff
Compare https://github.com/nodejs/node/compare/0600cf16568a8fc86bc3c3bf983cecce4631e1af..beedf90dbd0db650e89e72f9dc743eafaf6df7ff
May 27, 2024 11:54https://github.com/nodejs/node/pull/53144#event-12944979750
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
May 27, 2024 https://github.com/nodejs/node/pull/53144#ref-pullrequest-2313288054
v20.14.0 proposal #53120 https://github.com/nodejs/node/pull/53120
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 27, 2024https://github.com/nodejs/node/pull/53144#event-12945234985
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 27, 2024https://github.com/nodejs/node/pull/53144#event-12945377976
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 27, 2024https://github.com/nodejs/node/pull/53144#issuecomment-2133380051
https://ci.nodejs.org/job/node-test-pull-request/59448/https://ci.nodejs.org/job/node-test-pull-request/59448/
Please reload this pagehttps://github.com/nodejs/node/pull/53144
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 27, 2024https://github.com/nodejs/node/pull/53144#issuecomment-2133847221
https://ci.nodejs.org/job/node-test-pull-request/59457/https://ci.nodejs.org/job/node-test-pull-request/59457/
Please reload this pagehttps://github.com/nodejs/node/pull/53144
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
jasnellhttps://github.com/jasnell
mcollinahttps://github.com/mcollina
May 27, 2024 20:05https://github.com/nodejs/node/pull/53144#event-12949301445
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 27, 2024 https://github.com/nodejs/node/pull/53144#pullrequestreview-2081429587
View reviewed changes https://github.com/nodejs/node/pull/53144/files/beedf90dbd0db650e89e72f9dc743eafaf6df7ff
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/53144#pullrequestreview-2081429587
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/53144
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
May 27, 2024 https://github.com/nodejs/node/pull/53144#pullrequestreview-2081432120
View reviewed changes https://github.com/nodejs/node/pull/53144/files/beedf90dbd0db650e89e72f9dc743eafaf6df7ff
marco-ippolitohttps://github.com/marco-ippolito
May 27, 2024 https://github.com/nodejs/node/pull/53144#ref-commit-cffd2cc
https://github.com/marco-ippolito
Revert "stream: revert fix cloned webstreams not being unref'd"https://github.com/nodejs/node/commit/cffd2cc0c9ed7fbdb335d576c660316176511f4e
cffd2cchttps://github.com/nodejs/node/commit/cffd2cc0c9ed7fbdb335d576c660316176511f4e
8d20b64https://github.com/nodejs/node/commit/8d20b641a2ff79df804f6a0c21f2c9a0bdfe6f4a
#53144https://github.com/nodejs/node/pull/53144
#53143https://github.com/nodejs/node/issues/53143
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
May 27, 2024https://github.com/nodejs/node/pull/53144#issuecomment-2134014376
cffd2cchttps://github.com/nodejs/node/commit/cffd2cc0c9ed7fbdb335d576c660316176511f4e
Please reload this pagehttps://github.com/nodejs/node/pull/53144
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
May 27, 2024https://github.com/nodejs/node/pull/53144#event-12949393000
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53144
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/53144/files/beedf90dbd0db650e89e72f9dc743eafaf6df7ff
https://github.com/RafaelGSS
RafaelGSS https://github.com/RafaelGSS
https://github.com/nodejs/node/pull/53144/files/beedf90dbd0db650e89e72f9dc743eafaf6df7ff
https://github.com/jasnell
jasnell https://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/53144
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
web streams https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22web%20streams%22
Please reload this pagehttps://github.com/nodejs/node/pull/53144
https://github.com/marco-ippolito
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/RafaelGSS
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.