René's URL Explorer Experiment


Title: [v20.x backport] test_runner: ignore todo flag when running suites by atlowChemi · Pull Request #53093 · nodejs/node · GitHub

Open Graph Title: [v20.x backport] test_runner: ignore todo flag when running suites by atlowChemi · Pull Request #53093 · nodejs/node

X Title: [v20.x backport] test_runner: ignore todo flag when running suites by atlowChemi · Pull Request #53093 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit removes a check for the todo flag when determining if a suite should run. In general, the todo flag should have no impact on whether or not a test/suite runs. Instead, it should only im...

X Description: This commit removes a check for the todo flag when determining if a suite should run. In general, the todo flag should have no impact on whether or not a test/suite runs. Instead, it should only im...

Mail addresses
chemi@atlow.co.il
moshe@atlow.co.il

Opengraph URL: https://github.com/nodejs/node/pull/53093

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:de46ca52-fcfb-47bc-6630-6745cd95a6b1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id86A4:32A57E:3064A6:3D6F70:6B035485
html-safe-nonce2f36f667f3d082a7bb1d4510febe6c24c7d4548aeb064fddb22ad91def534dfb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkE0OjMyQTU3RTozMDY0QTY6M0Q2RjcwOjZCMDM1NDg1IiwidmlzaXRvcl9pZCI6IjUyNzcyOTQzNDIwODI2MTQ0MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6ac1750f96eed202b658edcb0f6fa10763a8e3f72bcb6903815e04b9712c0029
hovercard-subject-tagpull_request:1881629081
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/53093/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/073fd463e41f993c2b4d73d93e7a68823fdab5c139cd619adb7842cbc6dabc06/nodejs/node/pull/53093
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/073fd463e41f993c2b4d73d93e7a68823fdab5c139cd619adb7842cbc6dabc06/nodejs/node/pull/53093
og:image:altThis commit removes a check for the todo flag when determining if a suite should run. In general, the todo flag should have no impact on whether or not a test/suite runs. Instead, it should only im...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameatlowChemi
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/53093#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53093
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53093
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/53093
Reloadhttps://github.com/nodejs/node/pull/53093
Reloadhttps://github.com/nodejs/node/pull/53093
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
atlowChemihttps://github.com/atlowChemi
nodejs:v20.x-staginghttps://github.com/nodejs/node/tree/v20.x-staging
atlowChemi:test-runner-v20-backportshttps://github.com/atlowChemi/node/tree/test-runner-v20-backports
Conversationhttps://github.com/nodejs/node/pull/53093
Commits1 (1)https://github.com/nodejs/node/pull/53093/commits
Checkshttps://github.com/nodejs/node/pull/53093/checks
Files changedhttps://github.com/nodejs/node/pull/53093/files
[v20.x backport] test_runner: ignore todo flag when running suiteshttps://github.com/nodejs/node/pull/53093#top
atlowChemihttps://github.com/atlowChemi
nodejs:v20.x-staginghttps://github.com/nodejs/node/tree/v20.x-staging
atlowChemi:test-runner-v20-backportshttps://github.com/atlowChemi/node/tree/test-runner-v20-backports
https://github.com/atlowChemi
atlowChemihttps://github.com/atlowChemi
May 22, 2024https://github.com/nodejs/node/pull/53093#issue-2309610968
#52117https://github.com/nodejs/node/pull/52117
Please reload this pagehttps://github.com/nodejs/node/pull/53093
https://github.com/cjihrig
https://github.com/atlowChemi
test_runner: ignore todo flag when running suiteshttps://github.com/nodejs/node/pull/53093/commits/a547c423fb575360760500977a88c5a4c9b671ba
a547c42https://github.com/nodejs/node/pull/53093/commits/a547c423fb575360760500977a88c5a4c9b671ba
nodejs#52117https://github.com/nodejs/node/pull/52117
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 22, 2024https://github.com/nodejs/node/pull/53093#issuecomment-2123901489
Please reload this pagehttps://github.com/nodejs/node/pull/53093
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av20.x
May 22, 2024https://github.com/nodejs/node/pull/53093#event-12888500699
https://github.com/MoLow
MoLowhttps://github.com/MoLow
May 22, 2024 https://github.com/nodejs/node/pull/53093#pullrequestreview-2070537508
View reviewed changes https://github.com/nodejs/node/pull/53093/files/a547c423fb575360760500977a88c5a4c9b671ba
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 22, 2024https://github.com/nodejs/node/pull/53093#event-12894577800
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 22, 2024https://github.com/nodejs/node/pull/53093#event-12894660644
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 22, 2024https://github.com/nodejs/node/pull/53093#issuecomment-2124816201
https://ci.nodejs.org/job/node-test-pull-request/59351/https://ci.nodejs.org/job/node-test-pull-request/59351/
Please reload this pagehttps://github.com/nodejs/node/pull/53093
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
May 23, 2024 https://github.com/nodejs/node/pull/53093#pullrequestreview-2073333151
View reviewed changes https://github.com/nodejs/node/pull/53093/files/a547c423fb575360760500977a88c5a4c9b671ba
marco-ippolitohttps://github.com/marco-ippolito
May 23, 2024 https://github.com/nodejs/node/pull/53093#ref-commit-b7bc635
https://github.com/cjihrig
https://github.com/marco-ippolito
test_runner: ignore todo flag when running suiteshttps://github.com/nodejs/node/commit/b7bc63565ecd091890500751ad4e5a12f46e0ff1
b7bc635https://github.com/nodejs/node/commit/b7bc63565ecd091890500751ad4e5a12f46e0ff1
#52117https://github.com/nodejs/node/pull/52117
#53093https://github.com/nodejs/node/pull/53093
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
May 23, 2024https://github.com/nodejs/node/pull/53093#issuecomment-2126618256
b7bc635https://github.com/nodejs/node/commit/b7bc63565ecd091890500751ad4e5a12f46e0ff1
Please reload this pagehttps://github.com/nodejs/node/pull/53093
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
May 23, 2024https://github.com/nodejs/node/pull/53093#event-12906211391
https://github.com/atlowChemi
atlowChemihttps://github.com/atlowChemi
May 23, 2024 09:16https://github.com/nodejs/node/pull/53093#event-12906259125
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53093
https://github.com/MoLow
MoLow https://github.com/MoLow
https://github.com/nodejs/node/pull/53093/files/a547c423fb575360760500977a88c5a4c9b671ba
https://github.com/marco-ippolito
marco-ippolito https://github.com/marco-ippolito
https://github.com/nodejs/node/pull/53093/files/a547c423fb575360760500977a88c5a4c9b671ba
Please reload this pagehttps://github.com/nodejs/node/pull/53093
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
Please reload this pagehttps://github.com/nodejs/node/pull/53093
https://github.com/atlowChemi
https://github.com/nodejs-github-bot
https://github.com/marco-ippolito
https://github.com/MoLow
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.