René's URL Explorer Experiment


Title: Revert "src: make sure pass the `argv` to worker threads" by nicolo-ribaudo · Pull Request #53021 · nodejs/node · GitHub

Open Graph Title: Revert "src: make sure pass the `argv` to worker threads" by nicolo-ribaudo · Pull Request #53021 · nodejs/node

X Title: Revert "src: make sure pass the `argv` to worker threads" by nicolo-ribaudo · Pull Request #53021 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: aba4a00 introduced a regression, making it impossible to use Worker's env option when the process is start with process-specific flags, such as --title or --expose_gc. See the new test case, in...

X Description: aba4a00 introduced a regression, making it impossible to use Worker's env option when the process is start with process-specific flags, such as --title or --expose_gc. See the new test case...

Opengraph URL: https://github.com/nodejs/node/pull/53021

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8f4b2cbf-163d-862e-a5d4-75a77436984d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9EDE:3C4A99:EE8A65:13700ED:6AED56B1
html-safe-noncef41f802959b3c10c018b514fc702468ad1bd90c8d1b9091f99a4d5d6f4f07c94
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RURFOjNDNEE5OTpFRThBNjU6MTM3MDBFRDo2QUVENTZCMSIsInZpc2l0b3JfaWQiOiI0MjQ4NzM2ODkyNTkwMDUzMDQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7e50958f85117d18ff2f1d22c3e138f79f62b6f5dded50f0305688df7f4c43fc
hovercard-subject-tagpull_request:1872975895
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/53021/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a3c4a209f3ffcd89dcb957856371d17cd16fa212a1038da3b4b7b80cbc61411f/nodejs/node/pull/53021
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a3c4a209f3ffcd89dcb957856371d17cd16fa212a1038da3b4b7b80cbc61411f/nodejs/node/pull/53021
og:image:altaba4a00 introduced a regression, making it impossible to use Worker's env option when the process is start with process-specific flags, such as --title or --expose_gc. See the new test case, in...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenicolo-ribaudo
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/53021#start-of-content
Reloadhttps://github.com/nodejs/node/pull/53021
Reloadhttps://github.com/nodejs/node/pull/53021
Reloadhttps://github.com/nodejs/node/pull/53021
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nicolo-ribaudohttps://github.com/nicolo-ribaudo
nodejs:mainhttps://github.com/nodejs/node/tree/main
nicolo-ribaudo:fix-22.2-worker-regressionhttps://github.com/nicolo-ribaudo/node/tree/fix-22.2-worker-regression
Conversationhttps://github.com/nodejs/node/pull/53021
Commits2 (2)https://github.com/nodejs/node/pull/53021/commits
Checkshttps://github.com/nodejs/node/pull/53021/checks
Files changedhttps://github.com/nodejs/node/pull/53021/files
Revert "src: make sure pass the argv to worker threads"https://github.com/nodejs/node/pull/53021#top
nicolo-ribaudohttps://github.com/nicolo-ribaudo
nodejs:mainhttps://github.com/nodejs/node/tree/main
nicolo-ribaudo:fix-22.2-worker-regressionhttps://github.com/nicolo-ribaudo/node/tree/fix-22.2-worker-regression
https://github.com/nicolo-ribaudo
nicolo-ribaudohttps://github.com/nicolo-ribaudo
May 16, 2024https://github.com/nodejs/node/pull/53021#issue-2299872459
Please reload this pagehttps://github.com/nodejs/node/pull/53021
aba4a00https://github.com/nodejs/node/commit/aba4a00c8d20135ad8d071991bd8bff06d4e136c
aba4a00https://github.com/nodejs/node/commit/aba4a00c8d20135ad8d071991bd8bff06d4e136c
aba4a00https://github.com/nodejs/node/commit/aba4a00c8d20135ad8d071991bd8bff06d4e136c
#53011https://github.com/nodejs/node/issues/53011
@theanarkhhttps://github.com/theanarkh
Please reload this pagehttps://github.com/nodejs/node/pull/53021
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
May 16, 2024https://github.com/nodejs/node/pull/53021#event-12830306654
https://github.com/nicolo-ribaudo
nicolo-ribaudohttps://github.com/nicolo-ribaudo
force-pushedhttps://github.com/nodejs/node/compare/dd4cd0c1c43ba2415c5d34a8e61f8e257f2b7154..33bbb6cf84b7254e97b5a60e8f166160b58599fd
dd4cd0chttps://github.com/nodejs/node/commit/dd4cd0c1c43ba2415c5d34a8e61f8e257f2b7154
33bbb6chttps://github.com/nodejs/node/commit/33bbb6cf84b7254e97b5a60e8f166160b58599fd
Compare https://github.com/nodejs/node/compare/dd4cd0c1c43ba2415c5d34a8e61f8e257f2b7154..33bbb6cf84b7254e97b5a60e8f166160b58599fd
May 16, 2024 09:41https://github.com/nodejs/node/pull/53021#event-12830364956
https://github.com/nicolo-ribaudo
nicolo-ribaudohttps://github.com/nicolo-ribaudo
May 16, 2024https://github.com/nodejs/node/pull/53021#issuecomment-2114721814
Please reload this pagehttps://github.com/nodejs/node/pull/53021
Please reload this pagehttps://github.com/nodejs/node/pull/53021
https://github.com/nicolo-ribaudo
nicolo-ribaudohttps://github.com/nicolo-ribaudo
force-pushedhttps://github.com/nodejs/node/compare/33bbb6cf84b7254e97b5a60e8f166160b58599fd..2c65c8dce6249762c836749f11441f3ff114e4ab
33bbb6chttps://github.com/nodejs/node/commit/33bbb6cf84b7254e97b5a60e8f166160b58599fd
2c65c8dhttps://github.com/nodejs/node/commit/2c65c8dce6249762c836749f11441f3ff114e4ab
Compare https://github.com/nodejs/node/compare/33bbb6cf84b7254e97b5a60e8f166160b58599fd..2c65c8dce6249762c836749f11441f3ff114e4ab
May 16, 2024 10:06https://github.com/nodejs/node/pull/53021#event-12830832149
nicolo-ribaudohttps://github.com/nicolo-ribaudo
May 16, 2024 12:11https://github.com/nodejs/node/pull/53021#commits-pushed-cc4e8f2
https://github.com/nicolo-ribaudo
worker: add test for env option when using process-only cli flaghttps://github.com/nodejs/node/pull/53021/commits/cc4e8f26522b7e67a025c8f34b8a83605a5a6199
cc4e8f2https://github.com/nodejs/node/pull/53021/commits/cc4e8f26522b7e67a025c8f34b8a83605a5a6199
https://github.com/nicolo-ribaudo
Revert "src: make sure pass the argv to worker threads"https://github.com/nodejs/node/pull/53021/commits/e05e0724746b6fca404a730ee03b8bae05a3c4d6
e05e072https://github.com/nodejs/node/pull/53021/commits/e05e0724746b6fca404a730ee03b8bae05a3c4d6
aba4a00https://github.com/nicolo-ribaudo/node/commit/aba4a00c8d20135ad8d071991bd8bff06d4e136c
https://github.com/nicolo-ribaudo
nicolo-ribaudohttps://github.com/nicolo-ribaudo
force-pushedhttps://github.com/nodejs/node/compare/2c65c8dce6249762c836749f11441f3ff114e4ab..e05e0724746b6fca404a730ee03b8bae05a3c4d6
2c65c8dhttps://github.com/nodejs/node/commit/2c65c8dce6249762c836749f11441f3ff114e4ab
e05e072https://github.com/nodejs/node/commit/e05e0724746b6fca404a730ee03b8bae05a3c4d6
Compare https://github.com/nodejs/node/compare/2c65c8dce6249762c836749f11441f3ff114e4ab..e05e0724746b6fca404a730ee03b8bae05a3c4d6
May 16, 2024 10:12https://github.com/nodejs/node/pull/53021#event-12830943741
https://github.com/nicolo-ribaudo
nicolo-ribaudohttps://github.com/nicolo-ribaudo
May 16, 2024 https://github.com/nodejs/node/pull/53021#ref-pullrequest-2299992935
Pin CI to Node.js 22.1 babel/babel#16498 https://github.com/babel/babel/pull/16498
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
May 16, 2024https://github.com/nodejs/node/pull/53021#issuecomment-2116086666
Please reload this pagehttps://github.com/nodejs/node/pull/53021
Please reload this pagehttps://github.com/nodejs/node/pull/53021
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
revert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arevert
May 16, 2024https://github.com/nodejs/node/pull/53021#event-12839312529
https://github.com/aduh95
aduh95https://github.com/aduh95
May 17, 2024 https://github.com/nodejs/node/pull/53021#ref-pullrequest-2278747302
src: make sure pass the cli_options to worker #52827 https://github.com/nodejs/node/pull/52827
https://github.com/aduh95
aduh95https://github.com/aduh95
May 17, 2024https://github.com/nodejs/node/pull/53021#issuecomment-2116848966
Please reload this pagehttps://github.com/nodejs/node/pull/53021
https://github.com/theanarkh
theanarkhhttps://github.com/theanarkh
May 17, 2024https://github.com/nodejs/node/pull/53021#issuecomment-2117246097
PRhttps://github.com/nodejs/node/pull/53029
Please reload this pagehttps://github.com/nodejs/node/pull/53021
https://github.com/nicolo-ribaudo
nicolo-ribaudohttps://github.com/nicolo-ribaudo
May 22, 2024https://github.com/nodejs/node/pull/53021#issuecomment-2124770924
#53029https://github.com/nodejs/node/pull/53029
Please reload this pagehttps://github.com/nodejs/node/pull/53021
https://github.com/nicolo-ribaudo
nicolo-ribaudohttps://github.com/nicolo-ribaudo
May 22, 2024https://github.com/nodejs/node/pull/53021#event-12894346286
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F53021
Please reload this pagehttps://github.com/nodejs/node/pull/53021
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
revert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arevert
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
[v22.2.0 regression] Some Worker use cases are broken https://github.com/nodejs/node/issues/53011
Please reload this pagehttps://github.com/nodejs/node/pull/53021
https://github.com/nicolo-ribaudo
https://github.com/avivkeller
https://github.com/aduh95
https://github.com/theanarkh
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.