| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:214f452b-e862-01a3-b7e6-4112d36387c5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BD22:345820:93E302:C8FD06:6969E684 |
| html-safe-nonce | b2819ee1a53fe067476fc94731e6e77b54c7e3230ecb09b2878cbe5bf9749c7c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDIyOjM0NTgyMDo5M0UzMDI6QzhGRDA2OjY5NjlFNjg0IiwidmlzaXRvcl9pZCI6Ijg0NTcxNzYxODI3MjM2NDE2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 630901dd29c5f5ebb4cce519f0a3538a7b30dc1f4b8fa22203ef6d7d1bb0feb9 |
| hovercard-subject-tag | pull_request:1862681394 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/52925/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/cbadca7c06232d7a6e2e6ba65543325d2bdce82e506e010fd62d65a9ee12c5e2/nodejs/node/pull/52925 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/cbadca7c06232d7a6e2e6ba65543325d2bdce82e506e010fd62d65a9ee12c5e2/nodejs/node/pull/52925 |
| og:image:alt | v18 bullet point from #51308
This patch backports the test/v8-updates/test-linux-perf-logger.js test from #50352 to the v18 branch.
Related to #50079, this test suite includes the same assertions a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lukealbao |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/52925#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52925 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52925 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/52925 |
| Reload | https://github.com/nodejs/node/pull/52925 |
| Reload | https://github.com/nodejs/node/pull/52925 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/52925 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/52925 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/52925#issue-comment-box |
| lukealbao | https://github.com/lukealbao |
| nodejs:v18.x-staging | https://github.com/nodejs/node/tree/v18.x-staging |
| lukealbao:gh-51308-add-test-linux-perf-logger-to-v18x | https://github.com/lukealbao/node/tree/gh-51308-add-test-linux-perf-logger-to-v18x |
|
[v18 backport] test: add v8-updates/test-linux-perf-logger
| https://github.com/nodejs/node/pull/52925#top |
| lukealbao | https://github.com/lukealbao |
| nodejs:v18.x-staging | https://github.com/nodejs/node/tree/v18.x-staging |
| lukealbao:gh-51308-add-test-linux-perf-logger-to-v18x | https://github.com/lukealbao/node/tree/gh-51308-add-test-linux-perf-logger-to-v18x |
|
Conversation
7
| https://github.com/nodejs/node/pull/52925 |
|
Commits
2
| https://github.com/nodejs/node/pull/52925/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/52925/checks |
|
Files changed
| https://github.com/nodejs/node/pull/52925/files |
| Please reload this page | https://github.com/nodejs/node/pull/52925 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/lukealbao |
| lukealbao | https://github.com/lukealbao |
| May 9, 2024 | https://github.com/nodejs/node/pull/52925#issue-2288326763 |
| Please reload this page | https://github.com/nodejs/node/pull/52925 |
| #51308 | https://github.com/nodejs/node/issues/51308 |
| #50352 | https://github.com/nodejs/node/pull/50352 |
| #50079 | https://github.com/nodejs/node/issues/50079 |
| @richardlau | https://github.com/richardlau |
| Please reload this page | https://github.com/nodejs/node/pull/52925 |
| lukealbao | https://github.com/lukealbao |
| May 9, 2024 12:23 | https://github.com/nodejs/node/pull/52925#commits-pushed-7d8fec9 |
|
| https://github.com/lukealbao |
| test: v8: Add test-linux-perf-logger test suite | https://github.com/nodejs/node/pull/52925/commits/7d8fec9d736710a87342ab4f86581f473570a7c1 |
| 7d8fec9 | https://github.com/nodejs/node/pull/52925/commits/7d8fec9d736710a87342ab4f86581f473570a7c1 |
| 9c714d8 | https://github.com/lukealbao/node/commit/9c714d82323678f036ec93f8f526694604e7bb39 |
| nodejs#50352 | https://github.com/nodejs/node/pull/50352 |
|
| https://github.com/lukealbao |
| Add maintainers' note re: v8 options failure modes | https://github.com/nodejs/node/pull/52925/commits/dacfd73c593b2f352e27eb60b3a6c8ef57944cb0 |
| dacfd73 | https://github.com/nodejs/node/pull/52925/commits/dacfd73c593b2f352e27eb60b3a6c8ef57944cb0 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av18.x |
| May 9, 2024 | https://github.com/nodejs/node/pull/52925#event-12761316631 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
May 9, 2024
| https://github.com/nodejs/node/pull/52925#pullrequestreview-2048745671 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52925/files/dacfd73c593b2f352e27eb60b3a6c8ef57944cb0 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| May 9, 2024 | https://github.com/nodejs/node/pull/52925#event-12761707432 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| May 9, 2024 | https://github.com/nodejs/node/pull/52925#event-12761754783 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 9, 2024 | https://github.com/nodejs/node/pull/52925#issuecomment-2103363950 |
| https://ci.nodejs.org/job/node-test-pull-request/59066/ | https://ci.nodejs.org/job/node-test-pull-request/59066/ |
| Please reload this page | https://github.com/nodejs/node/pull/52925 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 10, 2024 | https://github.com/nodejs/node/pull/52925#issuecomment-2103639457 |
| https://ci.nodejs.org/job/node-test-pull-request/59070/ | https://ci.nodejs.org/job/node-test-pull-request/59070/ |
| Please reload this page | https://github.com/nodejs/node/pull/52925 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 10, 2024
| https://github.com/nodejs/node/pull/52925#pullrequestreview-2049307860 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52925/files/dacfd73c593b2f352e27eb60b3a6c8ef57944cb0 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 10, 2024 | https://github.com/nodejs/node/pull/52925#issuecomment-2103941342 |
| https://ci.nodejs.org/job/node-test-pull-request/59072/ | https://ci.nodejs.org/job/node-test-pull-request/59072/ |
| Please reload this page | https://github.com/nodejs/node/pull/52925 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 10, 2024 | https://github.com/nodejs/node/pull/52925#issuecomment-2104542499 |
| https://ci.nodejs.org/job/node-test-pull-request/59074/ | https://ci.nodejs.org/job/node-test-pull-request/59074/ |
| Please reload this page | https://github.com/nodejs/node/pull/52925 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 10, 2024 | https://github.com/nodejs/node/pull/52925#issuecomment-2104560402 |
| https://ci.nodejs.org/job/node-test-pull-request/59075/ | https://ci.nodejs.org/job/node-test-pull-request/59075/ |
| Please reload this page | https://github.com/nodejs/node/pull/52925 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 10, 2024 | https://github.com/nodejs/node/pull/52925#issuecomment-2104721943 |
| https://ci.nodejs.org/job/node-test-pull-request/59076/ | https://ci.nodejs.org/job/node-test-pull-request/59076/ |
| Please reload this page | https://github.com/nodejs/node/pull/52925 |
| richardlau | https://github.com/richardlau |
|
May 16, 2024
| https://github.com/nodejs/node/pull/52925#ref-commit-351ef18 |
|
| https://github.com/lukealbao |
|
| https://github.com/richardlau |
| test: v8: Add test-linux-perf-logger test suite | https://github.com/nodejs/node/commit/351ef189cab72b2bc1d16d3a03124399ac9886e7 |
| 351ef18 | https://github.com/nodejs/node/commit/351ef189cab72b2bc1d16d3a03124399ac9886e7 |
| 9c714d8 | https://github.com/nodejs/node/commit/9c714d82323678f036ec93f8f526694604e7bb39 |
| #50352 | https://github.com/nodejs/node/pull/50352 |
| #52925 | https://github.com/nodejs/node/pull/52925 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| May 16, 2024 | https://github.com/nodejs/node/pull/52925#issuecomment-2115570895 |
| 351ef18 | https://github.com/nodejs/node/commit/351ef189cab72b2bc1d16d3a03124399ac9886e7 |
| Please reload this page | https://github.com/nodejs/node/pull/52925 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| May 16, 2024 | https://github.com/nodejs/node/pull/52925#event-12836004008 |
| https://github.com/lukealbao |
| lukealbao | https://github.com/lukealbao |
| May 28, 2024 19:15 | https://github.com/nodejs/node/pull/52925#event-12962164622 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52925 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/52925/files/dacfd73c593b2f352e27eb60b3a6c8ef57944cb0 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/52925/files/dacfd73c593b2f352e27eb60b3a6c8ef57944cb0 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av18.x |
| Please reload this page | https://github.com/nodejs/node/pull/52925 |
|
| https://github.com/lukealbao |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/richardlau |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |