René's URL Explorer Experiment


Title: weak handles and promises in progress stuff by Fishrock123 · Pull Request #5292 · nodejs/node · GitHub

Open Graph Title: weak handles and promises in progress stuff by Fishrock123 · Pull Request #5292 · nodejs/node

X Title: weak handles and promises in progress stuff by Fishrock123 · Pull Request #5292 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Important: Please do not discuss the merits of this here. I will make the case for it once it works. This will be put into a new PR once ready. For now, I am only interested in figuring out why thi...

X Description: Important: Please do not discuss the merits of this here. I will make the case for it once it works. This will be put into a new PR once ready. For now, I am only interested in figuring out why thi...

Opengraph URL: https://github.com/nodejs/node/pull/5292

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:aa231bfd-4fab-a4b0-46bf-1e0f512657af
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8524:3AF9A7:50C4ABF:71345F9:6A4F9701
html-safe-nonce9bfa85a1cac2b54219f5ea45aa57bfd7eea540de728e263765d1d393836b36a4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTI0OjNBRjlBNzo1MEM0QUJGOjcxMzQ1Rjk6NkE0Rjk3MDEiLCJ2aXNpdG9yX2lkIjoiNDkyMTA2OTAwMjkyMTMxODE0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac61cd21cb335a11010ec794427329285aedb4c0bb4b5295f2ce88e5ea4c5bc40f
hovercard-subject-tagpull_request:59719642
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/5292/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5e5f0779c39f6130e1759efe952fcc16da45289651cd5fad54920e0ebd92ce3d/nodejs/node/pull/5292
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5e5f0779c39f6130e1759efe952fcc16da45289651cd5fad54920e0ebd92ce3d/nodejs/node/pull/5292
og:image:altImportant: Please do not discuss the merits of this here. I will make the case for it once it works. This will be put into a new PR once ready. For now, I am only interested in figuring out why thi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameFishrock123
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/5292#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5292
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5292
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/5292
Reloadhttps://github.com/nodejs/node/pull/5292
Reloadhttps://github.com/nodejs/node/pull/5292
Please reload this pagehttps://github.com/nodejs/node/pull/5292
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/5292
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 972 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Fishrock123https://github.com/Fishrock123
nodejs:masterhttps://github.com/nodejs/node/tree/master
Fishrock123:promise-unhandled-defaulthttps://github.com/Fishrock123/node/tree/promise-unhandled-default
Conversationhttps://github.com/nodejs/node/pull/5292
Commits1 (1)https://github.com/nodejs/node/pull/5292/commits
Checkshttps://github.com/nodejs/node/pull/5292/checks
Files changedhttps://github.com/nodejs/node/pull/5292/files
weak handles and promises in progress stuffhttps://github.com/nodejs/node/pull/5292#top
Fishrock123https://github.com/Fishrock123
nodejs:masterhttps://github.com/nodejs/node/tree/master
Fishrock123:promise-unhandled-defaulthttps://github.com/Fishrock123/node/tree/promise-unhandled-default
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Feb 17, 2016https://github.com/nodejs/node/pull/5292#issue-134419460
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
question https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aquestion
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Feb 17, 2016https://github.com/nodejs/node/pull/5292#event-554289784
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Feb 18, 2016https://github.com/nodejs/node/pull/5292#issuecomment-185518648
v8.hhttps://code.google.com/p/chromium/codesearch#chromium/src/v8/include/v8.h&l=553
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Feb 18, 2016https://github.com/nodejs/node/pull/5292#issuecomment-185525891
@ofrobotshttps://github.com/ofrobots
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Feb 18, 2016https://github.com/nodejs/node/pull/5292#issuecomment-185540416
Please reload this pagehttps://github.com/nodejs/node/pull/5292
trevnorrishttps://github.com/trevnorris
Feb 18, 2016 https://github.com/nodejs/node/pull/5292#discussion-diff-53296404
View reviewed changes https://github.com/nodejs/node/pull/5292/files#diff-74bbeccf1bee16f0134ad2447bef0ec1d97be84cd5502053d8f90c1b270533f6
src/track-promise.cchttps://github.com/nodejs/node/pull/5292/files#diff-74bbeccf1bee16f0134ad2447bef0ec1d97be84cd5502053d8f90c1b270533f6
trevnorrishttps://github.com/trevnorris
Feb 18, 2016https://github.com/nodejs/node/pull/5292#discussion_r53296404
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5292
Fishrock123https://github.com/Fishrock123
Feb 18, 2016https://github.com/nodejs/node/pull/5292#discussion_r53324532
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/5292
ofrobotshttps://github.com/ofrobots
Feb 18, 2016https://github.com/nodejs/node/pull/5292#discussion_r53325477
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Feb 19, 2016https://github.com/nodejs/node/pull/5292#issuecomment-185987139
@ofrobotshttps://github.com/ofrobots
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Feb 19, 2016https://github.com/nodejs/node/pull/5292#issuecomment-186430693
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Feb 19, 2016https://github.com/nodejs/node/pull/5292#issuecomment-186446240
@ofrobotshttps://github.com/ofrobots
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/vkurchatkin
vkurchatkinhttps://github.com/vkurchatkin
Feb 20, 2016https://github.com/nodejs/node/pull/5292#issuecomment-186575458
node-weakhttps://github.com/TooTallNate/node-weak
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Feb 22, 2016https://github.com/nodejs/node/pull/5292#issuecomment-187008135
@Fishrock123https://github.com/Fishrock123
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Feb 25, 2016 https://github.com/nodejs/node/pull/5292#ref-issue-136188250
Default Unhandled Rejection Behavior nodejs/promises#26 https://github.com/nodejs/promises/issues/26
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Feb 25, 2016https://github.com/nodejs/node/pull/5292#event-566313329
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Feb 25, 2016https://github.com/nodejs/node/pull/5292#issuecomment-188978393
@ofrobotshttps://github.com/ofrobots
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/5292
Fishrock123https://github.com/Fishrock123
Feb 25, 2016 https://github.com/nodejs/node/pull/5292#discussion-diff-54161784
View reviewed changes https://github.com/nodejs/node/pull/5292/files#diff-74bbeccf1bee16f0134ad2447bef0ec1d97be84cd5502053d8f90c1b270533f6
src/track-promise.cchttps://github.com/nodejs/node/pull/5292/files#diff-74bbeccf1bee16f0134ad2447bef0ec1d97be84cd5502053d8f90c1b270533f6
Fishrock123https://github.com/Fishrock123
Feb 25, 2016https://github.com/nodejs/node/pull/5292#discussion_r54161784
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5292
ofrobotshttps://github.com/ofrobots
Feb 25, 2016https://github.com/nodejs/node/pull/5292#discussion_r54164025
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5292
Fishrock123https://github.com/Fishrock123
Feb 25, 2016https://github.com/nodejs/node/pull/5292#discussion_r54167765
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5292
ofrobotshttps://github.com/ofrobots
Feb 25, 2016https://github.com/nodejs/node/pull/5292#discussion_r54169306
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
that function assertshttps://code.google.com/p/chromium/codesearch#chromium/src/v8/include/v8.h&l=7334&rcl=1456417974
FromMaybehttps://code.google.com/p/chromium/codesearch#chromium/src/v8/include/v8.h&l=377
Please reload this pagehttps://github.com/nodejs/node/pull/5292
bnoordhuishttps://github.com/bnoordhuis
Feb 26, 2016https://github.com/nodejs/node/pull/5292#discussion_r54237309
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5292
ofrobotshttps://github.com/ofrobots
Feb 26, 2016https://github.com/nodejs/node/pull/5292#discussion_r54257078
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5292
Fishrock123https://github.com/Fishrock123
Feb 26, 2016https://github.com/nodejs/node/pull/5292#discussion_r54264722
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Feb 26, 2016https://github.com/nodejs/node/pull/5292#issuecomment-189526572
@ofrobotshttps://github.com/ofrobots
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/vkurchatkin
vkurchatkinhttps://github.com/vkurchatkin
Feb 26, 2016https://github.com/nodejs/node/pull/5292#issuecomment-189529302
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Feb 27, 2016https://github.com/nodejs/node/pull/5292#issuecomment-189687371
@vkurchatkinhttps://github.com/vkurchatkin
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/vkurchatkin
vkurchatkinhttps://github.com/vkurchatkin
Feb 27, 2016https://github.com/nodejs/node/pull/5292#issuecomment-189692144
@Fishrock123https://github.com/Fishrock123
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Feb 27, 2016https://github.com/nodejs/node/pull/5292#issuecomment-189699285
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/jasnell
jasnellhttps://github.com/jasnell
dont-land-on-v5.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v5.x
Mar 2, 2016https://github.com/nodejs/node/pull/5292#event-575022982
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
force-pushedhttps://github.com/nodejs/node/compare/ac75659199874331391d620db4c1f54527bf9da4..3af1162ab2721bf7cab44bc84f0255bda432d49e
ac75659https://github.com/nodejs/node/commit/ac75659199874331391d620db4c1f54527bf9da4
3af1162https://github.com/nodejs/node/commit/3af1162ab2721bf7cab44bc84f0255bda432d49e
Compare https://github.com/nodejs/node/compare/ac75659199874331391d620db4c1f54527bf9da4..3af1162ab2721bf7cab44bc84f0255bda432d49e
April 25, 2016 00:05https://github.com/nodejs/node/pull/5292#event-639259144
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 25, 2016https://github.com/nodejs/node/pull/5292#issuecomment-214069345
Please reload this pagehttps://github.com/nodejs/node/pull/5292
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 25, 2016https://github.com/nodejs/node/pull/5292#issuecomment-214069506
Please reload this pagehttps://github.com/nodejs/node/pull/5292
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 25, 2016 https://github.com/nodejs/node/pull/5292#ref-pullrequest-150537896
promise: Add --throw-unhandled-rejection and --trace-unhandled-rejection #6355 https://github.com/nodejs/node/pull/6355
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
force-pushedhttps://github.com/nodejs/node/compare/3af1162ab2721bf7cab44bc84f0255bda432d49e..52d1396d262d213336b073ec946c505948dd2ec0
3af1162https://github.com/nodejs/node/commit/3af1162ab2721bf7cab44bc84f0255bda432d49e
52d1396https://github.com/nodejs/node/commit/52d1396d262d213336b073ec946c505948dd2ec0
Compare https://github.com/nodejs/node/compare/3af1162ab2721bf7cab44bc84f0255bda432d49e..52d1396d262d213336b073ec946c505948dd2ec0
April 25, 2016 02:05https://github.com/nodejs/node/pull/5292#event-639309812
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 25, 2016https://github.com/nodejs/node/pull/5292#issuecomment-214093087
https://ci.nodejs.org/job/node-test-pull-request/2376/https://ci.nodejs.org/job/node-test-pull-request/2376/
Please reload this pagehttps://github.com/nodejs/node/pull/5292
bnoordhuishttps://github.com/bnoordhuis
Apr 25, 2016 https://github.com/nodejs/node/pull/5292#discussion-diff-60896525
View reviewed changes https://github.com/nodejs/node/pull/5292/files/5493996a9131ddf792071d4effa9b8bc853e215f#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
src/node.cchttps://github.com/nodejs/node/pull/5292/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
bnoordhuishttps://github.com/bnoordhuis
Apr 25, 2016https://github.com/nodejs/node/pull/5292#discussion_r60896525
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5292
Fishrock123https://github.com/Fishrock123
Apr 25, 2016https://github.com/nodejs/node/pull/5292#discussion_r60905736
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5292
bnoordhuishttps://github.com/bnoordhuis
Apr 25, 2016https://github.com/nodejs/node/pull/5292#discussion_r60907415
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 25, 2016https://github.com/nodejs/node/pull/5292#issuecomment-214447514
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 25, 2016https://github.com/nodejs/node/pull/5292#event-640335380
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 25, 2016 https://github.com/nodejs/node/pull/5292#ref-pullrequest-150930412
lib,src: "throw" on unhandled promise rejections #6375 https://github.com/nodejs/node/pull/6375
Fishrock123https://github.com/Fishrock123
Apr 25, 2016 https://github.com/nodejs/node/pull/5292#ref-commit-7e2a08c
https://github.com/Fishrock123
lib,src: throw on unhanded promise rejectionshttps://github.com/Fishrock123/node/commit/7e2a08ce12aa385485098ae1d052c8ee03315abe
7e2a08chttps://github.com/Fishrock123/node/commit/7e2a08ce12aa385485098ae1d052c8ee03315abe
nodejs#5292https://github.com/nodejs/node/pull/5292
nodejs/promises#26https://github.com/nodejs/promises/issues/26
nodejs#6355https://github.com/nodejs/node/pull/6355
Fishrock123https://github.com/Fishrock123
Feb 10, 2017 https://github.com/nodejs/node/pull/5292#ref-commit-8a2e21a
https://github.com/Fishrock123
lib,src: throw on unhanded promise rejectionshttps://github.com/Fishrock123/node/commit/8a2e21a347b67990da5f94a0b44d3458ad9946ef
8a2e21ahttps://github.com/Fishrock123/node/commit/8a2e21a347b67990da5f94a0b44d3458ad9946ef
nodejs#5292https://github.com/nodejs/node/pull/5292
nodejs/promises#26https://github.com/nodejs/promises/issues/26
nodejs#6355https://github.com/nodejs/node/pull/6355
nodejs#6375https://github.com/nodejs/node/pull/6375
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Mar 23, 2017 https://github.com/nodejs/node/pull/5292#ref-pullrequest-216578404
lib,src: exit process on unhandled promise rejection cleanup #12010 https://github.com/nodejs/node/pull/12010
Fishrock123https://github.com/Fishrock123
Apr 28, 2017 https://github.com/nodejs/node/pull/5292#ref-commit-1f9635d
https://github.com/Fishrock123
lib,src: throw on unhanded promise rejectionshttps://github.com/Fishrock123/node/commit/1f9635d8f860a758cfd295504db16b02a22e51df
1f9635dhttps://github.com/Fishrock123/node/commit/1f9635d8f860a758cfd295504db16b02a22e51df
nodejs#5292https://github.com/nodejs/node/pull/5292
nodejs/promises#26https://github.com/nodejs/promises/issues/26
nodejs#6355https://github.com/nodejs/node/pull/6355
nodejs#6375https://github.com/nodejs/node/pull/6375
Fishrock123https://github.com/Fishrock123
Apr 28, 2017 https://github.com/nodejs/node/pull/5292#ref-commit-f6e35fe
https://github.com/Fishrock123
lib,src: throw on unhanded promise rejectionshttps://github.com/Fishrock123/node/commit/f6e35fed69a415f391aecca3e025c80c43a197db
f6e35fehttps://github.com/Fishrock123/node/commit/f6e35fed69a415f391aecca3e025c80c43a197db
nodejs#12010https://github.com/nodejs/node/pull/12010
nodejs#5292https://github.com/nodejs/node/pull/5292
nodejs/promises#26https://github.com/nodejs/promises/issues/26
nodejs#6355https://github.com/nodejs/node/pull/6355
nodejs#6375https://github.com/nodejs/node/pull/6375
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 28, 2017 https://github.com/nodejs/node/pull/5292#ref-pullrequest-225208618
lib,src: eagerly exit process on unhanded promise rejections #12734 https://github.com/nodejs/node/pull/12734
BridgeARhttps://github.com/BridgeAR
Sep 26, 2017 https://github.com/nodejs/node/pull/5292#ref-commit-711d699
https://github.com/Fishrock123
https://github.com/BridgeAR
lib,src: throw on unhanded promise rejectionshttps://github.com/BridgeAR/node/commit/711d699d249c9d44859a45dc6ce54844dc8ed386
711d699https://github.com/BridgeAR/node/commit/711d699d249c9d44859a45dc6ce54844dc8ed386
nodejs#5292https://github.com/nodejs/node/pull/5292
nodejs/promises#26https://github.com/nodejs/promises/issues/26
nodejs#6355https://github.com/nodejs/node/pull/6355
nodejs#6375https://github.com/nodejs/node/pull/6375
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5292
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Please reload this pagehttps://github.com/nodejs/node/pull/5292
https://github.com/Fishrock123
https://github.com/ofrobots
https://github.com/trevnorris
https://github.com/vkurchatkin
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.