| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f5921f9a-c5a7-8d2b-1222-6eaa04ee9740 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E93A:E27E8:BF2F0C:104154A:6969E75E |
| html-safe-nonce | 6ba43955baa69626ee40cce502bc9a17b10b472cf91918a941e771b2230e9cfc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTNBOkUyN0U4OkJGMkYwQzoxMDQxNTRBOjY5NjlFNzVFIiwidmlzaXRvcl9pZCI6IjU3NjU3MzI2MDc0MDI5MDM5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6fe76bfd64d0df4ec944e26f1bae6a435c99b1a9ae947c65a57bfe5fc38b9aae |
| hovercard-subject-tag | pull_request:1857470004 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/52870/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ce0417c043e76aaac72130442f71f722bd87d41212c1bba8fb4267a3bf3ecf8a/nodejs/node/pull/52870 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ce0417c043e76aaac72130442f71f722bd87d41212c1bba8fb4267a3bf3ecf8a/nodejs/node/pull/52870 |
| og:image:alt | The goal here is to do the right changes with lessons learned from #35433. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | targos |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/52870#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52870 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52870 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/52870 |
| Reload | https://github.com/nodejs/node/pull/52870 |
| Reload | https://github.com/nodejs/node/pull/52870 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/52870#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| targos:clang-cl-v2 | https://github.com/targos/node/tree/clang-cl-v2 |
|
build: add option to enable clang-cl on Windows
| https://github.com/nodejs/node/pull/52870#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| targos:clang-cl-v2 | https://github.com/targos/node/tree/clang-cl-v2 |
|
Conversation
45
| https://github.com/nodejs/node/pull/52870 |
|
Commits
1
| https://github.com/nodejs/node/pull/52870/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/52870/checks |
|
Files changed
| https://github.com/nodejs/node/pull/52870/files |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/targos |
| targos | https://github.com/targos |
| May 7, 2024 | https://github.com/nodejs/node/pull/52870#issue-2282336938 |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| #35433 | https://github.com/nodejs/node/pull/35433 |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 7, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2097498539 |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| May 7, 2024 | https://github.com/nodejs/node/pull/52870#event-12723662654 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| May 7, 2024 | https://github.com/nodejs/node/pull/52870#event-12723676328 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 7, 2024
| https://github.com/nodejs/node/pull/52870#ref-pullrequest-712178622 |
|
build: enable Clang-cl Windows builds
#35433
| https://github.com/nodejs/node/pull/35433 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/2fdab6c75871f89de6e17c74ed79820b98d90933..57b44a5cc34551ad64b47dad8d1738a4dcc2368d |
| 2fdab6c | https://github.com/nodejs/node/commit/2fdab6c75871f89de6e17c74ed79820b98d90933 |
| 57b44a5 | https://github.com/nodejs/node/commit/57b44a5cc34551ad64b47dad8d1738a4dcc2368d |
|
Compare
| https://github.com/nodejs/node/compare/2fdab6c75871f89de6e17c74ed79820b98d90933..57b44a5cc34551ad64b47dad8d1738a4dcc2368d |
| May 7, 2024 06:24 | https://github.com/nodejs/node/pull/52870#event-12723952859 |
| targos | https://github.com/targos |
|
May 7, 2024
| https://github.com/nodejs/node/pull/52870#ref-commit-a8e8ac7 |
|
| https://github.com/targos |
| feat: support language standard keys in msvs_settings | https://github.com/targos/gyp-next/commit/a8e8ac792d2a21a263c0d1952df60753a6f91409 |
| a8e8ac7 | https://github.com/targos/gyp-next/commit/a8e8ac792d2a21a263c0d1952df60753a6f91409 |
| nodejs/node#52870 | https://github.com/nodejs/node/pull/52870 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 7, 2024
| https://github.com/nodejs/node/pull/52870#ref-pullrequest-2282384518 |
|
feat: support language standard keys in msvs_settings
nodejs/gyp-next#252
| https://github.com/nodejs/gyp-next/pull/252 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 7, 2024
| https://github.com/nodejs/node/pull/52870#pullrequestreview-2042167906 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52870/files |
| tools/gyp/pylib/gyp/MSVSSettings.py | https://github.com/nodejs/node/pull/52870/files#diff-b87f5b5c9ff40e1285d22a4268c18f5e7142447345c309a06db4ddce782af24d |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 7, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2097576204 |
| #34201 | https://github.com/nodejs/node/issues/34201 |
| 711a822 | https://github.com/nodejs/node/commit/711a822f831f8c46f5935280257d3b7c8769a56a |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
help wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22help%20wanted%22 |
| May 7, 2024 | https://github.com/nodejs/node/pull/52870#event-12727857069 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 7, 2024
| https://github.com/nodejs/node/pull/52870#ref-pullrequest-2283080709 |
|
build: harmonize Clang checks and update V8 warning cflags
#52873
| https://github.com/nodejs/node/pull/52873 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/a0ba0e041e67b523314bf54f0ef6646a9c13bf3d..1106df1a054425ffd6d6a0351d10a66d5f82306c |
| a0ba0e0 | https://github.com/nodejs/node/commit/a0ba0e041e67b523314bf54f0ef6646a9c13bf3d |
| 1106df1 | https://github.com/nodejs/node/commit/1106df1a054425ffd6d6a0351d10a66d5f82306c |
|
Compare
| https://github.com/nodejs/node/compare/a0ba0e041e67b523314bf54f0ef6646a9c13bf3d..1106df1a054425ffd6d6a0351d10a66d5f82306c |
| May 7, 2024 13:35 | https://github.com/nodejs/node/pull/52870#event-12729760850 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 7, 2024
| https://github.com/nodejs/node/pull/52870#ref-issue-2283756172 |
|
Install ClangCL on Windows hosts
nodejs/build#3709
| https://github.com/nodejs/build/issues/3709 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 7, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2098877139 |
| #52873 | https://github.com/nodejs/node/pull/52873 |
| #34201 (comment) | https://github.com/nodejs/node/issues/34201#issuecomment-660868415 |
| nodejs/build#3709 | https://github.com/nodejs/build/issues/3709 |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/1106df1a054425ffd6d6a0351d10a66d5f82306c..3936842330674d55146fe65ff68c4a304090f17c |
| 1106df1 | https://github.com/nodejs/node/commit/1106df1a054425ffd6d6a0351d10a66d5f82306c |
| 3936842 | https://github.com/nodejs/node/commit/3936842330674d55146fe65ff68c4a304090f17c |
|
Compare
| https://github.com/nodejs/node/compare/1106df1a054425ffd6d6a0351d10a66d5f82306c..3936842330674d55146fe65ff68c4a304090f17c |
| May 7, 2024 16:41 | https://github.com/nodejs/node/pull/52870#event-12732447227 |
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
| May 7, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2098896508 |
| #52873 | https://github.com/nodejs/node/pull/52873 |
| #34201 (comment) | https://github.com/nodejs/node/issues/34201#issuecomment-660868415 |
| nodejs/build#3709 | https://github.com/nodejs/build/issues/3709 |
| my comment from the original PR | https://github.com/nodejs/node/pull/35433#discussion_r1581068508 |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| targos | https://github.com/targos |
|
May 8, 2024
| https://github.com/nodejs/node/pull/52870#ref-commit-322f6d5 |
|
| https://github.com/targos |
| feat: support language standard keys in msvs_settings ( | https://github.com/nodejs/gyp-next/commit/322f6d5d5233967522f3e55c623a8e7d7281e024 |
| #252 | https://github.com/nodejs/gyp-next/pull/252 |
| ) | https://github.com/nodejs/gyp-next/commit/322f6d5d5233967522f3e55c623a8e7d7281e024 |
| 322f6d5 | https://github.com/nodejs/gyp-next/commit/322f6d5d5233967522f3e55c623a8e7d7281e024 |
| nodejs/node#52870 | https://github.com/nodejs/node/pull/52870 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 8, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2099832600 |
| https://chromium.googlesource.com/chromium/deps/icu/+/refs/heads/main/README.chromium | https://chromium.googlesource.com/chromium/deps/icu/+/refs/heads/main/README.chromium |
| https://chromium.googlesource.com/chromium/deps/icu/+/refs/heads/main/common/ | https://chromium.googlesource.com/chromium/deps/icu/+/refs/heads/main/common/ |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 8, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2099900475 |
| @targos | https://github.com/targos |
| @StefanStojanovic | https://github.com/StefanStojanovic |
| #35433 (review) | https://github.com/nodejs/node/pull/35433#pullrequestreview-2025106112 |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 8, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2099903373 |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 8, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2099929011 |
| https://github.com/nodejs/node/actions/runs/8989345480/job/24692243725 | https://github.com/nodejs/node/actions/runs/8989345480/job/24692243725 |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/lemire |
| lemire | https://github.com/lemire |
| May 8, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2100824733 |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 8, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2100838007 |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
| May 8, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2101474752 |
| https://chromium.googlesource.com/chromium/deps/icu/+/refs/heads/main/README.chromium | https://chromium.googlesource.com/chromium/deps/icu/+/refs/heads/main/README.chromium |
| https://chromium.googlesource.com/chromium/deps/icu/+/refs/heads/main/common/ | https://chromium.googlesource.com/chromium/deps/icu/+/refs/heads/main/common/ |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 9, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2102465171 |
| 58a7bf7 | https://github.com/nodejs/node/commit/58a7bf7446206c2f67730ec6119056a3b634b918 |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/58a7bf7446206c2f67730ec6119056a3b634b918..ed3492dead45347d4bd08e85647f5f036e9a88a1 |
| 58a7bf7 | https://github.com/nodejs/node/commit/58a7bf7446206c2f67730ec6119056a3b634b918 |
| ed3492d | https://github.com/nodejs/node/commit/ed3492dead45347d4bd08e85647f5f036e9a88a1 |
|
Compare
| https://github.com/nodejs/node/compare/58a7bf7446206c2f67730ec6119056a3b634b918..ed3492dead45347d4bd08e85647f5f036e9a88a1 |
| May 10, 2024 05:24 | https://github.com/nodejs/node/pull/52870#event-12765026501 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 10, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2103892004 |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
help wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22help%20wanted%22 |
| May 10, 2024 | https://github.com/nodejs/node/pull/52870#event-12765039307 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 12, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2106192105 |
| https://ci.nodejs.org/job/node-test-pull-request/59167/ | https://ci.nodejs.org/job/node-test-pull-request/59167/ |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 13, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2106748795 |
| https://ci.nodejs.org/job/node-test-pull-request/59199/ | https://ci.nodejs.org/job/node-test-pull-request/59199/ |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
| May 13, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2106967570 |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 13, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2107016113 |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
|
May 13, 2024
| https://github.com/nodejs/node/pull/52870#pullrequestreview-2052122104 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52870/files/26b2f986a94adeceff5f55aae9c6cc6c6d81e914 |
| StefanStojanovic | https://github.com/StefanStojanovic |
| https://github.com/nodejs/node/pull/52870#pullrequestreview-2052122104 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
|
May 13, 2024
| https://github.com/nodejs/node/pull/52870#ref-issue-2276422914 |
|
build node.js using clangcl when under Windows
#52809
| https://github.com/nodejs/node/issues/52809 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 13, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2108552572 |
| @lemire | https://github.com/lemire |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 13, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2108567712 |
| llvm/llvm-project@03c698a | https://github.com/llvm/llvm-project/commit/03c698a431b4dc23c2b9de3e9befd1860fef6e80 |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/lemire |
| lemire | https://github.com/lemire |
|
May 13, 2024
| https://github.com/nodejs/node/pull/52870#pullrequestreview-2053454671 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52870/files/26b2f986a94adeceff5f55aae9c6cc6c6d81e914 |
| https://github.com/lemire |
| lemire | https://github.com/lemire |
| May 13, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2108574084 |
| @targos | https://github.com/targos |
| https://en.cppreference.com/w/cpp/numeric/bit_cast | https://en.cppreference.com/w/cpp/numeric/bit_cast |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| May 13, 2024 | https://github.com/nodejs/node/pull/52870#event-12791768327 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| May 13, 2024 | https://github.com/nodejs/node/pull/52870#event-12791797218 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| efa63f3 | https://github.com/nodejs/node/commit/efa63f3d054a42399b7183d4690dd5dfe65fbd02 |
| May 13, 2024 | https://github.com/nodejs/node/pull/52870#event-12791797903 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 13, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2108599639 |
| efa63f3 | https://github.com/nodejs/node/commit/efa63f3d054a42399b7183d4690dd5dfe65fbd02 |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 13, 2024 19:07 | https://github.com/nodejs/node/pull/52870#event-12791826306 |
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
| May 14, 2024 | https://github.com/nodejs/node/pull/52870#issuecomment-2109361654 |
| llvm/llvm-project@03c698a | https://github.com/llvm/llvm-project/commit/03c698a431b4dc23c2b9de3e9befd1860fef6e80 |
| FP16 | https://github.com/Maratyszcza/FP16 |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
| targos | https://github.com/targos |
|
May 15, 2024
| https://github.com/nodejs/node/pull/52870#ref-commit-a97ff75 |
|
| https://github.com/targos |
|
| https://github.com/lemire |
|
| https://github.com/StefanStojanovic |
| build: add option to enable clang-cl on Windows | https://github.com/nodejs/node/commit/a97ff753abaaef39b2b8df73f81284f7ed955e80 |
| a97ff75 | https://github.com/nodejs/node/commit/a97ff753abaaef39b2b8df73f81284f7ed955e80 |
| #52870 | https://github.com/nodejs/node/pull/52870 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 15, 2024
| https://github.com/nodejs/node/pull/52870#ref-pullrequest-2293520693 |
|
v22.2.0 release proposal
#52971
| https://github.com/nodejs/node/pull/52971 |
| eliphazbouye | https://github.com/eliphazbouye |
|
Jun 20, 2024
| https://github.com/nodejs/node/pull/52870#ref-commit-d68b489 |
|
| https://github.com/targos |
|
| https://github.com/lemire |
|
| https://github.com/StefanStojanovic |
|
| https://github.com/eliphazbouye |
| build: add option to enable clang-cl on Windows | https://github.com/eliphazbouye/node/commit/d68b48968d714d12662ae7f22d1746c8ac0bf232 |
| d68b489 | https://github.com/eliphazbouye/node/commit/d68b48968d714d12662ae7f22d1746c8ac0bf232 |
| nodejs#52870 | https://github.com/nodejs/node/pull/52870 |
| bmeck | https://github.com/bmeck |
|
Jun 22, 2024
| https://github.com/nodejs/node/pull/52870#ref-commit-7ffa193 |
|
| https://github.com/targos |
|
| https://github.com/lemire |
|
| https://github.com/StefanStojanovic |
|
| https://github.com/bmeck |
| build: add option to enable clang-cl on Windows | https://github.com/bmeck/node/commit/7ffa1932174d6272eb6034fa57780714ec796666 |
| 7ffa193 | https://github.com/bmeck/node/commit/7ffa1932174d6272eb6034fa57780714ec796666 |
| nodejs#52870 | https://github.com/nodejs/node/pull/52870 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 4, 2024
| https://github.com/nodejs/node/pull/52870#ref-pullrequest-2505616488 |
|
build: compile Node.js with C++20 support
electron/electron#43555
| https://github.com/electron/electron/pull/43555 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
dont-land-on-v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x |
| Sep 21, 2024 | https://github.com/nodejs/node/pull/52870#event-14348795812 |
| codebytere | https://github.com/codebytere |
|
Oct 16, 2024
| https://github.com/nodejs/node/pull/52870#ref-commit-e2b569c |
|
| https://github.com/codebytere |
| build: add option to enable clang-cl on Windows | https://github.com/electron/electron/commit/e2b569c32d079200fcbb4ca97d2d83423e5e0bd9 |
| e2b569c | https://github.com/electron/electron/commit/e2b569c32d079200fcbb4ca97d2d83423e5e0bd9 |
| nodejs/node#52870 | https://github.com/nodejs/node/pull/52870 |
| codebytere | https://github.com/codebytere |
|
Oct 21, 2024
| https://github.com/nodejs/node/pull/52870#ref-commit-3cee2ae |
|
| https://github.com/codebytere |
| build: add option to enable clang-cl on Windows | https://github.com/electron/electron/commit/3cee2ae080457489148f350d6156651c8e58c54f |
| 3cee2ae | https://github.com/electron/electron/commit/3cee2ae080457489148f350d6156651c8e58c54f |
| nodejs/node#52870 | https://github.com/nodejs/node/pull/52870 |
| codebytere | https://github.com/codebytere |
|
Oct 21, 2024
| https://github.com/nodejs/node/pull/52870#ref-commit-919819c |
|
| https://github.com/codebytere |
| build: add option to enable clang-cl on Windows | https://github.com/electron/electron/commit/919819ccd006931888c3bc33d08393a77b5403dd |
| 919819c | https://github.com/electron/electron/commit/919819ccd006931888c3bc33d08393a77b5403dd |
| nodejs/node#52870 | https://github.com/nodejs/node/pull/52870 |
| codebytere | https://github.com/codebytere |
|
Oct 22, 2024
| https://github.com/nodejs/node/pull/52870#ref-commit-b157550 |
|
| https://github.com/codebytere |
| build: add option to enable clang-cl on Windows | https://github.com/electron/electron/commit/b157550b406e2363b8f1045d7a6e1cb4b5624046 |
| b157550 | https://github.com/electron/electron/commit/b157550b406e2363b8f1045d7a6e1cb4b5624046 |
| nodejs/node#52870 | https://github.com/nodejs/node/pull/52870 |
| codebytere | https://github.com/codebytere |
|
Oct 28, 2024
| https://github.com/nodejs/node/pull/52870#ref-commit-f832fa9 |
|
| https://github.com/codebytere |
| build: add option to enable clang-cl on Windows | https://github.com/electron/electron/commit/f832fa96674ee538df226fc66f04a068ff8e2286 |
| f832fa9 | https://github.com/electron/electron/commit/f832fa96674ee538df226fc66f04a068ff8e2286 |
| nodejs/node#52870 | https://github.com/nodejs/node/pull/52870 |
| codebytere | https://github.com/codebytere |
|
Oct 29, 2024
| https://github.com/nodejs/node/pull/52870#ref-commit-835ef4a |
|
| https://github.com/codebytere |
| build: add option to enable clang-cl on Windows | https://github.com/electron/electron/commit/835ef4a01a138f62b657f66deaaf21f454e23b13 |
| 835ef4a | https://github.com/electron/electron/commit/835ef4a01a138f62b657f66deaaf21f454e23b13 |
| nodejs/node#52870 | https://github.com/nodejs/node/pull/52870 |
| codebytere | https://github.com/codebytere |
|
Oct 31, 2024
| https://github.com/nodejs/node/pull/52870#ref-commit-d9187c6 |
|
| https://github.com/codebytere |
| build: add option to enable clang-cl on Windows | https://github.com/electron/electron/commit/d9187c680cea1e7914664835095b663753560ed0 |
| d9187c6 | https://github.com/electron/electron/commit/d9187c680cea1e7914664835095b663753560ed0 |
| nodejs/node#52870 | https://github.com/nodejs/node/pull/52870 |
| jkleinsc | https://github.com/jkleinsc |
|
Nov 4, 2024
| https://github.com/nodejs/node/pull/52870#ref-commit-c63d0d6 |
|
| https://github.com/codebytere |
| chore: bump Node.js to v22.9.0 ( | https://github.com/electron/electron/commit/c63d0d61e71f12d29efb1df885a0883ae76bb164 |
| #44281 | https://github.com/electron/electron/pull/44281 |
| ) | https://github.com/electron/electron/commit/c63d0d61e71f12d29efb1df885a0883ae76bb164 |
| c63d0d6 | https://github.com/electron/electron/commit/c63d0d61e71f12d29efb1df885a0883ae76bb164 |
| nodejs/node#52856 | https://github.com/nodejs/node/pull/52856 |
| nodejs/node#50737 | https://github.com/nodejs/node/pull/50737 |
| nodejs/node#51344 | https://github.com/nodejs/node/pull/51344 |
| nodejs/node#50322 | https://github.com/nodejs/node/pull/50322 |
| nodejs-private/node-private#525 | https://github.com/nodejs-private/node-private/pull/525 |
| nodejs/node#54320 | https://github.com/nodejs/node/pull/54320 |
| nodejs/node#50234 | https://github.com/nodejs/node/pull/50234 |
| nodejs/node#54028 | https://github.com/nodejs/node/pull/54028 |
| nodejs/node#54775 | https://github.com/nodejs/node/pull/54775 |
| nodejs/node#47182 | https://github.com/nodejs/node/pull/47182 |
| nodejs/node#50650 | https://github.com/nodejs/node/pull/50650 |
| nodejs/node#53605 | https://github.com/nodejs/node/pull/53605 |
| nodejs/node#53822 | https://github.com/nodejs/node/pull/53822 |
| nodejs/node#49152 | https://github.com/nodejs/node/pull/49152 |
| nodejs/node#53656 | https://github.com/nodejs/node/pull/53656 |
| nodejs/node#52413 | https://github.com/nodejs/node/pull/52413 |
| nodejs/node#49639 | https://github.com/nodejs/node/pull/49639 |
| nodejs/node#49639 | https://github.com/nodejs/node/pull/49639 |
| nodejs/node#49639 | https://github.com/nodejs/node/pull/49639 |
| nodejs/node#50115 | https://github.com/nodejs/node/pull/50115 |
| nodejs/node#50650 | https://github.com/nodejs/node/pull/50650 |
| nodejs/node#50115 | https://github.com/nodejs/node/pull/50115 |
| nodejs/node#51362 | https://github.com/nodejs/node/pull/51362 |
| nodejs/node#51362 | https://github.com/nodejs/node/pull/51362 |
| nodejs/node#51362 | https://github.com/nodejs/node/pull/51362 |
| nodejs/node#50115 | https://github.com/nodejs/node/pull/50115 |
| nodejs/node#52996 | https://github.com/nodejs/node/pull/52996 |
| nodejs/node#53084 | https://github.com/nodejs/node/pull/53084 |
| nodejs/node#53084 | https://github.com/nodejs/node/pull/53084 |
| nodejs/node#53174 | https://github.com/nodejs/node/pull/53174 |
| nodejs/node#52745 | https://github.com/nodejs/node/pull/52745 |
| nodejs/node#51362 | https://github.com/nodejs/node/pull/51362 |
| nodejs/node#51999 | https://github.com/nodejs/node/pull/51999 |
| nodejs/node#54375 | https://github.com/nodejs/node/pull/54375 |
| nodejs/node#52177 | https://github.com/nodejs/node/pull/52177 |
| nodejs/node#53540 | https://github.com/nodejs/node/pull/53540 |
| nodejs/node#50115 | https://github.com/nodejs/node/pull/50115 |
| nodejs/node#52870 | https://github.com/nodejs/node/pull/52870 |
| nodejs/node#54890 | https://github.com/nodejs/node/pull/54890 |
| nodejs/node#52838 | https://github.com/nodejs/node/pull/52838 |
| nodejs/node#52966 | https://github.com/nodejs/node/pull/52966 |
| nodejs/node#51783 | https://github.com/nodejs/node/pull/51783 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| nodejs/node#52435 | https://github.com/nodejs/node/pull/52435 |
| nodejs/node#52609 | https://github.com/nodejs/node/pull/52609 |
| nodejs/node#54077 | https://github.com/nodejs/node/pull/54077 |
| nodejs/node#48325 | https://github.com/nodejs/node/pull/48325 |
| nodejs/node#54459 | https://github.com/nodejs/node/pull/54459 |
| nodejs/node#54320 | https://github.com/nodejs/node/pull/54320 |
| https://chromium-review.googlesource.com/c/v8/v8/+/5507047 | https://chromium-review.googlesource.com/c/v8/v8/+/5507047 |
| nodejs/node#54459 | https://github.com/nodejs/node/pull/54459 |
| nodejs/node#53656 | https://github.com/nodejs/node/pull/53656 |
| nodejs/node#54553 | https://github.com/nodejs/node/pull/54553 |
| nodejs/node#48528 | https://github.com/nodejs/node/pull/48528 |
| nodejs/node#52213 | https://github.com/nodejs/node/pull/52213 |
| nodejs/node#53592 | https://github.com/nodejs/node/pull/53592 |
| nodejs/node#50322 | https://github.com/nodejs/node/pull/50322 |
| nodejs/node#55584 | https://github.com/nodejs/node/issues/55584 |
| libuv/libuv#4341 | https://github.com/libuv/libuv/pull/4341 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52870 |
|
| https://github.com/lemire |
|
lemire
| https://github.com/lemire |
|
| https://github.com/nodejs/node/pull/52870/files/26b2f986a94adeceff5f55aae9c6cc6c6d81e914 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/52870/files/a8c4ac2f4f249ad36ef8bad126514933420d8f35 |
|
| https://github.com/StefanStojanovic |
|
StefanStojanovic
| https://github.com/StefanStojanovic |
|
| https://github.com/nodejs/node/pull/52870/files/26b2f986a94adeceff5f55aae9c6cc6c6d81e914 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
dont-land-on-v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Please reload this page | https://github.com/nodejs/node/pull/52870 |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/StefanStojanovic |
|
| https://github.com/lemire |
|
| https://github.com/lpinca |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |