| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:534a853c-092c-c81f-1ff7-d1fbbcedba08 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9BAA:3CF4F9:B7C15E:1079AE7:6A4E47AF |
| html-safe-nonce | 5af7291e523c55561b34233e06df1431ecbb49364da58604d425050ff8698b57 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkFBOjNDRjRGOTpCN0MxNUU6MTA3OUFFNzo2QTRFNDdBRiIsInZpc2l0b3JfaWQiOiI0Mzk1MjQwMjgwMDQwNTU2NDYzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8590f288188a573066c53ec307d50c5e20fb3179b298b07eaf2d74866fc00eec |
| hovercard-subject-tag | pull_request:1842856088 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/52706/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d37f2caceff15f98ffd256b86475e871e5e24feb08c72983a08f6e7695e439b9/nodejs/node/pull/52706 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d37f2caceff15f98ffd256b86475e871e5e24feb08c72983a08f6e7695e439b9/nodejs/node/pull/52706 |
| og:image:alt | This implements reusing the single esm loader hooks thread for all the subsequent workers.
It started as a trial to solve the test contributed by @GeoffreyBooth from #50752. The test content is tak... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dygabo |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e8506f6d0538364886e3f0153c154c410965e70d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/52706#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52706 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52706 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/52706 |
| Reload | https://github.com/nodejs/node/pull/52706 |
| Reload | https://github.com/nodejs/node/pull/52706 |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
964
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| dygabo:spawn-only-one-loader-thread | https://github.com/dygabo/node/tree/spawn-only-one-loader-thread |
| Conversation | https://github.com/nodejs/node/pull/52706 |
| Commits13 (13) | https://github.com/nodejs/node/pull/52706/commits |
| Checks | https://github.com/nodejs/node/pull/52706/checks |
| Files changed | https://github.com/nodejs/node/pull/52706/files |
| module: have a single hooks thread for all workers | https://github.com/nodejs/node/pull/52706#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| dygabo:spawn-only-one-loader-thread | https://github.com/dygabo/node/tree/spawn-only-one-loader-thread |
|
| https://github.com/dygabo |
| dygabo | https://github.com/dygabo |
| Apr 26, 2024 | https://github.com/nodejs/node/pull/52706#issue-2265783188 |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| @GeoffreyBooth | https://github.com/GeoffreyBooth |
| #50752 | https://github.com/nodejs/node/pull/50752 |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 26, 2024 | https://github.com/nodejs/node/pull/52706#issuecomment-2079389726 |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Apr 26, 2024 | https://github.com/nodejs/node/pull/52706#event-12623837420 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
|
module
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule |
|
loaders
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders |
| Apr 26, 2024 | https://github.com/nodejs/node/pull/52706#event-12623907764 |
| https://github.com/dygabo |
| dygabo | https://github.com/dygabo |
| force-pushed | https://github.com/nodejs/node/compare/1025b034f7d35cdee10eb95a644d474dc1284f05..fa24d02ca9dc0ade1037dffeb7faf360ca110be4 |
| 1025b03 | https://github.com/nodejs/node/commit/1025b034f7d35cdee10eb95a644d474dc1284f05 |
| fa24d02 | https://github.com/nodejs/node/commit/fa24d02ca9dc0ade1037dffeb7faf360ca110be4 |
|
Compare
| https://github.com/nodejs/node/compare/1025b034f7d35cdee10eb95a644d474dc1284f05..fa24d02ca9dc0ade1037dffeb7faf360ca110be4 |
| April 26, 2024 14:03 | https://github.com/nodejs/node/pull/52706#event-12624335255 |
| https://github.com/dygabo |
| dygabo | https://github.com/dygabo |
| April 26, 2024 14:08 | https://github.com/nodejs/node/pull/52706#event-12624392455 |
| https://github.com/dygabo |
| dygabo | https://github.com/dygabo |
| force-pushed | https://github.com/nodejs/node/compare/fa24d02ca9dc0ade1037dffeb7faf360ca110be4..ee16c1762c911eb43d0905b91a127e1accc1d18a |
| fa24d02 | https://github.com/nodejs/node/commit/fa24d02ca9dc0ade1037dffeb7faf360ca110be4 |
| ee16c17 | https://github.com/nodejs/node/commit/ee16c1762c911eb43d0905b91a127e1accc1d18a |
|
Compare
| https://github.com/nodejs/node/compare/fa24d02ca9dc0ade1037dffeb7faf360ca110be4..ee16c1762c911eb43d0905b91a127e1accc1d18a |
| April 26, 2024 14:21 | https://github.com/nodejs/node/pull/52706#event-12624552000 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Apr 26, 2024 | https://github.com/nodejs/node/pull/52706#issuecomment-2079514032 |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
Apr 26, 2024
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2025361284 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52706/files |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2025361284 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| lib/internal/modules/esm/loader.js | https://github.com/nodejs/node/pull/52706/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| April 26, 2024 15:50 | https://github.com/nodejs/node/pull/52706#event-12625669390 |
| https://github.com/dygabo |
| dygabo | https://github.com/dygabo |
| force-pushed | https://github.com/nodejs/node/compare/03f69a8c78a058918a57376c3d87280cd04f51ae..2fdf7b339c3098bc4489403952125b99d43581a8 |
| 03f69a8 | https://github.com/nodejs/node/commit/03f69a8c78a058918a57376c3d87280cd04f51ae |
| 2fdf7b3 | https://github.com/nodejs/node/commit/2fdf7b339c3098bc4489403952125b99d43581a8 |
|
Compare
| https://github.com/nodejs/node/compare/03f69a8c78a058918a57376c3d87280cd04f51ae..2fdf7b339c3098bc4489403952125b99d43581a8 |
| April 27, 2024 04:57 | https://github.com/nodejs/node/pull/52706#event-12630057853 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
Apr 27, 2024
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2026616293 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52706/files |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2026616293 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @dygabo | https://github.com/dygabo |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| lib/internal/modules/esm/hooks.js | https://github.com/nodejs/node/pull/52706/files#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| lib/internal/modules/esm/hooks.js | https://github.com/nodejs/node/pull/52706/files#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| lib/internal/modules/esm/hooks.js | https://github.com/nodejs/node/pull/52706/files#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| lib/internal/modules/esm/hooks.js | https://github.com/nodejs/node/pull/52706/files#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| lib/internal/modules/esm/hooks.js | https://github.com/nodejs/node/pull/52706/files#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| lib/internal/modules/esm/worker.js | https://github.com/nodejs/node/pull/52706/files#diff-b38c96b1c95d7c90430c8ea8f248ad3d49098a2e000bac8b4ee91cdde79cb25b |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| lib/internal/worker.js | https://github.com/nodejs/node/pull/52706/files#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564 |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| lib/internal/worker.js | https://github.com/nodejs/node/pull/52706/files#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564 |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| lib/internal/worker.js | https://github.com/nodejs/node/pull/52706/files#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564 |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| lib/internal/worker.js | https://github.com/nodejs/node/pull/52706/files#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564 |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Apr 27, 2024
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2026620084 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52706/files |
| lib/internal/modules/esm/worker.js | https://github.com/nodejs/node/pull/52706/files#diff-b38c96b1c95d7c90430c8ea8f248ad3d49098a2e000bac8b4ee91cdde79cb25b |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Apr 27, 2024
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2026620192 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52706/files |
| lib/internal/modules/esm/worker.js | https://github.com/nodejs/node/pull/52706/files#diff-b38c96b1c95d7c90430c8ea8f248ad3d49098a2e000bac8b4ee91cdde79cb25b |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Apr 27, 2024
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2026620782 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52706/files |
| lib/internal/modules/esm/hooks.js | https://github.com/nodejs/node/pull/52706/files#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Apr 27, 2024
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2026620814 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52706/files |
| lib/internal/modules/esm/hooks.js | https://github.com/nodejs/node/pull/52706/files#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/dygabo |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52706 |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
Apr 27, 2024
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2026747841 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52706/files |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2026747841 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Apr 27, 2024
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2026755507 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52706/files |
| lib/internal/modules/esm/worker.js | https://github.com/nodejs/node/pull/52706/files#diff-b38c96b1c95d7c90430c8ea8f248ad3d49098a2e000bac8b4ee91cdde79cb25b |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/dygabo |
| dygabo | https://github.com/dygabo |
| Apr 29, 2024 | https://github.com/nodejs/node/pull/52706#issuecomment-2082461521 |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/dygabo |
| dygabo | https://github.com/dygabo |
| force-pushed | https://github.com/nodejs/node/compare/bb59bc87cedbad9595a6f63b4d6a36c7195225ce..7f86cdeafd3369da3f60e91b9f544d045fbbe58e |
| bb59bc8 | https://github.com/nodejs/node/commit/bb59bc87cedbad9595a6f63b4d6a36c7195225ce |
| 7f86cde | https://github.com/nodejs/node/commit/7f86cdeafd3369da3f60e91b9f544d045fbbe58e |
|
Compare
| https://github.com/nodejs/node/compare/bb59bc87cedbad9595a6f63b4d6a36c7195225ce..7f86cdeafd3369da3f60e91b9f544d045fbbe58e |
| April 29, 2024 11:22 | https://github.com/nodejs/node/pull/52706#event-12641489359 |
| https://github.com/dygabo |
| dygabo | https://github.com/dygabo |
| Apr 29, 2024 | https://github.com/nodejs/node/pull/52706#event-12641496416 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
|
Apr 29, 2024
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2028135849 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52706/files |
| lib/internal/worker.js | https://github.com/nodejs/node/pull/52706/files#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564 |
| Flarna | https://github.com/Flarna |
| Apr 29, 2024 | https://github.com/nodejs/node/pull/52706#discussion_r1582874064 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Apr 29, 2024 | https://github.com/nodejs/node/pull/52706#discussion_r1582898608 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| lib/internal/modules/esm/worker.js | https://github.com/nodejs/node/pull/52706/files#diff-b38c96b1c95d7c90430c8ea8f248ad3d49098a2e000bac8b4ee91cdde79cb25b |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| lib/internal/modules/esm/worker.js | https://github.com/nodejs/node/pull/52706/files#diff-b38c96b1c95d7c90430c8ea8f248ad3d49098a2e000bac8b4ee91cdde79cb25b |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
|
Apr 29, 2024
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2028716647 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52706/files |
| lib/internal/modules/esm/hooks.js | https://github.com/nodejs/node/pull/52706/files#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/bmeck |
| bmeck | https://github.com/bmeck |
|
Apr 30, 2024
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2031395331 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52706/files |
| lib/internal/modules/esm/worker.js | https://github.com/nodejs/node/pull/52706/files#diff-b38c96b1c95d7c90430c8ea8f248ad3d49098a2e000bac8b4ee91cdde79cb25b |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/bmeck |
| bmeck | https://github.com/bmeck |
|
Apr 30, 2024
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2031404187 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52706/files |
| bmeck | https://github.com/bmeck |
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2031404187 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Apr 30, 2024 | https://github.com/nodejs/node/pull/52706#event-12659163132 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
|
Apr 30, 2024
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2031584820 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52706/files |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Apr 30, 2024 | https://github.com/nodejs/node/pull/52706#event-12659197722 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| May 8, 2024 | https://github.com/nodejs/node/pull/52706#event-12737240581 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| May 8, 2024 | https://github.com/nodejs/node/pull/52706#event-12737255280 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 8, 2024 | https://github.com/nodejs/node/pull/52706#issuecomment-2099593468 |
| https://github.com/nodejs/node/actions/runs/8995057971 | https://github.com/nodejs/node/actions/runs/8995057971 |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
May 8, 2024
| https://github.com/nodejs/node/pull/52706#pullrequestreview-2044490952 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52706/files/76599010882d6f66162db882d442d5b15e7d4cab |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
|
commit-queue-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed |
| May 8, 2024 | https://github.com/nodejs/node/pull/52706#event-12737305537 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| May 8, 2024 | https://github.com/nodejs/node/pull/52706#event-12737374690 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| 22cb99d | https://github.com/nodejs/node/commit/22cb99d073b03414e33843550cca3bac2833a361 |
| May 8, 2024 | https://github.com/nodejs/node/pull/52706#event-12737375003 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 8, 2024 | https://github.com/nodejs/node/pull/52706#issuecomment-2099611604 |
| 22cb99d | https://github.com/nodejs/node/commit/22cb99d073b03414e33843550cca3bac2833a361 |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/dygabo |
| dygabo | https://github.com/dygabo |
| May 8, 2024 04:13 | https://github.com/nodejs/node/pull/52706#event-12737952579 |
| targos | https://github.com/targos |
|
May 8, 2024
| https://github.com/nodejs/node/pull/52706#ref-commit-8fbf662 |
|
| https://github.com/dygabo |
|
| https://github.com/targos |
| module: have a single hooks thread for all workers | https://github.com/nodejs/node/commit/8fbf6628d629ce217366e8ac375f84f5d17d5efe |
| 8fbf662 | https://github.com/nodejs/node/commit/8fbf6628d629ce217366e8ac375f84f5d17d5efe |
| #52706 | https://github.com/nodejs/node/pull/52706 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 13, 2024
| https://github.com/nodejs/node/pull/52706#ref-pullrequest-2293520693 |
|
v22.2.0 release proposal
#52971
| https://github.com/nodejs/node/pull/52971 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
May 14, 2024
| https://github.com/nodejs/node/pull/52706#ref-issue-1686948525 |
|
ESM loaders cannot be defined via Worker option execArgv in v20
#47747
| https://github.com/nodejs/node/issues/47747 |
| https://github.com/dygabo |
| dygabo | https://github.com/dygabo |
|
May 15, 2024
| https://github.com/nodejs/node/pull/52706#ref-pullrequest-2298090127 |
|
doc: clarify options for single customization hooks thread
#53006
| https://github.com/nodejs/node/pull/53006 |
|
esm: spawn only one hooks thread
#50752
| https://github.com/nodejs/node/pull/50752 |
|
ESM Hook deadlocks since 21.2.0 a3e09b3
#50948
| https://github.com/nodejs/node/issues/50948 |
| https://github.com/alan-agius4 |
| alan-agius4 | https://github.com/alan-agius4 |
|
May 22, 2024
| https://github.com/nodejs/node/pull/52706#ref-issue-2310003736 |
|
ESM loader hooks in Workers no longer working since Node.js 22.2
#53097
| https://github.com/nodejs/node/issues/53097 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
|
May 28, 2024
| https://github.com/nodejs/node/pull/52706#ref-issue-2320452188 |
|
Module Hooks cannot be registered from worker thread in 22.2.0+
#53182
| https://github.com/nodejs/node/issues/53182 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
May 28, 2024
| https://github.com/nodejs/node/pull/52706#ref-pullrequest-2320537486 |
|
Revert "module: have a single hooks thread for all workers"
#53183
| https://github.com/nodejs/node/pull/53183 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
dont-land-on-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v18.x |
| May 28, 2024 | https://github.com/nodejs/node/pull/52706#event-12954471437 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| May 28, 2024 | https://github.com/nodejs/node/pull/52706#issuecomment-2134740124 |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
| https://github.com/alan-agius4 |
| alan-agius4 | https://github.com/alan-agius4 |
|
May 29, 2024
| https://github.com/nodejs/node/pull/52706#ref-issue-2322742053 |
|
Support registering worker specific custom ESM loader hooks (Regression from #52706)
#53195
| https://github.com/nodejs/node/issues/53195 |
| https://github.com/dygabo |
| dygabo | https://github.com/dygabo |
|
May 30, 2024
| https://github.com/nodejs/node/pull/52706#ref-pullrequest-2323392649 |
|
module: allow module.register from workers
#53200
| https://github.com/nodejs/node/pull/53200 |
|
Module customization hooks and worker threads
nodejs/TSC#1566
| https://github.com/nodejs/TSC/issues/1566 |
|
Release plan - v22.x Maintenance LTS
nodejs/Release#1001
| https://github.com/nodejs/Release/issues/1001 |
| https://github.com/dygabo |
| dygabo | https://github.com/dygabo |
| June 3, 2024 16:40 | https://github.com/nodejs/node/pull/52706#event-13024127234 |
| soophoo | https://github.com/soophoo |
|
Jun 20, 2024
| https://github.com/nodejs/node/pull/52706#ref-commit-8c1b6ff |
|
| https://github.com/dygabo |
|
| https://github.com/soophoo |
| module: have a single hooks thread for all workers | https://github.com/soophoo/node/commit/8c1b6ff28af3c3cad07d2e6cf5f447fd3013d7c7 |
| 8c1b6ff | https://github.com/soophoo/node/commit/8c1b6ff28af3c3cad07d2e6cf5f447fd3013d7c7 |
| nodejs#52706 | https://github.com/nodejs/node/pull/52706 |
| bmeck | https://github.com/bmeck |
|
Jun 22, 2024
| https://github.com/nodejs/node/pull/52706#ref-commit-1fa75f7 |
|
| https://github.com/dygabo |
|
| https://github.com/bmeck |
| module: have a single hooks thread for all workers | https://github.com/bmeck/node/commit/1fa75f759972eff66122833343714949f5592641 |
| 1fa75f7 | https://github.com/bmeck/node/commit/1fa75f759972eff66122833343714949f5592641 |
| nodejs#52706 | https://github.com/nodejs/node/pull/52706 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52706 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/52706/files/2fdf7b339c3098bc4489403952125b99d43581a8 |
|
| https://github.com/JakobJingleheimer |
|
JakobJingleheimer
| https://github.com/JakobJingleheimer |
|
| https://github.com/nodejs/node/pull/52706/files/7f86cdeafd3369da3f60e91b9f544d045fbbe58e |
|
| https://github.com/GeoffreyBooth |
|
GeoffreyBooth
| https://github.com/GeoffreyBooth |
|
| https://github.com/nodejs/node/pull/52706/files/76599010882d6f66162db882d442d5b15e7d4cab |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/52706/files/3bd737579f48dfd2a1e8282b8e1ad43e9c237d9a |
|
| https://github.com/Flarna |
|
Flarna
| https://github.com/Flarna |
|
| https://github.com/nodejs/node/pull/52706/files/698e337c7f8d82778484c48e27d7d0a591c8a39c |
|
| https://github.com/bmeck |
|
bmeck
| https://github.com/bmeck |
|
| https://github.com/nodejs/node/pull/52706/files/443c42797e9fdfd9379a67992896690d3be84753 |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
loaders
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders |
|
module
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Please reload this page | https://github.com/nodejs/node/pull/52706 |
|
| https://github.com/dygabo |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/targos |
|
| https://github.com/Flarna |
|
| https://github.com/aduh95 |
|
| https://github.com/mcollina |
|
| https://github.com/bmeck |
|
| https://github.com/GeoffreyBooth |
|
| https://github.com/benjamingr |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |