René's URL Explorer Experiment


Title: src: remove misplaced windows code under posix guard in node.cc by thisalihassan · Pull Request #52545 · nodejs/node · GitHub

Open Graph Title: src: remove misplaced windows code under posix guard in node.cc by thisalihassan · Pull Request #52545 · nodejs/node

X Title: src: remove misplaced windows code under posix guard in node.cc by thisalihassan · Pull Request #52545 · nodejs/node

Description: The V8 WebAssembly trap handler setup for Windows was incorrectly nested within a POSIX conditional compilation block in src/node.cc. This caused the related functions to be effectively non-operational on Windows. The changes involve removing the Windows-specific code from the POSIX section and correctly placing it under the WIN32 check. Fixes: #52404 Refs: #35033

Open Graph Description: The V8 WebAssembly trap handler setup for Windows was incorrectly nested within a POSIX conditional compilation block in src/node.cc. This caused the related functions to be effectively non-operati...

X Description: The V8 WebAssembly trap handler setup for Windows was incorrectly nested within a POSIX conditional compilation block in src/node.cc. This caused the related functions to be effectively non-operati...

Opengraph URL: https://github.com/nodejs/node/pull/52545

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bb4febd4-b609-13d9-ce9c-11877c93b677
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD96:AD997:563C54:6D2264:6B034E79
html-safe-nonce88b3e06db591ddda433213a0dff55c1afe73d90a02eec8eb7131b5171f216d1a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDk2OkFEOTk3OjU2M0M1NDo2RDIyNjQ6NkIwMzRFNzkiLCJ2aXNpdG9yX2lkIjoiODU5NDQ1NjE4NTA0MDc1MjI0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac26c6e8ae1f4b8c045f50bbd3a2dabd2780d3f492c7608394ca5c83a73b70fddf
hovercard-subject-tagpull_request:1823946836
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/52545/files
twitter:imagehttps://avatars.githubusercontent.com/u/24819103?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/24819103?s=400&v=4
og:image:altThe V8 WebAssembly trap handler setup for Windows was incorrectly nested within a POSIX conditional compilation block in src/node.cc. This caused the related functions to be effectively non-operati...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/52545/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52545%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52545%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/52545/files
Reloadhttps://github.com/nodejs/node/pull/52545/files
Reloadhttps://github.com/nodejs/node/pull/52545/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
thisalihassanhttps://github.com/thisalihassan
nodejs:mainhttps://github.com/nodejs/node/tree/main
thisalihassan:fix-misplace-win-from-posixhttps://github.com/thisalihassan/node/tree/fix-misplace-win-from-posix
Conversation 18 https://github.com/nodejs/node/pull/52545
Commits 5 https://github.com/nodejs/node/pull/52545/commits
Checks 0 https://github.com/nodejs/node/pull/52545/checks
Files changed https://github.com/nodejs/node/pull/52545/files
Please reload this pagehttps://github.com/nodejs/node/pull/52545/files
src: remove misplaced windows code under posix guard in node.cc https://github.com/nodejs/node/pull/52545/files#top
Show all changes 5 commits https://github.com/nodejs/node/pull/52545/files
2b3d7b0 src: remove misplaced windows code under posix guard in node.cc thisalihassan Apr 15, 2024 https://github.com/nodejs/node/pull/52545/commits/2b3d7b0da2bd00d0503d9031aec70a7a3bbd41ef
ce83aae src: format src/node thisalihassan Apr 15, 2024 https://github.com/nodejs/node/pull/52545/commits/ce83aae50b3f7a18ec7152dc80f7e7a6d950cfe7
c3166e8 src: resolve feedback thisalihassan Apr 19, 2024 https://github.com/nodejs/node/pull/52545/commits/c3166e818a7e5ac747a34c37736aa28a1c3337ab
e16d6f0 src: resolve feedback thisalihassan Apr 19, 2024 https://github.com/nodejs/node/pull/52545/commits/e16d6f01a90799bc6c18c9d3ae9662b1c1227584
2c68fcd src: fix build error on win thisalihassan Apr 22, 2024 https://github.com/nodejs/node/pull/52545/commits/2c68fcdc722f387898a8a0be145351fb54b104ed
Clear filters https://github.com/nodejs/node/pull/52545/files
Please reload this pagehttps://github.com/nodejs/node/pull/52545/files
Please reload this pagehttps://github.com/nodejs/node/pull/52545/files
src/node.cchttps://github.com/nodejs/node/pull/52545/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
View file https://github.com/thisalihassan/node/blob/2c68fcdc722f387898a8a0be145351fb54b104ed/src/node.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/52545/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/52545/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
https://github.com/nodejs/node/pull/52545/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
https://github.com/nodejs/node/pull/52545/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
https://github.com/nodejs/node/pull/52545/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
https://github.com/nodejs/node/pull/52545/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
https://github.com/nodejs/node/pull/52545/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
Please reload this pagehttps://github.com/nodejs/node/pull/52545/files
Please reload this pagehttps://github.com/nodejs/node/pull/52545/files
https://github.com/nodejs/node/pull/52545/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.