René's URL Explorer Experiment


Title: test: eval a strict function by kthelgason · Pull Request #5250 · nodejs/node · GitHub

Open Graph Title: test: eval a strict function by kthelgason · Pull Request #5250 · nodejs/node

X Title: test: eval a strict function by kthelgason · Pull Request #5250 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This PR adds a regression test for the bug mentioned in #2245 where when a strict function is evaled it would not capture it's context.

X Description: This PR adds a regression test for the bug mentioned in #2245 where when a strict function is evaled it would not capture it's context.

Opengraph URL: https://github.com/nodejs/node/pull/5250

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:76bbb196-522e-f3b3-d6e7-a6e4cd6c837b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE14:1EE1:46916F:5DCCCA:6A4EECA4
html-safe-nonce9e3085b9d2b97c9da27ef5db5414a9f0ef2f4feae2513ac28e4f3af1a1bfa5f4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTE0OjFFRTE6NDY5MTZGOjVEQ0NDQTo2QTRFRUNBNCIsInZpc2l0b3JfaWQiOiIzMDc0ODMxNDQ5MDc0ODg3ODQ0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac08e11fc038138f7a7862b105422f29dc455fe4551d795d8f9ca8fbf5b9593a8b
hovercard-subject-tagpull_request:59423266
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/5250/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a4a5de6756e7469422d6621706487c26207c8ebb68d5622904a63ee6c2ec2457/nodejs/node/pull/5250
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a4a5de6756e7469422d6621706487c26207c8ebb68d5622904a63ee6c2ec2457/nodejs/node/pull/5250
og:image:altThis PR adds a regression test for the bug mentioned in #2245 where when a strict function is evaled it would not capture it's context.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekthelgason
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release00d04d6b867d2f16ab50bebae8ccc56e07c8988b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/5250#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5250
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5250
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/5250
Reloadhttps://github.com/nodejs/node/pull/5250
Reloadhttps://github.com/nodejs/node/pull/5250
Please reload this pagehttps://github.com/nodejs/node/pull/5250
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/5250
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
kthelgasonhttps://github.com/kthelgason
nodejs:masterhttps://github.com/nodejs/node/tree/master
kthelgason:regr-test-eval-stricthttps://github.com/kthelgason/node/tree/regr-test-eval-strict
Conversationhttps://github.com/nodejs/node/pull/5250
Commits1 (1)https://github.com/nodejs/node/pull/5250/commits
Checkshttps://github.com/nodejs/node/pull/5250/checks
Files changedhttps://github.com/nodejs/node/pull/5250/files
test: eval a strict functionhttps://github.com/nodejs/node/pull/5250#top
kthelgasonhttps://github.com/kthelgason
nodejs:masterhttps://github.com/nodejs/node/tree/master
kthelgason:regr-test-eval-stricthttps://github.com/kthelgason/node/tree/regr-test-eval-strict
https://github.com/kthelgason
kthelgasonhttps://github.com/kthelgason
Feb 15, 2016https://github.com/nodejs/node/pull/5250#issue-133837964
#2245https://github.com/nodejs/node/issues/2245
Please reload this pagehttps://github.com/nodejs/node/pull/5250
https://github.com/mscdex
mscdexhttps://github.com/mscdex
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Feb 15, 2016https://github.com/nodejs/node/pull/5250#event-551323278
https://github.com/Trott
Trotthttps://github.com/Trott
Feb 16, 2016https://github.com/nodejs/node/pull/5250#issuecomment-184531932
Please reload this pagehttps://github.com/nodejs/node/pull/5250
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Feb 16, 2016https://github.com/nodejs/node/pull/5250#issuecomment-184532677
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/5250
https://github.com/Trott
Trotthttps://github.com/Trott
Feb 16, 2016https://github.com/nodejs/node/pull/5250#issuecomment-184534119
@thefourtheyehttps://github.com/thefourtheye
Please reload this pagehttps://github.com/nodejs/node/pull/5250
https://github.com/kthelgason
kthelgasonhttps://github.com/kthelgason
Feb 16, 2016https://github.com/nodejs/node/pull/5250#issuecomment-184595883
@Trotthttps://github.com/Trott
@thefourtheyehttps://github.com/thefourtheye
Please reload this pagehttps://github.com/nodejs/node/pull/5250
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Feb 16, 2016https://github.com/nodejs/node/pull/5250#issuecomment-184600667
@kthelgasonhttps://github.com/kthelgason
Please reload this pagehttps://github.com/nodejs/node/pull/5250
https://github.com/kthelgason
test: eval a strict functionhttps://github.com/nodejs/node/pull/5250/commits/cd5b3fc7c8326bf575a9d35cadc5477de503e97a
cd5b3fchttps://github.com/nodejs/node/pull/5250/commits/cd5b3fc7c8326bf575a9d35cadc5477de503e97a
https://github.com/kthelgason
kthelgasonhttps://github.com/kthelgason
force-pushedhttps://github.com/nodejs/node/compare/f7ea0f9907df5f832d0304f0c70655b3bed876a1..cd5b3fc7c8326bf575a9d35cadc5477de503e97a
f7ea0f9https://github.com/nodejs/node/commit/f7ea0f9907df5f832d0304f0c70655b3bed876a1
cd5b3fchttps://github.com/nodejs/node/commit/cd5b3fc7c8326bf575a9d35cadc5477de503e97a
Compare https://github.com/nodejs/node/compare/f7ea0f9907df5f832d0304f0c70655b3bed876a1..cd5b3fc7c8326bf575a9d35cadc5477de503e97a
February 16, 2016 14:09https://github.com/nodejs/node/pull/5250#event-552064412
https://github.com/kthelgason
kthelgasonhttps://github.com/kthelgason
Feb 16, 2016https://github.com/nodejs/node/pull/5250#issuecomment-184695359
@thefourtheyehttps://github.com/thefourtheye
Please reload this pagehttps://github.com/nodejs/node/pull/5250
thefourtheyehttps://github.com/thefourtheye
Feb 16, 2016 https://github.com/nodejs/node/pull/5250#discussion-diff-53014756
View reviewed changes https://github.com/nodejs/node/pull/5250/files/cd5b3fc7c8326bf575a9d35cadc5477de503e97a#diff-8b5f99eb08d87ab604b8db0dbbcad6275ed3f40d7ed0698a0cdf814dd608851f
test/parallel/test-regress-GH-2245.jshttps://github.com/nodejs/node/pull/5250/files#diff-8b5f99eb08d87ab604b8db0dbbcad6275ed3f40d7ed0698a0cdf814dd608851f
thefourtheyehttps://github.com/thefourtheye
Feb 16, 2016https://github.com/nodejs/node/pull/5250#discussion_r53014756
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5250
kthelgasonhttps://github.com/kthelgason
Feb 16, 2016https://github.com/nodejs/node/pull/5250#discussion_r53015084
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5250
targoshttps://github.com/targos
Feb 16, 2016https://github.com/nodejs/node/pull/5250#discussion_r53015583
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5250
kthelgasonhttps://github.com/kthelgason
Feb 16, 2016https://github.com/nodejs/node/pull/5250#discussion_r53016560
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5250
targoshttps://github.com/targos
Feb 16, 2016https://github.com/nodejs/node/pull/5250#discussion_r53018025
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5250
https://github.com/Trott
Trotthttps://github.com/Trott
Feb 16, 2016https://github.com/nodejs/node/pull/5250#issuecomment-184714936
Please reload this pagehttps://github.com/nodejs/node/pull/5250
https://github.com/kthelgason
kthelgasonhttps://github.com/kthelgason
Feb 16, 2016https://github.com/nodejs/node/pull/5250#issuecomment-184716598
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/5250
https://github.com/Trott
Trotthttps://github.com/Trott
Feb 16, 2016https://github.com/nodejs/node/pull/5250#issuecomment-184716923
@kthelgasonhttps://github.com/kthelgason
Please reload this pagehttps://github.com/nodejs/node/pull/5250
https://github.com/kthelgason
kthelgasonhttps://github.com/kthelgason
Mar 12, 2016https://github.com/nodejs/node/pull/5250#issuecomment-195816796
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/5250
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 12, 2016https://github.com/nodejs/node/pull/5250#issuecomment-195821445
Please reload this pagehttps://github.com/nodejs/node/pull/5250
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Mar 13, 2016https://github.com/nodejs/node/pull/5250#issuecomment-195906547
https://ci.nodejs.org/job/node-test-pull-request/1912/https://ci.nodejs.org/job/node-test-pull-request/1912/
Please reload this pagehttps://github.com/nodejs/node/pull/5250
https://github.com/jasnell
jasnellhttps://github.com/jasnell
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Mar 14, 2016https://github.com/nodejs/node/pull/5250#event-588869327
jasnellhttps://github.com/jasnell
Mar 14, 2016 https://github.com/nodejs/node/pull/5250#ref-commit-25eedf0
https://github.com/kthelgason
https://github.com/jasnell
test: eval a strict functionhttps://github.com/nodejs/node/commit/25eedf02a85bf3cac25f8f9b2c38d91969f52fcd
25eedf0https://github.com/nodejs/node/commit/25eedf02a85bf3cac25f8f9b2c38d91969f52fcd
#5250https://github.com/nodejs/node/pull/5250
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 14, 2016https://github.com/nodejs/node/pull/5250#issuecomment-196366028
25eedf0https://github.com/nodejs/node/commit/25eedf02a85bf3cac25f8f9b2c38d91969f52fcd
Please reload this pagehttps://github.com/nodejs/node/pull/5250
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 14, 2016https://github.com/nodejs/node/pull/5250#event-588869764
https://github.com/kthelgason
kthelgasonhttps://github.com/kthelgason
March 14, 2016 15:49https://github.com/nodejs/node/pull/5250#event-588912420
evanlucashttps://github.com/evanlucas
Mar 14, 2016 https://github.com/nodejs/node/pull/5250#ref-commit-1235176
https://github.com/kthelgason
https://github.com/evanlucas
test: eval a strict functionhttps://github.com/nodejs/node/commit/12351762c1e736047bc740a6ce6521b0e8c18720
1235176https://github.com/nodejs/node/commit/12351762c1e736047bc740a6ce6521b0e8c18720
#5250https://github.com/nodejs/node/pull/5250
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Mar 14, 2016 https://github.com/nodejs/node/pull/5250#ref-pullrequest-140754096
v5.9.0 proposal #5702 https://github.com/nodejs/node/pull/5702
rvagghttps://github.com/rvagg
Mar 16, 2016 https://github.com/nodejs/node/pull/5250#ref-commit-cceae5a
https://github.com/kthelgason
https://github.com/rvagg
test: eval a strict functionhttps://github.com/nodejs/node/commit/cceae5ae788d79879db502e091a6ae631e97a9e4
cceae5ahttps://github.com/nodejs/node/commit/cceae5ae788d79879db502e091a6ae631e97a9e4
#5250https://github.com/nodejs/node/pull/5250
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Mar 21, 2016https://github.com/nodejs/node/pull/5250#event-597639766
MylesBorinshttps://github.com/MylesBorins
Mar 21, 2016 https://github.com/nodejs/node/pull/5250#ref-commit-8c682a3
https://github.com/kthelgason
test: eval a strict functionhttps://github.com/nodejs/node/commit/8c682a39824521b78f84ff67b88ce2c7f5cfbe20
8c682a3https://github.com/nodejs/node/commit/8c682a39824521b78f84ff67b88ce2c7f5cfbe20
#5250https://github.com/nodejs/node/pull/5250
MylesBorinshttps://github.com/MylesBorins
Mar 21, 2016 https://github.com/nodejs/node/pull/5250#ref-commit-666d369
https://github.com/kthelgason
test: eval a strict functionhttps://github.com/nodejs/node/commit/666d3690d8f0078790b8bdfc65c86e653733583c
666d369https://github.com/nodejs/node/commit/666d3690d8f0078790b8bdfc65c86e653733583c
#5250https://github.com/nodejs/node/pull/5250
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 2, 2016 https://github.com/nodejs/node/pull/5250#ref-issue-97200469
vm.runInContext: eval a strict function #2245 https://github.com/nodejs/node/issues/2245
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5250
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Please reload this pagehttps://github.com/nodejs/node/pull/5250
https://github.com/kthelgason
https://github.com/Trott
https://github.com/thefourtheye
https://github.com/jasnell
https://github.com/targos
https://github.com/mscdex
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.