René's URL Explorer Experiment


Title: [v18.x] http: remove closeIdleConnections function while calling server close by kumarrishav · Pull Request #52335 · nodejs/node · GitHub

Open Graph Title: [v18.x] http: remove closeIdleConnections function while calling server close by kumarrishav · Pull Request #52335 · nodejs/node

X Title: [v18.x] http: remove closeIdleConnections function while calling server close by kumarrishav · Pull Request #52335 · nodejs/node

Description: ….\n Correcting the #50194 backporting mistake.\n closeIdleConnections shouldnot be called while server.close in node v18.\n This behavior is for node v19 and above.\n fixes: #52330, #51677

Open Graph Description: ….\n Correcting the #50194 backporting mistake.\n closeIdleConnections shouldnot be called while server.close in node v18.\n This behavior is for node v19 and above.\n fixes: #52330, #51677

X Description: ….\n Correcting the #50194 backporting mistake.\n closeIdleConnections shouldnot be called while server.close in node v18.\n This behavior is for node v19 and above.\n fixes: #52330, #51677

Opengraph URL: https://github.com/nodejs/node/pull/52335

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5b6d36b1-f384-9a01-287d-024e6660a465
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9578:9D4F4:E8E06C:13FF267:6969EFDB
html-safe-nonce07066673f80e7d8b9a591dca76b0dae6e02ae8cb0013eb361129e557cec2bfd4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTc4OjlENEY0OkU4RTA2QzoxM0ZGMjY3OjY5NjlFRkRCIiwidmlzaXRvcl9pZCI6IjkwOTEyNDUxODY2MDIzNjQ4OTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacaf2bd3df7a223ac7b83a35afe06c138e595878ff3addf86ec4f93ba1e24db1a0
hovercard-subject-tagpull_request:1803431370
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/52335/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/86a7430ba4bb11452461af7c329b937989e655f4b40d82cab95b7d211d282a2c/nodejs/node/pull/52335
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/86a7430ba4bb11452461af7c329b937989e655f4b40d82cab95b7d211d282a2c/nodejs/node/pull/52335
og:image:alt….\n Correcting the #50194 backporting mistake.\n closeIdleConnections shouldnot be called while server.close in node v18.\n This behavior is for node v19 and above.\n fixes: #52330, #51677
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekumarrishav
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/52335#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52335
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52335
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/52335
Reloadhttps://github.com/nodejs/node/pull/52335
Reloadhttps://github.com/nodejs/node/pull/52335
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/52335
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/52335
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/52335#issue-comment-box
kumarrishavhttps://github.com/kumarrishav
nodejs:v18.xhttps://github.com/nodejs/node/tree/v18.x
kumarrishav:patch-1https://github.com/kumarrishav/node/tree/patch-1
[v18.x] http: remove closeIdleConnections function while calling server close https://github.com/nodejs/node/pull/52335#top
kumarrishavhttps://github.com/kumarrishav
nodejs:v18.xhttps://github.com/nodejs/node/tree/v18.x
kumarrishav:patch-1https://github.com/kumarrishav/node/tree/patch-1
Conversation 1 https://github.com/nodejs/node/pull/52335
Commits 1 https://github.com/nodejs/node/pull/52335/commits
Checks 0 https://github.com/nodejs/node/pull/52335/checks
Files changed https://github.com/nodejs/node/pull/52335/files
Please reload this pagehttps://github.com/nodejs/node/pull/52335
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/kumarrishav
kumarrishavhttps://github.com/kumarrishav
Apr 2, 2024https://github.com/nodejs/node/pull/52335#issue-2221540272
#50194https://github.com/nodejs/node/pull/50194
#52330https://github.com/nodejs/node/issues/52330
#51677https://github.com/nodejs/node/issues/51677
Please reload this pagehttps://github.com/nodejs/node/pull/52335
https://github.com/kumarrishav
http: remove closeIdleConnections function while calling server close…https://github.com/nodejs/node/pull/52335/commits/bc7c5c5bfe4041b747a74aaac7460d382785e730
bc7c5c5https://github.com/nodejs/node/pull/52335/commits/bc7c5c5bfe4041b747a74aaac7460d382785e730
nodejs#50194https://github.com/nodejs/node/pull/50194
nodejs#52330https://github.com/nodejs/node/issues/52330
nodejs#51677https://github.com/nodejs/node/issues/51677
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 2, 2024https://github.com/nodejs/node/pull/52335#issuecomment-2033183698
Please reload this pagehttps://github.com/nodejs/node/pull/52335
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av18.x
Apr 2, 2024https://github.com/nodejs/node/pull/52335#event-12332573862
https://github.com/kumarrishav
kumarrishavhttps://github.com/kumarrishav
Apr 2, 2024https://github.com/nodejs/node/pull/52335#event-12332578087
https://github.com/kumarrishav
kumarrishavhttps://github.com/kumarrishav
April 2, 2024 22:07https://github.com/nodejs/node/pull/52335#event-12332583719
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52335
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av18.x
Please reload this pagehttps://github.com/nodejs/node/pull/52335
https://github.com/kumarrishav
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.