René's URL Explorer Experiment


Title: stream: fix no data on partial decode by mscdex · Pull Request #5226 · nodejs/node · GitHub

Open Graph Title: stream: fix no data on partial decode by mscdex · Pull Request #5226 · nodejs/node

X Title: stream: fix no data on partial decode by mscdex · Pull Request #5226 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Before this commit, it was possible to push a partial character to a readable stream where it was decoded as an empty string and then added to the internal buffer. This caused the stream to not emi...

X Description: Before this commit, it was possible to push a partial character to a readable stream where it was decoded as an empty string and then added to the internal buffer. This caused the stream to not emi...

Opengraph URL: https://github.com/nodejs/node/pull/5226

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bf289656-e112-35be-deeb-c4cbafc61012
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDEFE:E21C4:12C1FF0:196057E:6A4F132E
html-safe-nonce6be4c0d92aa8df4cccd4d82d477a2a5a043e6070fd7ab1a04643dee6239f5c80
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUZFOkUyMUM0OjEyQzFGRjA6MTk2MDU3RTo2QTRGMTMyRSIsInZpc2l0b3JfaWQiOiI1MjI1MzQyNjc1MzU2NDIyOTU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccb63c3ac047e96e0d487b42ffc0c28af934e6993d35d047cfc14eb829cdf851b
hovercard-subject-tagpull_request:59300519
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/5226/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/31f0fb68adbfa9c05cf926e8c0aa58b338b9780f54dd64a3e7efdc9c5fe75e96/nodejs/node/pull/5226
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/31f0fb68adbfa9c05cf926e8c0aa58b338b9780f54dd64a3e7efdc9c5fe75e96/nodejs/node/pull/5226
og:image:altBefore this commit, it was possible to push a partial character to a readable stream where it was decoded as an empty string and then added to the internal buffer. This caused the stream to not emi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemscdex
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/5226#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5226
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5226
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/5226
Reloadhttps://github.com/nodejs/node/pull/5226
Reloadhttps://github.com/nodejs/node/pull/5226
Please reload this pagehttps://github.com/nodejs/node/pull/5226
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/5226
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 966 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mscdexhttps://github.com/mscdex
nodejs:masterhttps://github.com/nodejs/node/tree/master
mscdex:fix-readable-partial-decodehttps://github.com/mscdex/io.js/tree/fix-readable-partial-decode
Conversationhttps://github.com/nodejs/node/pull/5226
Commits1 (1)https://github.com/nodejs/node/pull/5226/commits
Checkshttps://github.com/nodejs/node/pull/5226/checks
Files changedhttps://github.com/nodejs/node/pull/5226/files
stream: fix no data on partial decodehttps://github.com/nodejs/node/pull/5226#top
mscdexhttps://github.com/mscdex
nodejs:masterhttps://github.com/nodejs/node/tree/master
mscdex:fix-readable-partial-decodehttps://github.com/mscdex/io.js/tree/fix-readable-partial-decode
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 14, 2016https://github.com/nodejs/node/pull/5226#issue-133559011
#5223https://github.com/nodejs/node/issues/5223
Please reload this pagehttps://github.com/nodejs/node/pull/5226
https://github.com/mscdex
mscdexhttps://github.com/mscdex
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Feb 14, 2016https://github.com/nodejs/node/pull/5226#event-549952246
https://github.com/mscdex
mscdexhttps://github.com/mscdex
force-pushedhttps://github.com/nodejs/node/compare/873406b2515c4a24a0f9fc6d8205178abb88b46a..355b6c4e9a01123586a16197f0ded674caa36c53
873406bhttps://github.com/nodejs/node/commit/873406b2515c4a24a0f9fc6d8205178abb88b46a
355b6c4https://github.com/nodejs/node/commit/355b6c4e9a01123586a16197f0ded674caa36c53
Compare https://github.com/nodejs/node/compare/873406b2515c4a24a0f9fc6d8205178abb88b46a..355b6c4e9a01123586a16197f0ded674caa36c53
February 14, 2016 17:28https://github.com/nodejs/node/pull/5226#event-549952417
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 14, 2016https://github.com/nodejs/node/pull/5226#issuecomment-183933631
https://ci.nodejs.org/job/node-test-pull-request/1656/https://ci.nodejs.org/job/node-test-pull-request/1656/
Please reload this pagehttps://github.com/nodejs/node/pull/5226
mcollinahttps://github.com/mcollina
Feb 14, 2016 https://github.com/nodejs/node/pull/5226#discussion-diff-52846451
View reviewed changes https://github.com/nodejs/node/pull/5226/files#diff-1fd696295b3ae3f444c5c6839a11f89a91e2a42edeb5827e54e86b8acc3e6fe7
lib/_stream_readable.jshttps://github.com/nodejs/node/pull/5226/files#diff-1fd696295b3ae3f444c5c6839a11f89a91e2a42edeb5827e54e86b8acc3e6fe7
mcollinahttps://github.com/mcollina
Feb 14, 2016https://github.com/nodejs/node/pull/5226#discussion_r52846451
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5226
mscdexhttps://github.com/mscdex
Feb 14, 2016https://github.com/nodejs/node/pull/5226#discussion_r52846613
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5226
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Feb 14, 2016https://github.com/nodejs/node/pull/5226#issuecomment-183942379
Please reload this pagehttps://github.com/nodejs/node/pull/5226
https://github.com/mscdex
stream: fix no data on partial decodehttps://github.com/nodejs/node/pull/5226/commits/bbabbeebaf7e61d2aaa3a27db8cc083ee94a2cc0
bbabbeehttps://github.com/nodejs/node/pull/5226/commits/bbabbeebaf7e61d2aaa3a27db8cc083ee94a2cc0
nodejs#5223https://github.com/nodejs/node/issues/5223
https://github.com/mscdex
mscdexhttps://github.com/mscdex
force-pushedhttps://github.com/nodejs/node/compare/355b6c4e9a01123586a16197f0ded674caa36c53..bbabbeebaf7e61d2aaa3a27db8cc083ee94a2cc0
355b6c4https://github.com/nodejs/node/commit/355b6c4e9a01123586a16197f0ded674caa36c53
bbabbeehttps://github.com/nodejs/node/commit/bbabbeebaf7e61d2aaa3a27db8cc083ee94a2cc0
Compare https://github.com/nodejs/node/compare/355b6c4e9a01123586a16197f0ded674caa36c53..bbabbeebaf7e61d2aaa3a27db8cc083ee94a2cc0
February 14, 2016 18:23https://github.com/nodejs/node/pull/5226#event-549972442
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 14, 2016https://github.com/nodejs/node/pull/5226#issuecomment-183944251
Please reload this pagehttps://github.com/nodejs/node/pull/5226
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Feb 14, 2016https://github.com/nodejs/node/pull/5226#issuecomment-183962425
Please reload this pagehttps://github.com/nodejs/node/pull/5226
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 14, 2016https://github.com/nodejs/node/pull/5226#issuecomment-183964548
Please reload this pagehttps://github.com/nodejs/node/pull/5226
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Feb 14, 2016https://github.com/nodejs/node/pull/5226#issuecomment-183964758
Please reload this pagehttps://github.com/nodejs/node/pull/5226
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 15, 2016https://github.com/nodejs/node/pull/5226#issuecomment-184259005
Please reload this pagehttps://github.com/nodejs/node/pull/5226
https://github.com/jasnell
jasnellhttps://github.com/jasnell
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Feb 15, 2016https://github.com/nodejs/node/pull/5226#event-550836477
mscdexhttps://github.com/mscdex
Feb 17, 2016 https://github.com/nodejs/node/pull/5226#ref-commit-9221201
https://github.com/mscdex
stream: fix no data on partial decodehttps://github.com/nodejs/node/commit/92212014ffc95a8bc5e56fcc2c076bac63c20c23
9221201https://github.com/nodejs/node/commit/92212014ffc95a8bc5e56fcc2c076bac63c20c23
#5223https://github.com/nodejs/node/issues/5223
#5226https://github.com/nodejs/node/pull/5226
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 17, 2016https://github.com/nodejs/node/pull/5226#issuecomment-185358275
9221201https://github.com/nodejs/node/commit/92212014ffc95a8bc5e56fcc2c076bac63c20c23
Please reload this pagehttps://github.com/nodejs/node/pull/5226
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 17, 2016https://github.com/nodejs/node/pull/5226#event-554048401
https://github.com/mscdex
mscdexhttps://github.com/mscdex
February 17, 2016 19:17https://github.com/nodejs/node/pull/5226#event-554048775
rvagghttps://github.com/rvagg
Feb 18, 2016 https://github.com/nodejs/node/pull/5226#ref-commit-7684b0f
https://github.com/mscdex
https://github.com/rvagg
stream: fix no data on partial decodehttps://github.com/nodejs/node/commit/7684b0fcdfe8cc1dc9ac0f14cfddad7de7270e9a
7684b0fhttps://github.com/nodejs/node/commit/7684b0fcdfe8cc1dc9ac0f14cfddad7de7270e9a
#5223https://github.com/nodejs/node/issues/5223
#5226https://github.com/nodejs/node/pull/5226
MylesBorinshttps://github.com/MylesBorins
Mar 1, 2016 https://github.com/nodejs/node/pull/5226#ref-commit-0c7c763
https://github.com/mscdex
stream: fix no data on partial decodehttps://github.com/nodejs/node/commit/0c7c763d3228ebb55761371b2b1fbaa2e3dbfa71
0c7c763https://github.com/nodejs/node/commit/0c7c763d3228ebb55761371b2b1fbaa2e3dbfa71
#5223https://github.com/nodejs/node/issues/5223
#5226https://github.com/nodejs/node/pull/5226
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Mar 1, 2016https://github.com/nodejs/node/pull/5226#event-573685699
MylesBorinshttps://github.com/MylesBorins
Mar 17, 2016 https://github.com/nodejs/node/pull/5226#ref-commit-1576484
https://github.com/mscdex
stream: fix no data on partial decodehttps://github.com/nodejs/node/commit/1576484df291bb7ef88032a192d949000f80abab
1576484https://github.com/nodejs/node/commit/1576484df291bb7ef88032a192d949000f80abab
#5223https://github.com/nodejs/node/issues/5223
#5226https://github.com/nodejs/node/pull/5226
MylesBorinshttps://github.com/MylesBorins
Mar 21, 2016 https://github.com/nodejs/node/pull/5226#ref-commit-04db9ef
https://github.com/mscdex
stream: fix no data on partial decodehttps://github.com/nodejs/node/commit/04db9efd7822a1d616aa64b783a7b191e6c228db
04db9efhttps://github.com/nodejs/node/commit/04db9efd7822a1d616aa64b783a7b191e6c228db
#5223https://github.com/nodejs/node/issues/5223
#5226https://github.com/nodejs/node/pull/5226
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5226
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/5226
https://github.com/mscdex
https://github.com/mcollina
https://github.com/jasnell
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.