| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f51d5eab-ac6e-1d24-d6be-5af6c8a51796 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D4B6:16C0A6:1BEB74:27000B:6A4D07F9 |
| html-safe-nonce | a8f57e1b7775350f8c0b9cc986885a6523f9f19412fad9019440ed0000445d0a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEI2OjE2QzBBNjoxQkVCNzQ6MjcwMDBCOjZBNEQwN0Y5IiwidmlzaXRvcl9pZCI6Ijg3MDIzNjAzNTM1MDgyMzExNjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 380b36e3ecfd48852eb7f880ecd48534aa49f675ffcfa48349644efc5b94534b |
| hovercard-subject-tag | pull_request:1796321428 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/52253/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4929b623563b669a75ab4ac1624498e7a79fccaec4578b9fc44415df6448b63f/nodejs/node/pull/52253 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4929b623563b669a75ab4ac1624498e7a79fccaec4578b9fc44415df6448b63f/nodejs/node/pull/52253 |
| og:image:alt | This PR updates our process spawning mechanism from fork to spawn to incorporate the taskset command, enabling CPU pinning for benchmark tasks. This change aims to improve benchmark consistency and... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | thisalihassan |
| hostname | github.com |
| expected-hostname | github.com |
| None | 31e4db13a9e20081f2fac78f441659a6576e582bbb15e153f9c7fb6473aa29f5 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fb70bd3c4b2bec429781b65419e912c66e2d5581 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/52253#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52253 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52253 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/52253 |
| Reload | https://github.com/nodejs/node/pull/52253 |
| Reload | https://github.com/nodejs/node/pull/52253 |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
958
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| thisalihassan:taskset_support_benchmark | https://github.com/thisalihassan/node/tree/taskset_support_benchmark |
| Conversation | https://github.com/nodejs/node/pull/52253 |
| Commits6 (6) | https://github.com/nodejs/node/pull/52253/commits |
| Checks | https://github.com/nodejs/node/pull/52253/checks |
| Files changed | https://github.com/nodejs/node/pull/52253/files |
| benchmark: conditionally use spawn with taskset for CPU pinning | https://github.com/nodejs/node/pull/52253#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| thisalihassan:taskset_support_benchmark | https://github.com/thisalihassan/node/tree/taskset_support_benchmark |
|
| https://github.com/thisalihassan |
| thisalihassan | https://github.com/thisalihassan |
| Mar 28, 2024 | https://github.com/nodejs/node/pull/52253#issue-2213503013 |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| #52233 | https://github.com/nodejs/node/issues/52233 |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
|
performance
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance |
| Mar 28, 2024 | https://github.com/nodejs/node/pull/52253#event-12283378941 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Mar 28, 2024
| https://github.com/nodejs/node/pull/52253#pullrequestreview-1967042224 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52253/files |
| benchmark/compare.js | https://github.com/nodejs/node/pull/52253/files#diff-b0bed8b607714c703f4de110a731294b2643bf274a536cc00f50fdd90bf60b00 |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/thisalihassan |
| thisalihassan | https://github.com/thisalihassan |
| mcollina | https://github.com/mcollina |
| March 28, 2024 20:08 | https://github.com/nodejs/node/pull/52253#event-12286964096 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Mar 28, 2024
| https://github.com/nodejs/node/pull/52253#pullrequestreview-1967220755 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52253/files |
| benchmark/run.js | https://github.com/nodejs/node/pull/52253/files#diff-69d5379c13e6596c45f0cfdede0525c352f1e06a16ae376156d2b34713ed695b |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/thisalihassan |
| thisalihassan | https://github.com/thisalihassan |
| force-pushed | https://github.com/nodejs/node/compare/072af2519f3a52be8ca8eb29a3730f1e2cd74d0e..3fb5b79f1670a66fd8e366262203463196a80ef9 |
| 072af25 | https://github.com/nodejs/node/commit/072af2519f3a52be8ca8eb29a3730f1e2cd74d0e |
| 3fb5b79 | https://github.com/nodejs/node/commit/3fb5b79f1670a66fd8e366262203463196a80ef9 |
|
Compare
| https://github.com/nodejs/node/compare/072af2519f3a52be8ca8eb29a3730f1e2cd74d0e..3fb5b79f1670a66fd8e366262203463196a80ef9 |
| March 28, 2024 20:53 | https://github.com/nodejs/node/pull/52253#event-12287474747 |
| https://github.com/thisalihassan |
| thisalihassan | https://github.com/thisalihassan |
| mcollina | https://github.com/mcollina |
| March 28, 2024 20:57 | https://github.com/nodejs/node/pull/52253#event-12287506332 |
| https://github.com/thisalihassan |
| thisalihassan | https://github.com/thisalihassan |
| Mar 28, 2024 | https://github.com/nodejs/node/pull/52253#event-12287597819 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Mar 29, 2024
| https://github.com/nodejs/node/pull/52253#pullrequestreview-1969678438 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52253/files |
| benchmark/compare.js | https://github.com/nodejs/node/pull/52253/files#diff-b0bed8b607714c703f4de110a731294b2643bf274a536cc00f50fdd90bf60b00 |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| benchmark/compare.js | https://github.com/nodejs/node/pull/52253/files#diff-b0bed8b607714c703f4de110a731294b2643bf274a536cc00f50fdd90bf60b00 |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| benchmark/run.js | https://github.com/nodejs/node/pull/52253/files#diff-69d5379c13e6596c45f0cfdede0525c352f1e06a16ae376156d2b34713ed695b |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/thisalihassan |
| thisalihassan | https://github.com/thisalihassan |
| anonrig | https://github.com/anonrig |
| March 30, 2024 00:18 | https://github.com/nodejs/node/pull/52253#event-12299047344 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
|
Mar 30, 2024
| https://github.com/nodejs/node/pull/52253#pullrequestreview-1969854714 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52253/files |
| benchmark/run.js | https://github.com/nodejs/node/pull/52253/files#diff-69d5379c13e6596c45f0cfdede0525c352f1e06a16ae376156d2b34713ed695b |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/thisalihassan |
| thisalihassan | https://github.com/thisalihassan |
| force-pushed | https://github.com/nodejs/node/compare/bf8e66eebd20723ebc988d12f18409012ca7284c..9ac9d79096928f1f24e7a7a2370ff05f97da265c |
| bf8e66e | https://github.com/nodejs/node/commit/bf8e66eebd20723ebc988d12f18409012ca7284c |
| 9ac9d79 | https://github.com/nodejs/node/commit/9ac9d79096928f1f24e7a7a2370ff05f97da265c |
|
Compare
| https://github.com/nodejs/node/compare/bf8e66eebd20723ebc988d12f18409012ca7284c..9ac9d79096928f1f24e7a7a2370ff05f97da265c |
| March 30, 2024 12:17 | https://github.com/nodejs/node/pull/52253#event-12300484909 |
| https://github.com/thisalihassan |
| thisalihassan | https://github.com/thisalihassan |
| mertcanaltin | https://github.com/mertcanaltin |
| March 30, 2024 12:18 | https://github.com/nodejs/node/pull/52253#event-12300486068 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Mar 31, 2024
| https://github.com/nodejs/node/pull/52253#pullrequestreview-1970403896 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52253/files/d6b0a828c23c3b6c74a6d9ed60663fad9c92bc8f |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/52253#pullrequestreview-1970403896 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Mar 31, 2024 | https://github.com/nodejs/node/pull/52253#issuecomment-2028898809 |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| thisalihassan | https://github.com/thisalihassan |
| April 1, 2024 02:23 | https://github.com/nodejs/node/pull/52253#commits-pushed-28c68f0 |
|
| https://github.com/thisalihassan |
| benchmark: conditionally use spawn with taskset for cpu pinning | https://github.com/nodejs/node/pull/52253/commits/28c68f063055cd73669006f326683abfe43feaa4 |
| 28c68f0 | https://github.com/nodejs/node/pull/52253/commits/28c68f063055cd73669006f326683abfe43feaa4 |
| nodejs#52233 | https://github.com/nodejs/node/issues/52233 |
|
| https://github.com/thisalihassan |
| benchmark: run lint | https://github.com/nodejs/node/pull/52253/commits/a55914974e26bbe03bab3371f2860409b4a7fa5c |
| a559149 | https://github.com/nodejs/node/pull/52253/commits/a55914974e26bbe03bab3371f2860409b4a7fa5c |
|
| https://github.com/thisalihassan |
| benchmark: refactor code for benchmark cpu settings | https://github.com/nodejs/node/pull/52253/commits/3270cef6da25c31855438ddd3a9f7bb97c82956c |
| 3270cef | https://github.com/nodejs/node/pull/52253/commits/3270cef6da25c31855438ddd3a9f7bb97c82956c |
|
| https://github.com/thisalihassan |
| benchmark: prefer node import syntax for built-in child_process | https://github.com/nodejs/node/pull/52253/commits/d6b0a828c23c3b6c74a6d9ed60663fad9c92bc8f |
| d6b0a82 | https://github.com/nodejs/node/pull/52253/commits/d6b0a828c23c3b6c74a6d9ed60663fad9c92bc8f |
| https://github.com/thisalihassan |
| thisalihassan | https://github.com/thisalihassan |
| force-pushed | https://github.com/nodejs/node/compare/9ac9d79096928f1f24e7a7a2370ff05f97da265c..d6b0a828c23c3b6c74a6d9ed60663fad9c92bc8f |
| 9ac9d79 | https://github.com/nodejs/node/commit/9ac9d79096928f1f24e7a7a2370ff05f97da265c |
| d6b0a82 | https://github.com/nodejs/node/commit/d6b0a828c23c3b6c74a6d9ed60663fad9c92bc8f |
|
Compare
| https://github.com/nodejs/node/compare/9ac9d79096928f1f24e7a7a2370ff05f97da265c..d6b0a828c23c3b6c74a6d9ed60663fad9c92bc8f |
| March 31, 2024 21:25 | https://github.com/nodejs/node/pull/52253#event-12304816221 |
| https://github.com/thisalihassan |
| thisalihassan | https://github.com/thisalihassan |
| Mar 31, 2024 | https://github.com/nodejs/node/pull/52253#issuecomment-2028909033 |
| https://private-user-images.githubusercontent.com/24819103/318302747-96b10830-6122-445b-99e0-f8f53de125e1.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODM0MzM1MTAsIm5iZiI6MTc4MzQzMzIxMCwicGF0aCI6Ii8yNDgxOTEwMy8zMTgzMDI3NDctOTZiMTA4MzAtNjEyMi00NDViLTk5ZTAtZjhmNTNkZTEyNWUxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA3MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwNzA3VDE0MDY1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk1NmRmYWJhNTA2NzY2MzcyMTNjZjAxMTA3MmJlZDMxZjA5ZWVjODgxNzNhZmY2Yzc5Y2M5ZDBhMDVmZGMwNWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.sMUZdk7PeWRzgIGC8WyoDKhOj9n5LGvSW5a49oEJ5LE |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Apr 1, 2024
| https://github.com/nodejs/node/pull/52253#pullrequestreview-1970850302 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52253/files/d6b0a828c23c3b6c74a6d9ed60663fad9c92bc8f |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/52253#pullrequestreview-1970850302 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Apr 1, 2024 | https://github.com/nodejs/node/pull/52253#event-12307970249 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Apr 1, 2024 | https://github.com/nodejs/node/pull/52253#issuecomment-2029358988 |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Apr 1, 2024 | https://github.com/nodejs/node/pull/52253#event-12307979311 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 1, 2024 | https://github.com/nodejs/node/pull/52253#issuecomment-2029359487 |
| https://ci.nodejs.org/job/node-test-pull-request/58025/ | https://ci.nodejs.org/job/node-test-pull-request/58025/ |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/thisalihassan |
| thisalihassan | https://github.com/thisalihassan |
| Apr 1, 2024 | https://github.com/nodejs/node/pull/52253#issuecomment-2030583888 |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 4, 2024 | https://github.com/nodejs/node/pull/52253#issuecomment-2036543451 |
| https://ci.nodejs.org/job/node-test-pull-request/58098/ | https://ci.nodejs.org/job/node-test-pull-request/58098/ |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Apr 4, 2024 | https://github.com/nodejs/node/pull/52253#issuecomment-2036543646 |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
|
Apr 4, 2024
| https://github.com/nodejs/node/pull/52253#pullrequestreview-1979843474 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52253/files/d6b0a828c23c3b6c74a6d9ed60663fad9c92bc8f |
| mertcanaltin | https://github.com/mertcanaltin |
| https://github.com/nodejs/node/pull/52253#pullrequestreview-1979843474 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/rluvaton |
| rluvaton | https://github.com/rluvaton |
|
Apr 4, 2024
| https://github.com/nodejs/node/pull/52253#ref-pullrequest-2225286149 |
|
events: improve addAbortListener perf by saving the same options object
#52367
| https://github.com/nodejs/node/pull/52367 |
| https://github.com/rluvaton |
| rluvaton | https://github.com/rluvaton |
|
Apr 4, 2024
| https://github.com/nodejs/node/pull/52253#pullrequestreview-1980061821 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52253/files/d6b0a828c23c3b6c74a6d9ed60663fad9c92bc8f |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 4, 2024 | https://github.com/nodejs/node/pull/52253#issuecomment-2037340973 |
| https://ci.nodejs.org/job/node-test-pull-request/58115/ | https://ci.nodejs.org/job/node-test-pull-request/58115/ |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/thisalihassan |
| thisalihassan | https://github.com/thisalihassan |
| Apr 5, 2024 | https://github.com/nodejs/node/pull/52253#issuecomment-2038550253 |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Apr 5, 2024
| https://github.com/nodejs/node/pull/52253#pullrequestreview-1981518776 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52253/files/d6b0a828c23c3b6c74a6d9ed60663fad9c92bc8f |
| benchmark/_cli.js | https://github.com/nodejs/node/pull/52253/files/d6b0a828c23c3b6c74a6d9ed60663fad9c92bc8f#diff-b1419d09e458a93e0ff3f4b13fe6883065a4b189e66cc22ea25bcc377d48a6b2 |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| thisalihassan | https://github.com/thisalihassan |
| April 5, 2024 12:44 | https://github.com/nodejs/node/pull/52253#commits-pushed-e87f992 |
|
| https://github.com/thisalihassan |
| docs: update benchmarks md to explain CPUSET variable | https://github.com/nodejs/node/pull/52253/commits/e87f992b102837142b0040b54e7e36ff23c79bf8 |
| e87f992 | https://github.com/nodejs/node/pull/52253/commits/e87f992b102837142b0040b54e7e36ff23c79bf8 |
|
| https://github.com/thisalihassan |
| benchmark: fix stdio on stderr for child process | https://github.com/nodejs/node/pull/52253/commits/5f700f58ec81acdbecf39ea3ce4e94fb0fcd630d |
| 5f700f5 | https://github.com/nodejs/node/pull/52253/commits/5f700f58ec81acdbecf39ea3ce4e94fb0fcd630d |
| https://github.com/thisalihassan |
| thisalihassan | https://github.com/thisalihassan |
| force-pushed | https://github.com/nodejs/node/compare/b070fa2672b0dd5372c57a763624c5b5205dea29..5f700f58ec81acdbecf39ea3ce4e94fb0fcd630d |
| b070fa2 | https://github.com/nodejs/node/commit/b070fa2672b0dd5372c57a763624c5b5205dea29 |
| 5f700f5 | https://github.com/nodejs/node/commit/5f700f58ec81acdbecf39ea3ce4e94fb0fcd630d |
|
Compare
| https://github.com/nodejs/node/compare/b070fa2672b0dd5372c57a763624c5b5205dea29..5f700f58ec81acdbecf39ea3ce4e94fb0fcd630d |
| April 5, 2024 23:09 | https://github.com/nodejs/node/pull/52253#event-12379990630 |
| https://github.com/rluvaton |
| rluvaton | https://github.com/rluvaton |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Apr 6, 2024 | https://github.com/nodejs/node/pull/52253#event-12382561436 |
| https://github.com/rluvaton |
| rluvaton | https://github.com/rluvaton |
|
Apr 6, 2024
| https://github.com/nodejs/node/pull/52253#pullrequestreview-1984706306 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52253/files/5f700f58ec81acdbecf39ea3ce4e94fb0fcd630d |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Apr 6, 2024 | https://github.com/nodejs/node/pull/52253#event-12382569588 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 6, 2024 | https://github.com/nodejs/node/pull/52253#issuecomment-2041222507 |
| #52233 | https://github.com/nodejs/node/issues/52233 |
| #52253 | https://github.com/nodejs/node/pull/52253 |
| #52253 | https://github.com/nodejs/node/pull/52253 |
| #52253 | https://github.com/nodejs/node/pull/52253 |
| #52253 | https://github.com/nodejs/node/pull/52253 |
| #52253 | https://github.com/nodejs/node/pull/52253 |
| #52253 | https://github.com/nodejs/node/pull/52253 |
| https://github.com/nodejs/node/actions/runs/8584238305 |
| https://github.com/nodejs/node/actions/runs/8584238305 | https://github.com/nodejs/node/actions/runs/8584238305 |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/rluvaton |
| rluvaton | https://github.com/rluvaton |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
|
commit-queue-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed |
| Apr 6, 2024 | https://github.com/nodejs/node/pull/52253#event-12382572589 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Apr 6, 2024 | https://github.com/nodejs/node/pull/52253#event-12382578684 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| 47c934e | https://github.com/nodejs/node/commit/47c934e464756952719927529c2d28a92a58d701 |
| Apr 6, 2024 | https://github.com/nodejs/node/pull/52253#event-12382578749 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 6, 2024 | https://github.com/nodejs/node/pull/52253#issuecomment-2041223725 |
| 47c934e | https://github.com/nodejs/node/commit/47c934e464756952719927529c2d28a92a58d701 |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/rluvaton |
| rluvaton | https://github.com/rluvaton |
|
Apr 7, 2024
| https://github.com/nodejs/node/pull/52253#ref-issue-2198840296 |
|
Hetzner Benchmarking Machine Replacements
nodejs/build#3657
| https://github.com/nodejs/build/issues/3657 |
| https://github.com/rluvaton |
| rluvaton | https://github.com/rluvaton |
|
Apr 10, 2024
| https://github.com/nodejs/node/pull/52253#pullrequestreview-1992496917 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52253/files/5f700f58ec81acdbecf39ea3ce4e94fb0fcd630d |
| benchmark/compare.js | https://github.com/nodejs/node/pull/52253/files/5f700f58ec81acdbecf39ea3ce4e94fb0fcd630d#diff-b0bed8b607714c703f4de110a731294b2643bf274a536cc00f50fdd90bf60b00 |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/rluvaton |
| rluvaton | https://github.com/rluvaton |
|
Apr 10, 2024
| https://github.com/nodejs/node/pull/52253#pullrequestreview-1992504757 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52253/files/5f700f58ec81acdbecf39ea3ce4e94fb0fcd630d |
| benchmark/compare.js | https://github.com/nodejs/node/pull/52253/files/5f700f58ec81acdbecf39ea3ce4e94fb0fcd630d#diff-b0bed8b607714c703f4de110a731294b2643bf274a536cc00f50fdd90bf60b00 |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
| https://github.com/rluvaton |
| rluvaton | https://github.com/rluvaton |
|
Apr 10, 2024
| https://github.com/nodejs/node/pull/52253#ref-pullrequest-2236293917 |
|
run compare on perf cores
nodejs/performance#162
| https://github.com/nodejs/performance/pull/162 |
| https://github.com/thisalihassan |
| thisalihassan | https://github.com/thisalihassan |
|
Apr 15, 2024
| https://github.com/nodejs/node/pull/52253#ref-issue-1607703177 |
|
Force push does not invalidate existing approved reviews
nodejs/node-core-utils#677
| https://github.com/nodejs/node-core-utils/issues/677 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
Apr 15, 2024
| https://github.com/nodejs/node/pull/52253#ref-pullrequest-2240703753 |
|
2024-04-24, Version 22.0.0 (Current)
#52505
| https://github.com/nodejs/node/pull/52505 |
| marco-ippolito | https://github.com/marco-ippolito |
|
May 2, 2024
| https://github.com/nodejs/node/pull/52253#ref-commit-4196cf8 |
|
| https://github.com/thisalihassan |
|
| https://github.com/marco-ippolito |
| benchmark: conditionally use spawn with taskset for cpu pinning | https://github.com/nodejs/node/commit/4196cf869bd38136940b6e029e6978dc3c233ac6 |
| 4196cf8 | https://github.com/nodejs/node/commit/4196cf869bd38136940b6e029e6978dc3c233ac6 |
| #52233 | https://github.com/nodejs/node/issues/52233 |
| #52253 | https://github.com/nodejs/node/pull/52253 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
May 2, 2024
| https://github.com/nodejs/node/pull/52253#ref-pullrequest-2275045625 |
|
v20.13.0 proposal
#52793
| https://github.com/nodejs/node/pull/52793 |
| marco-ippolito | https://github.com/marco-ippolito |
|
May 3, 2024
| https://github.com/nodejs/node/pull/52253#ref-commit-7508d48 |
|
| https://github.com/thisalihassan |
|
| https://github.com/marco-ippolito |
| benchmark: conditionally use spawn with taskset for cpu pinning | https://github.com/nodejs/node/commit/7508d4873600db01d027a27d2edb2b92e01535d1 |
| 7508d48 | https://github.com/nodejs/node/commit/7508d4873600db01d027a27d2edb2b92e01535d1 |
| #52233 | https://github.com/nodejs/node/issues/52233 |
| #52253 | https://github.com/nodejs/node/pull/52253 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52253 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/52253/files/5f700f58ec81acdbecf39ea3ce4e94fb0fcd630d |
|
| https://github.com/rluvaton |
|
rluvaton
| https://github.com/rluvaton |
|
| https://github.com/nodejs/node/pull/52253/files/5f700f58ec81acdbecf39ea3ce4e94fb0fcd630d |
|
| https://github.com/anonrig |
|
anonrig
| https://github.com/anonrig |
|
| https://github.com/nodejs/node/pull/52253/files/d6b0a828c23c3b6c74a6d9ed60663fad9c92bc8f |
|
| https://github.com/mertcanaltin |
|
mertcanaltin
| https://github.com/mertcanaltin |
|
| https://github.com/nodejs/node/pull/52253/files/d6b0a828c23c3b6c74a6d9ed60663fad9c92bc8f |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
|
performance
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance |
|
Support starting benchmark tasks using taskset on Linux
| https://github.com/nodejs/node/issues/52233 |
| Please reload this page | https://github.com/nodejs/node/pull/52253 |
|
| https://github.com/thisalihassan |
|
| https://github.com/mcollina |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/anonrig |
|
| https://github.com/rluvaton |
|
| https://github.com/mertcanaltin |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |