René's URL Explorer Experiment


Title: test_runner: don't await the same promise for each test by cjihrig · Pull Request #52185 · nodejs/node · GitHub

Open Graph Title: test_runner: don't await the same promise for each test by cjihrig · Pull Request #52185 · nodejs/node

X Title: test_runner: don't await the same promise for each test by cjihrig · Pull Request #52185 · nodejs/node

Description: test: fix incorrect test fixture This commit updates a test runner fixture that includes a failing child test. However, the nested test is created using the top level test() function instead t.test(). This commit updates the fixture to use t.test(), while preserving the expected failure. Refs: #47164 test_runner: don't await the same promise for each test Prior to this commit, each top level test awaited the same global promise for setting up test reporters. This commit updates the logic to only await the promise the first time it is encountered.

Open Graph Description: test: fix incorrect test fixture This commit updates a test runner fixture that includes a failing child test. However, the nested test is created using the top level test() function instead t.test...

X Description: test: fix incorrect test fixture This commit updates a test runner fixture that includes a failing child test. However, the nested test is created using the top level test() function instead t.test...

Opengraph URL: https://github.com/nodejs/node/pull/52185

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.113.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0c1c5ac9-9abd-b1e1-b2ab-60b89d8643d6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9116:52410:6E51FD:8B7D99:6B0367C3
html-safe-nonce5b9c314973b67bba8d3ece59c0f0982c76e1048237c513b77eb0d119e000b590
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTE2OjUyNDEwOjZFNTFGRDo4QjdEOTk6NkIwMzY3QzMiLCJ2aXNpdG9yX2lkIjoiNDUyMDI0NjM4MTIzOTI5Nzk4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0d601826589e6fc545a21b4da8b395e2c43c330d20311a26e5b23f37e513c4da
hovercard-subject-tagpull_request:1785690259
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/52185/files
twitter:imagehttps://avatars.githubusercontent.com/u/2512748?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2512748?s=400&v=4
og:image:alttest: fix incorrect test fixture This commit updates a test runner fixture that includes a failing child test. However, the nested test is created using the top level test() function instead t.test...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/52185/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52185%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52185%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/52185/files
Reloadhttps://github.com/nodejs/node/pull/52185/files
Reloadhttps://github.com/nodejs/node/pull/52185/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues639 (639)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
cjihrighttps://github.com/cjihrig
nodejs:mainhttps://github.com/nodejs/node/tree/main
cjihrig:extra-awaithttps://github.com/cjihrig/node/tree/extra-await
Conversation 8 https://github.com/nodejs/node/pull/52185
Commits 2 https://github.com/nodejs/node/pull/52185/commits
Checks 0 https://github.com/nodejs/node/pull/52185/checks
Files changed https://github.com/nodejs/node/pull/52185/files
Please reload this pagehttps://github.com/nodejs/node/pull/52185/files
test_runner: don't await the same promise for each test https://github.com/nodejs/node/pull/52185/files#top
Show all changes 2 commits https://github.com/nodejs/node/pull/52185/files
b7d0808 test: fix incorrect test fixture cjihrig Mar 22, 2024 https://github.com/nodejs/node/pull/52185/commits/b7d08089d1dd269b48c088f675234ccadc736cce
ed1821a test_runner: don't await the same promise for each test cjihrig Mar 22, 2024 https://github.com/nodejs/node/pull/52185/commits/ed1821a0095f41f7ab3f77c4297b5a92be62360b
Clear filters https://github.com/nodejs/node/pull/52185/files
Please reload this pagehttps://github.com/nodejs/node/pull/52185/files
Please reload this pagehttps://github.com/nodejs/node/pull/52185/files
harness.js https://github.com/nodejs/node/pull/52185/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
default_output.js https://github.com/nodejs/node/pull/52185/files#diff-d43761c362ad3ea9db5306192c0b7e3e0ab121d8236fd26495ae4bdf9441c406
default_output.snapshot https://github.com/nodejs/node/pull/52185/files#diff-ad4f81ff654b3240ba7f6429e0d62fa509caaf5cacf0ed9c86a86b576c5b9d4c
lib/internal/test_runner/harness.jshttps://github.com/nodejs/node/pull/52185/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
View file https://github.com/cjihrig/node/blob/ed1821a0095f41f7ab3f77c4297b5a92be62360b/lib/internal/test_runner/harness.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/52185/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/52185/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
atlowChemihttps://github.com/atlowChemi
Mar 24, 2024https://github.com/nodejs/node/pull/52185/files#r1536916009
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/52185/files
MoLowhttps://github.com/MoLow
Mar 26, 2024https://github.com/nodejs/node/pull/52185/files#r1538820882
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/52185/files
cjihrighttps://github.com/cjihrig
Mar 26, 2024https://github.com/nodejs/node/pull/52185/files#r1539209393
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@MoLowhttps://github.com/MoLow
#52185 (comment)https://github.com/nodejs/node/pull/52185#discussion_r1536953698
MDNhttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/await
Please reload this pagehttps://github.com/nodejs/node/pull/52185/files
https://github.com/nodejs/node/pull/52185/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
test/fixtures/test-runner/output/default_output.jshttps://github.com/nodejs/node/pull/52185/files#diff-d43761c362ad3ea9db5306192c0b7e3e0ab121d8236fd26495ae4bdf9441c406
View file https://github.com/cjihrig/node/blob/ed1821a0095f41f7ab3f77c4297b5a92be62360b/test/fixtures/test-runner/output/default_output.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/52185/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/52185/files#diff-d43761c362ad3ea9db5306192c0b7e3e0ab121d8236fd26495ae4bdf9441c406
Please reload this pagehttps://github.com/nodejs/node/pull/52185/files
test/fixtures/test-runner/output/default_output.snapshothttps://github.com/nodejs/node/pull/52185/files#diff-ad4f81ff654b3240ba7f6429e0d62fa509caaf5cacf0ed9c86a86b576c5b9d4c
View file https://github.com/cjihrig/node/blob/ed1821a0095f41f7ab3f77c4297b5a92be62360b/test/fixtures/test-runner/output/default_output.snapshot
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/52185/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/52185/files#diff-ad4f81ff654b3240ba7f6429e0d62fa509caaf5cacf0ed9c86a86b576c5b9d4c
https://github.com/nodejs/node/pull/52185/files#diff-ad4f81ff654b3240ba7f6429e0d62fa509caaf5cacf0ed9c86a86b576c5b9d4c
https://github.com/nodejs/node/pull/52185/files#diff-ad4f81ff654b3240ba7f6429e0d62fa509caaf5cacf0ed9c86a86b576c5b9d4c
https://github.com/nodejs/node/pull/52185/files#diff-ad4f81ff654b3240ba7f6429e0d62fa509caaf5cacf0ed9c86a86b576c5b9d4c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.