| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:57bfdb87-4f80-5237-ab80-d597702c8b57 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 861A:1E74B0:60230F:7A340A:6B03523D |
| html-safe-nonce | f9a37d5368571986faad3cce495d5c2509ca1d920819d245e97ae1284a3fb1db |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjFBOjFFNzRCMDo2MDIzMEY6N0EzNDBBOjZCMDM1MjNEIiwidmlzaXRvcl9pZCI6IjE1OTc1NjkwMjk0OTE2MTAxNzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2f36fecda8630499bef574a0773fc3d197041bb3064b4d8bad6feac02e48369e |
| hovercard-subject-tag | pull_request:1785690259 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/52185/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f493a470c36124a7e10ebf7fab6a20f6fbec674bc55484e3dcea1c44f40339ef/nodejs/node/pull/52185 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f493a470c36124a7e10ebf7fab6a20f6fbec674bc55484e3dcea1c44f40339ef/nodejs/node/pull/52185 |
| og:image:alt | test: fix incorrect test fixture
This commit updates a test runner fixture that includes a failing
child test. However, the nested test is created using the top
level test() function instead t.test... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cjihrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/52185#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52185 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52185 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/52185 |
| Reload | https://github.com/nodejs/node/pull/52185 |
| Reload | https://github.com/nodejs/node/pull/52185 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues637 (637) | https://github.com/nodejs/node/issues |
| Pull requests667 (667) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/insights |
| https://github.com/nodejs/node |
| cjihrig | https://github.com/cjihrig |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| cjihrig:extra-await | https://github.com/cjihrig/node/tree/extra-await |
| Conversation | https://github.com/nodejs/node/pull/52185 |
| Commits2 (2) | https://github.com/nodejs/node/pull/52185/commits |
| Checks | https://github.com/nodejs/node/pull/52185/checks |
| Files changed | https://github.com/nodejs/node/pull/52185/files |
| test_runner: don't await the same promise for each test | https://github.com/nodejs/node/pull/52185#top |
| cjihrig | https://github.com/cjihrig |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| cjihrig:extra-await | https://github.com/cjihrig/node/tree/extra-await |
|
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Mar 22, 2024 | https://github.com/nodejs/node/pull/52185#issue-2201502059 |
| #47164 | https://github.com/nodejs/node/pull/47164 |
| Please reload this page | https://github.com/nodejs/node/pull/52185 |
| cjihrig | https://github.com/cjihrig |
| March 21, 2024 20:54 | https://github.com/nodejs/node/pull/52185#commits-pushed-b7d0808 |
|
| https://github.com/cjihrig |
| test: fix incorrect test fixture | https://github.com/nodejs/node/pull/52185/commits/b7d08089d1dd269b48c088f675234ccadc736cce |
| b7d0808 | https://github.com/nodejs/node/pull/52185/commits/b7d08089d1dd269b48c088f675234ccadc736cce |
| nodejs#47164 | https://github.com/nodejs/node/pull/47164 |
|
| https://github.com/cjihrig |
| test_runner: don't await the same promise for each test | https://github.com/nodejs/node/pull/52185/commits/ed1821a0095f41f7ab3f77c4297b5a92be62360b |
| ed1821a | https://github.com/nodejs/node/pull/52185/commits/ed1821a0095f41f7ab3f77c4297b5a92be62360b |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 22, 2024 | https://github.com/nodejs/node/pull/52185#issuecomment-2014152049 |
| Please reload this page | https://github.com/nodejs/node/pull/52185 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
test_runner
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner |
| Mar 22, 2024 | https://github.com/nodejs/node/pull/52185#event-12209712078 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| MoLow | https://github.com/MoLow |
| atlowChemi | https://github.com/atlowChemi |
| March 22, 2024 12:05 | https://github.com/nodejs/node/pull/52185#event-12214831335 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Mar 22, 2024
| https://github.com/nodejs/node/pull/52185#pullrequestreview-1955440329 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52185/files/ed1821a0095f41f7ab3f77c4297b5a92be62360b |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Mar 23, 2024 | https://github.com/nodejs/node/pull/52185#event-12224454521 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Mar 23, 2024 | https://github.com/nodejs/node/pull/52185#event-12224460981 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 23, 2024 | https://github.com/nodejs/node/pull/52185#issuecomment-2016500769 |
| https://ci.nodejs.org/job/node-test-pull-request/57916/ | https://ci.nodejs.org/job/node-test-pull-request/57916/ |
| Please reload this page | https://github.com/nodejs/node/pull/52185 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Mar 24, 2024 | https://github.com/nodejs/node/pull/52185#event-12226814179 |
| https://github.com/atlowChemi |
| atlowChemi | https://github.com/atlowChemi |
|
Mar 24, 2024
| https://github.com/nodejs/node/pull/52185#pullrequestreview-1956660945 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52185/files/ed1821a0095f41f7ab3f77c4297b5a92be62360b |
| lib/internal/test_runner/harness.js | https://github.com/nodejs/node/pull/52185/files/ed1821a0095f41f7ab3f77c4297b5a92be62360b#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c |
| atlowChemi | https://github.com/atlowChemi |
| Mar 24, 2024 | https://github.com/nodejs/node/pull/52185#discussion_r1536916009 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/52185 |
| MoLow | https://github.com/MoLow |
| Mar 26, 2024 | https://github.com/nodejs/node/pull/52185#discussion_r1538820882 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/52185 |
| cjihrig | https://github.com/cjihrig |
| Mar 26, 2024 | https://github.com/nodejs/node/pull/52185#discussion_r1539209393 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @MoLow | https://github.com/MoLow |
| #52185 (comment) | https://github.com/nodejs/node/pull/52185#discussion_r1536953698 |
| MDN | https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/await |
| Please reload this page | https://github.com/nodejs/node/pull/52185 |
| test/fixtures/test-runner/output/default_output.js | https://github.com/nodejs/node/pull/52185/files/ed1821a0095f41f7ab3f77c4297b5a92be62360b#diff-d43761c362ad3ea9db5306192c0b7e3e0ab121d8236fd26495ae4bdf9441c406 |
| Please reload this page | https://github.com/nodejs/node/pull/52185 |
| https://github.com/atlowChemi |
| atlowChemi | https://github.com/atlowChemi |
|
commit-queue-rebase
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-rebase |
| Mar 24, 2024 | https://github.com/nodejs/node/pull/52185#event-12227649367 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Mar 25, 2024 | https://github.com/nodejs/node/pull/52185#event-12228142645 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Mar 25, 2024 | https://github.com/nodejs/node/pull/52185#event-12228184319 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 25, 2024 | https://github.com/nodejs/node/pull/52185#issuecomment-2017033603 |
| bae14b7...4648c83 | https://github.com/nodejs/node/compare/bae14b7914624630c3e451def82a8f56c6402534...4648c83dbc695a77980777b9b7e712303369ff9e |
| Please reload this page | https://github.com/nodejs/node/pull/52185 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Mar 25, 2024
| https://github.com/nodejs/node/pull/52185#ref-commit-5905596 |
|
| https://github.com/cjihrig |
|
| https://github.com/nodejs-github-bot |
| test: fix incorrect test fixture | https://github.com/nodejs/node/commit/5905596719efc7d419b5743056f364d4d6089626 |
| 5905596 | https://github.com/nodejs/node/commit/5905596719efc7d419b5743056f364d4d6089626 |
| #47164 | https://github.com/nodejs/node/pull/47164 |
| #52185 | https://github.com/nodejs/node/pull/52185 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Mar 25, 2024
| https://github.com/nodejs/node/pull/52185#ref-commit-4648c83 |
|
| https://github.com/cjihrig |
|
| https://github.com/nodejs-github-bot |
| test_runner: don't await the same promise for each test | https://github.com/nodejs/node/commit/4648c83dbc695a77980777b9b7e712303369ff9e |
| 4648c83 | https://github.com/nodejs/node/commit/4648c83dbc695a77980777b9b7e712303369ff9e |
| #52185 | https://github.com/nodejs/node/pull/52185 |
| #47164 | https://github.com/nodejs/node/pull/47164 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 25, 2024 | https://github.com/nodejs/node/pull/52185#event-12228184958 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| March 25, 2024 23:19 | https://github.com/nodejs/node/pull/52185#event-12241968116 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
Apr 15, 2024
| https://github.com/nodejs/node/pull/52185#ref-pullrequest-2240703753 |
|
2024-04-24, Version 22.0.0 (Current)
#52505
| https://github.com/nodejs/node/pull/52505 |
| marco-ippolito | https://github.com/marco-ippolito |
|
May 2, 2024
| https://github.com/nodejs/node/pull/52185#ref-commit-96bbd51 |
|
| https://github.com/cjihrig |
|
| https://github.com/marco-ippolito |
| test: fix incorrect test fixture | https://github.com/nodejs/node/commit/96bbd5179712b2e6cb890149d367d837c94f510f |
| 96bbd51 | https://github.com/nodejs/node/commit/96bbd5179712b2e6cb890149d367d837c94f510f |
| #47164 | https://github.com/nodejs/node/pull/47164 |
| #52185 | https://github.com/nodejs/node/pull/52185 |
| marco-ippolito | https://github.com/marco-ippolito |
|
May 2, 2024
| https://github.com/nodejs/node/pull/52185#ref-commit-f6585f4 |
|
| https://github.com/cjihrig |
|
| https://github.com/marco-ippolito |
| test_runner: don't await the same promise for each test | https://github.com/nodejs/node/commit/f6585f45d47359af646442bc4a0dff025257855e |
| f6585f4 | https://github.com/nodejs/node/commit/f6585f45d47359af646442bc4a0dff025257855e |
| #52185 | https://github.com/nodejs/node/pull/52185 |
| #47164 | https://github.com/nodejs/node/pull/47164 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
May 2, 2024
| https://github.com/nodejs/node/pull/52185#ref-pullrequest-2275045625 |
|
v20.13.0 proposal
#52793
| https://github.com/nodejs/node/pull/52793 |
| marco-ippolito | https://github.com/marco-ippolito |
|
May 3, 2024
| https://github.com/nodejs/node/pull/52185#ref-commit-8a0b721 |
|
| https://github.com/cjihrig |
|
| https://github.com/marco-ippolito |
| test: fix incorrect test fixture | https://github.com/nodejs/node/commit/8a0b7219309e164a009eb3024a136a9c61d1f9db |
| 8a0b721 | https://github.com/nodejs/node/commit/8a0b7219309e164a009eb3024a136a9c61d1f9db |
| #47164 | https://github.com/nodejs/node/pull/47164 |
| #52185 | https://github.com/nodejs/node/pull/52185 |
| marco-ippolito | https://github.com/marco-ippolito |
|
May 23, 2024
| https://github.com/nodejs/node/pull/52185#ref-commit-a501860 |
|
| https://github.com/cjihrig |
|
| https://github.com/marco-ippolito |
| test_runner: don't await the same promise for each test | https://github.com/nodejs/node/commit/a501860d63e8b571bad613cc7a13da5c66261578 |
| a501860 | https://github.com/nodejs/node/commit/a501860d63e8b571bad613cc7a13da5c66261578 |
| #52185 | https://github.com/nodejs/node/pull/52185 |
| #47164 | https://github.com/nodejs/node/pull/47164 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
May 23, 2024
| https://github.com/nodejs/node/pull/52185#ref-pullrequest-2313288054 |
|
v20.14.0 proposal
#53120
| https://github.com/nodejs/node/pull/53120 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52185 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/52185/files/ed1821a0095f41f7ab3f77c4297b5a92be62360b |
|
| https://github.com/atlowChemi |
|
atlowChemi
| https://github.com/atlowChemi |
|
| https://github.com/nodejs/node/pull/52185/files/ed1821a0095f41f7ab3f77c4297b5a92be62360b |
|
| https://github.com/MoLow |
|
MoLow
| https://github.com/MoLow |
| Please reload this page | https://github.com/nodejs/node/pull/52185 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
commit-queue-rebase
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-rebase |
|
test_runner
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner |
| Please reload this page | https://github.com/nodejs/node/pull/52185 |
|
| https://github.com/cjihrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/lpinca |
|
| https://github.com/MoLow |
|
| https://github.com/atlowChemi |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |