René's URL Explorer Experiment


Title: test_runner: don't await the same promise for each test by cjihrig · Pull Request #52185 · nodejs/node · GitHub

Open Graph Title: test_runner: don't await the same promise for each test by cjihrig · Pull Request #52185 · nodejs/node

X Title: test_runner: don't await the same promise for each test by cjihrig · Pull Request #52185 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: test: fix incorrect test fixture This commit updates a test runner fixture that includes a failing child test. However, the nested test is created using the top level test() function instead t.test...

X Description: test: fix incorrect test fixture This commit updates a test runner fixture that includes a failing child test. However, the nested test is created using the top level test() function instead t.test...

Opengraph URL: https://github.com/nodejs/node/pull/52185

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:57bfdb87-4f80-5237-ab80-d597702c8b57
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id861A:1E74B0:60230F:7A340A:6B03523D
html-safe-noncef9a37d5368571986faad3cce495d5c2509ca1d920819d245e97ae1284a3fb1db
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjFBOjFFNzRCMDo2MDIzMEY6N0EzNDBBOjZCMDM1MjNEIiwidmlzaXRvcl9pZCI6IjE1OTc1NjkwMjk0OTE2MTAxNzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2f36fecda8630499bef574a0773fc3d197041bb3064b4d8bad6feac02e48369e
hovercard-subject-tagpull_request:1785690259
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/52185/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f493a470c36124a7e10ebf7fab6a20f6fbec674bc55484e3dcea1c44f40339ef/nodejs/node/pull/52185
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f493a470c36124a7e10ebf7fab6a20f6fbec674bc55484e3dcea1c44f40339ef/nodejs/node/pull/52185
og:image:alttest: fix incorrect test fixture This commit updates a test runner fixture that includes a failing child test. However, the nested test is created using the top level test() function instead t.test...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/52185#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52185
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52185
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/52185
Reloadhttps://github.com/nodejs/node/pull/52185
Reloadhttps://github.com/nodejs/node/pull/52185
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
cjihrighttps://github.com/cjihrig
nodejs:mainhttps://github.com/nodejs/node/tree/main
cjihrig:extra-awaithttps://github.com/cjihrig/node/tree/extra-await
Conversationhttps://github.com/nodejs/node/pull/52185
Commits2 (2)https://github.com/nodejs/node/pull/52185/commits
Checkshttps://github.com/nodejs/node/pull/52185/checks
Files changedhttps://github.com/nodejs/node/pull/52185/files
test_runner: don't await the same promise for each testhttps://github.com/nodejs/node/pull/52185#top
cjihrighttps://github.com/cjihrig
nodejs:mainhttps://github.com/nodejs/node/tree/main
cjihrig:extra-awaithttps://github.com/cjihrig/node/tree/extra-await
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 22, 2024https://github.com/nodejs/node/pull/52185#issue-2201502059
#47164https://github.com/nodejs/node/pull/47164
Please reload this pagehttps://github.com/nodejs/node/pull/52185
cjihrighttps://github.com/cjihrig
March 21, 2024 20:54https://github.com/nodejs/node/pull/52185#commits-pushed-b7d0808
https://github.com/cjihrig
test: fix incorrect test fixturehttps://github.com/nodejs/node/pull/52185/commits/b7d08089d1dd269b48c088f675234ccadc736cce
b7d0808https://github.com/nodejs/node/pull/52185/commits/b7d08089d1dd269b48c088f675234ccadc736cce
nodejs#47164https://github.com/nodejs/node/pull/47164
https://github.com/cjihrig
test_runner: don't await the same promise for each testhttps://github.com/nodejs/node/pull/52185/commits/ed1821a0095f41f7ab3f77c4297b5a92be62360b
ed1821ahttps://github.com/nodejs/node/pull/52185/commits/ed1821a0095f41f7ab3f77c4297b5a92be62360b
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 22, 2024https://github.com/nodejs/node/pull/52185#issuecomment-2014152049
Please reload this pagehttps://github.com/nodejs/node/pull/52185
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
Mar 22, 2024https://github.com/nodejs/node/pull/52185#event-12209712078
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
MoLowhttps://github.com/MoLow
atlowChemihttps://github.com/atlowChemi
March 22, 2024 12:05https://github.com/nodejs/node/pull/52185#event-12214831335
https://github.com/lpinca
lpincahttps://github.com/lpinca
Mar 22, 2024 https://github.com/nodejs/node/pull/52185#pullrequestreview-1955440329
View reviewed changes https://github.com/nodejs/node/pull/52185/files/ed1821a0095f41f7ab3f77c4297b5a92be62360b
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Mar 23, 2024https://github.com/nodejs/node/pull/52185#event-12224454521
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Mar 23, 2024https://github.com/nodejs/node/pull/52185#event-12224460981
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 23, 2024https://github.com/nodejs/node/pull/52185#issuecomment-2016500769
https://ci.nodejs.org/job/node-test-pull-request/57916/https://ci.nodejs.org/job/node-test-pull-request/57916/
Please reload this pagehttps://github.com/nodejs/node/pull/52185
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Mar 24, 2024https://github.com/nodejs/node/pull/52185#event-12226814179
https://github.com/atlowChemi
atlowChemihttps://github.com/atlowChemi
Mar 24, 2024 https://github.com/nodejs/node/pull/52185#pullrequestreview-1956660945
View reviewed changes https://github.com/nodejs/node/pull/52185/files/ed1821a0095f41f7ab3f77c4297b5a92be62360b
lib/internal/test_runner/harness.jshttps://github.com/nodejs/node/pull/52185/files/ed1821a0095f41f7ab3f77c4297b5a92be62360b#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
atlowChemihttps://github.com/atlowChemi
Mar 24, 2024https://github.com/nodejs/node/pull/52185#discussion_r1536916009
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/52185
MoLowhttps://github.com/MoLow
Mar 26, 2024https://github.com/nodejs/node/pull/52185#discussion_r1538820882
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/52185
cjihrighttps://github.com/cjihrig
Mar 26, 2024https://github.com/nodejs/node/pull/52185#discussion_r1539209393
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@MoLowhttps://github.com/MoLow
#52185 (comment)https://github.com/nodejs/node/pull/52185#discussion_r1536953698
MDNhttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/await
Please reload this pagehttps://github.com/nodejs/node/pull/52185
test/fixtures/test-runner/output/default_output.jshttps://github.com/nodejs/node/pull/52185/files/ed1821a0095f41f7ab3f77c4297b5a92be62360b#diff-d43761c362ad3ea9db5306192c0b7e3e0ab121d8236fd26495ae4bdf9441c406
Please reload this pagehttps://github.com/nodejs/node/pull/52185
https://github.com/atlowChemi
atlowChemihttps://github.com/atlowChemi
commit-queue-rebase https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-rebase
Mar 24, 2024https://github.com/nodejs/node/pull/52185#event-12227649367
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Mar 25, 2024https://github.com/nodejs/node/pull/52185#event-12228142645
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Mar 25, 2024https://github.com/nodejs/node/pull/52185#event-12228184319
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 25, 2024https://github.com/nodejs/node/pull/52185#issuecomment-2017033603
bae14b7...4648c83https://github.com/nodejs/node/compare/bae14b7914624630c3e451def82a8f56c6402534...4648c83dbc695a77980777b9b7e712303369ff9e
Please reload this pagehttps://github.com/nodejs/node/pull/52185
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 25, 2024 https://github.com/nodejs/node/pull/52185#ref-commit-5905596
https://github.com/cjihrig
https://github.com/nodejs-github-bot
test: fix incorrect test fixturehttps://github.com/nodejs/node/commit/5905596719efc7d419b5743056f364d4d6089626
5905596https://github.com/nodejs/node/commit/5905596719efc7d419b5743056f364d4d6089626
#47164https://github.com/nodejs/node/pull/47164
#52185https://github.com/nodejs/node/pull/52185
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 25, 2024 https://github.com/nodejs/node/pull/52185#ref-commit-4648c83
https://github.com/cjihrig
https://github.com/nodejs-github-bot
test_runner: don't await the same promise for each testhttps://github.com/nodejs/node/commit/4648c83dbc695a77980777b9b7e712303369ff9e
4648c83https://github.com/nodejs/node/commit/4648c83dbc695a77980777b9b7e712303369ff9e
#52185https://github.com/nodejs/node/pull/52185
#47164https://github.com/nodejs/node/pull/47164
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 25, 2024https://github.com/nodejs/node/pull/52185#event-12228184958
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
March 25, 2024 23:19https://github.com/nodejs/node/pull/52185#event-12241968116
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Apr 15, 2024 https://github.com/nodejs/node/pull/52185#ref-pullrequest-2240703753
2024-04-24, Version 22.0.0 (Current) #52505 https://github.com/nodejs/node/pull/52505
marco-ippolitohttps://github.com/marco-ippolito
May 2, 2024 https://github.com/nodejs/node/pull/52185#ref-commit-96bbd51
https://github.com/cjihrig
https://github.com/marco-ippolito
test: fix incorrect test fixturehttps://github.com/nodejs/node/commit/96bbd5179712b2e6cb890149d367d837c94f510f
96bbd51https://github.com/nodejs/node/commit/96bbd5179712b2e6cb890149d367d837c94f510f
#47164https://github.com/nodejs/node/pull/47164
#52185https://github.com/nodejs/node/pull/52185
marco-ippolitohttps://github.com/marco-ippolito
May 2, 2024 https://github.com/nodejs/node/pull/52185#ref-commit-f6585f4
https://github.com/cjihrig
https://github.com/marco-ippolito
test_runner: don't await the same promise for each testhttps://github.com/nodejs/node/commit/f6585f45d47359af646442bc4a0dff025257855e
f6585f4https://github.com/nodejs/node/commit/f6585f45d47359af646442bc4a0dff025257855e
#52185https://github.com/nodejs/node/pull/52185
#47164https://github.com/nodejs/node/pull/47164
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
May 2, 2024 https://github.com/nodejs/node/pull/52185#ref-pullrequest-2275045625
v20.13.0 proposal #52793 https://github.com/nodejs/node/pull/52793
marco-ippolitohttps://github.com/marco-ippolito
May 3, 2024 https://github.com/nodejs/node/pull/52185#ref-commit-8a0b721
https://github.com/cjihrig
https://github.com/marco-ippolito
test: fix incorrect test fixturehttps://github.com/nodejs/node/commit/8a0b7219309e164a009eb3024a136a9c61d1f9db
8a0b721https://github.com/nodejs/node/commit/8a0b7219309e164a009eb3024a136a9c61d1f9db
#47164https://github.com/nodejs/node/pull/47164
#52185https://github.com/nodejs/node/pull/52185
marco-ippolitohttps://github.com/marco-ippolito
May 23, 2024 https://github.com/nodejs/node/pull/52185#ref-commit-a501860
https://github.com/cjihrig
https://github.com/marco-ippolito
test_runner: don't await the same promise for each testhttps://github.com/nodejs/node/commit/a501860d63e8b571bad613cc7a13da5c66261578
a501860https://github.com/nodejs/node/commit/a501860d63e8b571bad613cc7a13da5c66261578
#52185https://github.com/nodejs/node/pull/52185
#47164https://github.com/nodejs/node/pull/47164
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
May 23, 2024 https://github.com/nodejs/node/pull/52185#ref-pullrequest-2313288054
v20.14.0 proposal #53120 https://github.com/nodejs/node/pull/53120
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52185
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/52185/files/ed1821a0095f41f7ab3f77c4297b5a92be62360b
https://github.com/atlowChemi
atlowChemi https://github.com/atlowChemi
https://github.com/nodejs/node/pull/52185/files/ed1821a0095f41f7ab3f77c4297b5a92be62360b
https://github.com/MoLow
MoLow https://github.com/MoLow
Please reload this pagehttps://github.com/nodejs/node/pull/52185
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue-rebase https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-rebase
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
Please reload this pagehttps://github.com/nodejs/node/pull/52185
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/MoLow
https://github.com/atlowChemi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.