René's URL Explorer Experiment


Title: deps: V8: backports for gcc 12 by richardlau · Pull Request #52183 · nodejs/node · GitHub

Open Graph Title: deps: V8: backports for gcc 12 by richardlau · Pull Request #52183 · nodejs/node

X Title: deps: V8: backports for gcc 12 by richardlau · Pull Request #52183 · nodejs/node

Description: Original commit message: Fix build with older versions of GCC. This ports the change from bazel on v8: https://crrev.com/c/3368869 Compilation errors started showing after this CL: https://crrev.com/c/5199515 Change-Id: I8c161a0d9ad5c04d452c444ef4feafae2ef4f6db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5280535 Reviewed-by: Leszek Swirski Commit-Queue: Milad Farazmand Cr-Commit-Position: refs/heads/main@{#92252} Refs: v8/v8@f8d5e57 Original commit message: Fix build with gcc12 - A number of erroneous flags have been added to BUILD.gn - wasm-init-expr.cc is creating an 8 byte buffer witch may be much smaller than max size_t output. We also need to make room for the `f` character and the terminating null character - inspector_protocol currently generates the following error ``` error: loop variable ‘json_in’ of type ‘const std::string&’ {aka ‘const std::__cxx11::basic_string&’} binds to a temporary constructed from type ‘const char* const’ ``` Change-Id: I1139899b2664e47d01ebc44f2e972fc4c0ec212d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5331756 Reviewed-by: Matthias Liedtke Commit-Queue: Milad Farazmand Reviewed-by: Toon Verwaest Cr-Commit-Position: refs/heads/main@{#92615} Refs: v8/v8@c4be0a9

Open Graph Description: Original commit message: Fix build with older versions of GCC. This ports the change from bazel on v8: https://crrev.com/c/3368869 Compilation errors started showing after this CL: https://crrev....

X Description: Original commit message: Fix build with older versions of GCC. This ports the change from bazel on v8: https://crrev.com/c/3368869 Compilation errors started showing after this CL: https://crrev....

Opengraph URL: https://github.com/nodejs/node/pull/52183

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.112.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:10814118-985e-33eb-3930-faebb5ac3d66
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA9BA:26CE8C:332A2B6:43A901D:6B0360EC
html-safe-noncecf4fa592f466f3d6940382e3b4454f1cb935512a12c9d37537a377c6335d2044
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUJBOjI2Q0U4QzozMzJBMkI2OjQzQTkwMUQ6NkIwMzYwRUMiLCJ2aXNpdG9yX2lkIjoiMjU5ODk4NTI0OTE5OTQ0ODMwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4764ec574e159e080ebf45fda0f8340cb85dde6871ef23c7e4ce9e35fd933b86
hovercard-subject-tagpull_request:1785258932
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/52183/files
twitter:imagehttps://avatars.githubusercontent.com/u/5445507?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5445507?s=400&v=4
og:image:altOriginal commit message: Fix build with older versions of GCC. This ports the change from bazel on v8: https://crrev.com/c/3368869 Compilation errors started showing after this CL: https://crrev....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/52183/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52183%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52183%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/52183/files
Reloadhttps://github.com/nodejs/node/pull/52183/files
Reloadhttps://github.com/nodejs/node/pull/52183/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues639 (639)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
richardlauhttps://github.com/richardlau
nodejs:mainhttps://github.com/nodejs/node/tree/main
richardlau:v8-gcc12https://github.com/richardlau/node-1/tree/v8-gcc12
Conversation 10 https://github.com/nodejs/node/pull/52183
Commits 2 https://github.com/nodejs/node/pull/52183/commits
Checks 0 https://github.com/nodejs/node/pull/52183/checks
Files changed https://github.com/nodejs/node/pull/52183/files
Please reload this pagehttps://github.com/nodejs/node/pull/52183/files
deps: V8: backports for gcc 12 https://github.com/nodejs/node/pull/52183/files#top
Show all changes 2 commits https://github.com/nodejs/node/pull/52183/files
9390aa3 deps: V8: cherry-pick f8d5e576b814 richardlau Mar 21, 2024 https://github.com/nodejs/node/pull/52183/commits/9390aa373b84f68711230fcba76916e22337f26a
d1cb8c1 deps: V8: backport c4be0a97f981 richardlau Mar 21, 2024 https://github.com/nodejs/node/pull/52183/commits/d1cb8c100cdbb49f98383ffcace7586912c36a64
Clear filters https://github.com/nodejs/node/pull/52183/files
Please reload this pagehttps://github.com/nodejs/node/pull/52183/files
Please reload this pagehttps://github.com/nodejs/node/pull/52183/files
common.gypi https://github.com/nodejs/node/pull/52183/files#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb
BUILD.gn https://github.com/nodejs/node/pull/52183/files#diff-c5f668a7e3a95bb9df5bc165514d324ad89421338302625d614ef5b11a74d18d
d8.cc https://github.com/nodejs/node/pull/52183/files#diff-f53d564ebaf76193c7a15f878a34a76f425e680a36b8c47c7004af54762917d1
function-compiler.cc https://github.com/nodejs/node/pull/52183/files#diff-4a102bdcec0094b007cb6c607fb8239b93ffed046c644971e1642057194a6bab
dispatch_test.cc https://github.com/nodejs/node/pull/52183/files#diff-75edcacaede208964903ba409b2adf641e99491516a1e60823197af526d44f82
json_test.cc https://github.com/nodejs/node/pull/52183/files#diff-151286fe4054ec967efb9b1b1740403dca4edbbfb7b2a7ba026a01fa5f71c73f
common.gypihttps://github.com/nodejs/node/pull/52183/files#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb
View file https://github.com/richardlau/node-1/blob/d1cb8c100cdbb49f98383ffcace7586912c36a64/common.gypi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/52183/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/52183/files#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb
https://github.com/nodejs/node/pull/52183/files#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb
deps/v8/BUILD.gnhttps://github.com/nodejs/node/pull/52183/files#diff-c5f668a7e3a95bb9df5bc165514d324ad89421338302625d614ef5b11a74d18d
View file https://github.com/richardlau/node-1/blob/d1cb8c100cdbb49f98383ffcace7586912c36a64/deps/v8/BUILD.gn
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/52183/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/52183/files#diff-c5f668a7e3a95bb9df5bc165514d324ad89421338302625d614ef5b11a74d18d
https://github.com/nodejs/node/pull/52183/files#diff-c5f668a7e3a95bb9df5bc165514d324ad89421338302625d614ef5b11a74d18d
deps/v8/src/d8/d8.cchttps://github.com/nodejs/node/pull/52183/files#diff-f53d564ebaf76193c7a15f878a34a76f425e680a36b8c47c7004af54762917d1
View file https://github.com/richardlau/node-1/blob/d1cb8c100cdbb49f98383ffcace7586912c36a64/deps/v8/src/d8/d8.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/52183/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/52183/files#diff-f53d564ebaf76193c7a15f878a34a76f425e680a36b8c47c7004af54762917d1
https://github.com/nodejs/node/pull/52183/files#diff-f53d564ebaf76193c7a15f878a34a76f425e680a36b8c47c7004af54762917d1
deps/v8/src/wasm/function-compiler.cchttps://github.com/nodejs/node/pull/52183/files#diff-4a102bdcec0094b007cb6c607fb8239b93ffed046c644971e1642057194a6bab
View file https://github.com/richardlau/node-1/blob/d1cb8c100cdbb49f98383ffcace7586912c36a64/deps/v8/src/wasm/function-compiler.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/52183/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/52183/files#diff-4a102bdcec0094b007cb6c607fb8239b93ffed046c644971e1642057194a6bab
https://github.com/nodejs/node/pull/52183/files#diff-4a102bdcec0094b007cb6c607fb8239b93ffed046c644971e1642057194a6bab
https://github.com/nodejs/node/pull/52183/files#diff-4a102bdcec0094b007cb6c607fb8239b93ffed046c644971e1642057194a6bab
https://github.com/nodejs/node/pull/52183/files#diff-4a102bdcec0094b007cb6c607fb8239b93ffed046c644971e1642057194a6bab
https://github.com/nodejs/node/pull/52183/files#diff-4a102bdcec0094b007cb6c607fb8239b93ffed046c644971e1642057194a6bab
deps/v8/third_party/inspector_protocol/crdtp/dispatch_test.cchttps://github.com/nodejs/node/pull/52183/files#diff-75edcacaede208964903ba409b2adf641e99491516a1e60823197af526d44f82
View file https://github.com/richardlau/node-1/blob/d1cb8c100cdbb49f98383ffcace7586912c36a64/deps/v8/third_party/inspector_protocol/crdtp/dispatch_test.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/52183/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/52183/files#diff-75edcacaede208964903ba409b2adf641e99491516a1e60823197af526d44f82
https://github.com/nodejs/node/pull/52183/files#diff-75edcacaede208964903ba409b2adf641e99491516a1e60823197af526d44f82
https://github.com/nodejs/node/pull/52183/files#diff-75edcacaede208964903ba409b2adf641e99491516a1e60823197af526d44f82
deps/v8/third_party/inspector_protocol/crdtp/json_test.cchttps://github.com/nodejs/node/pull/52183/files#diff-151286fe4054ec967efb9b1b1740403dca4edbbfb7b2a7ba026a01fa5f71c73f
View file https://github.com/richardlau/node-1/blob/d1cb8c100cdbb49f98383ffcace7586912c36a64/deps/v8/third_party/inspector_protocol/crdtp/json_test.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/52183/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/52183/files#diff-151286fe4054ec967efb9b1b1740403dca4edbbfb7b2a7ba026a01fa5f71c73f
https://github.com/nodejs/node/pull/52183/files#diff-151286fe4054ec967efb9b1b1740403dca4edbbfb7b2a7ba026a01fa5f71c73f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.