| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:10814118-985e-33eb-3930-faebb5ac3d66 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A9BA:26CE8C:332A2B6:43A901D:6B0360EC |
| html-safe-nonce | cf4fa592f466f3d6940382e3b4454f1cb935512a12c9d37537a377c6335d2044 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUJBOjI2Q0U4QzozMzJBMkI2OjQzQTkwMUQ6NkIwMzYwRUMiLCJ2aXNpdG9yX2lkIjoiMjU5ODk4NTI0OTE5OTQ0ODMwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4764ec574e159e080ebf45fda0f8340cb85dde6871ef23c7e4ce9e35fd933b86 |
| hovercard-subject-tag | pull_request:1785258932 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/52183/files |
| twitter:image | https://avatars.githubusercontent.com/u/5445507?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5445507?s=400&v=4 |
| og:image:alt | Original commit message:
Fix build with older versions of GCC.
This ports the change from bazel on v8:
https://crrev.com/c/3368869
Compilation errors started showing after this CL:
https://crrev.... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/52183/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52183%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52183%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/52183/files |
| Reload | https://github.com/nodejs/node/pull/52183/files |
| Reload | https://github.com/nodejs/node/pull/52183/files |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues639 (639) | https://github.com/nodejs/node/issues |
| Pull requests667 (667) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| richardlau | https://github.com/richardlau |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| richardlau:v8-gcc12 | https://github.com/richardlau/node-1/tree/v8-gcc12 |
|
Conversation
10
| https://github.com/nodejs/node/pull/52183 |
|
Commits
2
| https://github.com/nodejs/node/pull/52183/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/52183/checks |
|
Files changed
| https://github.com/nodejs/node/pull/52183/files |
| Please reload this page | https://github.com/nodejs/node/pull/52183/files |
|
deps: V8: backports for gcc 12
| https://github.com/nodejs/node/pull/52183/files#top |
|
Show all changes
2 commits
| https://github.com/nodejs/node/pull/52183/files |
|
9390aa3
deps: V8: cherry-pick f8d5e576b814
richardlau Mar 21, 2024
| https://github.com/nodejs/node/pull/52183/commits/9390aa373b84f68711230fcba76916e22337f26a |
|
d1cb8c1
deps: V8: backport c4be0a97f981
richardlau Mar 21, 2024
| https://github.com/nodejs/node/pull/52183/commits/d1cb8c100cdbb49f98383ffcace7586912c36a64 |
|
Clear filters
| https://github.com/nodejs/node/pull/52183/files |
| Please reload this page | https://github.com/nodejs/node/pull/52183/files |
| Please reload this page | https://github.com/nodejs/node/pull/52183/files |
|
common.gypi
| https://github.com/nodejs/node/pull/52183/files#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb |
|
BUILD.gn
| https://github.com/nodejs/node/pull/52183/files#diff-c5f668a7e3a95bb9df5bc165514d324ad89421338302625d614ef5b11a74d18d |
|
d8.cc
| https://github.com/nodejs/node/pull/52183/files#diff-f53d564ebaf76193c7a15f878a34a76f425e680a36b8c47c7004af54762917d1 |
|
function-compiler.cc
| https://github.com/nodejs/node/pull/52183/files#diff-4a102bdcec0094b007cb6c607fb8239b93ffed046c644971e1642057194a6bab |
|
dispatch_test.cc
| https://github.com/nodejs/node/pull/52183/files#diff-75edcacaede208964903ba409b2adf641e99491516a1e60823197af526d44f82 |
|
json_test.cc
| https://github.com/nodejs/node/pull/52183/files#diff-151286fe4054ec967efb9b1b1740403dca4edbbfb7b2a7ba026a01fa5f71c73f |
| common.gypi | https://github.com/nodejs/node/pull/52183/files#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb |
|
View file
| https://github.com/richardlau/node-1/blob/d1cb8c100cdbb49f98383ffcace7586912c36a64/common.gypi |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/52183/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/52183/files#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb |
|
| https://github.com/nodejs/node/pull/52183/files#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb |
| deps/v8/BUILD.gn | https://github.com/nodejs/node/pull/52183/files#diff-c5f668a7e3a95bb9df5bc165514d324ad89421338302625d614ef5b11a74d18d |
|
View file
| https://github.com/richardlau/node-1/blob/d1cb8c100cdbb49f98383ffcace7586912c36a64/deps/v8/BUILD.gn |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/52183/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/52183/files#diff-c5f668a7e3a95bb9df5bc165514d324ad89421338302625d614ef5b11a74d18d |
|
| https://github.com/nodejs/node/pull/52183/files#diff-c5f668a7e3a95bb9df5bc165514d324ad89421338302625d614ef5b11a74d18d |
| deps/v8/src/d8/d8.cc | https://github.com/nodejs/node/pull/52183/files#diff-f53d564ebaf76193c7a15f878a34a76f425e680a36b8c47c7004af54762917d1 |
|
View file
| https://github.com/richardlau/node-1/blob/d1cb8c100cdbb49f98383ffcace7586912c36a64/deps/v8/src/d8/d8.cc |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/52183/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/52183/files#diff-f53d564ebaf76193c7a15f878a34a76f425e680a36b8c47c7004af54762917d1 |
|
| https://github.com/nodejs/node/pull/52183/files#diff-f53d564ebaf76193c7a15f878a34a76f425e680a36b8c47c7004af54762917d1 |
| deps/v8/src/wasm/function-compiler.cc | https://github.com/nodejs/node/pull/52183/files#diff-4a102bdcec0094b007cb6c607fb8239b93ffed046c644971e1642057194a6bab |
|
View file
| https://github.com/richardlau/node-1/blob/d1cb8c100cdbb49f98383ffcace7586912c36a64/deps/v8/src/wasm/function-compiler.cc |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/52183/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/52183/files#diff-4a102bdcec0094b007cb6c607fb8239b93ffed046c644971e1642057194a6bab |
|
| https://github.com/nodejs/node/pull/52183/files#diff-4a102bdcec0094b007cb6c607fb8239b93ffed046c644971e1642057194a6bab |
|
| https://github.com/nodejs/node/pull/52183/files#diff-4a102bdcec0094b007cb6c607fb8239b93ffed046c644971e1642057194a6bab |
|
| https://github.com/nodejs/node/pull/52183/files#diff-4a102bdcec0094b007cb6c607fb8239b93ffed046c644971e1642057194a6bab |
|
| https://github.com/nodejs/node/pull/52183/files#diff-4a102bdcec0094b007cb6c607fb8239b93ffed046c644971e1642057194a6bab |
| deps/v8/third_party/inspector_protocol/crdtp/dispatch_test.cc | https://github.com/nodejs/node/pull/52183/files#diff-75edcacaede208964903ba409b2adf641e99491516a1e60823197af526d44f82 |
|
View file
| https://github.com/richardlau/node-1/blob/d1cb8c100cdbb49f98383ffcace7586912c36a64/deps/v8/third_party/inspector_protocol/crdtp/dispatch_test.cc |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/52183/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/52183/files#diff-75edcacaede208964903ba409b2adf641e99491516a1e60823197af526d44f82 |
|
| https://github.com/nodejs/node/pull/52183/files#diff-75edcacaede208964903ba409b2adf641e99491516a1e60823197af526d44f82 |
|
| https://github.com/nodejs/node/pull/52183/files#diff-75edcacaede208964903ba409b2adf641e99491516a1e60823197af526d44f82 |
| deps/v8/third_party/inspector_protocol/crdtp/json_test.cc | https://github.com/nodejs/node/pull/52183/files#diff-151286fe4054ec967efb9b1b1740403dca4edbbfb7b2a7ba026a01fa5f71c73f |
|
View file
| https://github.com/richardlau/node-1/blob/d1cb8c100cdbb49f98383ffcace7586912c36a64/deps/v8/third_party/inspector_protocol/crdtp/json_test.cc |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/52183/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/52183/files#diff-151286fe4054ec967efb9b1b1740403dca4edbbfb7b2a7ba026a01fa5f71c73f |
|
| https://github.com/nodejs/node/pull/52183/files#diff-151286fe4054ec967efb9b1b1740403dca4edbbfb7b2a7ba026a01fa5f71c73f |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |