| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c4efee9f-1cdf-4cf5-b073-6c1b3e1fd211 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9118:2F339D:913824:C14554:6AED2CE3 |
| html-safe-nonce | 815d60e87a9fa2fbc681b29cd0e9b39f5634db4649dbdd2db17e2555f91f243d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTE4OjJGMzM5RDo5MTM4MjQ6QzE0NTU0OjZBRUQyQ0UzIiwidmlzaXRvcl9pZCI6IjcwNjg1Mzc4Mjg5OTk1MDcxNzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 90b19880795fc52aee96107273ba4eb651e67b5a223b7b026ba190d2bda03846 |
| hovercard-subject-tag | pull_request:1775629064 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/52119/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/edd76273c802ece91661206a3462fa118eb7caddf01504baf61bb7a32d95cb5d/nodejs/node/pull/52119 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/edd76273c802ece91661206a3462fa118eb7caddf01504baf61bb7a32d95cb5d/nodejs/node/pull/52119 |
| og:image:alt | Currently we can call listen twice with same server in cluster worker. It will make some issues.
the server will emit listening event twice(See lib: make sure clear the old timer in http server #5... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | theanarkh |
| hostname | github.com |
| expected-hostname | github.com |
| None | e51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ebb7b901cc154ecc179a44f266fcf69f343b30 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/52119#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52119 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52119 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/52119 |
| Reload | https://github.com/nodejs/node/pull/52119 |
| Reload | https://github.com/nodejs/node/pull/52119 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues656 (656) | https://github.com/nodejs/node/issues |
| Pull requests666 (666) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/pulse |
| https://github.com/nodejs/node |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| theanarkh:fix_call_net_listen_twice | https://github.com/theanarkh/node/tree/fix_call_net_listen_twice |
| Conversation | https://github.com/nodejs/node/pull/52119 |
| Commits1 (1) | https://github.com/nodejs/node/pull/52119/commits |
| Checks | https://github.com/nodejs/node/pull/52119/checks |
| Files changed | https://github.com/nodejs/node/pull/52119/files |
| lib: emit listening event once when call listen twice | https://github.com/nodejs/node/pull/52119#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| theanarkh:fix_call_net_listen_twice | https://github.com/theanarkh/node/tree/fix_call_net_listen_twice |
|
| https://github.com/theanarkh |
| theanarkh | https://github.com/theanarkh |
| Mar 16, 2024 | https://github.com/nodejs/node/pull/52119#issue-2190180707 |
| lib: make sure clear the old timer in http server #52118 | https://github.com/nodejs/node/pull/52118 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/52119 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 16, 2024 | https://github.com/nodejs/node/pull/52119#issuecomment-2002082892 |
| Please reload this page | https://github.com/nodejs/node/pull/52119 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
| Mar 16, 2024 | https://github.com/nodejs/node/pull/52119#event-12140610002 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
|
Mar 18, 2024
| https://github.com/nodejs/node/pull/52119#pullrequestreview-1942044076 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52119/files |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Mar 18, 2024
| https://github.com/nodejs/node/pull/52119#pullrequestreview-1942412097 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52119/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/52119#pullrequestreview-1942412097 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/52119 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Mar 18, 2024 | https://github.com/nodejs/node/pull/52119#event-12148705114 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Mar 18, 2024 | https://github.com/nodejs/node/pull/52119#event-12148738105 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 18, 2024 | https://github.com/nodejs/node/pull/52119#issuecomment-2003341002 |
| https://ci.nodejs.org/job/node-test-pull-request/57799/ | https://ci.nodejs.org/job/node-test-pull-request/57799/ |
| Please reload this page | https://github.com/nodejs/node/pull/52119 |
| https://github.com/theanarkh |
| theanarkh | https://github.com/theanarkh |
| force-pushed | https://github.com/nodejs/node/compare/ae3fc20bbb1ce1664ab68764d85dc877c7006da3..dae3f7e9b104780577af025fabacfd037d7f44e1 |
| ae3fc20 | https://github.com/nodejs/node/commit/ae3fc20bbb1ce1664ab68764d85dc877c7006da3 |
| dae3f7e | https://github.com/nodejs/node/commit/dae3f7e9b104780577af025fabacfd037d7f44e1 |
|
Compare
| https://github.com/nodejs/node/compare/ae3fc20bbb1ce1664ab68764d85dc877c7006da3..dae3f7e9b104780577af025fabacfd037d7f44e1 |
| March 18, 2024 15:37 | https://github.com/nodejs/node/pull/52119#event-12154411837 |
|
| https://github.com/theanarkh |
| lib: emit listening event once when call listen twice | https://github.com/nodejs/node/pull/52119/commits/db908c771a55891ded4d837ce4b2435cb53e2740 |
| db908c7 | https://github.com/nodejs/node/pull/52119/commits/db908c771a55891ded4d837ce4b2435cb53e2740 |
| https://github.com/theanarkh |
| theanarkh | https://github.com/theanarkh |
| force-pushed | https://github.com/nodejs/node/compare/dae3f7e9b104780577af025fabacfd037d7f44e1..db908c771a55891ded4d837ce4b2435cb53e2740 |
| dae3f7e | https://github.com/nodejs/node/commit/dae3f7e9b104780577af025fabacfd037d7f44e1 |
| db908c7 | https://github.com/nodejs/node/commit/db908c771a55891ded4d837ce4b2435cb53e2740 |
|
Compare
| https://github.com/nodejs/node/compare/dae3f7e9b104780577af025fabacfd037d7f44e1..db908c771a55891ded4d837ce4b2435cb53e2740 |
| March 18, 2024 16:46 | https://github.com/nodejs/node/pull/52119#event-12155714395 |
| https://github.com/theanarkh |
| theanarkh | https://github.com/theanarkh |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Mar 19, 2024 | https://github.com/nodejs/node/pull/52119#event-12162193652 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Mar 19, 2024 | https://github.com/nodejs/node/pull/52119#event-12162221622 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 19, 2024 | https://github.com/nodejs/node/pull/52119#issuecomment-2005587431 |
| https://ci.nodejs.org/job/node-test-pull-request/57827/ | https://ci.nodejs.org/job/node-test-pull-request/57827/ |
| Please reload this page | https://github.com/nodejs/node/pull/52119 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 19, 2024 | https://github.com/nodejs/node/pull/52119#issuecomment-2006923498 |
| https://ci.nodejs.org/job/node-test-pull-request/57835/ | https://ci.nodejs.org/job/node-test-pull-request/57835/ |
| Please reload this page | https://github.com/nodejs/node/pull/52119 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Mar 19, 2024 | https://github.com/nodejs/node/pull/52119#event-12171337799 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Mar 19, 2024 | https://github.com/nodejs/node/pull/52119#event-12171463589 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 19, 2024 | https://github.com/nodejs/node/pull/52119#issuecomment-2007497616 |
| https://github.com/nodejs/node/actions/runs/8345768283 | https://github.com/nodejs/node/actions/runs/8345768283 |
| Please reload this page | https://github.com/nodejs/node/pull/52119 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Mar 19, 2024
| https://github.com/nodejs/node/pull/52119#pullrequestreview-1946681230 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52119/files/db908c771a55891ded4d837ce4b2435cb53e2740 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/52119#pullrequestreview-1946681230 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/52119 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Mar 19, 2024
| https://github.com/nodejs/node/pull/52119#pullrequestreview-1946681633 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/52119/files/db908c771a55891ded4d837ce4b2435cb53e2740 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/52119#pullrequestreview-1946681633 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/52119 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
|
commit-queue-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed |
| Mar 19, 2024 | https://github.com/nodejs/node/pull/52119#event-12171786127 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Mar 19, 2024 | https://github.com/nodejs/node/pull/52119#event-12171848425 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| 14de082 | https://github.com/nodejs/node/commit/14de082ab47cd461ab0cc9d205ff42d7c8f24b32 |
| Mar 19, 2024 | https://github.com/nodejs/node/pull/52119#event-12171849313 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 19, 2024 | https://github.com/nodejs/node/pull/52119#issuecomment-2007557911 |
| 14de082 | https://github.com/nodejs/node/commit/14de082ab47cd461ab0cc9d205ff42d7c8f24b32 |
| Please reload this page | https://github.com/nodejs/node/pull/52119 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
Apr 15, 2024
| https://github.com/nodejs/node/pull/52119#ref-pullrequest-2240703753 |
|
2024-04-24, Version 22.0.0 (Current)
#52505
| https://github.com/nodejs/node/pull/52505 |
| marco-ippolito | https://github.com/marco-ippolito |
|
May 2, 2024
| https://github.com/nodejs/node/pull/52119#ref-commit-28590b4 |
|
| https://github.com/theanarkh |
|
| https://github.com/marco-ippolito |
| lib: emit listening event once when call listen twice | https://github.com/nodejs/node/commit/28590b472289c992edf1b3b0b5f7c020779b0bd1 |
| 28590b4 | https://github.com/nodejs/node/commit/28590b472289c992edf1b3b0b5f7c020779b0bd1 |
| #52119 | https://github.com/nodejs/node/pull/52119 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
May 2, 2024
| https://github.com/nodejs/node/pull/52119#ref-pullrequest-2275045625 |
|
v20.13.0 proposal
#52793
| https://github.com/nodejs/node/pull/52793 |
| marco-ippolito | https://github.com/marco-ippolito |
|
May 3, 2024
| https://github.com/nodejs/node/pull/52119#ref-commit-d5d6e04 |
|
| https://github.com/theanarkh |
|
| https://github.com/marco-ippolito |
| lib: emit listening event once when call listen twice | https://github.com/nodejs/node/commit/d5d6e041c8a4ac1e0b98b70853f559d929a8a536 |
| d5d6e04 | https://github.com/nodejs/node/commit/d5d6e041c8a4ac1e0b98b70853f559d929a8a536 |
| #52119 | https://github.com/nodejs/node/pull/52119 |
| https://github.com/theanarkh |
| theanarkh | https://github.com/theanarkh |
|
May 30, 2024
| https://github.com/nodejs/node/pull/52119#ref-issue-2323889701 |
|
The registration order of http server listen depends on the Node.js version
#53204
| https://github.com/nodejs/node/issues/53204 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F52119 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/52119/files/db908c771a55891ded4d837ce4b2435cb53e2740 |
|
| https://github.com/ShogunPanda |
|
ShogunPanda
| https://github.com/ShogunPanda |
|
| https://github.com/nodejs/node/pull/52119/files/ae3fc20bbb1ce1664ab68764d85dc877c7006da3 |
| Please reload this page | https://github.com/nodejs/node/pull/52119 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
| Please reload this page | https://github.com/nodejs/node/pull/52119 |
|
| https://github.com/theanarkh |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mcollina |
|
| https://github.com/ShogunPanda |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |