| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a00803e1-65cd-1c98-2a11-1a239b9f4012 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D13E:305E50:4091859:5B8F075:6A56BA6C |
| html-safe-nonce | 435caf036110c41c320451f000665f2f020499ab845f47a24bbbc8c7925cb3f9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTNFOjMwNUU1MDo0MDkxODU5OjVCOEYwNzU6NkE1NkJBNkMiLCJ2aXNpdG9yX2lkIjoiNTIxMjM5MDY0NzQyNTA1NTM0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | db41b256bb127c97cd7eea64ddedab9fd08d3a4dabaeb88f3c9fe0dbbf9b0c04 |
| hovercard-subject-tag | pull_request:59169194 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/5204/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e7eb5ac3af2314746b256348a8df7d817cff7962307a4f72be298fde33be6663/nodejs/node/pull/5204 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e7eb5ac3af2314746b256348a8df7d817cff7962307a4f72be298fde33be6663/nodejs/node/pull/5204 |
| og:image:alt | Continuing from #5159, this PR replaces deprecated uses of SetAccessor and most uses of SetWeak on the vee-eight-4.9 branch.
The use of SetWeak in src/node_buffer.cc is more involved because it exp... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ofrobots |
| hostname | github.com |
| expected-hostname | github.com |
| None | df99b7164e1d961b639cf5d3cbd6b5ba673edc67bd7e47cdc4746b96099e11ae |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c29ba03b1896083dbe1084f6cd1c5367d8a0d67c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/5204#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5204 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5204 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/5204 |
| Reload | https://github.com/nodejs/node/pull/5204 |
| Reload | https://github.com/nodejs/node/pull/5204 |
| Please reload this page | https://github.com/nodejs/node/pull/5204 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/5204 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.2k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
1k
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| ofrobots | https://github.com/ofrobots |
| nodejs:vee-eight-4.9 | https://github.com/nodejs/node/tree/vee-eight-4.9 |
| ofrobots:vee-eight-4.9 | https://github.com/ofrobots/node/tree/vee-eight-4.9 |
| Conversation | https://github.com/nodejs/node/pull/5204 |
| Commits4 (4) | https://github.com/nodejs/node/pull/5204/commits |
| Checks | https://github.com/nodejs/node/pull/5204/checks |
| Files changed | https://github.com/nodejs/node/pull/5204/files |
| (vee-eight-4.9) Replace more deprecated V8 API usage | https://github.com/nodejs/node/pull/5204#top |
| ofrobots | https://github.com/ofrobots |
| nodejs:vee-eight-4.9 | https://github.com/nodejs/node/tree/vee-eight-4.9 |
| ofrobots:vee-eight-4.9 | https://github.com/ofrobots/node/tree/vee-eight-4.9 |
|
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Feb 12, 2016 | https://github.com/nodejs/node/pull/5204#issue-133233063 |
| #5159 | https://github.com/nodejs/node/pull/5159 |
| (vee-eight-4.9) contextify: update deprecated SetWeak usage #5392 | https://github.com/nodejs/node/pull/5392 |
| #4869 | https://github.com/nodejs/node/issues/4869 |
| @bnoordhuis | https://github.com/bnoordhuis |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/5204 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Feb 12, 2016 | https://github.com/nodejs/node/pull/5204#event-548482779 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| force-pushed | https://github.com/nodejs/node/compare/2d3c7b0197f2a4cee686a04a35edd8fa09044ddb..720f9f0cf0f1ce93acfd6faa9bf97562a1f0bd67 |
| 2d3c7b0 | https://github.com/nodejs/node/commit/2d3c7b0197f2a4cee686a04a35edd8fa09044ddb |
| 720f9f0 | https://github.com/nodejs/node/commit/720f9f0cf0f1ce93acfd6faa9bf97562a1f0bd67 |
|
Compare
| https://github.com/nodejs/node/compare/2d3c7b0197f2a4cee686a04a35edd8fa09044ddb..720f9f0cf0f1ce93acfd6faa9bf97562a1f0bd67 |
| February 13, 2016 03:04 | https://github.com/nodejs/node/pull/5204#event-549303293 |
| ofrobots | https://github.com/ofrobots |
| February 18, 2016 12:12 | https://github.com/nodejs/node/pull/5204#commits-pushed-23589ac |
|
| https://github.com/ofrobots |
| src: replace usage of deprecated SetAccessor | https://github.com/nodejs/node/pull/5204/commits/23589acb1c97e6199a83e46789ebe04ec3bf99ca |
| 23589ac | https://github.com/nodejs/node/pull/5204/commits/23589acb1c97e6199a83e46789ebe04ec3bf99ca |
|
| https://github.com/ofrobots |
| src: fix deprecated SetWeak usage in base-object | https://github.com/nodejs/node/pull/5204/commits/14ba959be1173b6243a67d632f91f1750e17da6e |
| 14ba959 | https://github.com/nodejs/node/pull/5204/commits/14ba959be1173b6243a67d632f91f1750e17da6e |
|
| https://github.com/ofrobots |
| buffer: cleanup CallbackInfo | https://github.com/nodejs/node/pull/5204/commits/34bf1da4e1020661bbc2fbf034b09d83a4915c2d |
| 34bf1da | https://github.com/nodejs/node/pull/5204/commits/34bf1da4e1020661bbc2fbf034b09d83a4915c2d |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| force-pushed | https://github.com/nodejs/node/compare/7a580bef3d57190a630115c115fdad8734b62608..f5cc7af209fc5cefc4c764c5dec2b821950014b4 |
| 7a580be | https://github.com/nodejs/node/commit/7a580bef3d57190a630115c115fdad8734b62608 |
| f5cc7af | https://github.com/nodejs/node/commit/f5cc7af209fc5cefc4c764c5dec2b821950014b4 |
|
Compare
| https://github.com/nodejs/node/compare/7a580bef3d57190a630115c115fdad8734b62608..f5cc7af209fc5cefc4c764c5dec2b821950014b4 |
| February 18, 2016 20:27 | https://github.com/nodejs/node/pull/5204#event-555646164 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Feb 21, 2016
| https://github.com/nodejs/node/pull/5204#discussion-diff-53573507 |
| View reviewed changes
| https://github.com/nodejs/node/pull/5204/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b |
| src/node_buffer.cc | https://github.com/nodejs/node/pull/5204/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b |
| bnoordhuis | https://github.com/bnoordhuis |
| Feb 21, 2016 | https://github.com/nodejs/node/pull/5204#discussion_r53573507 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/5204 |
| trevnorris | https://github.com/trevnorris |
| Feb 21, 2016 | https://github.com/nodejs/node/pull/5204#discussion_r53574383 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/5204 |
| ofrobots | https://github.com/ofrobots |
| Feb 22, 2016 | https://github.com/nodejs/node/pull/5204#discussion_r53637813 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/5204 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Feb 21, 2016 | https://github.com/nodejs/node/pull/5204#issuecomment-186919694 |
| Please reload this page | https://github.com/nodejs/node/pull/5204 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Feb 21, 2016 | https://github.com/nodejs/node/pull/5204#issuecomment-186922940 |
| Please reload this page | https://github.com/nodejs/node/pull/5204 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| force-pushed | https://github.com/nodejs/node/compare/f5cc7af209fc5cefc4c764c5dec2b821950014b4..8be49858fab49e35ce9d27c4f52db1d3525b2e94 |
| f5cc7af | https://github.com/nodejs/node/commit/f5cc7af209fc5cefc4c764c5dec2b821950014b4 |
| 8be4985 | https://github.com/nodejs/node/commit/8be49858fab49e35ce9d27c4f52db1d3525b2e94 |
|
Compare
| https://github.com/nodejs/node/compare/f5cc7af209fc5cefc4c764c5dec2b821950014b4..8be49858fab49e35ce9d27c4f52db1d3525b2e94 |
| February 22, 2016 15:11 | https://github.com/nodejs/node/pull/5204#event-559787794 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Feb 22, 2016 | https://github.com/nodejs/node/pull/5204#issuecomment-187226178 |
| https://ci.nodejs.org/job/node-test-pull-request/1721/ | https://ci.nodejs.org/job/node-test-pull-request/1721/ |
| Please reload this page | https://github.com/nodejs/node/pull/5204 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
|
Feb 23, 2016
| https://github.com/nodejs/node/pull/5204#ref-pullrequest-135814667 |
|
(vee-eight-4.9) contextify: update deprecated SetWeak usage
#5392
| https://github.com/nodejs/node/pull/5392 |
|
| https://github.com/ofrobots |
| buffer: replace deprecated SetWeak usage | https://github.com/nodejs/node/pull/5204/commits/dcecbde399df0dbffc12203a223f610ce4ae712f |
| dcecbde | https://github.com/nodejs/node/pull/5204/commits/dcecbde399df0dbffc12203a223f610ce4ae712f |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| force-pushed | https://github.com/nodejs/node/compare/8be49858fab49e35ce9d27c4f52db1d3525b2e94..dcecbde399df0dbffc12203a223f610ce4ae712f |
| 8be4985 | https://github.com/nodejs/node/commit/8be49858fab49e35ce9d27c4f52db1d3525b2e94 |
| dcecbde | https://github.com/nodejs/node/commit/dcecbde399df0dbffc12203a223f610ce4ae712f |
|
Compare
| https://github.com/nodejs/node/compare/8be49858fab49e35ce9d27c4f52db1d3525b2e94..dcecbde399df0dbffc12203a223f610ce4ae712f |
| February 24, 2016 17:31 | https://github.com/nodejs/node/pull/5204#event-564004562 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Feb 25, 2016 | https://github.com/nodejs/node/pull/5204#issuecomment-188862683 |
| #5392 | https://github.com/nodejs/node/pull/5392 |
| https://ci.nodejs.org/job/node-test-pull-request/1749/ | https://ci.nodejs.org/job/node-test-pull-request/1749/ |
| Please reload this page | https://github.com/nodejs/node/pull/5204 |
| ofrobots | https://github.com/ofrobots |
|
Feb 25, 2016
| https://github.com/nodejs/node/pull/5204#ref-commit-2e6934c |
|
| https://github.com/ofrobots |
| src: replace usage of deprecated SetAccessor | https://github.com/nodejs/node/commit/2e6934c5e20c5aad7716c2c6303d441d415ff746 |
| 2e6934c | https://github.com/nodejs/node/commit/2e6934c5e20c5aad7716c2c6303d441d415ff746 |
| #5204 | https://github.com/nodejs/node/pull/5204 |
| ofrobots | https://github.com/ofrobots |
|
Feb 25, 2016
| https://github.com/nodejs/node/pull/5204#ref-commit-0aaacb5 |
|
| https://github.com/ofrobots |
| src: fix deprecated SetWeak usage in base-object | https://github.com/nodejs/node/commit/0aaacb552a05ebb09ba3468edac14a8e4446df86 |
| 0aaacb5 | https://github.com/nodejs/node/commit/0aaacb552a05ebb09ba3468edac14a8e4446df86 |
| #5204 | https://github.com/nodejs/node/pull/5204 |
| ofrobots | https://github.com/ofrobots |
|
Feb 25, 2016
| https://github.com/nodejs/node/pull/5204#ref-commit-a942d56 |
|
| https://github.com/ofrobots |
| buffer: cleanup CallbackInfo | https://github.com/nodejs/node/commit/a942d5672389880394e8e909ad8bd3a3e4a8ef05 |
| a942d56 | https://github.com/nodejs/node/commit/a942d5672389880394e8e909ad8bd3a3e4a8ef05 |
| #5204 | https://github.com/nodejs/node/pull/5204 |
| ofrobots | https://github.com/ofrobots |
|
Feb 25, 2016
| https://github.com/nodejs/node/pull/5204#ref-commit-7a863af |
|
| https://github.com/ofrobots |
| buffer: replace deprecated SetWeak usage | https://github.com/nodejs/node/commit/7a863afce565a1053f97c3ccd9e6e798c1d77083 |
| 7a863af | https://github.com/nodejs/node/commit/7a863afce565a1053f97c3ccd9e6e798c1d77083 |
| #5204 | https://github.com/nodejs/node/pull/5204 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Feb 25, 2016 | https://github.com/nodejs/node/pull/5204#issuecomment-188867751 |
| Please reload this page | https://github.com/nodejs/node/pull/5204 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Feb 25, 2016 | https://github.com/nodejs/node/pull/5204#event-565902003 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
|
dont-land-on-v5.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v5.x |
| Feb 25, 2016 | https://github.com/nodejs/node/pull/5204#event-565955692 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
|
Feb 26, 2016
| https://github.com/nodejs/node/pull/5204#ref-pullrequest-136833146 |
|
(vee-eight-4.9) src: update uses of deprecated NewExternal
#5462
| https://github.com/nodejs/node/pull/5462 |
| ofrobots | https://github.com/ofrobots |
|
Mar 1, 2016
| https://github.com/nodejs/node/pull/5204#ref-commit-81238bb |
|
| https://github.com/ofrobots |
| src: replace usage of deprecated SetAccessor | https://github.com/ofrobots/node/commit/81238bbfd2308461e3699d533d2c99681030e86c |
| 81238bb | https://github.com/ofrobots/node/commit/81238bbfd2308461e3699d533d2c99681030e86c |
| nodejs#5204 | https://github.com/nodejs/node/pull/5204 |
| ofrobots | https://github.com/ofrobots |
|
Mar 1, 2016
| https://github.com/nodejs/node/pull/5204#ref-commit-502568e |
|
| https://github.com/ofrobots |
| src: fix deprecated SetWeak usage in base-object | https://github.com/ofrobots/node/commit/502568e8e82b1c8e0507a73b298fbed9cdb68d5c |
| 502568e | https://github.com/ofrobots/node/commit/502568e8e82b1c8e0507a73b298fbed9cdb68d5c |
| nodejs#5204 | https://github.com/nodejs/node/pull/5204 |
| ofrobots | https://github.com/ofrobots |
|
Mar 3, 2016
| https://github.com/nodejs/node/pull/5204#ref-commit-ea4f27c |
|
| https://github.com/ofrobots |
| src: replace usage of deprecated SetAccessor | https://github.com/ofrobots/node/commit/ea4f27cb975918a7092800f26a9df7c79c39bf3c |
| ea4f27c | https://github.com/ofrobots/node/commit/ea4f27cb975918a7092800f26a9df7c79c39bf3c |
| nodejs#5204 | https://github.com/nodejs/node/pull/5204 |
| ofrobots | https://github.com/ofrobots |
|
Mar 3, 2016
| https://github.com/nodejs/node/pull/5204#ref-commit-bdbd3a2 |
|
| https://github.com/ofrobots |
| src: fix deprecated SetWeak usage in base-object | https://github.com/ofrobots/node/commit/bdbd3a2bf2daf257ef9268b421b21c2fb093699a |
| bdbd3a2 | https://github.com/ofrobots/node/commit/bdbd3a2bf2daf257ef9268b421b21c2fb093699a |
| nodejs#5204 | https://github.com/nodejs/node/pull/5204 |
| ofrobots | https://github.com/ofrobots |
|
Mar 3, 2016
| https://github.com/nodejs/node/pull/5204#ref-commit-8d6ae3b |
|
| https://github.com/ofrobots |
| buffer: cleanup CallbackInfo | https://github.com/ofrobots/node/commit/8d6ae3be41175596f82ab4efde647b2065e3bfc7 |
| 8d6ae3b | https://github.com/ofrobots/node/commit/8d6ae3be41175596f82ab4efde647b2065e3bfc7 |
| nodejs#5204 | https://github.com/nodejs/node/pull/5204 |
| ofrobots | https://github.com/ofrobots |
|
Mar 3, 2016
| https://github.com/nodejs/node/pull/5204#ref-commit-9e5cd28 |
|
| https://github.com/ofrobots |
| buffer: replace deprecated SetWeak usage | https://github.com/ofrobots/node/commit/9e5cd28ae26d552ad31c8d51fa97a4e4893ae064 |
| 9e5cd28 | https://github.com/ofrobots/node/commit/9e5cd28ae26d552ad31c8d51fa97a4e4893ae064 |
| nodejs#5204 | https://github.com/nodejs/node/pull/5204 |
| ofrobots | https://github.com/ofrobots |
|
Mar 4, 2016
| https://github.com/nodejs/node/pull/5204#ref-commit-c1649a7 |
|
| https://github.com/ofrobots |
| src: replace usage of deprecated SetAccessor | https://github.com/nodejs/node/commit/c1649a7e4e01bcae2f9efb84e121f51a79b5ebaa |
| c1649a7 | https://github.com/nodejs/node/commit/c1649a7e4e01bcae2f9efb84e121f51a79b5ebaa |
| #5204 | https://github.com/nodejs/node/pull/5204 |
| ofrobots | https://github.com/ofrobots |
|
Mar 4, 2016
| https://github.com/nodejs/node/pull/5204#ref-commit-a45e1f9 |
|
| https://github.com/ofrobots |
| src: fix deprecated SetWeak usage in base-object | https://github.com/nodejs/node/commit/a45e1f9f98eabf08148f0881aef8e8a08890c0f0 |
| a45e1f9 | https://github.com/nodejs/node/commit/a45e1f9f98eabf08148f0881aef8e8a08890c0f0 |
| #5204 | https://github.com/nodejs/node/pull/5204 |
| ofrobots | https://github.com/ofrobots |
|
Mar 4, 2016
| https://github.com/nodejs/node/pull/5204#ref-commit-34aac23 |
|
| https://github.com/ofrobots |
| buffer: cleanup CallbackInfo | https://github.com/nodejs/node/commit/34aac23d0b14bd081fc6785873063a147fa5fa65 |
| 34aac23 | https://github.com/nodejs/node/commit/34aac23d0b14bd081fc6785873063a147fa5fa65 |
| #5204 | https://github.com/nodejs/node/pull/5204 |
| ofrobots | https://github.com/ofrobots |
|
Mar 4, 2016
| https://github.com/nodejs/node/pull/5204#ref-commit-ebbbc5a |
|
| https://github.com/ofrobots |
| buffer: replace deprecated SetWeak usage | https://github.com/nodejs/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589 |
|
| https://github.com/nodejs/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589#comments |
| ebbbc5a | https://github.com/nodejs/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589 |
| #5204 | https://github.com/nodejs/node/pull/5204 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
|
Mar 17, 2016
| https://github.com/nodejs/node/pull/5204#ref-pullrequest-141448841 |
|
buffer: fix buffer alignment restriction
#5752
| https://github.com/nodejs/node/pull/5752 |
| https://github.com/lovell |
| lovell | https://github.com/lovell |
|
May 18, 2016
| https://github.com/nodejs/node/pull/5204#ref-issue-155216395 |
|
Understanding sharp mem usage with a disabled cache
lovell/sharp#429
| https://github.com/lovell/sharp/issues/429 |
| addaleax | https://github.com/addaleax |
|
Jan 13, 2019
| https://github.com/nodejs/node/pull/5204#ref-commit-98da4cc |
|
| https://github.com/addaleax |
| src: remove outdated Neuter() call in node_buffer.cc | https://github.com/addaleax/node/commit/98da4cc75cd6af1d3895df453c48a1877e9f2f2b |
| 98da4cc | https://github.com/addaleax/node/commit/98da4cc75cd6af1d3895df453c48a1877e9f2f2b |
| 827ee49 | https://github.com/addaleax/node/commit/827ee498e332e316421f565c5f763f347f81274c |
| ebbbc5a | https://github.com/addaleax/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589 |
| nodejs#3624 | https://github.com/nodejs/node/pull/3624 |
| nodejs#5204 | https://github.com/nodejs/node/pull/5204 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jan 13, 2019
| https://github.com/nodejs/node/pull/5204#ref-pullrequest-398699574 |
|
src: remove outdated Neuter() call in node_buffer.cc
#25479
| https://github.com/nodejs/node/pull/25479 |
| addaleax | https://github.com/addaleax |
|
Jan 21, 2019
| https://github.com/nodejs/node/pull/5204#ref-commit-30f4568 |
|
| https://github.com/addaleax |
| src: remove outdated Neuter() call in node_buffer.cc | https://github.com/nodejs/node/commit/30f45683aaeb1d4917fff7bc7cb2937ee89f0082 |
| 30f4568 | https://github.com/nodejs/node/commit/30f45683aaeb1d4917fff7bc7cb2937ee89f0082 |
| 827ee49 | https://github.com/nodejs/node/commit/827ee498e332e316421f565c5f763f347f81274c |
| ebbbc5a | https://github.com/nodejs/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589 |
| #3624 | https://github.com/nodejs/node/pull/3624 |
| #5204 | https://github.com/nodejs/node/pull/5204 |
| #25479 | https://github.com/nodejs/node/pull/25479 |
| targos | https://github.com/targos |
|
Jan 24, 2019
| https://github.com/nodejs/node/pull/5204#ref-commit-dbecc82 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| src: remove outdated Neuter() call in node_buffer.cc | https://github.com/nodejs/node/commit/dbecc8252493d347b16f3ccbb859ec02a0601a83 |
| dbecc82 | https://github.com/nodejs/node/commit/dbecc8252493d347b16f3ccbb859ec02a0601a83 |
| 827ee49 | https://github.com/nodejs/node/commit/827ee498e332e316421f565c5f763f347f81274c |
| ebbbc5a | https://github.com/nodejs/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589 |
| #3624 | https://github.com/nodejs/node/pull/3624 |
| #5204 | https://github.com/nodejs/node/pull/5204 |
| #25479 | https://github.com/nodejs/node/pull/25479 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 29, 2019
| https://github.com/nodejs/node/pull/5204#ref-commit-1d2d3f3 |
|
| https://github.com/addaleax |
|
| https://github.com/BethGriggs |
| src: remove outdated Neuter() call in node_buffer.cc | https://github.com/nodejs/node/commit/1d2d3f3946fce389e40ff7fde8b052500f482fe6 |
| 1d2d3f3 | https://github.com/nodejs/node/commit/1d2d3f3946fce389e40ff7fde8b052500f482fe6 |
| 827ee49 | https://github.com/nodejs/node/commit/827ee498e332e316421f565c5f763f347f81274c |
| ebbbc5a | https://github.com/nodejs/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589 |
| #3624 | https://github.com/nodejs/node/pull/3624 |
| #5204 | https://github.com/nodejs/node/pull/5204 |
| #25479 | https://github.com/nodejs/node/pull/25479 |
| BethGriggs | https://github.com/BethGriggs |
|
May 10, 2019
| https://github.com/nodejs/node/pull/5204#ref-commit-f71c55b |
|
| https://github.com/addaleax |
|
| https://github.com/BethGriggs |
| src: remove outdated Neuter() call in node_buffer.cc | https://github.com/nodejs/node/commit/f71c55b7f21de64fdc643fb09be9ba91c8ad9e67 |
| f71c55b | https://github.com/nodejs/node/commit/f71c55b7f21de64fdc643fb09be9ba91c8ad9e67 |
| 827ee49 | https://github.com/nodejs/node/commit/827ee498e332e316421f565c5f763f347f81274c |
| ebbbc5a | https://github.com/nodejs/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589 |
| #3624 | https://github.com/nodejs/node/pull/3624 |
| #5204 | https://github.com/nodejs/node/pull/5204 |
| #25479 | https://github.com/nodejs/node/pull/25479 |
| MylesBorins | https://github.com/MylesBorins |
|
May 16, 2019
| https://github.com/nodejs/node/pull/5204#ref-commit-cd4a932 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| src: remove outdated Neuter() call in node_buffer.cc | https://github.com/nodejs/node/commit/cd4a932af3645e537d6af12e70a7acd67961232f |
| cd4a932 | https://github.com/nodejs/node/commit/cd4a932af3645e537d6af12e70a7acd67961232f |
| 827ee49 | https://github.com/nodejs/node/commit/827ee498e332e316421f565c5f763f347f81274c |
| ebbbc5a | https://github.com/nodejs/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589 |
| #3624 | https://github.com/nodejs/node/pull/3624 |
| #5204 | https://github.com/nodejs/node/pull/5204 |
| #25479 | https://github.com/nodejs/node/pull/25479 |
| deepak1556 | https://github.com/deepak1556 |
|
Jul 10, 2019
| https://github.com/nodejs/node/pull/5204#ref-commit-e13e8fe |
|
| https://github.com/addaleax |
|
| https://github.com/deepak1556 |
| src: remove outdated Neuter() call in node_buffer.cc | https://github.com/electron/node/commit/e13e8fe0bff67de3c600096ae0c1818b22a082a8 |
| e13e8fe | https://github.com/electron/node/commit/e13e8fe0bff67de3c600096ae0c1818b22a082a8 |
| 827ee49 | https://github.com/electron/node/commit/827ee498e332e316421f565c5f763f347f81274c |
| ebbbc5a | https://github.com/electron/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589 |
| nodejs/node#3624 | https://github.com/nodejs/node/pull/3624 |
| nodejs/node#5204 | https://github.com/nodejs/node/pull/5204 |
| nodejs/node#25479 | https://github.com/nodejs/node/pull/25479 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5204 |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/5204 |
|
| https://github.com/ofrobots |
|
| https://github.com/bnoordhuis |
|
| https://github.com/indutny |
|
| https://github.com/trevnorris |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |