| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:27eceb52-e7d3-8aa3-5bb0-887486c04fa4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D07C:1EFC6:3F37AC:585A2E:696A7534 |
| html-safe-nonce | 3757079a9f9a78d2709eaacb3ce7f307cabd5f72dc74433edde4cd33c6c1f959 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDdDOjFFRkM2OjNGMzdBQzo1ODVBMkU6Njk2QTc1MzQiLCJ2aXNpdG9yX2lkIjoiMzU5MjQ1NDg1MTY2OTk0NzcwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c3c91dd8a73d64b72ad9edbf61b2c1b86df26fe882667684fb8ec3333334058f |
| hovercard-subject-tag | pull_request:1705914662 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/51631/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1b08ed888bd2ae95b4f5afb405bd7ac33c67f99d27602df01fd9ce963bf8abdd/nodejs/node/pull/51631 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1b08ed888bd2ae95b4f5afb405bd7ac33c67f99d27602df01fd9ce963bf8abdd/nodejs/node/pull/51631 |
| og:image:alt | Not sure what the semverness of this would be, hopefully we can backport it to v18.x if #51136 can land there. Here's what the warning looks like:
$ ./node --input-type=module -e 'import &q... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | aduh95 |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/51631#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51631 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51631 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/51631 |
| Reload | https://github.com/nodejs/node/pull/51631 |
| Reload | https://github.com/nodejs/node/pull/51631 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/51631 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/51631 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/51631#issue-comment-box |
| aduh95 | https://github.com/aduh95 |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| aduh95:assert-deprecation-runtime-warning | https://github.com/aduh95/node/tree/assert-deprecation-runtime-warning |
|
deps: add deprecation warning for import assertion syntax
| https://github.com/nodejs/node/pull/51631#top |
| aduh95 | https://github.com/aduh95 |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| aduh95:assert-deprecation-runtime-warning | https://github.com/aduh95/node/tree/assert-deprecation-runtime-warning |
|
Conversation
3
| https://github.com/nodejs/node/pull/51631 |
|
Commits
2
| https://github.com/nodejs/node/pull/51631/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/51631/checks |
|
Files changed
| https://github.com/nodejs/node/pull/51631/files |
| Please reload this page | https://github.com/nodejs/node/pull/51631 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Feb 1, 2024 | https://github.com/nodejs/node/pull/51631#issue-2112136863 |
| Please reload this page | https://github.com/nodejs/node/pull/51631 |
| #51136 | https://github.com/nodejs/node/pull/51136 |
| #51622 | https://github.com/nodejs/node/issues/51622 |
| Please reload this page | https://github.com/nodejs/node/pull/51631 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 1, 2024 | https://github.com/nodejs/node/pull/51631#issuecomment-1921004896 |
| Please reload this page | https://github.com/nodejs/node/pull/51631 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Feb 1, 2024 | https://github.com/nodejs/node/pull/51631#event-11667947640 |
| aduh95 | https://github.com/aduh95 |
| February 1, 2024 13:57 | https://github.com/nodejs/node/pull/51631#commits-pushed-26592ec |
|
| https://github.com/aduh95 |
| deps: V8: cherry-pick ae5a4db8ad86 | https://github.com/nodejs/node/pull/51631/commits/26592ec76a7f85246927fe277b0e51d5bd33f4e0 |
| 26592ec | https://github.com/nodejs/node/pull/51631/commits/26592ec76a7f85246927fe277b0e51d5bd33f4e0 |
| https://groups.google.com/a/chromium.org/g/blink-dev/c/ZHvzLaJZRvo/m/FgNDBjrtBQAJ | https://groups.google.com/a/chromium.org/g/blink-dev/c/ZHvzLaJZRvo/m/FgNDBjrtBQAJ |
| https://chromium-review.googlesource.com/c/v8/v8/+/5055681 | https://chromium-review.googlesource.com/c/v8/v8/+/5055681 |
| v8/v8@ae5a4db | https://github.com/v8/v8/commit/ae5a4db8ad86c817f80856901ea121829f8b5184 |
|
| https://github.com/aduh95 |
| deps: V8: cherry-pick 26fd1dfa9cd6 | https://github.com/nodejs/node/pull/51631/commits/545a983d0e780847d6d4c1d641a41ca7de1b0dc5 |
| 545a983 | https://github.com/nodejs/node/pull/51631/commits/545a983d0e780847d6d4c1d641a41ca7de1b0dc5 |
| https://chromium-review.googlesource.com/c/v8/v8/+/5249778 | https://chromium-review.googlesource.com/c/v8/v8/+/5249778 |
| v8/v8@26fd1df | https://github.com/v8/v8/commit/26fd1dfa9cd6d56eae8ecfc7a136fd6709fba161 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| force-pushed | https://github.com/nodejs/node/compare/d56a4be4df366ef5b65ef28ade2c0c33f0316cdd..545a983d0e780847d6d4c1d641a41ca7de1b0dc5 |
| d56a4be | https://github.com/nodejs/node/commit/d56a4be4df366ef5b65ef28ade2c0c33f0316cdd |
| 545a983 | https://github.com/nodejs/node/commit/545a983d0e780847d6d4c1d641a41ca7de1b0dc5 |
|
Compare
| https://github.com/nodejs/node/compare/d56a4be4df366ef5b65ef28ade2c0c33f0316cdd..545a983d0e780847d6d4c1d641a41ca7de1b0dc5 |
| February 1, 2024 13:12 | https://github.com/nodejs/node/pull/51631#event-11669947535 |
| https://github.com/debadree25 |
| debadree25 | https://github.com/debadree25 |
| Feb 8, 2024 | https://github.com/nodejs/node/pull/51631#issuecomment-1934632908 |
| Please reload this page | https://github.com/nodejs/node/pull/51631 |
| https://github.com/nicolo-ribaudo |
| nicolo-ribaudo | https://github.com/nicolo-ribaudo |
|
Mar 15, 2024
| https://github.com/nodejs/node/pull/51631#ref-issue-2110612949 |
|
Re-flag assert syntax for import attributes in Node.js 22
#51622
| https://github.com/nodejs/node/issues/51622 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Mar 15, 2024 | https://github.com/nodejs/node/pull/51631#issuecomment-1999972380 |
| Please reload this page | https://github.com/nodejs/node/pull/51631 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Apr 18, 2024
| https://github.com/nodejs/node/pull/51631#ref-pullrequest-2240703753 |
|
2024-04-24, Version 22.0.0 (Current)
#52505
| https://github.com/nodejs/node/pull/52505 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| May 5, 2024 | https://github.com/nodejs/node/pull/51631#event-12706721043 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| May 5, 2024 08:18 | https://github.com/nodejs/node/pull/51631#event-12706721135 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Nov 15, 2024
| https://github.com/nodejs/node/pull/51631#ref-issue-2662294169 |
|
[v18.20.5 / next v20.x LTS version] NodeJS should provide some kind of warning when using import assertions as they are non-standard
#55869
| https://github.com/nodejs/node/issues/55869 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51631 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/51631 |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/debadree25 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |