René's URL Explorer Experiment


Title: Revert "fs: deprecate fs.read's string interface" by MylesBorins · Pull Request #5163 · nodejs/node · GitHub

Open Graph Title: Revert "fs: deprecate fs.read's string interface" by MylesBorins · Pull Request #5163 · nodejs/node

X Title: Revert "fs: deprecate fs.read's string interface" by MylesBorins · Pull Request #5163 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This reverts commit 1124de2 which landed in #4525 This commit has broken both npm + node-gyp How did it break npm? Deprecating fs.read's string interface includes internal/util Currently npm...

X Description: This reverts commit 1124de2 which landed in #4525 This commit has broken both npm + node-gyp How did it break npm? Deprecating fs.read's string interface includes internal/util Currently np...

Opengraph URL: https://github.com/nodejs/node/pull/5163

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:059a275a-2b39-1d71-debf-21a0982ac9ff
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC534:1258EF:186EE4E:2021673:6AED897C
html-safe-nonce141e1fae6d984e04bc6acc2a3aa5e87bda1eb53da5c9e323de2e80529337a7c9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTM0OjEyNThFRjoxODZFRTRFOjIwMjE2NzM6NkFFRDg5N0MiLCJ2aXNpdG9yX2lkIjoiODUwNDE2MDk0MDA5MTg2OTU2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc4f46ab8d2986d2ade0299cc1385c507bd2030412473ef2447c3afb7e82ecf47
hovercard-subject-tagpull_request:58785684
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/5163/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/52b41396e839b60e0b28aee6d87855d5d3935a7956d300930fcda06e9fda4d1a/nodejs/node/pull/5163
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/52b41396e839b60e0b28aee6d87855d5d3935a7956d300930fcda06e9fda4d1a/nodejs/node/pull/5163
og:image:altThis reverts commit 1124de2 which landed in #4525 This commit has broken both npm + node-gyp How did it break npm? Deprecating fs.read's string interface includes internal/util Currently npm...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMylesBorins
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/5163#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5163
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5163
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/5163
Reloadhttps://github.com/nodejs/node/pull/5163
Reloadhttps://github.com/nodejs/node/pull/5163
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
MylesBorinshttps://github.com/MylesBorins
nodejs:masterhttps://github.com/nodejs/node/tree/master
MylesBorins:revert-1124de2https://github.com/MylesBorins/node/tree/revert-1124de2
Conversationhttps://github.com/nodejs/node/pull/5163
Commits2 (2)https://github.com/nodejs/node/pull/5163/commits
Checkshttps://github.com/nodejs/node/pull/5163/checks
Files changedhttps://github.com/nodejs/node/pull/5163/files
Revert "fs: deprecate fs.read's string interface"https://github.com/nodejs/node/pull/5163#top
MylesBorinshttps://github.com/MylesBorins
nodejs:masterhttps://github.com/nodejs/node/tree/master
MylesBorins:revert-1124de2https://github.com/MylesBorins/node/tree/revert-1124de2
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 9, 2016https://github.com/nodejs/node/pull/5163#issue-132489743
1124de2https://github.com/nodejs/node/commit/1124de2d76ad7118267d91a08485aa928a5f0865
#4525https://github.com/nodejs/node/pull/4525
#5102https://github.com/nodejs/node/pull/5102
@rvagghttps://github.com/rvagg
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/5163
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
npm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anpm
Feb 9, 2016https://github.com/nodejs/node/pull/5163#event-544703247
Revert "fs: deprecate fs.read's string interface"https://github.com/nodejs/node/pull/5163/commits/3e32ff58c9eb3e7d660d8cef40d48868e50f6b42
3e32ff5https://github.com/nodejs/node/pull/5163/commits/3e32ff58c9eb3e7d660d8cef40d48868e50f6b42
1124de2https://github.com/MylesBorins/node/commit/1124de2d76ad7118267d91a08485aa928a5f0865
nodejs#4525https://github.com/nodejs/node/pull/4525
nodejs#5102https://github.com/nodejs/node/pull/5102
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/5ce2552a34dcbdbc587edaad77d410588662baff..3e32ff58c9eb3e7d660d8cef40d48868e50f6b42
5ce2552https://github.com/nodejs/node/commit/5ce2552a34dcbdbc587edaad77d410588662baff
3e32ff5https://github.com/nodejs/node/commit/3e32ff58c9eb3e7d660d8cef40d48868e50f6b42
Compare https://github.com/nodejs/node/compare/5ce2552a34dcbdbc587edaad77d410588662baff..3e32ff58c9eb3e7d660d8cef40d48868e50f6b42
February 9, 2016 18:14https://github.com/nodejs/node/pull/5163#event-544713600
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Feb 9, 2016https://github.com/nodejs/node/pull/5163#issuecomment-181989501
Please reload this pagehttps://github.com/nodejs/node/pull/5163
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 9, 2016https://github.com/nodejs/node/pull/5163#issuecomment-181990708
@Fishrock123https://github.com/Fishrock123
Please reload this pagehttps://github.com/nodejs/node/pull/5163
test: add test-npm-install to parallel tests suitehttps://github.com/nodejs/node/pull/5163/commits/7453d727895880730c33835ebd454ae9557d7363
7453d72https://github.com/nodejs/node/pull/5163/commits/7453d727895880730c33835ebd454ae9557d7363
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 9, 2016https://github.com/nodejs/node/pull/5163#issuecomment-182022311
#5166https://github.com/nodejs/node/pull/5166
https://ci.nodejs.org/job/node-test-pull-request/1615/https://ci.nodejs.org/job/node-test-pull-request/1615/
#5166https://github.com/nodejs/node/pull/5166
#5166https://github.com/nodejs/node/pull/5166
Please reload this pagehttps://github.com/nodejs/node/pull/5163
https://github.com/jasnell
jasnellhttps://github.com/jasnell
ctc-agenda https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Actc-agenda
Feb 9, 2016https://github.com/nodejs/node/pull/5163#event-544823127
fs: add a temporary fix for re-evaluation support #5102 https://github.com/nodejs/node/pull/5102
test: add test-npm-install to parallel tests suite #5166 https://github.com/nodejs/node/pull/5166
https://github.com/vkurchatkin
vkurchatkinhttps://github.com/vkurchatkin
Feb 9, 2016https://github.com/nodejs/node/pull/5163#issuecomment-182030873
Please reload this pagehttps://github.com/nodejs/node/pull/5163
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Feb 9, 2016https://github.com/nodejs/node/pull/5163#issuecomment-182065827
Please reload this pagehttps://github.com/nodejs/node/pull/5163
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 9, 2016https://github.com/nodejs/node/pull/5163#issuecomment-182067180
Please reload this pagehttps://github.com/nodejs/node/pull/5163
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Feb 9, 2016https://github.com/nodejs/node/pull/5163#issuecomment-182084354
Please reload this pagehttps://github.com/nodejs/node/pull/5163
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Feb 9, 2016https://github.com/nodejs/node/pull/5163#issuecomment-182094834
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/5163
https://github.com/rvagg
rvagghttps://github.com/rvagg
Feb 9, 2016https://github.com/nodejs/node/pull/5163#issuecomment-182109495
Please reload this pagehttps://github.com/nodejs/node/pull/5163
https://github.com/rvagg
rvagghttps://github.com/rvagg
Feb 10, 2016 https://github.com/nodejs/node/pull/5163#ref-issue-132685748
Node.js Foundation Core Technical Committee (CTC) Meeting 2016-02-10 #5176 https://github.com/nodejs/node/issues/5176
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 11, 2016https://github.com/nodejs/node/pull/5163#issuecomment-183011737
#5102https://github.com/nodejs/node/pull/5102
Please reload this pagehttps://github.com/nodejs/node/pull/5163
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 11, 2016https://github.com/nodejs/node/pull/5163#event-547602749
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
ctc-agenda https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Actc-agenda
Mar 2, 2016https://github.com/nodejs/node/pull/5163#event-575207429
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
April 16, 2016 18:44https://github.com/nodejs/node/pull/5163#event-630029933
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5163
Please reload this pagehttps://github.com/nodejs/node/pull/5163
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
npm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anpm
Please reload this pagehttps://github.com/nodejs/node/pull/5163
https://github.com/MylesBorins
https://github.com/Fishrock123
https://github.com/vkurchatkin
https://github.com/ChALkeR
https://github.com/trevnorris
https://github.com/rvagg
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.