René's URL Explorer Experiment


Title: fs: load rimraf lazily in fs/promises by joyeecheung · Pull Request #51617 · nodejs/node · GitHub

Open Graph Title: fs: load rimraf lazily in fs/promises by joyeecheung · Pull Request #51617 · nodejs/node

X Title: fs: load rimraf lazily in fs/promises by joyeecheung · Pull Request #51617 · nodejs/node

Description: Avoid the potential circular dependency and make fs/promises load faster when rimraf is not used.

Open Graph Description: Avoid the potential circular dependency and make fs/promises load faster when rimraf is not used.

X Description: Avoid the potential circular dependency and make fs/promises load faster when rimraf is not used.

Opengraph URL: https://github.com/nodejs/node/pull/51617

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1b94eb3e-f6ed-db5d-f5c0-70e32a4508bf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8916:367397:148CD1:1D36F9:696A03E7
html-safe-nonce1eac735ae9b5665778a52645d1d62cafd7c04cac2ec9c0b04b35df18c2eaf8b2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTE2OjM2NzM5NzoxNDhDRDE6MUQzNkY5OjY5NkEwM0U3IiwidmlzaXRvcl9pZCI6IjgyNjQwNTA3NTQ3Mjg4ODcyNzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1d1d3e33d739e563793559f0d103235ae38604a5e91c7974bbb8eb8d840939ab
hovercard-subject-tagpull_request:1704137987
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/51617/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5f3cb65a8041a3bf9465a3e25f66c3d093e90ef558c13da72aa248232526589d/nodejs/node/pull/51617
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5f3cb65a8041a3bf9465a3e25f66c3d093e90ef558c13da72aa248232526589d/nodejs/node/pull/51617
og:image:altAvoid the potential circular dependency and make fs/promises load faster when rimraf is not used.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release671c2f67171dbced24284331f3133a613d08c366
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/51617#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51617
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51617
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/51617
Reloadhttps://github.com/nodejs/node/pull/51617
Reloadhttps://github.com/nodejs/node/pull/51617
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/51617
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/51617
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/51617#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
joyeecheung:lazy-load-rimrafhttps://github.com/joyeecheung/node/tree/lazy-load-rimraf
fs: load rimraf lazily in fs/promises https://github.com/nodejs/node/pull/51617#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
joyeecheung:lazy-load-rimrafhttps://github.com/joyeecheung/node/tree/lazy-load-rimraf
Conversation 4 https://github.com/nodejs/node/pull/51617
Commits 1 https://github.com/nodejs/node/pull/51617/commits
Checks 0 https://github.com/nodejs/node/pull/51617/checks
Files changed 1 https://github.com/nodejs/node/pull/51617/files
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jan 31, 2024https://github.com/nodejs/node/pull/51617#issue-2110167391
Please reload this pagehttps://github.com/nodejs/node/pull/51617
https://github.com/joyeecheung
fs: load rimraf lazily in fs/promiseshttps://github.com/nodejs/node/pull/51617/commits/0f37549613ed82883297695986ab4e6eae5e956c
0f37549https://github.com/nodejs/node/pull/51617/commits/0f37549613ed82883297695986ab4e6eae5e956c
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jan 31, 2024https://github.com/nodejs/node/pull/51617#event-11656241140
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Jan 31, 2024 https://github.com/nodejs/node/pull/51617#pullrequestreview-1853828564
View reviewed changes https://github.com/nodejs/node/pull/51617/files/0f37549613ed82883297695986ab4e6eae5e956c
https://github.com/Uzlopak
Uzlopakhttps://github.com/Uzlopak
Jan 31, 2024 https://github.com/nodejs/node/pull/51617#pullrequestreview-1853979063
View reviewed changes https://github.com/nodejs/node/pull/51617/files/0f37549613ed82883297695986ab4e6eae5e956c
Uzlopakhttps://github.com/Uzlopak
https://github.com/nodejs/node/pull/51617#pullrequestreview-1853979063
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/51617
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jan 31, 2024 https://github.com/nodejs/node/pull/51617#pullrequestreview-1854023307
View reviewed changes https://github.com/nodejs/node/pull/51617/files/0f37549613ed82883297695986ab4e6eae5e956c
https://github.com/H4ad
H4adhttps://github.com/H4ad
Jan 31, 2024 https://github.com/nodejs/node/pull/51617#pullrequestreview-1854361254
View reviewed changes https://github.com/nodejs/node/pull/51617/files/0f37549613ed82883297695986ab4e6eae5e956c
https://github.com/H4ad
H4adhttps://github.com/H4ad
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 31, 2024https://github.com/nodejs/node/pull/51617#event-11658956048
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 31, 2024https://github.com/nodejs/node/pull/51617#event-11658996650
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 31, 2024https://github.com/nodejs/node/pull/51617#issuecomment-1919558664
https://ci.nodejs.org/job/node-test-pull-request/56988/https://ci.nodejs.org/job/node-test-pull-request/56988/
Please reload this pagehttps://github.com/nodejs/node/pull/51617
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jan 31, 2024 https://github.com/nodejs/node/pull/51617#pullrequestreview-1854619841
View reviewed changes https://github.com/nodejs/node/pull/51617/files/0f37549613ed82883297695986ab4e6eae5e956c
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 31, 2024 https://github.com/nodejs/node/pull/51617#pullrequestreview-1854783947
View reviewed changes https://github.com/nodejs/node/pull/51617/files/0f37549613ed82883297695986ab4e6eae5e956c
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 31, 2024https://github.com/nodejs/node/pull/51617#issuecomment-1920160973
https://ci.nodejs.org/job/node-test-pull-request/56999/https://ci.nodejs.org/job/node-test-pull-request/56999/
Please reload this pagehttps://github.com/nodejs/node/pull/51617
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Feb 2, 2024https://github.com/nodejs/node/pull/51617#event-11682108042
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Feb 2, 2024https://github.com/nodejs/node/pull/51617#event-11684726678
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
ce05a07https://github.com/nodejs/node/commit/ce05a07c1a311adcb3ed32daa0032a23e8d16888
Feb 2, 2024https://github.com/nodejs/node/pull/51617#event-11684727468
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 2, 2024https://github.com/nodejs/node/pull/51617#issuecomment-1923957808
ce05a07https://github.com/nodejs/node/commit/ce05a07c1a311adcb3ed32daa0032a23e8d16888
Please reload this pagehttps://github.com/nodejs/node/pull/51617
rdw-msfthttps://github.com/rdw-msft
Feb 9, 2024 https://github.com/nodejs/node/pull/51617#ref-commit-4ca1b61
https://github.com/joyeecheung
https://github.com/rdw-msft
fs: load rimraf lazily in fs/promiseshttps://github.com/rdw-msft/node/commit/4ca1b612f27c0c68f1f69e22d19f5bee64d9f071
4ca1b61https://github.com/rdw-msft/node/commit/4ca1b612f27c0c68f1f69e22d19f5bee64d9f071
nodejs#51617https://github.com/nodejs/node/pull/51617
targoshttps://github.com/targos
Feb 15, 2024 https://github.com/nodejs/node/pull/51617#ref-commit-5a8af3d
https://github.com/joyeecheung
https://github.com/targos
fs: load rimraf lazily in fs/promiseshttps://github.com/nodejs/node/commit/5a8af3d362570e2479fc0981878f8e3355307ab8
5a8af3dhttps://github.com/nodejs/node/commit/5a8af3d362570e2479fc0981878f8e3355307ab8
#51617https://github.com/nodejs/node/pull/51617
marco-ippolitohttps://github.com/marco-ippolito
Feb 19, 2024 https://github.com/nodejs/node/pull/51617#ref-commit-58370fb
https://github.com/joyeecheung
https://github.com/marco-ippolito
fs: load rimraf lazily in fs/promiseshttps://github.com/marco-ippolito/node/commit/58370fba39e9ec3a5a851451aeaba58f142981d8
58370fbhttps://github.com/marco-ippolito/node/commit/58370fba39e9ec3a5a851451aeaba58f142981d8
nodejs#51617https://github.com/nodejs/node/pull/51617
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
Mar 1, 2024 https://github.com/nodejs/node/pull/51617#ref-pullrequest-2162891978
v21.7.0 proposal #51932 https://github.com/nodejs/node/pull/51932
richardlauhttps://github.com/richardlau
Mar 25, 2024 https://github.com/nodejs/node/pull/51617#ref-commit-ede4eb9
https://github.com/joyeecheung
https://github.com/richardlau
fs: load rimraf lazily in fs/promiseshttps://github.com/nodejs/node/commit/ede4eb9cf247dfe654dec0f272a397953ccf2b5a
ede4eb9https://github.com/nodejs/node/commit/ede4eb9cf247dfe654dec0f272a397953ccf2b5a
#51617https://github.com/nodejs/node/pull/51617
richardlauhttps://github.com/richardlau
Mar 25, 2024 https://github.com/nodejs/node/pull/51617#ref-commit-287a02c
https://github.com/joyeecheung
https://github.com/richardlau
fs: load rimraf lazily in fs/promiseshttps://github.com/nodejs/node/commit/287a02c4b20bf1348d2d35d1a9463126ae92ea4d
287a02chttps://github.com/nodejs/node/commit/287a02c4b20bf1348d2d35d1a9463126ae92ea4d
#51617https://github.com/nodejs/node/pull/51617
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 25, 2024 https://github.com/nodejs/node/pull/51617#ref-pullrequest-2206634908
v20.12.0 proposal #52212 https://github.com/nodejs/node/pull/52212
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51617
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/51617/files/0f37549613ed82883297695986ab4e6eae5e956c
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/51617/files/0f37549613ed82883297695986ab4e6eae5e956c
https://github.com/MoLow
MoLow https://github.com/MoLow
https://github.com/nodejs/node/pull/51617/files/0f37549613ed82883297695986ab4e6eae5e956c
https://github.com/H4ad
H4ad https://github.com/H4ad
https://github.com/nodejs/node/pull/51617/files/0f37549613ed82883297695986ab4e6eae5e956c
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/51617/files/0f37549613ed82883297695986ab4e6eae5e956c
https://github.com/Uzlopak
Uzlopak https://github.com/Uzlopak
https://github.com/nodejs/node/pull/51617/files/0f37549613ed82883297695986ab4e6eae5e956c
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/51617
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/anonrig
https://github.com/Uzlopak
https://github.com/MoLow
https://github.com/H4ad
https://github.com/trivikr
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.