René's URL Explorer Experiment


Title: tools: do not pass invalid flag to C compiler by targos · Pull Request #51409 · nodejs/node · GitHub

Open Graph Title: tools: do not pass invalid flag to C compiler by targos · Pull Request #51409 · nodejs/node

X Title: tools: do not pass invalid flag to C compiler by targos · Pull Request #51409 · nodejs/node

Description: -Wno-invalid-offsetof is only valid for C++ and GCC warns about its usage for C.

Open Graph Description: -Wno-invalid-offsetof is only valid for C++ and GCC warns about its usage for C.

X Description: -Wno-invalid-offsetof is only valid for C++ and GCC warns about its usage for C.

Opengraph URL: https://github.com/nodejs/node/pull/51409

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2ae44bdb-4676-2811-3837-6549d9ae2df0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE954:87E17:1B52DE4:24407C9:696AF372
html-safe-nonce2e6180c2ef59792985d3f10f3934edf078f621f7c9a6fda2f4af8c3188109c32
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTU0Ojg3RTE3OjFCNTJERTQ6MjQ0MDdDOTo2OTZBRjM3MiIsInZpc2l0b3JfaWQiOiIxNzMzNDI3ODQyOTkzODEyMzM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace208d6c0820d74ac8fd772d6a9aeeab42fea733721fdcbb1ee2001465c6f6243
hovercard-subject-tagpull_request:1670322555
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/51409/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ec18d8145d151e00abc0120fc862385476674de4355a5dc6ee0116ed0b86cdf5/nodejs/node/pull/51409
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ec18d8145d151e00abc0120fc862385476674de4355a5dc6ee0116ed0b86cdf5/nodejs/node/pull/51409
og:image:alt-Wno-invalid-offsetof is only valid for C++ and GCC warns about its usage for C.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametargos
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/51409#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51409
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51409
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/51409
Reloadhttps://github.com/nodejs/node/pull/51409
Reloadhttps://github.com/nodejs/node/pull/51409
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/51409
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 692 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/51409
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/51409#issue-comment-box
targoshttps://github.com/targos
nodejs:mainhttps://github.com/nodejs/node/tree/main
targos:no-invalid-offsetofhttps://github.com/targos/node/tree/no-invalid-offsetof
tools: do not pass invalid flag to C compiler https://github.com/nodejs/node/pull/51409#top
targoshttps://github.com/targos
nodejs:mainhttps://github.com/nodejs/node/tree/main
targos:no-invalid-offsetofhttps://github.com/targos/node/tree/no-invalid-offsetof
Conversation 8 https://github.com/nodejs/node/pull/51409
Commits 1 https://github.com/nodejs/node/pull/51409/commits
Checks 0 https://github.com/nodejs/node/pull/51409/checks
Files changed https://github.com/nodejs/node/pull/51409/files
Please reload this pagehttps://github.com/nodejs/node/pull/51409
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/targos
targoshttps://github.com/targos
Jan 9, 2024https://github.com/nodejs/node/pull/51409#issue-2072015479
Please reload this pagehttps://github.com/nodejs/node/pull/51409
https://github.com/targos
tools: do not pass invalid flag to C compilerhttps://github.com/nodejs/node/pull/51409/commits/c7f8b1629123065c20362ca5c2be0552405fbc4a
c7f8b16https://github.com/nodejs/node/pull/51409/commits/c7f8b1629123065c20362ca5c2be0552405fbc4a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 9, 2024https://github.com/nodejs/node/pull/51409#issuecomment-1882746021
Please reload this pagehttps://github.com/nodejs/node/pull/51409
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Jan 9, 2024https://github.com/nodejs/node/pull/51409#event-11427949052
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Jan 9, 2024 https://github.com/nodejs/node/pull/51409#pullrequestreview-1810986453
View reviewed changes https://github.com/nodejs/node/pull/51409/files/c7f8b1629123065c20362ca5c2be0552405fbc4a
https://github.com/targos
targoshttps://github.com/targos
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 9, 2024https://github.com/nodejs/node/pull/51409#event-11429552037
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 9, 2024https://github.com/nodejs/node/pull/51409#event-11429623616
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 9, 2024https://github.com/nodejs/node/pull/51409#issuecomment-1882967076
https://ci.nodejs.org/job/node-test-pull-request/56720/https://ci.nodejs.org/job/node-test-pull-request/56720/
Please reload this pagehttps://github.com/nodejs/node/pull/51409
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51409
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51409
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51409
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 9, 2024 https://github.com/nodejs/node/pull/51409#pullrequestreview-1811108460
View reviewed changes https://github.com/nodejs/node/pull/51409/files/c7f8b1629123065c20362ca5c2be0552405fbc4a
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jan 9, 2024 https://github.com/nodejs/node/pull/51409#pullrequestreview-1811201885
View reviewed changes https://github.com/nodejs/node/pull/51409/files/c7f8b1629123065c20362ca5c2be0552405fbc4a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 10, 2024https://github.com/nodejs/node/pull/51409#issuecomment-1884343907
https://ci.nodejs.org/job/node-test-pull-request/56725/https://ci.nodejs.org/job/node-test-pull-request/56725/
Please reload this pagehttps://github.com/nodejs/node/pull/51409
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 11, 2024https://github.com/nodejs/node/pull/51409#issuecomment-1887192142
https://ci.nodejs.org/job/node-test-pull-request/56745/https://ci.nodejs.org/job/node-test-pull-request/56745/
Please reload this pagehttps://github.com/nodejs/node/pull/51409
https://github.com/aymen94
aymen94https://github.com/aymen94
Jan 11, 2024 https://github.com/nodejs/node/pull/51409#pullrequestreview-1816062561
View reviewed changes https://github.com/nodejs/node/pull/51409/files/c7f8b1629123065c20362ca5c2be0552405fbc4a
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jan 14, 2024 https://github.com/nodejs/node/pull/51409#pullrequestreview-1820296376
View reviewed changes https://github.com/nodejs/node/pull/51409/files/c7f8b1629123065c20362ca5c2be0552405fbc4a
targoshttps://github.com/targos
Jan 15, 2024 https://github.com/nodejs/node/pull/51409#ref-commit-b180512
https://github.com/targos
tools: do not pass invalid flag to C compilerhttps://github.com/nodejs/node/commit/b180512aef7349a10a3fe8e5cca81cdc13e57f5a
b180512https://github.com/nodejs/node/commit/b180512aef7349a10a3fe8e5cca81cdc13e57f5a
#51409https://github.com/nodejs/node/pull/51409
https://github.com/targos
targoshttps://github.com/targos
Jan 15, 2024https://github.com/nodejs/node/pull/51409#issuecomment-1891991086
b180512https://github.com/nodejs/node/commit/b180512aef7349a10a3fe8e5cca81cdc13e57f5a
Please reload this pagehttps://github.com/nodejs/node/pull/51409
https://github.com/targos
targoshttps://github.com/targos
Jan 15, 2024https://github.com/nodejs/node/pull/51409#event-11487084783
https://github.com/targos
targoshttps://github.com/targos
January 15, 2024 11:30https://github.com/nodejs/node/pull/51409#event-11487085491
Medhansh404https://github.com/Medhansh404
Jan 19, 2024 https://github.com/nodejs/node/pull/51409#ref-commit-bed1938
https://github.com/targos
https://github.com/Medhansh404
tools: do not pass invalid flag to C compilerhttps://github.com/Medhansh404/node/commit/bed193838f318cea39226a20a9c226a9479672f8
bed1938https://github.com/Medhansh404/node/commit/bed193838f318cea39226a20a9c226a9479672f8
nodejs#51409https://github.com/nodejs/node/pull/51409
targoshttps://github.com/targos
Feb 15, 2024 https://github.com/nodejs/node/pull/51409#ref-commit-e88a301
https://github.com/targos
tools: do not pass invalid flag to C compilerhttps://github.com/nodejs/node/commit/e88a301e989cc291eec76ed25fec2e1eabd5b810
e88a301https://github.com/nodejs/node/commit/e88a301e989cc291eec76ed25fec2e1eabd5b810
#51409https://github.com/nodejs/node/pull/51409
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
Mar 1, 2024 https://github.com/nodejs/node/pull/51409#ref-pullrequest-2162891978
v21.7.0 proposal #51932 https://github.com/nodejs/node/pull/51932
richardlauhttps://github.com/richardlau
Mar 25, 2024 https://github.com/nodejs/node/pull/51409#ref-commit-fe4cd0e
https://github.com/targos
https://github.com/richardlau
tools: do not pass invalid flag to C compilerhttps://github.com/nodejs/node/commit/fe4cd0e36845a296f30c6222fb41628b8eef22d4
fe4cd0ehttps://github.com/nodejs/node/commit/fe4cd0e36845a296f30c6222fb41628b8eef22d4
#51409https://github.com/nodejs/node/pull/51409
richardlauhttps://github.com/richardlau
Mar 25, 2024 https://github.com/nodejs/node/pull/51409#ref-commit-97470b1
https://github.com/targos
https://github.com/richardlau
tools: do not pass invalid flag to C compilerhttps://github.com/nodejs/node/commit/97470b179ba811a56d21c880b0327c93f71e5aa2
97470b1https://github.com/nodejs/node/commit/97470b179ba811a56d21c880b0327c93f71e5aa2
#51409https://github.com/nodejs/node/pull/51409
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 25, 2024 https://github.com/nodejs/node/pull/51409#ref-pullrequest-2206634908
v20.12.0 proposal #52212 https://github.com/nodejs/node/pull/52212
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51409
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/51409/files/c7f8b1629123065c20362ca5c2be0552405fbc4a
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/51409/files/c7f8b1629123065c20362ca5c2be0552405fbc4a
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/51409/files/c7f8b1629123065c20362ca5c2be0552405fbc4a
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/51409/files/c7f8b1629123065c20362ca5c2be0552405fbc4a
https://github.com/aymen94
aymen94 https://github.com/aymen94
https://github.com/nodejs/node/pull/51409/files/c7f8b1629123065c20362ca5c2be0552405fbc4a
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Please reload this pagehttps://github.com/nodejs/node/pull/51409
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com/benjamingr
https://github.com/lpinca
https://github.com/tniessen
https://github.com/gengjiawen
https://github.com/aymen94
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.