René's URL Explorer Experiment


Title: string_decoder: fix performance regression by mscdex · Pull Request #5134 · nodejs/node · GitHub

Open Graph Title: string_decoder: fix performance regression by mscdex · Pull Request #5134 · nodejs/node

X Title: string_decoder: fix performance regression by mscdex · Pull Request #5134 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit reverts the const usage introduced by 68a6abc because v8 currently cannot optimize functions that contain these uses of const (unsupported phi use of const variable). The performance di...

X Description: This commit reverts the const usage introduced by 68a6abc because v8 currently cannot optimize functions that contain these uses of const (unsupported phi use of const variable). The performance di...

Opengraph URL: https://github.com/nodejs/node/pull/5134

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0a438c9e-0735-ff34-2015-65e2ad0d70a2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8450:F5AD2:9020E:BD0E0:6A4ECAD9
html-safe-nonce87b515b6bb63275e53807bc0545d6f88b96e9010457c823200c1311b76693f50
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDUwOkY1QUQyOjkwMjBFOkJEMEUwOjZBNEVDQUQ5IiwidmlzaXRvcl9pZCI6IjQ5NzI5MDY3Nzk5ODc4NTYwODkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3dfadaaaedc02980c36bc283cb5c70c7cb3c4a8a769a38f72b90c01d0742f87f
hovercard-subject-tagpull_request:58559402
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/5134/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/53860d83c3c178ddf45e25161bfed5481e1b5e6fce3115dab74d75b37d373b97/nodejs/node/pull/5134
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/53860d83c3c178ddf45e25161bfed5481e1b5e6fce3115dab74d75b37d373b97/nodejs/node/pull/5134
og:image:altThis commit reverts the const usage introduced by 68a6abc because v8 currently cannot optimize functions that contain these uses of const (unsupported phi use of const variable). The performance di...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemscdex
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/5134#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5134
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5134
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/5134
Reloadhttps://github.com/nodejs/node/pull/5134
Reloadhttps://github.com/nodejs/node/pull/5134
Please reload this pagehttps://github.com/nodejs/node/pull/5134
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/5134
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mscdexhttps://github.com/mscdex
nodejs:masterhttps://github.com/nodejs/node/tree/master
mscdex:fix-string-decoder-write-deopthttps://github.com/mscdex/io.js/tree/fix-string-decoder-write-deopt
Conversationhttps://github.com/nodejs/node/pull/5134
Commits1 (1)https://github.com/nodejs/node/pull/5134/commits
Checkshttps://github.com/nodejs/node/pull/5134/checks
Files changedhttps://github.com/nodejs/node/pull/5134/files
string_decoder: fix performance regressionhttps://github.com/nodejs/node/pull/5134#top
mscdexhttps://github.com/mscdex
nodejs:masterhttps://github.com/nodejs/node/tree/master
mscdex:fix-string-decoder-write-deopthttps://github.com/mscdex/io.js/tree/fix-string-decoder-write-deopt
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 7, 2016https://github.com/nodejs/node/pull/5134#issue-132020870
68a6abchttps://github.com/nodejs/node/commit/68a6abc806a0b359f72d73cfeb7ad7fd383f2c8b
Please reload this pagehttps://github.com/nodejs/node/pull/5134
https://github.com/mscdex
mscdexhttps://github.com/mscdex
string_decoder https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astring_decoder
Feb 7, 2016https://github.com/nodejs/node/pull/5134#event-542346247
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Feb 7, 2016https://github.com/nodejs/node/pull/5134#issuecomment-181137471
Please reload this pagehttps://github.com/nodejs/node/pull/5134
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 7, 2016https://github.com/nodejs/node/pull/5134#issuecomment-181137836
Please reload this pagehttps://github.com/nodejs/node/pull/5134
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 7, 2016https://github.com/nodejs/node/pull/5134#issuecomment-181137983
https://ci.nodejs.org/job/node-test-pull-request/1583/https://ci.nodejs.org/job/node-test-pull-request/1583/
Please reload this pagehttps://github.com/nodejs/node/pull/5134
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 10, 2016https://github.com/nodejs/node/pull/5134#issuecomment-182193541
Please reload this pagehttps://github.com/nodejs/node/pull/5134
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 10, 2016https://github.com/nodejs/node/pull/5134#issuecomment-182207315
Please reload this pagehttps://github.com/nodejs/node/pull/5134
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 10, 2016https://github.com/nodejs/node/pull/5134#issuecomment-182474996
Please reload this pagehttps://github.com/nodejs/node/pull/5134
https://github.com/mscdex
string_decoder: fix performance regressionhttps://github.com/nodejs/node/pull/5134/commits/67edf11bc8cc7f94d5119843d46d940a768760de
67edf11https://github.com/nodejs/node/pull/5134/commits/67edf11bc8cc7f94d5119843d46d940a768760de
https://github.com/mscdex
mscdexhttps://github.com/mscdex
force-pushedhttps://github.com/nodejs/node/compare/e58ae8645a4c58b68e603c491a5866c8146ec27d..67edf11bc8cc7f94d5119843d46d940a768760de
e58ae86https://github.com/nodejs/node/commit/e58ae8645a4c58b68e603c491a5866c8146ec27d
67edf11https://github.com/nodejs/node/commit/67edf11bc8cc7f94d5119843d46d940a768760de
Compare https://github.com/nodejs/node/compare/e58ae8645a4c58b68e603c491a5866c8146ec27d..67edf11bc8cc7f94d5119843d46d940a768760de
February 11, 2016 15:40https://github.com/nodejs/node/pull/5134#event-547314854
mscdexhttps://github.com/mscdex
Feb 11, 2016 https://github.com/nodejs/node/pull/5134#ref-commit-ae244a2
https://github.com/mscdex
string_decoder: fix performance regressionhttps://github.com/nodejs/node/commit/ae244a26c1364857752db2aa79ef1a4a80912459
ae244a2https://github.com/nodejs/node/commit/ae244a26c1364857752db2aa79ef1a4a80912459
#5134https://github.com/nodejs/node/pull/5134
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 11, 2016https://github.com/nodejs/node/pull/5134#issuecomment-182922948
ae244a2https://github.com/nodejs/node/commit/ae244a26c1364857752db2aa79ef1a4a80912459
Please reload this pagehttps://github.com/nodejs/node/pull/5134
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 11, 2016https://github.com/nodejs/node/pull/5134#event-547320194
https://github.com/mscdex
mscdexhttps://github.com/mscdex
February 11, 2016 15:45https://github.com/nodejs/node/pull/5134#event-547322421
rvagghttps://github.com/rvagg
Feb 15, 2016 https://github.com/nodejs/node/pull/5134#ref-commit-25513a4
https://github.com/mscdex
https://github.com/rvagg
string_decoder: fix performance regressionhttps://github.com/nodejs/node/commit/25513a473ac7c51e77787f8ab7af69d0aec22a32
25513a4https://github.com/nodejs/node/commit/25513a473ac7c51e77787f8ab7af69d0aec22a32
#5134https://github.com/nodejs/node/pull/5134
stefanmbhttps://github.com/stefanmb
Feb 23, 2016 https://github.com/nodejs/node/pull/5134#ref-commit-f6e84f2
https://github.com/mscdex
https://github.com/stefanmb
string_decoder: fix performance regressionhttps://github.com/stefanmb/node/commit/f6e84f27468dc478ba21b7d48a9dd730f7dae05b
f6e84f2https://github.com/stefanmb/node/commit/f6e84f27468dc478ba21b7d48a9dd730f7dae05b
nodejs#5134https://github.com/nodejs/node/pull/5134
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 10, 2016 https://github.com/nodejs/node/pull/5134#ref-issue-139999585
Audit commits not found on v4.x #5647 https://github.com/nodejs/node/issues/5647
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Mar 10, 2016https://github.com/nodejs/node/pull/5134#event-585530032
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 10, 2016https://github.com/nodejs/node/pull/5134#issuecomment-195056300
Please reload this pagehttps://github.com/nodejs/node/pull/5134
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 11, 2016https://github.com/nodejs/node/pull/5134#issuecomment-195143922
Please reload this pagehttps://github.com/nodejs/node/pull/5134
https://github.com/rvagg
rvagghttps://github.com/rvagg
Mar 14, 2016https://github.com/nodejs/node/pull/5134#issuecomment-196102636
Please reload this pagehttps://github.com/nodejs/node/pull/5134
MylesBorinshttps://github.com/MylesBorins
Mar 17, 2016 https://github.com/nodejs/node/pull/5134#ref-commit-04d6d5b
https://github.com/mscdex
string_decoder: fix performance regressionhttps://github.com/nodejs/node/commit/04d6d5b1c9c7c3ef983261626ee46e0a734ec40b
04d6d5bhttps://github.com/nodejs/node/commit/04d6d5b1c9c7c3ef983261626ee46e0a734ec40b
#5134https://github.com/nodejs/node/pull/5134
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Mar 17, 2016https://github.com/nodejs/node/pull/5134#event-593798975
MylesBorinshttps://github.com/MylesBorins
Mar 21, 2016 https://github.com/nodejs/node/pull/5134#ref-commit-cc0e36f
https://github.com/mscdex
string_decoder: fix performance regressionhttps://github.com/nodejs/node/commit/cc0e36ff98f7b5b6610bbfeed508c4163673c897
cc0e36fhttps://github.com/nodejs/node/commit/cc0e36ff98f7b5b6610bbfeed508c4163673c897
#5134https://github.com/nodejs/node/pull/5134
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5134
string_decoder https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astring_decoder
Please reload this pagehttps://github.com/nodejs/node/pull/5134
https://github.com/mscdex
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/MylesBorins
https://github.com/rvagg
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.