René's URL Explorer Experiment


Title: lib: reduce overhead of `SafePromiseAllSettledReturnVoid` calls by aduh95 · Pull Request #51243 · nodejs/node · GitHub

Open Graph Title: lib: reduce overhead of `SafePromiseAllSettledReturnVoid` calls by aduh95 · Pull Request #51243 · nodejs/node

X Title: lib: reduce overhead of `SafePromiseAllSettledReturnVoid` calls by aduh95 · Pull Request #51243 · nodejs/node

Description: It was simply calling SafePromiseAllSettled, which itself calls arrayToSafePromiseIterable which wraps all promises into new SafePromise object and wraps it into a SafeArrayIterator. Since we don't...

Open Graph Description: It was simply calling SafePromiseAllSettled, which itself calls arrayToSafePromiseIterable which wraps all promises into new SafePromise object and wraps it into a SafeArrayIterator. Since we don&#...

X Description: It was simply calling SafePromiseAllSettled, which itself calls arrayToSafePromiseIterable which wraps all promises into new SafePromise object and wraps it into a SafeArrayIterator. Since we don&a...

Opengraph URL: https://github.com/nodejs/node/pull/51243

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8ea52d6b-0ab5-9f89-d992-bb051c910678
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8814:15CCBD:BD81F:10A8C0:696A0355
html-safe-nonce8c63eb30565e2b3b95d3455caae08bce4c83ced994b267f3a3f4415ada367a53
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODE0OjE1Q0NCRDpCRDgxRjoxMEE4QzA6Njk2QTAzNTUiLCJ2aXNpdG9yX2lkIjoiMTAyMzQ1NTI1MzQ1MDMyNjg2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac49f99ac947f3cb593b7409fb647b256ad1c216899979ad05e91b178da9884f0f
hovercard-subject-tagpull_request:1652542879
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/51243/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7c15f0aa3eeb285e9960ac4330791a17eb92557cd790bdd8869bad9654a211a3/nodejs/node/pull/51243
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7c15f0aa3eeb285e9960ac4330791a17eb92557cd790bdd8869bad9654a211a3/nodejs/node/pull/51243
og:image:altIt was simply calling SafePromiseAllSettled, which itself calls arrayToSafePromiseIterable which wraps all promises into new SafePromise object and wraps it into a SafeArrayIterator. Since we don&#...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaduh95
hostnamegithub.com
expected-hostnamegithub.com
None578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release671c2f67171dbced24284331f3133a613d08c366
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/51243#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51243
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51243
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/51243
Reloadhttps://github.com/nodejs/node/pull/51243
Reloadhttps://github.com/nodejs/node/pull/51243
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/51243
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/51243
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/51243#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
aduh95:SafePromiseAllSettledReturnVoidhttps://github.com/aduh95/node/tree/SafePromiseAllSettledReturnVoid
lib: reduce overhead of SafePromiseAllSettledReturnVoid calls https://github.com/nodejs/node/pull/51243#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
aduh95:SafePromiseAllSettledReturnVoidhttps://github.com/aduh95/node/tree/SafePromiseAllSettledReturnVoid
Conversation 5 https://github.com/nodejs/node/pull/51243
Commits 1 https://github.com/nodejs/node/pull/51243/commits
Checks 0 https://github.com/nodejs/node/pull/51243/checks
Files changed https://github.com/nodejs/node/pull/51243/files
Please reload this pagehttps://github.com/nodejs/node/pull/51243
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 20, 2023https://github.com/nodejs/node/pull/51243#issue-2051069746
node/lib/internal/per_context/primordials.jshttps://github.com/nodejs/node/blob/fd21429ef5f6c2c06ce9e108a8548a1703577714/lib/internal/per_context/primordials.js#L483-L490
fd21429https://github.com/nodejs/node/commit/fd21429ef5f6c2c06ce9e108a8548a1703577714
Please reload this pagehttps://github.com/nodejs/node/pull/51243
https://github.com/aduh95
lib: reduce overhead of SafePromiseAllSettledReturnVoid callshttps://github.com/nodejs/node/pull/51243/commits/7ce04bfb09778c45c08acc2a8dba4fded4b0d626
7ce04bfhttps://github.com/nodejs/node/pull/51243/commits/7ce04bfb09778c45c08acc2a8dba4fded4b0d626
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Dec 20, 2023https://github.com/nodejs/node/pull/51243#event-11306072856
https://github.com/targos
targoshttps://github.com/targos
Dec 21, 2023 https://github.com/nodejs/node/pull/51243#pullrequestreview-1792370171
View reviewed changes https://github.com/nodejs/node/pull/51243/files/7ce04bfb09778c45c08acc2a8dba4fded4b0d626
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 21, 2023https://github.com/nodejs/node/pull/51243#event-11311466549
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 21, 2023https://github.com/nodejs/node/pull/51243#event-11311510426
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 21, 2023https://github.com/nodejs/node/pull/51243#issuecomment-1865789874
https://ci.nodejs.org/job/node-test-pull-request/56423/https://ci.nodejs.org/job/node-test-pull-request/56423/
Please reload this pagehttps://github.com/nodejs/node/pull/51243
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 21, 2023https://github.com/nodejs/node/pull/51243#issuecomment-1866019881
Please reload this pagehttps://github.com/nodejs/node/pull/51243
https://ci.nodejs.org/job/node-test-pull-request/56427/https://ci.nodejs.org/job/node-test-pull-request/56427/
Please reload this pagehttps://github.com/nodejs/node/pull/51243
https://github.com/H4ad
H4adhttps://github.com/H4ad
Dec 21, 2023 https://github.com/nodejs/node/pull/51243#pullrequestreview-1793672182
View reviewed changes https://github.com/nodejs/node/pull/51243/files/7ce04bfb09778c45c08acc2a8dba4fded4b0d626
https://github.com/H4ad
H4adhttps://github.com/H4ad
Dec 21, 2023 https://github.com/nodejs/node/pull/51243#pullrequestreview-1793672682
View reviewed changes https://github.com/nodejs/node/pull/51243/files/7ce04bfb09778c45c08acc2a8dba4fded4b0d626
lib/internal/per_context/primordials.jshttps://github.com/nodejs/node/pull/51243/files/7ce04bfb09778c45c08acc2a8dba4fded4b0d626#diff-779a6c11149216db58bb1399288c9999a94dd9de3773d87a5ab708c92a6dab8f
Please reload this pagehttps://github.com/nodejs/node/pull/51243
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Dec 21, 2023https://github.com/nodejs/node/pull/51243#event-11321068991
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 22, 2023 https://github.com/nodejs/node/pull/51243#pullrequestreview-1793878040
View reviewed changes https://github.com/nodejs/node/pull/51243/files/7ce04bfb09778c45c08acc2a8dba4fded4b0d626
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Dec 22, 2023https://github.com/nodejs/node/pull/51243#event-11328720843
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
bc16952https://github.com/nodejs/node/commit/bc16952cda4ed2a73964a31f6838277ece442389
Dec 22, 2023https://github.com/nodejs/node/pull/51243#event-11328721330
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 22, 2023https://github.com/nodejs/node/pull/51243#issuecomment-1867969654
bc16952https://github.com/nodejs/node/commit/bc16952cda4ed2a73964a31f6838277ece442389
Please reload this pagehttps://github.com/nodejs/node/pull/51243
https://github.com/aduh95
aduh95https://github.com/aduh95
December 23, 2023 00:48https://github.com/nodejs/node/pull/51243#event-11329973155
RafaelGSShttps://github.com/RafaelGSS
Jan 2, 2024 https://github.com/nodejs/node/pull/51243#ref-commit-ed7305e
https://github.com/aduh95
https://github.com/RafaelGSS
lib: reduce overhead of SafePromiseAllSettledReturnVoid callshttps://github.com/nodejs/node/commit/ed7305e49b5f6a38e589c6e595b6a6c5bf12e20f
ed7305ehttps://github.com/nodejs/node/commit/ed7305e49b5f6a38e589c6e595b6a6c5bf12e20f
#51243https://github.com/nodejs/node/pull/51243
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Jan 2, 2024 https://github.com/nodejs/node/pull/51243#ref-pullrequest-2062770813
v21.6.0 proposal #51342 https://github.com/nodejs/node/pull/51342
richardlauhttps://github.com/richardlau
Mar 25, 2024 https://github.com/nodejs/node/pull/51243#ref-commit-0a85b0f
https://github.com/aduh95
https://github.com/richardlau
lib: reduce overhead of SafePromiseAllSettledReturnVoid callshttps://github.com/nodejs/node/commit/0a85b0fd9de0e4031f85db7548700f537dda832e
0a85b0fhttps://github.com/nodejs/node/commit/0a85b0fd9de0e4031f85db7548700f537dda832e
#51243https://github.com/nodejs/node/pull/51243
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 25, 2024 https://github.com/nodejs/node/pull/51243#ref-pullrequest-2206634908
v20.12.0 proposal #52212 https://github.com/nodejs/node/pull/52212
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51243
https://github.com/H4ad
H4ad https://github.com/H4ad
https://github.com/nodejs/node/pull/51243/files/7ce04bfb09778c45c08acc2a8dba4fded4b0d626
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/51243/files/7ce04bfb09778c45c08acc2a8dba4fded4b0d626
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/51243/files/7ce04bfb09778c45c08acc2a8dba4fded4b0d626
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/51243
https://github.com/aduh95
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/targos
https://github.com/H4ad
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.