| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9af79fbc-4771-e2c9-6ba6-e3e9f15fd016 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E552:180D24:8D18DC:B295AA:6B036080 |
| html-safe-nonce | 35f0184ca83699bc0d97858acf5e6f58354c16f61eea4c012688e322c8b62d0e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTUyOjE4MEQyNDo4RDE4REM6QjI5NUFBOjZCMDM2MDgwIiwidmlzaXRvcl9pZCI6IjQ2NTA0MjMyNzA4NjMyMzMxNTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 67a65281891209dff374ea89044873e4c5846f4c7affcda99726ea534ca52d73 |
| hovercard-subject-tag | pull_request:1646697446 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/51168/files |
| twitter:image | https://avatars.githubusercontent.com/u/649348?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/649348?s=400&v=4 |
| og:image:alt | Follow-up on #50126.
Avoid PromiseResolve in ensureIsPromise. Web IDL requires this to always return a new Promise, whereas PromiseResolve may return the same Promise. This leads to a different ti... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/51168/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51168%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51168%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/51168/files |
| Reload | https://github.com/nodejs/node/pull/51168/files |
| Reload | https://github.com/nodejs/node/pull/51168/files |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues639 (639) | https://github.com/nodejs/node/issues |
| Pull requests667 (667) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
|
Conversation
24
| https://github.com/nodejs/node/pull/51168 |
|
Commits
20
| https://github.com/nodejs/node/pull/51168/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/51168/checks |
|
Files changed
| https://github.com/nodejs/node/pull/51168/files |
| Please reload this page | https://github.com/nodejs/node/pull/51168/files |
|
streams: fixes for webstreams
| https://github.com/nodejs/node/pull/51168/files#top |
|
Show all changes
20 commits
| https://github.com/nodejs/node/pull/51168/files |
|
cb4e020
stream: fix code style
MattiasBuelens Dec 15, 2023
| https://github.com/nodejs/node/pull/51168/commits/cb4e020de5b95647dcead2c503c7480b22cd3b83 |
|
46022b8
stream: avoid PromiseResolve in ensureIsPromise
MattiasBuelens Dec 4, 2023
| https://github.com/nodejs/node/pull/51168/commits/46022b87c83c89a406c5d62b675f58f763f9d560 |
|
62fc1e1
stream: fix handling sync errors from source cancel and sink abort
MattiasBuelens Dec 4, 2023
| https://github.com/nodejs/node/pull/51168/commits/62fc1e142f533bbf93c626ee8b46a90892c561db |
|
19e8940
stream: check for promise only when constructing from source/sink/tra…
MattiasBuelens Dec 4, 2023
| https://github.com/nodejs/node/pull/51168/commits/19e8940b351a946fd2607160ce836052c2730d3c |
|
ab33b45
stream: fix TeeReadableStream
MattiasBuelens Dec 4, 2023
| https://github.com/nodejs/node/pull/51168/commits/ab33b45ec7529120dbc798fe18e0aa87d9168998 |
|
463f49a
stream: rename TeeReadableStream to InternalReadableStream
MattiasBuelens Dec 4, 2023
| https://github.com/nodejs/node/pull/51168/commits/463f49a4017be43259d561a135622aa49cb773a6 |
|
36324d5
stream: use internal ReadableStream for teeing byte streams
MattiasBuelens Dec 4, 2023
| https://github.com/nodejs/node/pull/51168/commits/36324d5d6cbc56c62c5675ecbab7bf8d9c7179ac |
|
f0b1036
stream: use internal ReadableStream for ReadableStream.from()
MattiasBuelens Dec 4, 2023
| https://github.com/nodejs/node/pull/51168/commits/f0b10365df0d8d8659fa274cf71491bf085f9d2a |
|
3846bfe
stream: use internal streams for TransformStream
MattiasBuelens Dec 4, 2023
| https://github.com/nodejs/node/pull/51168/commits/3846bfed16a387bc62a077e6ffefb06112a00dff |
|
0d45e6f
stream: add helpers to create internal state
MattiasBuelens Dec 15, 2023
| https://github.com/nodejs/node/pull/51168/commits/0d45e6f3ff0ff723a16ffebb203ab2a87e6ab4db |
|
5df4f2e
stream: remove unused field in internal state
MattiasBuelens Dec 15, 2023
| https://github.com/nodejs/node/pull/51168/commits/5df4f2e2e2d6661d489b3edfabaa975709cadb3c |
|
15b30ca
stream: fix validating callbacks
MattiasBuelens Dec 4, 2023
| https://github.com/nodejs/node/pull/51168/commits/15b30ca6c923a26a1842255c18db12a5c57e18b5 |
|
0bd501f
test: update expectations for streams wpt
MattiasBuelens Dec 15, 2023
| https://github.com/nodejs/node/pull/51168/commits/0bd501f541cf45ca4e447827fd77b345dd3003b6 |
|
112a717
stream: set __proto__ to null for internal state
MattiasBuelens Dec 15, 2023
| https://github.com/nodejs/node/pull/51168/commits/112a71713286a179b106f80d80759de9264c179c |
|
b9a13b5
fixup! simplify ensureIsPromise
MattiasBuelens Dec 15, 2023
| https://github.com/nodejs/node/pull/51168/commits/b9a13b528e6330cd7d58e5bf9943909c2eb8a22a |
|
162cfdc
fixup! remove unused imports
MattiasBuelens Dec 15, 2023
| https://github.com/nodejs/node/pull/51168/commits/162cfdc0d99568962e045865603f1889c4cfd631 |
|
a889e2c
fixup! whitespace
MattiasBuelens Dec 15, 2023
| https://github.com/nodejs/node/pull/51168/commits/a889e2c7eec96c4e9afaeaa78dbb5b12e5b8c74d |
|
16a9cc7
fixup! code style
MattiasBuelens Dec 15, 2023
| https://github.com/nodejs/node/pull/51168/commits/16a9cc7113e0b768085c5a5bb3eb90fdea6330fa |
|
11e6f94
fixup! fix timing of ensureIsPromise
MattiasBuelens Dec 16, 2023
| https://github.com/nodejs/node/pull/51168/commits/11e6f94bd6740e7f3880711edb3727508afe8ab5 |
|
0c0e3c1
fixup! rename to invokePromiseCallback
MattiasBuelens Dec 16, 2023
| https://github.com/nodejs/node/pull/51168/commits/0c0e3c184c600ca98937c7ca760e312179be89eb |
|
Clear filters
| https://github.com/nodejs/node/pull/51168/files |
| Please reload this page | https://github.com/nodejs/node/pull/51168/files |
| Please reload this page | https://github.com/nodejs/node/pull/51168/files |
|
readablestream.js
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
transformstream.js
| https://github.com/nodejs/node/pull/51168/files#diff-45cad4ef90ad1549d1ed2ed3f3b7bc9782fece8a0daf45f04e4ec93241693c38 |
|
util.js
| https://github.com/nodejs/node/pull/51168/files#diff-aaaca5a0d724d6d820d62d474521e10fb5c7d5714401cf3ac799040a30b5ede9 |
|
writablestream.js
| https://github.com/nodejs/node/pull/51168/files#diff-2495cd91c53a338612a351c4f9e08fdb506d0843f377e20a02641fbb2ac15c78 |
|
streams.json
| https://github.com/nodejs/node/pull/51168/files#diff-83220a2020a08d0cfe6d7eed96c98dbd75f0743a7e829e5e5e75a0525a6456b6 |
| lib/internal/webstreams/readablestream.js | https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
View file
| https://github.com/nodejs/node/blob/0c0e3c184c600ca98937c7ca760e312179be89eb/lib/internal/webstreams/readablestream.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/51168/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
|
| https://github.com/nodejs/node/pull/51168/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47 |
| Please reload this page | https://github.com/nodejs/node/pull/51168/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |