René's URL Explorer Experiment


Title: streams: fixes for webstreams by MattiasBuelens · Pull Request #51168 · nodejs/node · GitHub

Open Graph Title: streams: fixes for webstreams by MattiasBuelens · Pull Request #51168 · nodejs/node

X Title: streams: fixes for webstreams by MattiasBuelens · Pull Request #51168 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Follow-up on #50126. Avoid PromiseResolve in ensureIsPromise. Web IDL requires this to always return a new Promise, whereas PromiseResolve may return the same Promise. This leads to a different ti...

X Description: Follow-up on #50126. Avoid PromiseResolve in ensureIsPromise. Web IDL requires this to always return a new Promise, whereas PromiseResolve may return the same Promise. This leads to a different ti...

Opengraph URL: https://github.com/nodejs/node/pull/51168

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:4a4068f5-c3eb-04d3-3bcb-d73b16b0842f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB980:43FF1:83EBF7:A6D886:6B035C95
html-safe-noncea272b18c1a770ef069d735294020f37d91da2d781d76e3769bfa9a82de137872
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTgwOjQzRkYxOjgzRUJGNzpBNkQ4ODY6NkIwMzVDOTUiLCJ2aXNpdG9yX2lkIjoiMzg4MzExNTg1MjkyMDQ3ODg2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2d182c57312abcfb1b177ce54d62a723537a426922dd633a28faeb1a36146f03
hovercard-subject-tagpull_request:1646697446
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/51168/commits
twitter:imagehttps://opengraph.githubassets.com/5a14abede8c21386c65e1b27fed3ed507a30d3d4086fe566f6bd0eae1da3d0fb/nodejs/node/pull/51168
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5a14abede8c21386c65e1b27fed3ed507a30d3d4086fe566f6bd0eae1da3d0fb/nodejs/node/pull/51168
og:image:altFollow-up on #50126. Avoid PromiseResolve in ensureIsPromise. Web IDL requires this to always return a new Promise, whereas PromiseResolve may return the same Promise. This leads to a different ti...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMattiasBuelens
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/51168/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51168%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51168%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/51168/commits
Reloadhttps://github.com/nodejs/node/pull/51168/commits
Reloadhttps://github.com/nodejs/node/pull/51168/commits
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues638 (638)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
Conversationhttps://github.com/nodejs/node/pull/51168
Commits20 (20)https://github.com/nodejs/node/pull/51168/commits
Checkshttps://github.com/nodejs/node/pull/51168/checks
Files changedhttps://github.com/nodejs/node/pull/51168/files
streams: fixes for webstreamshttps://github.com/nodejs/node/pull/51168/commits#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
stream: fix code stylehttps://github.com/nodejs/node/pull/51168/commits/cb4e020de5b95647dcead2c503c7480b22cd3b83
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
cb4e020https://github.com/nodejs/node/pull/51168/commits/cb4e020de5b95647dcead2c503c7480b22cd3b83
https://github.com/nodejs/node/tree/cb4e020de5b95647dcead2c503c7480b22cd3b83
stream: avoid PromiseResolve in ensureIsPromisehttps://github.com/nodejs/node/pull/51168/commits/46022b87c83c89a406c5d62b675f58f763f9d560
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
46022b8https://github.com/nodejs/node/pull/51168/commits/46022b87c83c89a406c5d62b675f58f763f9d560
https://github.com/nodejs/node/tree/46022b87c83c89a406c5d62b675f58f763f9d560
stream: fix handling sync errors from source cancel and sink aborthttps://github.com/nodejs/node/pull/51168/commits/62fc1e142f533bbf93c626ee8b46a90892c561db
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
62fc1e1https://github.com/nodejs/node/pull/51168/commits/62fc1e142f533bbf93c626ee8b46a90892c561db
https://github.com/nodejs/node/tree/62fc1e142f533bbf93c626ee8b46a90892c561db
stream: check for promise only when constructing from source/sink/transformerhttps://github.com/nodejs/node/pull/51168/commits/19e8940b351a946fd2607160ce836052c2730d3c
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
19e8940https://github.com/nodejs/node/pull/51168/commits/19e8940b351a946fd2607160ce836052c2730d3c
https://github.com/nodejs/node/tree/19e8940b351a946fd2607160ce836052c2730d3c
stream: fix TeeReadableStreamhttps://github.com/nodejs/node/pull/51168/commits/ab33b45ec7529120dbc798fe18e0aa87d9168998
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
ab33b45https://github.com/nodejs/node/pull/51168/commits/ab33b45ec7529120dbc798fe18e0aa87d9168998
https://github.com/nodejs/node/tree/ab33b45ec7529120dbc798fe18e0aa87d9168998
stream: rename TeeReadableStream to InternalReadableStreamhttps://github.com/nodejs/node/pull/51168/commits/463f49a4017be43259d561a135622aa49cb773a6
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
463f49ahttps://github.com/nodejs/node/pull/51168/commits/463f49a4017be43259d561a135622aa49cb773a6
https://github.com/nodejs/node/tree/463f49a4017be43259d561a135622aa49cb773a6
stream: use internal ReadableStream for teeing byte streamshttps://github.com/nodejs/node/pull/51168/commits/36324d5d6cbc56c62c5675ecbab7bf8d9c7179ac
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
36324d5https://github.com/nodejs/node/pull/51168/commits/36324d5d6cbc56c62c5675ecbab7bf8d9c7179ac
https://github.com/nodejs/node/tree/36324d5d6cbc56c62c5675ecbab7bf8d9c7179ac
stream: use internal ReadableStream for ReadableStream.from()https://github.com/nodejs/node/pull/51168/commits/f0b10365df0d8d8659fa274cf71491bf085f9d2a
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
f0b1036https://github.com/nodejs/node/pull/51168/commits/f0b10365df0d8d8659fa274cf71491bf085f9d2a
https://github.com/nodejs/node/tree/f0b10365df0d8d8659fa274cf71491bf085f9d2a
stream: use internal streams for TransformStreamhttps://github.com/nodejs/node/pull/51168/commits/3846bfed16a387bc62a077e6ffefb06112a00dff
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
3846bfehttps://github.com/nodejs/node/pull/51168/commits/3846bfed16a387bc62a077e6ffefb06112a00dff
https://github.com/nodejs/node/tree/3846bfed16a387bc62a077e6ffefb06112a00dff
stream: add helpers to create internal statehttps://github.com/nodejs/node/pull/51168/commits/0d45e6f3ff0ff723a16ffebb203ab2a87e6ab4db
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
0d45e6fhttps://github.com/nodejs/node/pull/51168/commits/0d45e6f3ff0ff723a16ffebb203ab2a87e6ab4db
https://github.com/nodejs/node/tree/0d45e6f3ff0ff723a16ffebb203ab2a87e6ab4db
stream: remove unused field in internal statehttps://github.com/nodejs/node/pull/51168/commits/5df4f2e2e2d6661d489b3edfabaa975709cadb3c
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
5df4f2ehttps://github.com/nodejs/node/pull/51168/commits/5df4f2e2e2d6661d489b3edfabaa975709cadb3c
https://github.com/nodejs/node/tree/5df4f2e2e2d6661d489b3edfabaa975709cadb3c
stream: fix validating callbackshttps://github.com/nodejs/node/pull/51168/commits/15b30ca6c923a26a1842255c18db12a5c57e18b5
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
15b30cahttps://github.com/nodejs/node/pull/51168/commits/15b30ca6c923a26a1842255c18db12a5c57e18b5
https://github.com/nodejs/node/tree/15b30ca6c923a26a1842255c18db12a5c57e18b5
test: update expectations for streams wpthttps://github.com/nodejs/node/pull/51168/commits/0bd501f541cf45ca4e447827fd77b345dd3003b6
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
0bd501fhttps://github.com/nodejs/node/pull/51168/commits/0bd501f541cf45ca4e447827fd77b345dd3003b6
https://github.com/nodejs/node/tree/0bd501f541cf45ca4e447827fd77b345dd3003b6
stream: set __proto__ to null for internal statehttps://github.com/nodejs/node/pull/51168/commits/112a71713286a179b106f80d80759de9264c179c
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
112a717https://github.com/nodejs/node/pull/51168/commits/112a71713286a179b106f80d80759de9264c179c
https://github.com/nodejs/node/tree/112a71713286a179b106f80d80759de9264c179c
fixup! simplify ensureIsPromisehttps://github.com/nodejs/node/pull/51168/commits/b9a13b528e6330cd7d58e5bf9943909c2eb8a22a
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
b9a13b5https://github.com/nodejs/node/pull/51168/commits/b9a13b528e6330cd7d58e5bf9943909c2eb8a22a
https://github.com/nodejs/node/tree/b9a13b528e6330cd7d58e5bf9943909c2eb8a22a
fixup! remove unused importshttps://github.com/nodejs/node/pull/51168/commits/162cfdc0d99568962e045865603f1889c4cfd631
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
162cfdchttps://github.com/nodejs/node/pull/51168/commits/162cfdc0d99568962e045865603f1889c4cfd631
https://github.com/nodejs/node/tree/162cfdc0d99568962e045865603f1889c4cfd631
fixup! whitespacehttps://github.com/nodejs/node/pull/51168/commits/a889e2c7eec96c4e9afaeaa78dbb5b12e5b8c74d
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
a889e2chttps://github.com/nodejs/node/pull/51168/commits/a889e2c7eec96c4e9afaeaa78dbb5b12e5b8c74d
https://github.com/nodejs/node/tree/a889e2c7eec96c4e9afaeaa78dbb5b12e5b8c74d
fixup! code stylehttps://github.com/nodejs/node/pull/51168/commits/16a9cc7113e0b768085c5a5bb3eb90fdea6330fa
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
16a9cc7https://github.com/nodejs/node/pull/51168/commits/16a9cc7113e0b768085c5a5bb3eb90fdea6330fa
https://github.com/nodejs/node/tree/16a9cc7113e0b768085c5a5bb3eb90fdea6330fa
fixup! fix timing of ensureIsPromisehttps://github.com/nodejs/node/pull/51168/commits/11e6f94bd6740e7f3880711edb3727508afe8ab5
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
11e6f94https://github.com/nodejs/node/pull/51168/commits/11e6f94bd6740e7f3880711edb3727508afe8ab5
https://github.com/nodejs/node/tree/11e6f94bd6740e7f3880711edb3727508afe8ab5
fixup! rename to invokePromiseCallbackhttps://github.com/nodejs/node/pull/51168/commits/0c0e3c184c600ca98937c7ca760e312179be89eb
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/nodejs/node/commits?author=MattiasBuelens
0c0e3c1https://github.com/nodejs/node/pull/51168/commits/0c0e3c184c600ca98937c7ca760e312179be89eb
https://github.com/nodejs/node/tree/0c0e3c184c600ca98937c7ca760e312179be89eb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.