René's URL Explorer Experiment


Title: module: move the CJS exports cache to internal/modules/cjs/loader by joyeecheung · Pull Request #51157 · nodejs/node · GitHub

Open Graph Title: module: move the CJS exports cache to internal/modules/cjs/loader by joyeecheung · Pull Request #51157 · nodejs/node

X Title: module: move the CJS exports cache to internal/modules/cjs/loader by joyeecheung · Pull Request #51157 · nodejs/node

Description: This puts it together with the cjsParseCache and reduces the circular dependency on the singleton loader, which is the only place where this cache is stored. Drive-by: remove always-false module st...

Open Graph Description: This puts it together with the cjsParseCache and reduces the circular dependency on the singleton loader, which is the only place where this cache is stored. Drive-by: remove always-false module st...

X Description: This puts it together with the cjsParseCache and reduces the circular dependency on the singleton loader, which is the only place where this cache is stored. Drive-by: remove always-false module st...

Opengraph URL: https://github.com/nodejs/node/pull/51157

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bdb4a66f-62c0-b3e5-b5c1-96628525cafa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9370:1C07BE:742A60:A09E23:696A2A04
html-safe-nonce3334cf7398cafab4048c2cfd786b313695ecfeb87ef397fd9d50b2bb41fa899b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzcwOjFDMDdCRTo3NDJBNjA6QTA5RTIzOjY5NkEyQTA0IiwidmlzaXRvcl9pZCI6Ijg5NjQ2MTI0NjUzMzYzOTYyOTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacca37b59afa7467faaf63bc888c2a51967fe5461def097be548946facc0b11a39
hovercard-subject-tagpull_request:1644521253
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/51157/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a16e49b96f1fbac899d5152b691e39de3d93371fea70f70e92774c8774151774/nodejs/node/pull/51157
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a16e49b96f1fbac899d5152b691e39de3d93371fea70f70e92774c8774151774/nodejs/node/pull/51157
og:image:altThis puts it together with the cjsParseCache and reduces the circular dependency on the singleton loader, which is the only place where this cache is stored. Drive-by: remove always-false module st...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
Nonea1022f03e4f0d91ea173e4e5dac892c982e0588c62f1ce56121d755a320a3569
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef472b8e6c7b3fdd5d0354972a3f4c516289bf0be
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/51157#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51157
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51157
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/51157
Reloadhttps://github.com/nodejs/node/pull/51157
Reloadhttps://github.com/nodejs/node/pull/51157
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/51157
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/51157
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/51157#issue-comment-box
joyeecheunghttps://github.com/joyeecheung
nodejs:mainhttps://github.com/nodejs/node/tree/main
joyeecheung:cache-refactorhttps://github.com/joyeecheung/node/tree/cache-refactor
module: move the CJS exports cache to internal/modules/cjs/loader https://github.com/nodejs/node/pull/51157#top
joyeecheunghttps://github.com/joyeecheung
nodejs:mainhttps://github.com/nodejs/node/tree/main
joyeecheung:cache-refactorhttps://github.com/joyeecheung/node/tree/cache-refactor
Conversation 8 https://github.com/nodejs/node/pull/51157
Commits 1 https://github.com/nodejs/node/pull/51157/commits
Checks 0 https://github.com/nodejs/node/pull/51157/checks
Files changed https://github.com/nodejs/node/pull/51157/files
Please reload this pagehttps://github.com/nodejs/node/pull/51157
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 14, 2023https://github.com/nodejs/node/pull/51157#issue-2042050462
#34605https://github.com/nodejs/node/pull/34605
Please reload this pagehttps://github.com/nodejs/node/pull/51157
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 14, 2023https://github.com/nodejs/node/pull/51157#issuecomment-1856166987
Please reload this pagehttps://github.com/nodejs/node/pull/51157
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Dec 14, 2023https://github.com/nodejs/node/pull/51157#event-11250299504
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/12234a0f3014a21ee57fb3ada48d5a1bd346e70d..f2a3d8e743c229d44fec068a9a9769c210b2567f
12234a0https://github.com/nodejs/node/commit/12234a0f3014a21ee57fb3ada48d5a1bd346e70d
f2a3d8ehttps://github.com/nodejs/node/commit/f2a3d8e743c229d44fec068a9a9769c210b2567f
Compare https://github.com/nodejs/node/compare/12234a0f3014a21ee57fb3ada48d5a1bd346e70d..f2a3d8e743c229d44fec068a9a9769c210b2567f
December 14, 2023 16:32https://github.com/nodejs/node/pull/51157#event-11250307647
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 14, 2023https://github.com/nodejs/node/pull/51157#event-11250716518
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 14, 2023https://github.com/nodejs/node/pull/51157#event-11250826660
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 14, 2023https://github.com/nodejs/node/pull/51157#issuecomment-1856256540
https://ci.nodejs.org/job/node-test-pull-request/56291/https://ci.nodejs.org/job/node-test-pull-request/56291/
Please reload this pagehttps://github.com/nodejs/node/pull/51157
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Dec 14, 2023 https://github.com/nodejs/node/pull/51157#pullrequestreview-1782337664
View reviewed changes https://github.com/nodejs/node/pull/51157/files
ljharbhttps://github.com/ljharb
https://github.com/nodejs/node/pull/51157#pullrequestreview-1782337664
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/51157
https://github.com/lpinca
lpincahttps://github.com/lpinca
Dec 14, 2023 https://github.com/nodejs/node/pull/51157#pullrequestreview-1782709165
View reviewed changes https://github.com/nodejs/node/pull/51157/files
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Dec 14, 2023 https://github.com/nodejs/node/pull/51157#pullrequestreview-1782764666
View reviewed changes https://github.com/nodejs/node/pull/51157/files
GeoffreyBoothhttps://github.com/GeoffreyBooth
https://github.com/nodejs/node/pull/51157#pullrequestreview-1782764666
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/nodejs/node/tree/main/lib/internal/moduleshttps://github.com/nodejs/node/tree/main/lib/internal/modules
Please reload this pagehttps://github.com/nodejs/node/pull/51157
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 14, 2023https://github.com/nodejs/node/pull/51157#issuecomment-1856949871
Please reload this pagehttps://github.com/nodejs/node/pull/51157
Please reload this pagehttps://github.com/nodejs/node/pull/51157
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 14, 2023https://github.com/nodejs/node/pull/51157#event-11253934350
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 14, 2023https://github.com/nodejs/node/pull/51157#event-11253958182
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 14, 2023https://github.com/nodejs/node/pull/51157#issuecomment-1856973838
https://ci.nodejs.org/job/node-test-pull-request/56297/https://ci.nodejs.org/job/node-test-pull-request/56297/
Please reload this pagehttps://github.com/nodejs/node/pull/51157
https://github.com/joyeecheung
module: move the CJS exports cache to internal/modules/cjs/loaderhttps://github.com/nodejs/node/pull/51157/commits/3d01dbb5b90870df5c9dca9d4cc8c5d9c58ed98f
3d01dbbhttps://github.com/nodejs/node/pull/51157/commits/3d01dbb5b90870df5c9dca9d4cc8c5d9c58ed98f
nodejs#34605https://github.com/nodejs/node/pull/34605
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/97b58d8ece5b83668acae0c14e3c0e4a25084216..3d01dbb5b90870df5c9dca9d4cc8c5d9c58ed98f
97b58d8https://github.com/nodejs/node/commit/97b58d8ece5b83668acae0c14e3c0e4a25084216
3d01dbbhttps://github.com/nodejs/node/commit/3d01dbb5b90870df5c9dca9d4cc8c5d9c58ed98f
Compare https://github.com/nodejs/node/compare/97b58d8ece5b83668acae0c14e3c0e4a25084216..3d01dbb5b90870df5c9dca9d4cc8c5d9c58ed98f
December 15, 2023 17:57https://github.com/nodejs/node/pull/51157#event-11262237650
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 15, 2023https://github.com/nodejs/node/pull/51157#event-11262239310
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 15, 2023https://github.com/nodejs/node/pull/51157#event-11262297104
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 15, 2023https://github.com/nodejs/node/pull/51157#issuecomment-1858290509
Please reload this pagehttps://github.com/nodejs/node/pull/51157
https://ci.nodejs.org/job/node-test-pull-request/56317/https://ci.nodejs.org/job/node-test-pull-request/56317/
Please reload this pagehttps://github.com/nodejs/node/pull/51157
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 22, 2023 https://github.com/nodejs/node/pull/51157#pullrequestreview-1793837269
View reviewed changes https://github.com/nodejs/node/pull/51157/files/3d01dbb5b90870df5c9dca9d4cc8c5d9c58ed98f
jasnellhttps://github.com/jasnell
Dec 22, 2023 https://github.com/nodejs/node/pull/51157#ref-commit-9c5ef11
https://github.com/joyeecheung
https://github.com/jasnell
module: move the CJS exports cache to internal/modules/cjs/loaderhttps://github.com/nodejs/node/commit/9c5ef11026301d02db541581b6fd64da18ea5b5b
9c5ef11https://github.com/nodejs/node/commit/9c5ef11026301d02db541581b6fd64da18ea5b5b
#34605https://github.com/nodejs/node/pull/34605
#51157https://github.com/nodejs/node/pull/51157
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 22, 2023https://github.com/nodejs/node/pull/51157#issuecomment-1867111987
9c5ef11https://github.com/nodejs/node/commit/9c5ef11026301d02db541581b6fd64da18ea5b5b
Please reload this pagehttps://github.com/nodejs/node/pull/51157
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 22, 2023https://github.com/nodejs/node/pull/51157#event-11321541410
RafaelGSShttps://github.com/RafaelGSS
Jan 2, 2024 https://github.com/nodejs/node/pull/51157#ref-commit-b621ada
https://github.com/joyeecheung
https://github.com/RafaelGSS
module: move the CJS exports cache to internal/modules/cjs/loaderhttps://github.com/nodejs/node/commit/b621ada69aba703a6d432c910cc2e6024755d659
b621adahttps://github.com/nodejs/node/commit/b621ada69aba703a6d432c910cc2e6024755d659
#34605https://github.com/nodejs/node/pull/34605
#51157https://github.com/nodejs/node/pull/51157
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Jan 2, 2024 https://github.com/nodejs/node/pull/51157#ref-pullrequest-2062770813
v21.6.0 proposal #51342 https://github.com/nodejs/node/pull/51342
richardlauhttps://github.com/richardlau
Mar 25, 2024 https://github.com/nodejs/node/pull/51157#ref-commit-d8da197
https://github.com/joyeecheung
https://github.com/richardlau
module: move the CJS exports cache to internal/modules/cjs/loaderhttps://github.com/nodejs/node/commit/d8da197f86dd1c76fa3526a46b30f5ef0ed7780c
d8da197https://github.com/nodejs/node/commit/d8da197f86dd1c76fa3526a46b30f5ef0ed7780c
#34605https://github.com/nodejs/node/pull/34605
#51157https://github.com/nodejs/node/pull/51157
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 25, 2024 https://github.com/nodejs/node/pull/51157#ref-pullrequest-2206634908
v20.12.0 proposal #52212 https://github.com/nodejs/node/pull/52212
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51157
https://github.com/GeoffreyBooth
GeoffreyBooth https://github.com/GeoffreyBooth
https://github.com/nodejs/node/pull/51157/files/f2a3d8e743c229d44fec068a9a9769c210b2567f
https://github.com/ljharb
ljharb https://github.com/ljharb
https://github.com/nodejs/node/pull/51157/files/f2a3d8e743c229d44fec068a9a9769c210b2567f
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/51157/files/3d01dbb5b90870df5c9dca9d4cc8c5d9c58ed98f
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/51157/files/f2a3d8e743c229d44fec068a9a9769c210b2567f
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/51157
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/ljharb
https://github.com/GeoffreyBooth
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.