| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ae6c896f-e270-561f-a1a0-f4c32ba829bd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 83F8:24B4E0:4B79DB:65E67D:6969B12C |
| html-safe-nonce | e2aecbd102cc5c16a797acd451c496a5218944786b8da6625bfe7420dbe1e876 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0Y4OjI0QjRFMDo0Qjc5REI6NjVFNjdEOjY5NjlCMTJDIiwidmlzaXRvcl9pZCI6Ijg3MTM2ODc1ODI0MTIyMjI3NjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 52a90b49d765f9f1b020d310e2b6f93a2ad6159c3348d95041c25ebe74193967 |
| hovercard-subject-tag | pull_request:1638574907 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/51116/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a6b368c074f508fe98e90954b2c006aa9585371994ac55b23d47457a057f5955/nodejs/node/pull/51116 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a6b368c074f508fe98e90954b2c006aa9585371994ac55b23d47457a057f5955/nodejs/node/pull/51116 |
| og:image:alt | As a part of the new signing requirements for Windows, this changes the approach to using the DigiCert cloud HSM service KeyLocker. This change already landed on the main branch in this PR. This is... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | StefanStojanovic |
| hostname | github.com |
| expected-hostname | github.com |
| None | b23b8fcc855cd29bb04d6c94aafa62d336bf44eefa8229444eecc968cad03aee |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0672399d88424758731ec07fe24509e23bb17fb5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/51116#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51116 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51116 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/51116 |
| Reload | https://github.com/nodejs/node/pull/51116 |
| Reload | https://github.com/nodejs/node/pull/51116 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/51116 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/51116 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/51116#issue-comment-box |
| StefanStojanovic | https://github.com/StefanStojanovic |
| nodejs:v20.x-staging | https://github.com/nodejs/node/tree/v20.x-staging |
| JaneaSystems:mefi-new-cert-v20 | https://github.com/JaneaSystems/node/tree/mefi-new-cert-v20 |
|
[v20.x backport] win,tools: upgrade Windows signing to smctl
| https://github.com/nodejs/node/pull/51116#top |
| StefanStojanovic | https://github.com/StefanStojanovic |
| nodejs:v20.x-staging | https://github.com/nodejs/node/tree/v20.x-staging |
| JaneaSystems:mefi-new-cert-v20 | https://github.com/JaneaSystems/node/tree/mefi-new-cert-v20 |
|
Conversation
4
| https://github.com/nodejs/node/pull/51116 |
|
Commits
1
| https://github.com/nodejs/node/pull/51116/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/51116/checks |
|
Files changed
| https://github.com/nodejs/node/pull/51116/files |
| Please reload this page | https://github.com/nodejs/node/pull/51116 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
| Dec 11, 2023 | https://github.com/nodejs/node/pull/51116#issue-2035388829 |
| this PR | https://github.com/nodejs/node/pull/50956 |
| nodejs/build#3491 | https://github.com/nodejs/build/issues/3491 |
| Please reload this page | https://github.com/nodejs/node/pull/51116 |
|
| https://github.com/StefanStojanovic |
| win,tools: upgrade Windows signing to smctl | https://github.com/nodejs/node/pull/51116/commits/bfc9c849d847e0015d92b1d51d1b926a3e9fad67 |
| bfc9c84 | https://github.com/nodejs/node/pull/51116/commits/bfc9c849d847e0015d92b1d51d1b926a3e9fad67 |
| nodejs#50956 | https://github.com/nodejs/node/pull/50956 |
| nodejs/build#3491 | https://github.com/nodejs/build/issues/3491 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
|
v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av20.x |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| Dec 11, 2023 | https://github.com/nodejs/node/pull/51116#event-11208695786 |
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
| Dec 11, 2023 | https://github.com/nodejs/node/pull/51116#event-11209660021 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Dec 11, 2023
| https://github.com/nodejs/node/pull/51116#pullrequestreview-1775116225 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/51116/files/bfc9c849d847e0015d92b1d51d1b926a3e9fad67 |
| richardlau | https://github.com/richardlau |
| https://github.com/nodejs/node/pull/51116#pullrequestreview-1775116225 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| nodejs/build#3491 | https://github.com/nodejs/build/issues/3491 |
| Please reload this page | https://github.com/nodejs/node/pull/51116 |
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
| Dec 11, 2023 | https://github.com/nodejs/node/pull/51116#issuecomment-1850181868 |
| Please reload this page | https://github.com/nodejs/node/pull/51116 |
| https://github.com/UlisesGascon |
| UlisesGascon | https://github.com/UlisesGascon |
| force-pushed | https://github.com/nodejs/node/compare/423c7573778048af06caf45348ca580cafe5b7c4..fd4149d8a419c12ca16eadde24a5904830260847 |
| 423c757 | https://github.com/nodejs/node/commit/423c7573778048af06caf45348ca580cafe5b7c4 |
| fd4149d | https://github.com/nodejs/node/commit/fd4149d8a419c12ca16eadde24a5904830260847 |
|
Compare
| https://github.com/nodejs/node/compare/423c7573778048af06caf45348ca580cafe5b7c4..fd4149d8a419c12ca16eadde24a5904830260847 |
| December 13, 2023 09:09 | https://github.com/nodejs/node/pull/51116#event-11233172681 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Dec 14, 2023
| https://github.com/nodejs/node/pull/51116#ref-pullrequest-2036750657 |
|
v20.11.0 proposal
#51124
| https://github.com/nodejs/node/pull/51124 |
| https://github.com/UlisesGascon |
| UlisesGascon | https://github.com/UlisesGascon |
| force-pushed | https://github.com/nodejs/node/compare/4c9099f762a1908d3afe8c94af2f422ed754c4c5..7af8e20ee8e96b3d1ae90e9d5195dcc828a72418 |
| 4c9099f | https://github.com/nodejs/node/commit/4c9099f762a1908d3afe8c94af2f422ed754c4c5 |
| 7af8e20 | https://github.com/nodejs/node/commit/7af8e20ee8e96b3d1ae90e9d5195dcc828a72418 |
|
Compare
| https://github.com/nodejs/node/compare/4c9099f762a1908d3afe8c94af2f422ed754c4c5..7af8e20ee8e96b3d1ae90e9d5195dcc828a72418 |
| December 20, 2023 15:15 | https://github.com/nodejs/node/pull/51116#event-11303984162 |
| https://github.com/UlisesGascon |
| UlisesGascon | https://github.com/UlisesGascon |
| force-pushed | https://github.com/nodejs/node/compare/a42629c9ec83a5bf345817cc8132d65c30235dcb..435f9c92767534bf60dfc506670feef59e451cbb |
| a42629c | https://github.com/nodejs/node/commit/a42629c9ec83a5bf345817cc8132d65c30235dcb |
| 435f9c9 | https://github.com/nodejs/node/commit/435f9c92767534bf60dfc506670feef59e451cbb |
|
Compare
| https://github.com/nodejs/node/compare/a42629c9ec83a5bf345817cc8132d65c30235dcb..435f9c92767534bf60dfc506670feef59e451cbb |
| January 9, 2024 08:44 | https://github.com/nodejs/node/pull/51116#event-11427088453 |
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
| Jan 16, 2024 | https://github.com/nodejs/node/pull/51116#issuecomment-1893741499 |
| #51124 | https://github.com/nodejs/node/pull/51124 |
| Please reload this page | https://github.com/nodejs/node/pull/51116 |
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
| Jan 16, 2024 | https://github.com/nodejs/node/pull/51116#event-11498911726 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51116 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/51116/files/bfc9c849d847e0015d92b1d51d1b926a3e9fad67 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
|
v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av20.x |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| Please reload this page | https://github.com/nodejs/node/pull/51116 |
|
| https://github.com/StefanStojanovic |
|
| https://github.com/richardlau |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |