René's URL Explorer Experiment


Title: stream: fix timing relative to promises by ronag · Pull Request #51070 · nodejs/node · GitHub

Open Graph Title: stream: fix timing relative to promises by ronag · Pull Request #51070 · nodejs/node

X Title: stream: fix timing relative to promises by ronag · Pull Request #51070 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Workaround for Node "bug". If the stream is destroyed in same tick as it is created, then a user who is waiting for a promise (i.e micro tick) for installing a 'error' listener wi...

X Description: Workaround for Node "bug". If the stream is destroyed in same tick as it is created, then a user who is waiting for a promise (i.e micro tick) for installing a 'error&...

Opengraph URL: https://github.com/nodejs/node/pull/51070

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f607548b-e1c0-7cda-6205-1664ea824d7d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9DF8:1587FA:6D1CA7:919A5D:6AED229F
html-safe-nonce772dedcfd5594e1fe4820603fac9ea169b759410e81231edc15f25ca7db505e6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REY4OjE1ODdGQTo2RDFDQTc6OTE5QTVEOjZBRUQyMjlGIiwidmlzaXRvcl9pZCI6IjE4Mzg3MjQ5MDYyMjAzMzE2NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaceea7ee0a4bf8c3614185ffae84f4808a4017b403accf119079227c5555d797c7
hovercard-subject-tagpull_request:1632359724
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/51070/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c43c69e56618832952b0768f303758ee4115f6f2802e240b84ebab9ce66878f2/nodejs/node/pull/51070
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c43c69e56618832952b0768f303758ee4115f6f2802e240b84ebab9ce66878f2/nodejs/node/pull/51070
og:image:altWorkaround for Node "bug". If the stream is destroyed in same tick as it is created, then a user who is waiting for a promise (i.e micro tick) for installing a 'error' listener wi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/51070#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51070
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51070
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/51070
Reloadhttps://github.com/nodejs/node/pull/51070
Reloadhttps://github.com/nodejs/node/pull/51070
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
ronaghttps://github.com/ronag
nodejs:mainhttps://github.com/nodejs/node/tree/main
nxtedition:stream-timinghttps://github.com/nxtedition/node/tree/stream-timing
Conversationhttps://github.com/nodejs/node/pull/51070
Commits1 (1)https://github.com/nodejs/node/pull/51070/commits
Checkshttps://github.com/nodejs/node/pull/51070/checks
Files changedhttps://github.com/nodejs/node/pull/51070/files
stream: fix timing relative to promiseshttps://github.com/nodejs/node/pull/51070#top
ronaghttps://github.com/ronag
nodejs:mainhttps://github.com/nodejs/node/tree/main
nxtedition:stream-timinghttps://github.com/nxtedition/node/tree/stream-timing
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 6, 2023https://github.com/nodejs/node/pull/51070#issue-2028398275
Please reload this pagehttps://github.com/nodejs/node/pull/51070
nodejs/undici#2497https://github.com/nodejs/undici/pull/2497
Please reload this pagehttps://github.com/nodejs/node/pull/51070
https://github.com/ronag
ronaghttps://github.com/ronag
mcollinahttps://github.com/mcollina
rluvatonhttps://github.com/rluvaton
December 6, 2023 12:07https://github.com/nodejs/node/pull/51070#event-11167377624
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 6, 2023https://github.com/nodejs/node/pull/51070#issuecomment-1842742756
Please reload this pagehttps://github.com/nodejs/node/pull/51070
https://github.com/ronag
ronaghttps://github.com/ronag
ShogunPandahttps://github.com/ShogunPanda
rluvatonhttps://github.com/rluvaton
rluvatonhttps://github.com/rluvaton
December 6, 2023 12:08https://github.com/nodejs/node/pull/51070#event-11167377924
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Dec 6, 2023https://github.com/nodejs/node/pull/51070#event-11167379127
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/32b6db19f4a39d9fec296d944a2d73985243f125..d44bc8d6b4efe21541366bce05392fc3967de774
32b6db1https://github.com/nodejs/node/commit/32b6db19f4a39d9fec296d944a2d73985243f125
d44bc8dhttps://github.com/nodejs/node/commit/d44bc8d6b4efe21541366bce05392fc3967de774
Compare https://github.com/nodejs/node/compare/32b6db19f4a39d9fec296d944a2d73985243f125..d44bc8d6b4efe21541366bce05392fc3967de774
December 6, 2023 12:09https://github.com/nodejs/node/pull/51070#event-11167395529
https://github.com/ronag
ronaghttps://github.com/ronag
December 6, 2023 12:09https://github.com/nodejs/node/pull/51070#event-11167396869
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/d44bc8d6b4efe21541366bce05392fc3967de774..7ed1e1256ad085d90fd8f3fb1fb54b42766a1d12
d44bc8dhttps://github.com/nodejs/node/commit/d44bc8d6b4efe21541366bce05392fc3967de774
7ed1e12https://github.com/nodejs/node/commit/7ed1e1256ad085d90fd8f3fb1fb54b42766a1d12
Compare https://github.com/nodejs/node/compare/d44bc8d6b4efe21541366bce05392fc3967de774..7ed1e1256ad085d90fd8f3fb1fb54b42766a1d12
December 6, 2023 12:10https://github.com/nodejs/node/pull/51070#event-11167401967
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 6, 2023https://github.com/nodejs/node/pull/51070#event-11167403609
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 6, 2023https://github.com/nodejs/node/pull/51070#issuecomment-1842746472
Please reload this pagehttps://github.com/nodejs/node/pull/51070
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 6, 2023 https://github.com/nodejs/node/pull/51070#pullrequestreview-1767396473
View reviewed changes https://github.com/nodejs/node/pull/51070/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/51070#pullrequestreview-1767396473
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/51070
https://github.com/ronag
ronaghttps://github.com/ronag
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 6, 2023https://github.com/nodejs/node/pull/51070#event-11167439062
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/7ed1e1256ad085d90fd8f3fb1fb54b42766a1d12..b3d92c3c267337a94be3ee9e8e6d4b7e72a378fb
7ed1e12https://github.com/nodejs/node/commit/7ed1e1256ad085d90fd8f3fb1fb54b42766a1d12
b3d92c3https://github.com/nodejs/node/commit/b3d92c3c267337a94be3ee9e8e6d4b7e72a378fb
Compare https://github.com/nodejs/node/compare/7ed1e1256ad085d90fd8f3fb1fb54b42766a1d12..b3d92c3c267337a94be3ee9e8e6d4b7e72a378fb
December 6, 2023 12:14https://github.com/nodejs/node/pull/51070#event-11167444729
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 6, 2023https://github.com/nodejs/node/pull/51070#event-11167460505
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 6, 2023https://github.com/nodejs/node/pull/51070#issuecomment-1842753613
https://ci.nodejs.org/job/node-test-pull-request/56129/https://ci.nodejs.org/job/node-test-pull-request/56129/
Please reload this pagehttps://github.com/nodejs/node/pull/51070
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
Dec 6, 2023 https://github.com/nodejs/node/pull/51070#pullrequestreview-1767534288
View reviewed changes https://github.com/nodejs/node/pull/51070/files
ShogunPandahttps://github.com/ShogunPanda
https://github.com/nodejs/node/pull/51070#pullrequestreview-1767534288
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/51070
https://github.com/rluvaton
rluvatonhttps://github.com/rluvaton
Dec 6, 2023 https://github.com/nodejs/node/pull/51070#pullrequestreview-1768029510
View reviewed changes https://github.com/nodejs/node/pull/51070/files
lib/internal/streams/destroy.jshttps://github.com/nodejs/node/pull/51070/files#diff-f9aa56489c061a70f83b602c8a32200b4f092a23b6eb8769f978ac1adb322a46
Please reload this pagehttps://github.com/nodejs/node/pull/51070
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Dec 6, 2023https://github.com/nodejs/node/pull/51070#issuecomment-1843626473
Please reload this pagehttps://github.com/nodejs/node/pull/51070
Please reload this pagehttps://github.com/nodejs/node/pull/51070
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 9, 2023 https://github.com/nodejs/node/pull/51070#pullrequestreview-1773720246
View reviewed changes https://github.com/nodejs/node/pull/51070/files
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Dec 10, 2023 https://github.com/nodejs/node/pull/51070#pullrequestreview-1774087973
View reviewed changes https://github.com/nodejs/node/pull/51070/files
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 10, 2023 https://github.com/nodejs/node/pull/51070#pullrequestreview-1774092654
View reviewed changes https://github.com/nodejs/node/pull/51070/files
lib/internal/streams/destroy.jshttps://github.com/nodejs/node/pull/51070/files#diff-f9aa56489c061a70f83b602c8a32200b4f092a23b6eb8769f978ac1adb322a46
Please reload this pagehttps://github.com/nodejs/node/pull/51070
https://github.com/ronag
ronaghttps://github.com/ronag
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 10, 2023https://github.com/nodejs/node/pull/51070#event-11203629681
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 10, 2023https://github.com/nodejs/node/pull/51070#event-11203638723
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 10, 2023https://github.com/nodejs/node/pull/51070#issuecomment-1849078872
https://ci.nodejs.org/job/node-test-pull-request/56212/https://ci.nodejs.org/job/node-test-pull-request/56212/
Please reload this pagehttps://github.com/nodejs/node/pull/51070
ronaghttps://github.com/ronag
Dec 29, 2023 https://github.com/nodejs/node/pull/51070#ref-commit-da76346
https://github.com/ronag
lib: run microtasks before tickshttps://github.com/nxtedition/node/commit/da76346fbdeb1bf81675144e6fbfdc42eccdc46b
da76346https://github.com/nxtedition/node/commit/da76346fbdeb1bf81675144e6fbfdc42eccdc46b
nodejs#51156https://github.com/nodejs/node/issues/51156
nodejs#51156 (comment)https://github.com/nodejs/node/issues/51156#issuecomment-1864656761
nodejs#51114https://github.com/nodejs/node/pull/51114
nodejs#51070https://github.com/nodejs/node/pull/51070
nodejs#51156https://github.com/nodejs/node/issues/51156
nodejs#51267https://github.com/nodejs/node/pull/51267
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 15, 2024 https://github.com/nodejs/node/pull/51070#ref-pullrequest-2081461201
process: add deferTick #51471 https://github.com/nodejs/node/pull/51471
ronaghttps://github.com/ronag
Jan 16, 2024 https://github.com/nodejs/node/pull/51070#ref-commit-9e07efe
https://github.com/ronag
process: add deferTickhttps://github.com/nxtedition/node/commit/9e07efed0de26fc32e5be14a15f53dabbf3f7c14
9e07efehttps://github.com/nxtedition/node/commit/9e07efed0de26fc32e5be14a15f53dabbf3f7c14
nodejs#51156https://github.com/nodejs/node/issues/51156
nodejs#51280https://github.com/nodejs/node/pull/51280
nodejs#51114https://github.com/nodejs/node/pull/51114
nodejs#51070https://github.com/nodejs/node/pull/51070
nodejs/undici#2497https://github.com/nodejs/undici/pull/2497
nodejs#51471https://github.com/nodejs/node/pull/51471
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 21, 2024 https://github.com/nodejs/node/pull/51070#ref-issue-2146841062
Session Proposal: NodeJS Asynchronous Scheduling openjs-foundation/summit#392 https://github.com/openjs-foundation/summit/issues/392
https://github.com/ronag
ronaghttps://github.com/ronag
Jun 6, 2024https://github.com/nodejs/node/pull/51070#event-13062745974
https://github.com/targos
targoshttps://github.com/targos
lts-watch-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v20.x
Sep 30, 2024https://github.com/nodejs/node/pull/51070#event-14450542754
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51070
https://github.com/rluvaton
rluvaton https://github.com/rluvaton
https://github.com/nodejs/node/pull/51070/files/b3d92c3c267337a94be3ee9e8e6d4b7e72a378fb
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/51070/files/6d85fca859415b51ef968a5eb45cba4c7370f911
https://github.com/ShogunPanda
ShogunPanda https://github.com/ShogunPanda
https://github.com/nodejs/node/pull/51070/files/b3d92c3c267337a94be3ee9e8e6d4b7e72a378fb
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/51070/files/b3d92c3c267337a94be3ee9e8e6d4b7e72a378fb
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/51070/files/b3d92c3c267337a94be3ee9e8e6d4b7e72a378fb
Please reload this pagehttps://github.com/nodejs/node/pull/51070
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/51070
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/Flarna
https://github.com/rluvaton
https://github.com/benjamingr
https://github.com/mcollina
https://github.com/ShogunPanda
https://github.com/jasnell
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.