René's URL Explorer Experiment


Title: net: deferred self.destroy calls in internalConnect(Multiple) to next… by timothyjrogers · Pull Request #51038 · nodejs/node · GitHub

Open Graph Title: net: deferred self.destroy calls in internalConnect(Multiple) to next… by timothyjrogers · Pull Request #51038 · nodejs/node

X Title: net: deferred self.destroy calls in internalConnect(Multiple) to next… by timothyjrogers · Pull Request #51038 · nodejs/node

Description: … tick self.destroy calls in the internalConnect adn internalConnectMultiple functions have a narrow case where they can throw before an error handler has been established. This change defers them to the next tick to allow time for the error handler to be set. Fixes: #48771

Open Graph Description: … tick self.destroy calls in the internalConnect adn internalConnectMultiple functions have a narrow case where they can throw before an error handler has been established. This change defers them ...

X Description: … tick self.destroy calls in the internalConnect adn internalConnectMultiple functions have a narrow case where they can throw before an error handler has been established. This change defers them ...

Opengraph URL: https://github.com/nodejs/node/pull/51038

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:273339c5-16f3-c327-6999-313aabb29f2b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDA56:31D4:4C34DF:6C2F29:6A4CA664
html-safe-nonce9cd1efe8e6f3eb78968033a15203b5f87e03a676764c3f2e0c2e3b439c31837f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTU2OjMxRDQ6NEMzNERGOjZDMkYyOTo2QTRDQTY2NCIsInZpc2l0b3JfaWQiOiI5MTU1NTY4NDg5NDQ3ODU5ODEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca79bb27f41e71836bec053593896d18b5fa3cf51e605628180ae5e628a2eee3a
hovercard-subject-tagpull_request:1627361666
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/51038/files
twitter:imagehttps://avatars.githubusercontent.com/u/1100533?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1100533?s=400&v=4
og:image:alt… tick self.destroy calls in the internalConnect adn internalConnectMultiple functions have a narrow case where they can throw before an error handler has been established. This change defers them ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseae90d426644ca15e89bacceb72e51f4e9dbf85f7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/51038/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51038%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F51038%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/51038/files
Reloadhttps://github.com/nodejs/node/pull/51038/files
Reloadhttps://github.com/nodejs/node/pull/51038/files
Please reload this pagehttps://github.com/nodejs/node/pull/51038/files
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/51038/files
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
timothyjrogershttps://github.com/timothyjrogers
nodejs:mainhttps://github.com/nodejs/node/tree/main
Conversation 5 https://github.com/nodejs/node/pull/51038
Commits 1 https://github.com/nodejs/node/pull/51038/commits
Checks 0 https://github.com/nodejs/node/pull/51038/checks
Files changed https://github.com/nodejs/node/pull/51038/files
Please reload this pagehttps://github.com/nodejs/node/pull/51038/files
net: deferred self.destroy calls in internalConnect(Multiple) to next… https://github.com/nodejs/node/pull/51038/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/51038/files
0d9f934 net: deferred self.destroy calls in internalConnect(Multiple) to next… timothyjrogers Dec 4, 2023 https://github.com/nodejs/node/pull/51038/commits/0d9f93499ad94056c8c2ee668c1c75df3f9ce0e5
Clear filters https://github.com/nodejs/node/pull/51038/files
Please reload this pagehttps://github.com/nodejs/node/pull/51038/files
Please reload this pagehttps://github.com/nodejs/node/pull/51038/files
lib/net.jshttps://github.com/nodejs/node/pull/51038/files#diff-218c57e035f64b18af4db037c96f13014aeb40a1f783d4f52919e2075621da0c
View file https://github.com/nodejs/node/blob/0d9f93499ad94056c8c2ee668c1c75df3f9ce0e5/lib/net.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/51038/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/51038/files#diff-218c57e035f64b18af4db037c96f13014aeb40a1f783d4f52919e2075621da0c
https://github.com/nodejs/node/pull/51038/files#diff-218c57e035f64b18af4db037c96f13014aeb40a1f783d4f52919e2075621da0c
https://github.com/nodejs/node/pull/51038/files#diff-218c57e035f64b18af4db037c96f13014aeb40a1f783d4f52919e2075621da0c
https://github.com/nodejs/node/pull/51038/files#diff-218c57e035f64b18af4db037c96f13014aeb40a1f783d4f52919e2075621da0c
https://github.com/nodejs/node/pull/51038/files#diff-218c57e035f64b18af4db037c96f13014aeb40a1f783d4f52919e2075621da0c
https://github.com/nodejs/node/pull/51038/files#diff-218c57e035f64b18af4db037c96f13014aeb40a1f783d4f52919e2075621da0c
Please reload this pagehttps://github.com/nodejs/node/pull/51038/files
https://github.com/nodejs/node/pull/51038/files#diff-218c57e035f64b18af4db037c96f13014aeb40a1f783d4f52919e2075621da0c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.