René's URL Explorer Experiment


Title: lib: send the `argv` to the ESM worker thread loader by juanarbol · Pull Request #50916 · nodejs/node · GitHub

Open Graph Title: lib: send the `argv` to the ESM worker thread loader by juanarbol · Pull Request #50916 · nodejs/node

X Title: lib: send the `argv` to the ESM worker thread loader by juanarbol · Pull Request #50916 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: When the --conditions is sent to a worker thread, it should affect the worker thread with the ESM loader on it. This patch sends the execArgv to the ESM worker. Fixes: #50885

X Description: When the --conditions is sent to a worker thread, it should affect the worker thread with the ESM loader on it. This patch sends the execArgv to the ESM worker. Fixes: #50885

Opengraph URL: https://github.com/nodejs/node/pull/50916

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:190b290d-6f2a-9bda-64fd-d0ab976499b2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2FC:2373EB:523DCA:6F493D:6A4EBAE6
html-safe-noncec2500385687397cff7f85b26570f61e2b1b30ac884ca124d86da77dedbcc0ce6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkZDOjIzNzNFQjo1MjNEQ0E6NkY0OTNEOjZBNEVCQUU2IiwidmlzaXRvcl9pZCI6Ijc2ODM1MDExMDMzODAzNDc2MjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8783062ac60578a5b40201fc8580ca183826dd4edf99e634c20ae73b4dea70a1
hovercard-subject-tagpull_request:1616777895
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/50916/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9508700da511c43f51c4e7eb4b43dee0d53510f4f8292287164a47d2ab580a73/nodejs/node/pull/50916
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9508700da511c43f51c4e7eb4b43dee0d53510f4f8292287164a47d2ab580a73/nodejs/node/pull/50916
og:image:altWhen the --conditions is sent to a worker thread, it should affect the worker thread with the ESM loader on it. This patch sends the execArgv to the ESM worker. Fixes: #50885
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejuanarbol
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/50916#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50916
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50916
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/50916
Reloadhttps://github.com/nodejs/node/pull/50916
Reloadhttps://github.com/nodejs/node/pull/50916
Please reload this pagehttps://github.com/nodejs/node/pull/50916
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/50916
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
juanarbolhttps://github.com/juanarbol
nodejs:mainhttps://github.com/nodejs/node/tree/main
juanarbol:juan/esm-argvhttps://github.com/juanarbol/node/tree/juan/esm-argv
Conversationhttps://github.com/nodejs/node/pull/50916
Commits1 (1)https://github.com/nodejs/node/pull/50916/commits
Checkshttps://github.com/nodejs/node/pull/50916/checks
Files changedhttps://github.com/nodejs/node/pull/50916/files
lib: send the argv to the ESM worker thread loaderhttps://github.com/nodejs/node/pull/50916#top
juanarbolhttps://github.com/juanarbol
nodejs:mainhttps://github.com/nodejs/node/tree/main
juanarbol:juan/esm-argvhttps://github.com/juanarbol/node/tree/juan/esm-argv
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Nov 26, 2023https://github.com/nodejs/node/pull/50916#issue-2010892419
#50885https://github.com/nodejs/node/issues/50885
Please reload this pagehttps://github.com/nodejs/node/pull/50916
https://github.com/juanarbol
lib: send the argv to the ESM worker thread loaderhttps://github.com/nodejs/node/pull/50916/commits/95155c44af0eb15f8ac2b8f983d7970b99dc61c7
95155c4https://github.com/nodejs/node/pull/50916/commits/95155c44af0eb15f8ac2b8f983d7970b99dc61c7
nodejs#50885https://github.com/nodejs/node/issues/50885
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
himself65https://github.com/himself65
November 26, 2023 04:55https://github.com/nodejs/node/pull/50916#event-11061904356
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Nov 26, 2023https://github.com/nodejs/node/pull/50916#event-11061904365
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 26, 2023https://github.com/nodejs/node/pull/50916#issuecomment-1826535001
Please reload this pagehttps://github.com/nodejs/node/pull/50916
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Nov 26, 2023https://github.com/nodejs/node/pull/50916#event-11061904553
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Nov 26, 2023 https://github.com/nodejs/node/pull/50916#pullrequestreview-1749269386
View reviewed changes https://github.com/nodejs/node/pull/50916/files/95155c44af0eb15f8ac2b8f983d7970b99dc61c7
GeoffreyBoothhttps://github.com/GeoffreyBooth
https://github.com/nodejs/node/pull/50916#pullrequestreview-1749269386
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50916
lib/internal/worker.jshttps://github.com/nodejs/node/pull/50916/files/95155c44af0eb15f8ac2b8f983d7970b99dc61c7#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564
GeoffreyBoothhttps://github.com/GeoffreyBooth
Nov 26, 2023https://github.com/nodejs/node/pull/50916#discussion_r1405332370
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50916
juanarbolhttps://github.com/juanarbol
Nov 26, 2023https://github.com/nodejs/node/pull/50916#discussion_r1405405120
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50916
guybedfordhttps://github.com/guybedford
Nov 29, 2023https://github.com/nodejs/node/pull/50916#discussion_r1408838710
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50916
https://github.com/targos
targoshttps://github.com/targos
Nov 26, 2023https://github.com/nodejs/node/pull/50916#issuecomment-1826700791
Please reload this pagehttps://github.com/nodejs/node/pull/50916
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Nov 26, 2023https://github.com/nodejs/node/pull/50916#issuecomment-1826791431
Please reload this pagehttps://github.com/nodejs/node/pull/50916
https://github.com/targos
targoshttps://github.com/targos
Nov 26, 2023https://github.com/nodejs/node/pull/50916#issuecomment-1826805094
Please reload this pagehttps://github.com/nodejs/node/pull/50916
https://github.com/targos
targoshttps://github.com/targos
Nov 26, 2023https://github.com/nodejs/node/pull/50916#event-11063141182
https://github.com/targos
targoshttps://github.com/targos
Nov 26, 2023https://github.com/nodejs/node/pull/50916#event-11063141274
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Nov 26, 2023https://github.com/nodejs/node/pull/50916#issuecomment-1826824433
Please reload this pagehttps://github.com/nodejs/node/pull/50916
https://github.com/anonrig
anonrighttps://github.com/anonrig
Nov 26, 2023 https://github.com/nodejs/node/pull/50916#pullrequestreview-1749372871
View reviewed changes https://github.com/nodejs/node/pull/50916/files/95155c44af0eb15f8ac2b8f983d7970b99dc61c7
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/50916/files/95155c44af0eb15f8ac2b8f983d7970b99dc61c7#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
anonrighttps://github.com/anonrig
Nov 26, 2023https://github.com/nodejs/node/pull/50916#discussion_r1405430383
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50916
https://github.com/himself65
himself65https://github.com/himself65
Nov 26, 2023 https://github.com/nodejs/node/pull/50916#pullrequestreview-1749374731
View reviewed changes https://github.com/nodejs/node/pull/50916/files/95155c44af0eb15f8ac2b8f983d7970b99dc61c7
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Nov 26, 2023 https://github.com/nodejs/node/pull/50916#pullrequestreview-1749379887
View reviewed changes https://github.com/nodejs/node/pull/50916/files/95155c44af0eb15f8ac2b8f983d7970b99dc61c7
GeoffreyBoothhttps://github.com/GeoffreyBooth
Please reload this pagehttps://github.com/nodejs/node/pull/50916
https://github.com/nodejs/node/pull/50916#pullrequestreview-1749379887
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://nodejs.org/api/worker_threads.html#new-workerfilename-optionshttps://nodejs.org/api/worker_threads.html#new-workerfilename-options
Please reload this pagehttps://github.com/nodejs/node/pull/50916
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Nov 27, 2023https://github.com/nodejs/node/pull/50916#issuecomment-1826981194
Please reload this pagehttps://github.com/nodejs/node/pull/50916
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Nov 27, 2023https://github.com/nodejs/node/pull/50916#event-11064781948
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Nov 27, 2023 https://github.com/nodejs/node/pull/50916#ref-issue-2008750471
--conditions xxx cannot pass into worker_thread #50885 https://github.com/nodejs/node/issues/50885
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Nov 28, 2023https://github.com/nodejs/node/pull/50916#event-11088396762
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Nov 28, 2023https://github.com/nodejs/node/pull/50916#issuecomment-1830670031
Please reload this pagehttps://github.com/nodejs/node/pull/50916
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 29, 2023 https://github.com/nodejs/node/pull/50916#pullrequestreview-1754579347
View reviewed changes https://github.com/nodejs/node/pull/50916/files/95155c44af0eb15f8ac2b8f983d7970b99dc61c7
guybedfordhttps://github.com/guybedford
https://github.com/nodejs/node/pull/50916#pullrequestreview-1754579347
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50916
lib/internal/worker.jshttps://github.com/nodejs/node/pull/50916/files/95155c44af0eb15f8ac2b8f983d7970b99dc61c7#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564
guybedfordhttps://github.com/guybedford
Nov 29, 2023https://github.com/nodejs/node/pull/50916#discussion_r1408838710
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50916
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Dec 1, 2023https://github.com/nodejs/node/pull/50916#issuecomment-1836432813
#50752https://github.com/nodejs/node/pull/50752
#50885 (comment)https://github.com/nodejs/node/issues/50885#issuecomment-1834906555
Please reload this pagehttps://github.com/nodejs/node/pull/50916
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Dec 1, 2023https://github.com/nodejs/node/pull/50916#event-11124304004
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
December 6, 2023 03:27https://github.com/nodejs/node/pull/50916#event-11161872157
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50916
https://github.com/GeoffreyBooth
GeoffreyBooth https://github.com/GeoffreyBooth
https://github.com/nodejs/node/pull/50916/files/95155c44af0eb15f8ac2b8f983d7970b99dc61c7
https://github.com/guybedford
guybedford https://github.com/guybedford
https://github.com/nodejs/node/pull/50916/files/95155c44af0eb15f8ac2b8f983d7970b99dc61c7
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/50916/files/95155c44af0eb15f8ac2b8f983d7970b99dc61c7
https://github.com/himself65
himself65 https://github.com/himself65
https://github.com/nodejs/node/pull/50916/files/95155c44af0eb15f8ac2b8f983d7970b99dc61c7
https://github.com/juanarbol
juanarbol https://github.com/juanarbol
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
--conditions xxx cannot pass into worker_thread https://github.com/nodejs/node/issues/50885
Please reload this pagehttps://github.com/nodejs/node/pull/50916
https://github.com/juanarbol
https://github.com/nodejs-github-bot
https://github.com/targos
https://github.com/GeoffreyBooth
https://github.com/guybedford
https://github.com/anonrig
https://github.com/himself65
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.