René's URL Explorer Experiment


Title: src: assert return value of BN_bn2binpad by tniessen · Pull Request #50860 · nodejs/node · GitHub

Open Graph Title: src: assert return value of BN_bn2binpad by tniessen · Pull Request #50860 · nodejs/node

X Title: src: assert return value of BN_bn2binpad by tniessen · Pull Request #50860 · nodejs/node

Description: Every other invocation of BN_bn2binpad checks the return value. For safety and consistency, do so in RandomPrimeTraits::EncodeOutput() as well.

Open Graph Description: Every other invocation of BN_bn2binpad checks the return value. For safety and consistency, do so in RandomPrimeTraits::EncodeOutput() as well.

X Description: Every other invocation of BN_bn2binpad checks the return value. For safety and consistency, do so in RandomPrimeTraits::EncodeOutput() as well.

Opengraph URL: https://github.com/nodejs/node/pull/50860

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8128a246-a1c2-4015-3fb6-3870818e62eb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD8D0:2D2FEF:13A684F:1A5D350:69699D18
html-safe-nonce931e765cb6b572e0b6319ad650e7d33fe18cb7c485bd1f88ea79d93f6f3f3fe1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEQwOjJEMkZFRjoxM0E2ODRGOjFBNUQzNTA6Njk2OTlEMTgiLCJ2aXNpdG9yX2lkIjoiNTMxNDk5NDU3NzEzNzU3MzE0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac59189d2a8ec36929a910fc73ecd7a67c3444c227f93cd2480be70eb3e71ed9c5
hovercard-subject-tagpull_request:1613689540
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/50860/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f61e1760fdfc134e09e39bf0c3f24296614a0a570d765c5b829fefc467ab19c8/nodejs/node/pull/50860
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f61e1760fdfc134e09e39bf0c3f24296614a0a570d765c5b829fefc467ab19c8/nodejs/node/pull/50860
og:image:altEvery other invocation of BN_bn2binpad checks the return value. For safety and consistency, do so in RandomPrimeTraits::EncodeOutput() as well.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release124667f43168afb6c9c03b7c02eb5b1d2e1be3d9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/50860#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50860
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50860
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/50860
Reloadhttps://github.com/nodejs/node/pull/50860
Reloadhttps://github.com/nodejs/node/pull/50860
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/50860
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/50860
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/50860#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:src-crypto-random-bn2binpad-rethttps://github.com/tniessen/node/tree/src-crypto-random-bn2binpad-ret
src: assert return value of BN_bn2binpad https://github.com/nodejs/node/pull/50860#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:src-crypto-random-bn2binpad-rethttps://github.com/tniessen/node/tree/src-crypto-random-bn2binpad-ret
Conversation 6 https://github.com/nodejs/node/pull/50860
Commits 1 https://github.com/nodejs/node/pull/50860/commits
Checks 0 https://github.com/nodejs/node/pull/50860/checks
Files changed https://github.com/nodejs/node/pull/50860/files
Please reload this pagehttps://github.com/nodejs/node/pull/50860
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Nov 23, 2023https://github.com/nodejs/node/pull/50860#issue-2007332367
Please reload this pagehttps://github.com/nodejs/node/pull/50860
https://github.com/tniessen
src: assert return value of BN_bn2binpadhttps://github.com/nodejs/node/pull/50860/commits/a9ed26081c4388271d2f7969d5e376c1d5e61052
a9ed260https://github.com/nodejs/node/pull/50860/commits/a9ed26081c4388271d2f7969d5e376c1d5e61052
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 23, 2023https://github.com/nodejs/node/pull/50860#issuecomment-1823713666
Please reload this pagehttps://github.com/nodejs/node/pull/50860
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Nov 23, 2023https://github.com/nodejs/node/pull/50860#event-11042399132
https://github.com/panva
panvahttps://github.com/panva
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 23, 2023https://github.com/nodejs/node/pull/50860#event-11046685640
https://github.com/panva
panvahttps://github.com/panva
Nov 23, 2023 https://github.com/nodejs/node/pull/50860#pullrequestreview-1746278146
View reviewed changes https://github.com/nodejs/node/pull/50860/files/a9ed26081c4388271d2f7969d5e376c1d5e61052
https://github.com/panva
panvahttps://github.com/panva
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 23, 2023https://github.com/nodejs/node/pull/50860#event-11046689135
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 23, 2023https://github.com/nodejs/node/pull/50860#event-11046741823
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50860
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50860
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 23, 2023 https://github.com/nodejs/node/pull/50860#pullrequestreview-1746950028
View reviewed changes https://github.com/nodejs/node/pull/50860/files/a9ed26081c4388271d2f7969d5e376c1d5e61052
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50860
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 24, 2023https://github.com/nodejs/node/pull/50860#issuecomment-1825848022
https://ci.nodejs.org/job/node-test-pull-request/55899/https://ci.nodejs.org/job/node-test-pull-request/55899/
Please reload this pagehttps://github.com/nodejs/node/pull/50860
https://github.com/lpinca
lpincahttps://github.com/lpinca
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 25, 2023https://github.com/nodejs/node/pull/50860#event-11061367889
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 25, 2023https://github.com/nodejs/node/pull/50860#event-11061372893
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
ed5cb37https://github.com/nodejs/node/commit/ed5cb37ccbc44e2310286db309edc521d8deb91d
Nov 25, 2023https://github.com/nodejs/node/pull/50860#event-11061372979
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 25, 2023https://github.com/nodejs/node/pull/50860#issuecomment-1826408892
ed5cb37https://github.com/nodejs/node/commit/ed5cb37ccbc44e2310286db309edc521d8deb91d
Please reload this pagehttps://github.com/nodejs/node/pull/50860
martenrichterhttps://github.com/martenrichter
Nov 26, 2023 https://github.com/nodejs/node/pull/50860#ref-commit-030bccc
https://github.com/tniessen
https://github.com/martenrichter
src: assert return value of BN_bn2binpadhttps://github.com/martenrichter/node/commit/030bccc570e56d8d371d1b9931ab982159c7fd6c
030bccchttps://github.com/martenrichter/node/commit/030bccc570e56d8d371d1b9931ab982159c7fd6c
nodejs#50860https://github.com/nodejs/node/pull/50860
lucshihttps://github.com/lucshi
Nov 27, 2023 https://github.com/nodejs/node/pull/50860#ref-commit-a24623e
https://github.com/tniessen
src: assert return value of BN_bn2binpadhttps://github.com/lucshi/node/commit/a24623e4bb5c476237a21d8e9c5ac726b9583baf
a24623ehttps://github.com/lucshi/node/commit/a24623e4bb5c476237a21d8e9c5ac726b9583baf
nodejs#50860https://github.com/nodejs/node/pull/50860
RafaelGSShttps://github.com/RafaelGSS
Nov 27, 2023 https://github.com/nodejs/node/pull/50860#ref-commit-9bbc300
https://github.com/tniessen
https://github.com/RafaelGSS
src: assert return value of BN_bn2binpadhttps://github.com/nodejs/node/commit/9bbc30037291b8378d140409757f6280e8a4e62e
9bbc300https://github.com/nodejs/node/commit/9bbc30037291b8378d140409757f6280e8a4e62e
#50860https://github.com/nodejs/node/pull/50860
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 28, 2023 https://github.com/nodejs/node/pull/50860#ref-pullrequest-2014290477
v21.3.0 proposal #50954 https://github.com/nodejs/node/pull/50954
RafaelGSShttps://github.com/RafaelGSS
Nov 29, 2023 https://github.com/nodejs/node/pull/50860#ref-commit-feb8ff9
https://github.com/tniessen
https://github.com/RafaelGSS
src: assert return value of BN_bn2binpadhttps://github.com/nodejs/node/commit/feb8ff94272dcc9ad503792a37a05a2f36849365
feb8ff9https://github.com/nodejs/node/commit/feb8ff94272dcc9ad503792a37a05a2f36849365
#50860https://github.com/nodejs/node/pull/50860
RafaelGSShttps://github.com/RafaelGSS
Nov 30, 2023 https://github.com/nodejs/node/pull/50860#ref-commit-13c9b09
https://github.com/tniessen
https://github.com/RafaelGSS
src: assert return value of BN_bn2binpadhttps://github.com/nodejs/node/commit/13c9b094cbd94f20559bcbc9af1116abf189e719
13c9b09https://github.com/nodejs/node/commit/13c9b094cbd94f20559bcbc9af1116abf189e719
#50860https://github.com/nodejs/node/pull/50860
UlisesGasconhttps://github.com/UlisesGascon
Dec 11, 2023 https://github.com/nodejs/node/pull/50860#ref-commit-4c079f5
https://github.com/tniessen
https://github.com/UlisesGascon
src: assert return value of BN_bn2binpadhttps://github.com/nodejs/node/commit/4c079f5f066f42c0b02329c196f26d32f2145e04
4c079f5https://github.com/nodejs/node/commit/4c079f5f066f42c0b02329c196f26d32f2145e04
#50860https://github.com/nodejs/node/pull/50860
https://github.com/UlisesGascon
UlisesGasconhttps://github.com/UlisesGascon
Dec 12, 2023 https://github.com/nodejs/node/pull/50860#ref-pullrequest-2036750657
v20.11.0 proposal #51124 https://github.com/nodejs/node/pull/51124
UlisesGasconhttps://github.com/UlisesGascon
Dec 13, 2023 https://github.com/nodejs/node/pull/50860#ref-commit-8811eca
https://github.com/tniessen
https://github.com/UlisesGascon
src: assert return value of BN_bn2binpadhttps://github.com/nodejs/node/commit/8811eca25d341f080f0fbcb1c42f1fb7d902b253
8811ecahttps://github.com/nodejs/node/commit/8811eca25d341f080f0fbcb1c42f1fb7d902b253
#50860https://github.com/nodejs/node/pull/50860
UlisesGasconhttps://github.com/UlisesGascon
Dec 15, 2023 https://github.com/nodejs/node/pull/50860#ref-commit-8109ff5
https://github.com/tniessen
https://github.com/UlisesGascon
src: assert return value of BN_bn2binpadhttps://github.com/nodejs/node/commit/8109ff589edfcf05da5d716e35c6c5e88006ee20
8109ff5https://github.com/nodejs/node/commit/8109ff589edfcf05da5d716e35c6c5e88006ee20
#50860https://github.com/nodejs/node/pull/50860
UlisesGasconhttps://github.com/UlisesGascon
Dec 19, 2023 https://github.com/nodejs/node/pull/50860#ref-commit-07a4e94
https://github.com/tniessen
https://github.com/UlisesGascon
src: assert return value of BN_bn2binpadhttps://github.com/nodejs/node/commit/07a4e94e8488979c942769874b6325542388a7fb
07a4e94https://github.com/nodejs/node/commit/07a4e94e8488979c942769874b6325542388a7fb
#50860https://github.com/nodejs/node/pull/50860
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50860
https://github.com/panva
panva https://github.com/panva
https://github.com/nodejs/node/pull/50860/files/a9ed26081c4388271d2f7969d5e376c1d5e61052
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/50860/files/a9ed26081c4388271d2f7969d5e376c1d5e61052
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/50860
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/panva
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.