| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b855d7fe-f708-1552-045c-2902789c0592 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8166:333370:655875:8BACD4:696A1E2D |
| html-safe-nonce | 5878be19efb34364108c0686835c11104782baa5dc33e0de5d301c2ea4bdcb02 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTY2OjMzMzM3MDo2NTU4NzU6OEJBQ0Q0OjY5NkExRTJEIiwidmlzaXRvcl9pZCI6IjQ4MzEyMzUzMDM3MzQzODYyMjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 39b808f73769dd9aacbc5fe3e2509c9d23058f107a85efef3a36ad4da3c8a93a |
| hovercard-subject-tag | pull_request:1609455264 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/50825/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/79d10e0de6079e3b688505a0a1414c180e5612239b6cbfab5f4a85c0251965a6/nodejs/node/pull/50825 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/79d10e0de6079e3b688505a0a1414c180e5612239b6cbfab5f4a85c0251965a6/nodejs/node/pull/50825 |
| og:image:alt | When using the Modules Customization Hooks API to load CommonJS modules, we want to support the returned value of defaultLoad which must be nullish to preserve backward compatibility. This can be a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | aduh95 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d515f6f09fa57a93bf90355cb894eb84ca4f458f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/50825#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50825 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50825 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/50825 |
| Reload | https://github.com/nodejs/node/pull/50825 |
| Reload | https://github.com/nodejs/node/pull/50825 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/50825#issue-comment-box |
| aduh95 | https://github.com/aduh95 |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| aduh95:cjs-nullish-source | https://github.com/aduh95/node/tree/cjs-nullish-source |
|
esm: fallback to readFileSync when source is nullish
| https://github.com/nodejs/node/pull/50825#top |
| aduh95 | https://github.com/aduh95 |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| aduh95:cjs-nullish-source | https://github.com/aduh95/node/tree/cjs-nullish-source |
|
Conversation
20
| https://github.com/nodejs/node/pull/50825 |
|
Commits
5
| https://github.com/nodejs/node/pull/50825/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/50825/checks |
|
Files changed
| https://github.com/nodejs/node/pull/50825/files |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Nov 20, 2023 | https://github.com/nodejs/node/pull/50825#issue-2002591227 |
| #50435 | https://github.com/nodejs/node/issues/50435 |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 20, 2023 | https://github.com/nodejs/node/pull/50825#issuecomment-1819421046 |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Nov 20, 2023 | https://github.com/nodejs/node/pull/50825#event-11014227290 |
|
| https://github.com/aduh95 |
| esm: fallback to getSource when load returns nullish source | https://github.com/nodejs/node/pull/50825/commits/e1f1a800eb15635d0a6a5fe198d628f38bbcf693 |
| e1f1a80 | https://github.com/nodejs/node/pull/50825/commits/e1f1a800eb15635d0a6a5fe198d628f38bbcf693 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| force-pushed | https://github.com/nodejs/node/compare/594830d60f8ffb7da09fe7a999f091aa5f220dc4..e1f1a800eb15635d0a6a5fe198d628f38bbcf693 |
| 594830d | https://github.com/nodejs/node/commit/594830d60f8ffb7da09fe7a999f091aa5f220dc4 |
| e1f1a80 | https://github.com/nodejs/node/commit/e1f1a800eb15635d0a6a5fe198d628f38bbcf693 |
|
Compare
| https://github.com/nodejs/node/compare/594830d60f8ffb7da09fe7a999f091aa5f220dc4..e1f1a800eb15635d0a6a5fe198d628f38bbcf693 |
| November 20, 2023 16:48 | https://github.com/nodejs/node/pull/50825#event-11014371777 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
Nov 20, 2023
| https://github.com/nodejs/node/pull/50825#pullrequestreview-1740433118 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50825/files/e1f1a800eb15635d0a6a5fe198d628f38bbcf693 |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| https://github.com/nodejs/node/pull/50825#pullrequestreview-1740433118 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Nov 20, 2023 | https://github.com/nodejs/node/pull/50825#issuecomment-1819633259 |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 20, 2023 | https://github.com/nodejs/node/pull/50825#event-11015560102 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 20, 2023 | https://github.com/nodejs/node/pull/50825#event-11015576129 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 20, 2023 | https://github.com/nodejs/node/pull/50825#issuecomment-1819636714 |
| https://ci.nodejs.org/job/node-test-pull-request/55794/ | https://ci.nodejs.org/job/node-test-pull-request/55794/ |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Nov 21, 2023
| https://github.com/nodejs/node/pull/50825#ref-issue-2004375014 |
|
esmocha broken by ESM hook changes?
nodejs/citgm#1029
| https://github.com/nodejs/citgm/issues/1029 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Nov 21, 2023 | https://github.com/nodejs/node/pull/50825#issuecomment-1821031292 |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| nodejs/citgm#1029 | https://github.com/nodejs/citgm/issues/1029 |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3347/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3347/ |
| https://ci.nodejs.org/job/citgm-smoker/nodes=fedora-latest-x64/3347/ | https://ci.nodejs.org/job/citgm-smoker/nodes=fedora-latest-x64/3347/ |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Nov 21, 2023
| https://github.com/nodejs/node/pull/50825#pullrequestreview-1742215376 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50825/files/e1f1a800eb15635d0a6a5fe198d628f38bbcf693 |
| lib/internal/modules/esm/translators.js | https://github.com/nodejs/node/pull/50825/files/e1f1a800eb15635d0a6a5fe198d628f38bbcf693#diff-b1de5e9ce1e9b411001c63d11a5092dbba32e1586269a20dc11408375eb2f16c |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Nov 21, 2023
| https://github.com/nodejs/node/pull/50825#pullrequestreview-1742217519 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50825/files/e1f1a800eb15635d0a6a5fe198d628f38bbcf693 |
| lib/internal/modules/esm/translators.js | https://github.com/nodejs/node/pull/50825/files/e1f1a800eb15635d0a6a5fe198d628f38bbcf693#diff-b1de5e9ce1e9b411001c63d11a5092dbba32e1586269a20dc11408375eb2f16c |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
|
| https://github.com/aduh95 |
| fixup! esm: fallback to getSource when load returns nullish source | https://github.com/nodejs/node/pull/50825/commits/11c610a4827f1aaa4d3d97124dec5b542f21d4de |
| 11c610a | https://github.com/nodejs/node/pull/50825/commits/11c610a4827f1aaa4d3d97124dec5b542f21d4de |
| https://github.com/merceyz |
| merceyz | https://github.com/merceyz |
| Nov 21, 2023 | https://github.com/nodejs/node/pull/50825#issuecomment-1821597930 |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| https://ci.nodejs.org/job/citgm-smoker/nodes=fedora-latest-x64/3347/ | https://ci.nodejs.org/job/citgm-smoker/nodes=fedora-latest-x64/3347/ |
| @targos | https://github.com/targos |
| nodejs/citgm#1022 | https://github.com/nodejs/citgm/pull/1022 |
| nodejs/citgm#1022 | https://github.com/nodejs/citgm/pull/1022 |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 23, 2023 | https://github.com/nodejs/node/pull/50825#event-11050180912 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 23, 2023 | https://github.com/nodejs/node/pull/50825#event-11050223766 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 23, 2023 | https://github.com/nodejs/node/pull/50825#issuecomment-1824800721 |
| https://ci.nodejs.org/job/node-test-pull-request/55882/ | https://ci.nodejs.org/job/node-test-pull-request/55882/ |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Nov 25, 2023
| https://github.com/nodejs/node/pull/50825#pullrequestreview-1749227633 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50825/files/11c610a4827f1aaa4d3d97124dec5b542f21d4de |
| test/es-module/test-esm-loader-hooks.mjs | https://github.com/nodejs/node/pull/50825/files/11c610a4827f1aaa4d3d97124dec5b542f21d4de#diff-82a900b610fadd4d760c0af4f8707a3477aa9e28ebe03bfcbb2fcc0cd51947cf |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Nov 25, 2023
| https://github.com/nodejs/node/pull/50825#pullrequestreview-1749227660 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50825/files/11c610a4827f1aaa4d3d97124dec5b542f21d4de |
| test/es-module/test-esm-loader-hooks.mjs | https://github.com/nodejs/node/pull/50825/files/11c610a4827f1aaa4d3d97124dec5b542f21d4de#diff-82a900b610fadd4d760c0af4f8707a3477aa9e28ebe03bfcbb2fcc0cd51947cf |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
|
| https://github.com/aduh95 |
| Apply suggestions from code review | https://github.com/nodejs/node/pull/50825/commits/b58772c02d0774fd2bda7802f7a4a0123b6e258f |
| b58772c | https://github.com/nodejs/node/pull/50825/commits/b58772c02d0774fd2bda7802f7a4a0123b6e258f |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 25, 2023 | https://github.com/nodejs/node/pull/50825#issuecomment-1826399400 |
| https://ci.nodejs.org/job/node-test-pull-request/55919/ | https://ci.nodejs.org/job/node-test-pull-request/55919/ |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
Nov 27, 2023
| https://github.com/nodejs/node/pull/50825#pullrequestreview-1751271273 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50825/files/b58772c02d0774fd2bda7802f7a4a0123b6e258f |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| https://github.com/nodejs/node/pull/50825#pullrequestreview-1751271273 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
|
| https://github.com/aduh95 |
| remove weird condition | https://github.com/nodejs/node/pull/50825/commits/a359b028c2c62ead72359550d0089d19b31d7ab4 |
| a359b02 | https://github.com/nodejs/node/pull/50825/commits/a359b028c2c62ead72359550d0089d19b31d7ab4 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 27, 2023 | https://github.com/nodejs/node/pull/50825#issuecomment-1828701188 |
| https://ci.nodejs.org/job/node-test-pull-request/55961/ | https://ci.nodejs.org/job/node-test-pull-request/55961/ |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
|
| https://github.com/aduh95 |
| fixup! remove weird condition | https://github.com/nodejs/node/pull/50825/commits/3cde424ad9b5e4b7332f13a0c1934fb64f2687d2 |
| 3cde424 | https://github.com/nodejs/node/pull/50825/commits/3cde424ad9b5e4b7332f13a0c1934fb64f2687d2 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 28, 2023 | https://github.com/nodejs/node/pull/50825#issuecomment-1829885959 |
| https://ci.nodejs.org/job/node-test-pull-request/55976/ | https://ci.nodejs.org/job/node-test-pull-request/55976/ |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 28, 2023 | https://github.com/nodejs/node/pull/50825#issuecomment-1830865902 |
| https://ci.nodejs.org/job/node-test-pull-request/55986/ | https://ci.nodejs.org/job/node-test-pull-request/55986/ |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| 4eafcf8 | https://github.com/nodejs/node/commit/4eafcf8ff556c2518a216efbce014d62ff7ba091 |
| Nov 29, 2023 | https://github.com/nodejs/node/pull/50825#event-11093573143 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Nov 29, 2023 | https://github.com/nodejs/node/pull/50825#issuecomment-1831501811 |
| 4eafcf8 | https://github.com/nodejs/node/commit/4eafcf8ff556c2518a216efbce014d62ff7ba091 |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| November 29, 2023 09:12 | https://github.com/nodejs/node/pull/50825#event-11093576272 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Nov 29, 2023
| https://github.com/nodejs/node/pull/50825#ref-commit-50f336c |
|
| https://github.com/aduh95 |
|
| https://github.com/RafaelGSS |
| esm: fallback to getSource when load returns nullish source | https://github.com/nodejs/node/commit/50f336c06f981cd13f94e29e9967d0c56db1b3af |
| 50f336c | https://github.com/nodejs/node/commit/50f336c06f981cd13f94e29e9967d0c56db1b3af |
| #50825 | https://github.com/nodejs/node/pull/50825 |
| #50435 | https://github.com/nodejs/node/issues/50435 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
Nov 29, 2023
| https://github.com/nodejs/node/pull/50825#ref-pullrequest-2014290477 |
|
v21.3.0 proposal
#50954
| https://github.com/nodejs/node/pull/50954 |
| https://github.com/lizthegrey |
| lizthegrey | https://github.com/lizthegrey |
| Dec 8, 2023 | https://github.com/nodejs/node/pull/50825#issuecomment-1846302191 |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| UlisesGascon | https://github.com/UlisesGascon |
|
Dec 11, 2023
| https://github.com/nodejs/node/pull/50825#ref-commit-8df32ab |
|
| https://github.com/aduh95 |
|
| https://github.com/UlisesGascon |
| esm: fallback to getSource when load returns nullish source | https://github.com/nodejs/node/commit/8df32ab1d88a26d0dbfb33fcc6cc76eca60f6eb0 |
| 8df32ab | https://github.com/nodejs/node/commit/8df32ab1d88a26d0dbfb33fcc6cc76eca60f6eb0 |
| #50825 | https://github.com/nodejs/node/pull/50825 |
| #50435 | https://github.com/nodejs/node/issues/50435 |
| https://github.com/UlisesGascon |
| UlisesGascon | https://github.com/UlisesGascon |
|
Dec 12, 2023
| https://github.com/nodejs/node/pull/50825#ref-pullrequest-2036750657 |
|
v20.11.0 proposal
#51124
| https://github.com/nodejs/node/pull/51124 |
| UlisesGascon | https://github.com/UlisesGascon |
|
Dec 13, 2023
| https://github.com/nodejs/node/pull/50825#ref-commit-fbdf291 |
|
| https://github.com/aduh95 |
|
| https://github.com/UlisesGascon |
| esm: fallback to getSource when load returns nullish source | https://github.com/nodejs/node/commit/fbdf291bb9b375275903f121d4ddc6fb38afb616 |
| fbdf291 | https://github.com/nodejs/node/commit/fbdf291bb9b375275903f121d4ddc6fb38afb616 |
| #50825 | https://github.com/nodejs/node/pull/50825 |
| #50435 | https://github.com/nodejs/node/issues/50435 |
| https://github.com/lizthegrey |
| lizthegrey | https://github.com/lizthegrey |
| Dec 14, 2023 | https://github.com/nodejs/node/pull/50825#issuecomment-1855254943 |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
| UlisesGascon | https://github.com/UlisesGascon |
|
Dec 15, 2023
| https://github.com/nodejs/node/pull/50825#ref-commit-06cee79 |
|
| https://github.com/aduh95 |
|
| https://github.com/UlisesGascon |
| esm: fallback to getSource when load returns nullish source | https://github.com/nodejs/node/commit/06cee79aeef7b219e350bc10bef4f2a140339674 |
| 06cee79 | https://github.com/nodejs/node/commit/06cee79aeef7b219e350bc10bef4f2a140339674 |
| #50825 | https://github.com/nodejs/node/pull/50825 |
| #50435 | https://github.com/nodejs/node/issues/50435 |
| UlisesGascon | https://github.com/UlisesGascon |
|
Dec 19, 2023
| https://github.com/nodejs/node/pull/50825#ref-commit-843d5f8 |
|
| https://github.com/aduh95 |
|
| https://github.com/UlisesGascon |
| esm: fallback to getSource when load returns nullish source | https://github.com/nodejs/node/commit/843d5f84ca0c34d4cc59194fc1284a2c631ead97 |
| 843d5f8 | https://github.com/nodejs/node/commit/843d5f84ca0c34d4cc59194fc1284a2c631ead97 |
| #50825 | https://github.com/nodejs/node/pull/50825 |
| #50435 | https://github.com/nodejs/node/issues/50435 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
lts-watch-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v18.x |
| Dec 24, 2023 | https://github.com/nodejs/node/pull/50825#event-11332348745 |
| codebytere | https://github.com/codebytere |
|
Jan 10, 2024
| https://github.com/nodejs/node/pull/50825#ref-commit-d21d3d0 |
|
| https://github.com/codebytere |
| esm: fallback to readFileSync when source is nullish | https://github.com/electron/electron/commit/d21d3d0d180eae199b887840eba3c79cdee8f3eb |
| d21d3d0 | https://github.com/electron/electron/commit/d21d3d0d180eae199b887840eba3c79cdee8f3eb |
| nodejs/node#50825 | https://github.com/nodejs/node/pull/50825 |
| zcbenz | https://github.com/zcbenz |
|
Jan 12, 2024
| https://github.com/nodejs/node/pull/50825#ref-commit-acb8b30 |
|
| https://github.com/codebytere |
|
| https://github.com/zcbenz |
| esm: fallback to readFileSync when source is nullish | https://github.com/electron/electron/commit/acb8b3051916d3b503e296dceca99317f6a6c4e2 |
| acb8b30 | https://github.com/electron/electron/commit/acb8b3051916d3b503e296dceca99317f6a6c4e2 |
| nodejs/node#50825 | https://github.com/nodejs/node/pull/50825 |
| zcbenz | https://github.com/zcbenz |
|
Jan 12, 2024
| https://github.com/nodejs/node/pull/50825#ref-commit-3b334f8 |
|
| https://github.com/codebytere |
|
| https://github.com/zcbenz |
| esm: fallback to readFileSync when source is nullish | https://github.com/electron/electron/commit/3b334f8ce574de36ba94622a08d3e70a6fcd4a99 |
| 3b334f8 | https://github.com/electron/electron/commit/3b334f8ce574de36ba94622a08d3e70a6fcd4a99 |
| nodejs/node#50825 | https://github.com/nodejs/node/pull/50825 |
| codebytere | https://github.com/codebytere |
|
Jan 15, 2024
| https://github.com/nodejs/node/pull/50825#ref-commit-38c94c5 |
|
| https://github.com/codebytere |
| esm: fallback to readFileSync when source is nullish | https://github.com/electron/electron/commit/38c94c53924477678e0dc1f47cf5eb3771dee70d |
| 38c94c5 | https://github.com/electron/electron/commit/38c94c53924477678e0dc1f47cf5eb3771dee70d |
| nodejs/node#50825 | https://github.com/nodejs/node/pull/50825 |
| codebytere | https://github.com/codebytere |
|
Jan 15, 2024
| https://github.com/nodejs/node/pull/50825#ref-commit-7928388 |
|
| https://github.com/codebytere |
| esm: fallback to readFileSync when source is nullish | https://github.com/electron/electron/commit/79283889901e46ba1ca3b47dafb2b4e7e10dbdb7 |
| 7928388 | https://github.com/electron/electron/commit/79283889901e46ba1ca3b47dafb2b4e7e10dbdb7 |
| nodejs/node#50825 | https://github.com/nodejs/node/pull/50825 |
| codebytere | https://github.com/codebytere |
|
Jan 16, 2024
| https://github.com/nodejs/node/pull/50825#ref-commit-0c5dbcb |
|
| https://github.com/codebytere |
| esm: fallback to readFileSync when source is nullish | https://github.com/electron/electron/commit/0c5dbcbab406b4dc4b060873cc220346579d7415 |
| 0c5dbcb | https://github.com/electron/electron/commit/0c5dbcbab406b4dc4b060873cc220346579d7415 |
| nodejs/node#50825 | https://github.com/nodejs/node/pull/50825 |
| codebytere | https://github.com/codebytere |
|
Jan 18, 2024
| https://github.com/nodejs/node/pull/50825#ref-commit-67152ba |
|
| https://github.com/codebytere |
| esm: fallback to readFileSync when source is nullish | https://github.com/electron/electron/commit/67152bae7bd28dacf2f64f9e51bf1033bb738658 |
| 67152ba | https://github.com/electron/electron/commit/67152bae7bd28dacf2f64f9e51bf1033bb738658 |
| nodejs/node#50825 | https://github.com/nodejs/node/pull/50825 |
| jkleinsc | https://github.com/jkleinsc |
|
Jan 18, 2024
| https://github.com/nodejs/node/pull/50825#ref-commit-1f2d223 |
|
| https://github.com/codebytere |
|
| https://github.com/jkleinsc |
| esm: fallback to readFileSync when source is nullish | https://github.com/electron/electron/commit/1f2d2234bda808f0a04d50e76dc400766e072976 |
| 1f2d223 | https://github.com/electron/electron/commit/1f2d2234bda808f0a04d50e76dc400766e072976 |
| nodejs/node#50825 | https://github.com/nodejs/node/pull/50825 |
| codebytere | https://github.com/codebytere |
|
Jan 18, 2024
| https://github.com/nodejs/node/pull/50825#ref-commit-e604a2d |
|
| https://github.com/codebytere |
| esm: fallback to readFileSync when source is nullish | https://github.com/electron/electron/commit/e604a2d6d73126e542710452917afb5f39910291 |
| e604a2d | https://github.com/electron/electron/commit/e604a2d6d73126e542710452917afb5f39910291 |
| nodejs/node#50825 | https://github.com/nodejs/node/pull/50825 |
| jkleinsc | https://github.com/jkleinsc |
|
Jan 18, 2024
| https://github.com/nodejs/node/pull/50825#ref-commit-f4ee3c1 |
|
| https://github.com/apps/electron-roller |
|
| https://github.com/codebytere |
|
| https://github.com/zcbenz |
| chore: bump node to v20.11.0 (main) ( | https://github.com/electron/electron/commit/f4ee3c1b2a4a2c0ae69140a04cc76d0ffbaab320 |
| #40941 | https://github.com/electron/electron/pull/40941 |
| ) | https://github.com/electron/electron/commit/f4ee3c1b2a4a2c0ae69140a04cc76d0ffbaab320 |
| f4ee3c1 | https://github.com/electron/electron/commit/f4ee3c1b2a4a2c0ae69140a04cc76d0ffbaab320 |
| nodejs/node#48655 | https://github.com/nodejs/node/pull/48655 |
| nodejs/node#50158 | https://github.com/nodejs/node/pull/50158 |
| nodejs/node#50820 | https://github.com/nodejs/node/pull/50820 |
| nodejs/node#50465 | https://github.com/nodejs/node/pull/50465 |
| nodejs/node#50825 | https://github.com/nodejs/node/pull/50825 |
| nodejs/node#50360 | https://github.com/nodejs/node/pull/50360 |
| nodejs/node#50327 | https://github.com/nodejs/node/pull/50327 |
| nodejs/node#50465 | https://github.com/nodejs/node/pull/50465 |
| nodejs/node#50634 | https://github.com/nodejs/node/pull/50634 |
| nodejs/node#50709 | https://github.com/nodejs/node/pull/50709 |
| nodejs/node#50629 | https://github.com/nodejs/node/pull/50629 |
| nodejs/node#50663 | https://github.com/nodejs/node/pull/50663 |
| nodejs/node#50709 | https://github.com/nodejs/node/pull/50709 |
| nodejs/node#50186 | https://github.com/nodejs/node/pull/50186 |
| nodejs/node#51239 | https://github.com/nodejs/node/pull/51239 |
| nodejs/node#50421 | https://github.com/nodejs/node/pull/50421 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
lts-watch-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v18.x |
| Nov 2, 2024 | https://github.com/nodejs/node/pull/50825#event-15082325873 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50825 |
|
| https://github.com/anonrig |
|
anonrig
| https://github.com/anonrig |
|
| https://github.com/nodejs/node/pull/50825/files/e1f1a800eb15635d0a6a5fe198d628f38bbcf693 |
|
| https://github.com/GeoffreyBooth |
|
GeoffreyBooth
| https://github.com/GeoffreyBooth |
|
| https://github.com/nodejs/node/pull/50825/files/e1f1a800eb15635d0a6a5fe198d628f38bbcf693 |
|
| https://github.com/JakobJingleheimer |
|
JakobJingleheimer
| https://github.com/JakobJingleheimer |
|
| https://github.com/nodejs/node/pull/50825/files/b58772c02d0774fd2bda7802f7a4a0123b6e258f |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
ERR_INVALID_RETURN_PROPERTY_VALUE with load hook and commonjs
| https://github.com/nodejs/node/issues/50435 |
| Please reload this page | https://github.com/nodejs/node/pull/50825 |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/targos |
|
| https://github.com/merceyz |
|
| https://github.com/lizthegrey |
|
| https://github.com/GeoffreyBooth |
|
| https://github.com/anonrig |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |