| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:27cc3c95-4961-16ac-bba1-16d929260040 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 81E8:366DBA:1AB223A:23B1214:6969B302 |
| html-safe-nonce | 2f1a4a1a5694070d2e1ae35f222022a762b7d5ac4113ffe2761d697ebbb2a357 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MUU4OjM2NkRCQToxQUIyMjNBOjIzQjEyMTQ6Njk2OUIzMDIiLCJ2aXNpdG9yX2lkIjoiMjM0OTU5MDUzNDI0NzAwMjg4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cc08d15ccb204ed5f6e1e43335663ffe4f5a20794507ec7148c13343bdc95c99 |
| hovercard-subject-tag | pull_request:1607846186 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/50811/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/22635b2e6416213d382fd872b2c279102bb3512fd4d047a75d7659a02d094dc8/nodejs/node/pull/50811 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/22635b2e6416213d382fd872b2c279102bb3512fd4d047a75d7659a02d094dc8/nodejs/node/pull/50811 |
| og:image:alt | handle.setServers() takes an array, not a string. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lpinca |
| hostname | github.com |
| expected-hostname | github.com |
| None | b23b8fcc855cd29bb04d6c94aafa62d336bf44eefa8229444eecc968cad03aee |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0672399d88424758731ec07fe24509e23bb17fb5 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/50811#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50811 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50811 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/50811 |
| Reload | https://github.com/nodejs/node/pull/50811 |
| Reload | https://github.com/nodejs/node/pull/50811 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/50811 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/50811 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/50811#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| lpinca:fix/argument-type | https://github.com/lpinca/node/tree/fix/argument-type |
|
dns: call handle.setServers() with a valid array
| https://github.com/nodejs/node/pull/50811#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| lpinca:fix/argument-type | https://github.com/lpinca/node/tree/fix/argument-type |
|
Conversation
4
| https://github.com/nodejs/node/pull/50811 |
|
Commits
1
| https://github.com/nodejs/node/pull/50811/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/50811/checks |
|
Files changed
| https://github.com/nodejs/node/pull/50811/files |
| Please reload this page | https://github.com/nodejs/node/pull/50811 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Nov 19, 2023 | https://github.com/nodejs/node/pull/50811#issue-2000756522 |
| Please reload this page | https://github.com/nodejs/node/pull/50811 |
|
| https://github.com/lpinca |
| dns: call handle.setServers() with a valid array | https://github.com/nodejs/node/pull/50811/commits/8c33bc6af7054d55c10e59b38ff9f8d2ae7d78f3 |
| 8c33bc6 | https://github.com/nodejs/node/pull/50811/commits/8c33bc6af7054d55c10e59b38ff9f8d2ae7d78f3 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 19, 2023 | https://github.com/nodejs/node/pull/50811#issuecomment-1817788744 |
| Please reload this page | https://github.com/nodejs/node/pull/50811 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dns
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Nov 19, 2023 | https://github.com/nodejs/node/pull/50811#event-11003318516 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Nov 19, 2023
| https://github.com/nodejs/node/pull/50811#ref-pullrequest-2000571878 |
|
deps: update c-ares to 1.23.0
#50800
| https://github.com/nodejs/node/pull/50800 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 19, 2023 | https://github.com/nodejs/node/pull/50811#event-11003521995 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 19, 2023 | https://github.com/nodejs/node/pull/50811#event-11003535158 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 19, 2023 | https://github.com/nodejs/node/pull/50811#issuecomment-1817820387 |
| https://ci.nodejs.org/job/node-test-pull-request/55758/ | https://ci.nodejs.org/job/node-test-pull-request/55758/ |
| Please reload this page | https://github.com/nodejs/node/pull/50811 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 19, 2023
| https://github.com/nodejs/node/pull/50811#pullrequestreview-1738718360 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50811/files/8c33bc6af7054d55c10e59b38ff9f8d2ae7d78f3 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Nov 20, 2023
| https://github.com/nodejs/node/pull/50811#pullrequestreview-1740575641 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50811/files/8c33bc6af7054d55c10e59b38ff9f8d2ae7d78f3 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/50811#pullrequestreview-1740575641 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/50811 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
Nov 21, 2023
| https://github.com/nodejs/node/pull/50811#pullrequestreview-1741989161 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50811/files/8c33bc6af7054d55c10e59b38ff9f8d2ae7d78f3 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Nov 21, 2023 | https://github.com/nodejs/node/pull/50811#event-11029095118 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Nov 21, 2023 | https://github.com/nodejs/node/pull/50811#event-11029129604 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| 053f368 | https://github.com/nodejs/node/commit/053f36855afa8b6492129492dc15fc050726fdfb |
| Nov 21, 2023 | https://github.com/nodejs/node/pull/50811#event-11029130362 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 21, 2023 | https://github.com/nodejs/node/pull/50811#issuecomment-1821665597 |
| 053f368 | https://github.com/nodejs/node/commit/053f36855afa8b6492129492dc15fc050726fdfb |
| Please reload this page | https://github.com/nodejs/node/pull/50811 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| November 21, 2023 20:56 | https://github.com/nodejs/node/pull/50811#event-11029135946 |
| targos | https://github.com/targos |
|
Nov 23, 2023
| https://github.com/nodejs/node/pull/50811#ref-commit-e8fc3d4 |
|
| https://github.com/lpinca |
|
| https://github.com/targos |
| dns: call handle.setServers() with a valid array | https://github.com/nodejs/node/commit/e8fc3d450fe520c7bc2c3c8a68f07648ce30da54 |
| e8fc3d4 | https://github.com/nodejs/node/commit/e8fc3d450fe520c7bc2c3c8a68f07648ce30da54 |
| #50811 | https://github.com/nodejs/node/pull/50811 |
| martenrichter | https://github.com/martenrichter |
|
Nov 26, 2023
| https://github.com/nodejs/node/pull/50811#ref-commit-6e3d160 |
|
| https://github.com/lpinca |
|
| https://github.com/martenrichter |
| dns: call handle.setServers() with a valid array | https://github.com/martenrichter/node/commit/6e3d1604c3bcc63baee9a342eed2ea0d68f52c2a |
| 6e3d160 | https://github.com/martenrichter/node/commit/6e3d1604c3bcc63baee9a342eed2ea0d68f52c2a |
| nodejs#50811 | https://github.com/nodejs/node/pull/50811 |
| lucshi | https://github.com/lucshi |
|
Nov 27, 2023
| https://github.com/nodejs/node/pull/50811#ref-commit-9af0fb0 |
|
| https://github.com/lpinca |
| dns: call handle.setServers() with a valid array | https://github.com/lucshi/node/commit/9af0fb013b42781086c7a0bdd9614862c3677d77 |
| 9af0fb0 | https://github.com/lucshi/node/commit/9af0fb013b42781086c7a0bdd9614862c3677d77 |
| nodejs#50811 | https://github.com/nodejs/node/pull/50811 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
Nov 28, 2023
| https://github.com/nodejs/node/pull/50811#ref-pullrequest-2014290477 |
|
v21.3.0 proposal
#50954
| https://github.com/nodejs/node/pull/50954 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Nov 29, 2023
| https://github.com/nodejs/node/pull/50811#ref-commit-6dfe102 |
|
| https://github.com/lpinca |
|
| https://github.com/RafaelGSS |
| dns: call handle.setServers() with a valid array | https://github.com/nodejs/node/commit/6dfe1023c30972f4d97d1a7727d95c0b388e0e84 |
| 6dfe102 | https://github.com/nodejs/node/commit/6dfe1023c30972f4d97d1a7727d95c0b388e0e84 |
| #50811 | https://github.com/nodejs/node/pull/50811 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Nov 30, 2023
| https://github.com/nodejs/node/pull/50811#ref-commit-e572466 |
|
| https://github.com/lpinca |
|
| https://github.com/RafaelGSS |
| dns: call handle.setServers() with a valid array | https://github.com/nodejs/node/commit/e57246603e3774cd0ae51171320a9ebeee0916d3 |
| e572466 | https://github.com/nodejs/node/commit/e57246603e3774cd0ae51171320a9ebeee0916d3 |
| #50811 | https://github.com/nodejs/node/pull/50811 |
| UlisesGascon | https://github.com/UlisesGascon |
|
Dec 11, 2023
| https://github.com/nodejs/node/pull/50811#ref-commit-7003e55 |
|
| https://github.com/lpinca |
|
| https://github.com/UlisesGascon |
| dns: call handle.setServers() with a valid array | https://github.com/nodejs/node/commit/7003e5529b362d239541fb25baa5ac2efd5f1479 |
| 7003e55 | https://github.com/nodejs/node/commit/7003e5529b362d239541fb25baa5ac2efd5f1479 |
| #50811 | https://github.com/nodejs/node/pull/50811 |
| https://github.com/UlisesGascon |
| UlisesGascon | https://github.com/UlisesGascon |
|
Dec 12, 2023
| https://github.com/nodejs/node/pull/50811#ref-pullrequest-2036750657 |
|
v20.11.0 proposal
#51124
| https://github.com/nodejs/node/pull/51124 |
| UlisesGascon | https://github.com/UlisesGascon |
|
Dec 15, 2023
| https://github.com/nodejs/node/pull/50811#ref-commit-ce725bc |
|
| https://github.com/lpinca |
|
| https://github.com/UlisesGascon |
| dns: call handle.setServers() with a valid array | https://github.com/nodejs/node/commit/ce725bcc626b2bec717b4b7270f752409fc7b3c2 |
| ce725bc | https://github.com/nodejs/node/commit/ce725bcc626b2bec717b4b7270f752409fc7b3c2 |
| #50811 | https://github.com/nodejs/node/pull/50811 |
| UlisesGascon | https://github.com/UlisesGascon |
|
Dec 19, 2023
| https://github.com/nodejs/node/pull/50811#ref-commit-d5c16f8 |
|
| https://github.com/lpinca |
|
| https://github.com/UlisesGascon |
| dns: call handle.setServers() with a valid array | https://github.com/nodejs/node/commit/d5c16f897ad93ef9522ff815167c955e64f24f69 |
| d5c16f8 | https://github.com/nodejs/node/commit/d5c16f897ad93ef9522ff815167c955e64f24f69 |
| #50811 | https://github.com/nodejs/node/pull/50811 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50811 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/50811/files/8c33bc6af7054d55c10e59b38ff9f8d2ae7d78f3 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/50811/files/8c33bc6af7054d55c10e59b38ff9f8d2ae7d78f3 |
|
| https://github.com/marco-ippolito |
|
marco-ippolito
| https://github.com/marco-ippolito |
|
| https://github.com/nodejs/node/pull/50811/files/8c33bc6af7054d55c10e59b38ff9f8d2ae7d78f3 |
|
dns
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Please reload this page | https://github.com/nodejs/node/pull/50811 |
|
| https://github.com/lpinca |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mcollina |
|
| https://github.com/jasnell |
|
| https://github.com/marco-ippolito |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |