Title: build,tools: make addons tests work with GN by zcbenz · Pull Request #50737 · nodejs/node · GitHub
Open Graph Title: build,tools: make addons tests work with GN by zcbenz · Pull Request #50737 · nodejs/node
X Title: build,tools: make addons tests work with GN by zcbenz · Pull Request #50737 · nodejs/node
Description: This PR refactors the install and build_addons scripts so they can be reused by node-ci and electron projects to build the addons tests. In detail, this PR does following things: Minor modifications of the GN configurations to fix loading native modules. Add some flags to tools/install.py script to allow customize locations of config.gypi, v8, etc. With some refactoring to remove global variables. Rewrite the tools/build_addons.py script: Rewrite it from js to python, because implementing cmd args handling with vanilla Node.js would take much longer time than a simple rewrite. Add a few more flags to make it easier to use for embedders. Modify the Makefile to generate headers in out dir first, and then calls build_addons.py --headers-dir=out_dir/headers (which calls node-gyp --nodedir=out_dir/headers) to build addons. Previously the build system was just calling node-gyp --nodedir=., which relied on quirky behavior of node-gyp and did not really test whether the generated headers work. Users that rely on make or vcbuild.bat to work on Node are not affected.
Open Graph Description: This PR refactors the install and build_addons scripts so they can be reused by node-ci and electron projects to build the addons tests. In detail, this PR does following things: Minor modificatio...
X Description: This PR refactors the install and build_addons scripts so they can be reused by node-ci and electron projects to build the addons tests. In detail, this PR does following things: Minor modificatio...
Opengraph URL: https://github.com/nodejs/node/pull/50737
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8b7ade97-dddd-5975-2ef6-1ebc9a8dab86 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E0A0:22A978:12DCC52:1A704DC:696A3291 |
| html-safe-nonce | 9810ce385ec1e74cde876ef49cdc82b29f918d1515f4006c1cbc3507c0c0f692 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEEwOjIyQTk3ODoxMkRDQzUyOjFBNzA0REM6Njk2QTMyOTEiLCJ2aXNpdG9yX2lkIjoiNzU3ODUxNTQwMzgxODI4MzY2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 065cf7275ab0b9af5aa738fe3dba4c122fee50a5a16c92b7d573d419d6a4d898 |
| hovercard-subject-tag | pull_request:1602108652 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/50737/files |
| twitter:image | https://avatars.githubusercontent.com/u/639601?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/639601?s=400&v=4 |
| og:image:alt | This PR refactors the install and build_addons scripts so they can be reused by node-ci and electron projects to build the addons tests. In detail, this PR does following things: Minor modificatio... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width